Graphe des révisions

789 Révisions

Auteur SHA1 Message Date
Satya Rama Aditya Pinapala
196502bc12 disp: msm: sde: setting async cmd wait flag only for DSI
Asynchronous command transfer wait during pre kickoff
is only applicable for DSI. The change ensures that
the flag is set only for DSI connector, otherwise it can
result in memory scribbling for other connectors.

Change-Id: I623f15cf13fcd3ae72f584d5ef8883570a848c93
Signed-off-by: Satya Rama Aditya Pinapala <psraditya30@codeaurora.org>
2020-03-18 15:08:02 -07:00
Lei Chen
3842597275 disp: msm: dsi: disallow backlight update during panel mode switch
DSI controller and clock will be disabled/enabled during panel mode
switch, so disallow backlight update during panel mode switch to
avoiding DSI exception.

Change-Id: I37e2f3c9aa929555593ffb53950521150ee7698f
Signed-off-by: Lei Chen <chenlei@codeaurora.org>
Signed-off-by: Satya Rama Aditya Pinapala <psraditya30@codeaurora.org>
2020-03-17 19:34:51 -07:00
Neeraj Upadhyay
7d33aeb87e disp: msm: dsi: Fix compilation error with -fno-builtin removed
Fix compilation error observed with -fno-builtin compilation
flag removed.

Change-Id: I07ac73db206fab3a1b648d7b656e002c6d347b3b
Signed-off-by: Neeraj Upadhyay <neeraju@codeaurora.org>
Signed-off-by: Satya Rama Aditya Pinapala <psraditya30@codeaurora.org>
2020-03-17 19:34:51 -07:00
Vara Reddy
df28b30edf drm/msm/dsi: update recommended non-embedded mode sequence
Removing dsi soft reset logic while arbitrating transferring
embedded mode and non-embedded dsi commands. This change
follows the recommended sequence for kona.

Change-Id: I05eef0c6cfd671f48fbfdf7cb2cab788e42bb1e5
Signed-off-by: Vara Reddy <varar@codeaurora.org>
Signed-off-by: Satya Rama Aditya Pinapala <psraditya30@codeaurora.org>
2020-03-17 19:34:51 -07:00
Vara Reddy
294db87b1f drm/msm/dsi: set cmd dma done mask before triggering cmds
Make sure that cmd dma done mask is set before sending
dma commands. This will make sure that we don't timeout
if the refcnt's are not properly handled. Many oem's
have their own customizations around this which maynot
handle the refcnt's correctly.

Change-Id: If7f5ed1fae20b57f6e9147cae2caa3c5097466c9
Signed-off-by: Vara Reddy <varar@codeaurora.org>
Signed-off-by: Satya Rama Aditya Pinapala <psraditya30@codeaurora.org>
2020-03-17 19:34:51 -07:00
Satya Rama Aditya Pinapala
918f7479dd disp: msm: dsi: do not skip DSI CTRL init for DMS on first frame
For command mode panels, if a dynamic mode switch occurs on
the first frame, the current code skips DSI controller initialization
and registering for error handlers. This causes the software state
to be uninitialized for DSI CTRL, resulting in command transfer
failures and eventual crash. The change ensures that initialization
is complete even if the DMS occurs on first frame.

Change-Id: I83e3336f7c09424b6c7b95826c30b37974ec29ab
Signed-off-by: Lipsa Rout <lrout@codeaurora.org>
Signed-off-by: Satya Rama Aditya Pinapala <psraditya30@codeaurora.org>
2020-03-17 19:34:39 -07:00
Lei Chen
64675ef266 disp: msm: dsi: add panel mode restriction for DFPS and RFI
Add this change to ensure that DFPS and RFI happen in the
same panel mode for avoiding unexpected panel mode switch.

Change-Id: I6783b320e73a88e8f75cb83bcce85e50f798b6ab
Signed-off-by: Lei Chen <chenlei@codeaurora.org>
Signed-off-by: Satya Rama Aditya Pinapala <psraditya30@codeaurora.org>
2020-03-17 19:31:41 -07:00
Lei Chen
fda33778de disp: msm: dsi: reject POMS commit with active changed
Reject composition if panel mode switch is requested
during power on/off commits.

Change-Id: I3a5b28fd9f5bd927537824033a1c8dc838366d5b
Signed-off-by: Lei Chen <chenlei@codeaurora.org>
Signed-off-by: Satya Rama Aditya Pinapala <psraditya30@codeaurora.org>
2020-03-17 19:31:35 -07:00
Dhaval Patel
9652f27293 disp: msm: avoid esd check during pm_suspend state
Avoid esd check during pm_suspend state because core
clock enable will fail. This change adds additional
check and also adds the clock enable failure check.

Change-Id: Ie8bfa4f74d323ff15a07fb037675f07ab942f016
Signed-off-by: Dhaval Patel <pdhaval@codeaurora.org>
Signed-off-by: Satya Rama Aditya Pinapala <psraditya30@codeaurora.org>
2020-03-17 19:31:26 -07:00
Lei Chen
8fbd145c74 disp: msm: dsi: update panel mode parsing message for POMS
It should not be an error that panel mode isn't specified
in timing node, so add this change to lower the log level
from error to info.

Change-Id: I49bd1fec1c09697d9829a8e0767dfa3cf2cff512
Signed-off-by: Lei Chen <chenlei@codeaurora.org>
Signed-off-by: Satya Rama Aditya Pinapala <psraditya30@codeaurora.org>
2020-03-17 19:31:12 -07:00
Satya Rama Aditya Pinapala
4a85d3152c disp: msm: dsi: Fix porch calculation issue for constant fps
For constant fps feature, porch is calculated based on supported
clk rates. Currently, data type of local variables used for porch
calculation is u32 which leads to incorrect porch calculation for
higher clk rates. So, update the data type to u64.

Change-Id: I8eb04487d1dcce05989448c0b063e56752af412b
Signed-off-by: Lipsa Rout <lrout@codeaurora.org>
Signed-off-by: Ritesh Kumar <riteshk@codeaurora.org>
Signed-off-by: Satya Rama Aditya Pinapala <psraditya30@codeaurora.org>
2020-03-17 19:31:03 -07:00
Lipsa Rout
10fde7ee16 disp: msm: dsi: Add support for dynamically switch dsi clock
Add changes to support dynamic switching of dsi clock feature for
phy ver 2.0. This helps to avoid RF interference with DSI clock.

Change-Id: I69958d9224665296cc0f272e39dcdfcefbe293d4
Signed-off-by: Ritesh Kumar <riteshk@codeaurora.org>
Signed-off-by: Lipsa Rout <lrout@codeaurora.org>
Signed-off-by: Satya Rama Aditya Pinapala <psraditya30@codeaurora.org>
2020-03-17 19:30:58 -07:00
Aravind Venkateswaran
e84524efd2 disp: msm: dsi: disable DSI cmd tx async wait for video mode
For video mode panels, async wait feature for DCS command
transmission may not always be reliable as additional programming
would be needed to ensure that the DCS commands are correctly scheduled.
Until this feature is properly implemented and validated, disable this
for video mode panels to avoid potential DSI command transfer
failures.

Change-Id: I18c853bc5607cc1cc523b36f6f346b213911c1a9
Signed-off-by: Aravind Venkateswaran <aravindh@codeaurora.org>
Signed-off-by: Satya Rama Aditya Pinapala <psraditya30@codeaurora.org>
2020-03-17 19:30:53 -07:00
Aravind Venkateswaran
bce44eed47 disp: msm: dsi: add additional validation checks for async cmd wait
Disable DSI command transfer async wait feature for DSI read commands
and the commands sent in non-embedded mode.

CRs-Fixed: 2579259
Change-Id: Ib3b08fbb091711aa4be87400b79d01f0dcc05e71
Signed-off-by: Aravind Venkateswaran <aravindh@codeaurora.org>
Signed-off-by: Satya Rama Aditya Pinapala <psraditya30@codeaurora.org>
2020-03-17 19:30:46 -07:00
Vara Reddy
81ad4ef407 drm/msm/dsi: fix dsi command dma async race condition
Change will be removing checking and clearing dsi cmd done
interrupt in commit thread and in workqueue context, which
can race with dsi isr, when it tries to clear the interrupt.

Change-Id: I96e7f8dffed1af3cec0c7668ab1729337d4b260e
Signed-off-by: Vara Reddy <varar@codeaurora.org>
Signed-off-by: Satya Rama Aditya Pinapala <psraditya30@codeaurora.org>
2020-03-17 19:30:32 -07:00
Lipsa Rout
5e09ea2aed disp: msm: dsi: Add support for clk switch with constant FPS
There is lag or lead in the FPS during dynamic clock change,
along with the increment or decrement in clock. So, HFP or
VFP are adjusted to ensure a constant FPS.

Change-Id: I87ba7a185104a0f5f1d13734a7e487e728d6b2c0
Signed-off-by: Lipsa Rout <lrout@codeaurora.org>
Signed-off-by: Satya Rama Aditya Pinapala <psraditya30@codeaurora.org>
2020-03-17 19:30:26 -07:00
Lipsa Rout
5644d01f7a disp: msm: dsi: Update dsi byte interface clock calculation
Update dsi byte interface clock as per hardware recommendation.
For Phy ver 2.0 and below: byte intf clk equals to byte clk.
For Phy ver 3.0 and above: byte intf clk equals to byte clk / 2.

Change-Id: Ic3af2e4348403aeacb2e1c73c4dc133db63a51a4
Signed-off-by: Ritesh Kumar <riteshk@codeaurora.org>
Signed-off-by: Lipsa Rout <lrout@codeaurora.org>
Signed-off-by: Satya Rama Aditya Pinapala <psraditya30@codeaurora.org>
2020-03-17 19:30:09 -07:00
qctecmdr
b15ed9edec Merge "disp: msm: dsi: fix parsing of display name from boot name" 2020-03-13 13:53:41 -07:00
qctecmdr
3af9cf96b7 Merge "disp: msm: sde: refactor catalog dspp parsing" 2020-03-12 22:05:29 -07:00
qctecmdr
5d2e2f435f Merge "disp: msm: sde: align timing engine vsync based on panel vsync" 2020-03-12 20:15:59 -07:00
qctecmdr
a27a0cd2c1 Merge "disp: msm: dsi: add check for invalid arguments in DSI clock control" 2020-03-12 18:39:29 -07:00
Narendra Muppalla
68ee65353b disp: msm: sde: align timing engine vsync based on panel vsync
This change adds logic to align timing engine vsync with panel
tear check if it is supported.

Change-Id: I3f881f392929589848c893f567822b21c0650000
Signed-off-by: Narendra Muppalla <NarendraM@codeaurora.org>
2020-03-11 10:14:57 -07:00
Narendra Muppalla
cd1e996b44 disp: msm: defer panel TE disable with poms switch
DSI host vsync is expected to align with panel internal vsync
during transition from command mode to video mode operation.
In order to facilitate this, keep panel TE enabled in video mode
operation until it is aligned with vysnc.

Change-Id: I3fc59b01336b30cd436be332af6953c5a01be7fd
Signed-off-by: Narendra Muppalla <NarendraM@codeaurora.org>
2020-03-10 16:37:21 -07:00
Satya Rama Aditya Pinapala
06e8f4436a disp: msm: dsi: fix parsing of display name from boot name
Change fixes parsing of software TE tag added to the display
name from bootloader.

Change-Id: I4747cc6eff43d681477150d6cad7a737963bf11c
Signed-off-by: Satya Rama Aditya Pinapala <psraditya30@codeaurora.org>
2020-03-10 16:20:50 -07:00
Satya Rama Aditya Pinapala
e6e39e8b94 disp: msm: dsi: add check for invalid arguments in DSI clock control
Check against the max clk_type and clk_state enumerations before
to validate the type and state of DSI clocks to avoid Control
Flow Integrity issues.

Change-Id: Id53465c2b12debb1b356c0c91064eb017c2ca30d
Signed-off-by: Satya Rama Aditya Pinapala <psraditya30@codeaurora.org>
2020-03-10 10:24:50 -07:00
Steve Cohen
32ad348d81 disp: msm: sde: add MDSS_HW block range for debugfs register access
Register the MDSS_HW block (at base offset 0) for access via the
sde_reg node in SDE's debugfs directory. This is needed for
validating correct UBWC register programming.

Change-Id: I2494e066a7603747f2ec12546e58a17f2120a521
Signed-off-by: Steve Cohen <cohens@codeaurora.org>
2020-03-08 01:42:56 -08:00
Steve Cohen
6cb33c8d11 disp: msm: sde: refactor catalog dspp parsing
Refactor dspp catalog parsing functions to reduce
cyclomatic complexity.

Change-Id: I0a8200f8e08a7ac40172fdcd6cc62e08135bba61
Signed-off-by: Amine Najahi <anajahi@codeaurora.org>
Signed-off-by: Steve Cohen <cohens@codeaurora.org>
2020-03-06 13:58:36 -08:00
qctecmdr
13a29a2855 Merge "disp: msm: dp: update swing and pre-emphasis levels" 2020-03-05 18:06:13 -08:00
qctecmdr
879c309e6a Merge "Revert "disp: msm: dp: use the correct checksum for EDID"" 2020-03-05 18:06:13 -08:00
Tatenda Chipeperekwa
310e888d0f Revert "Revert "disp: msm: sde: remove colorspace property from connector""
This reverts commit 7470449242.
This is required to satisfy cross component dependencies with
kernel-5.4.

Change-Id: Idba2983923a8605ec0a05408da48f7549730035d
Signed-off-by: Tatenda Chipeperekwa <tatendac@codeaurora.org>
2020-03-04 17:49:00 -08:00
Tatenda Chipeperekwa
43599c49a3 Revert "disp: msm: dp: use updated colorimetry and DSC definitions"
This reverts commit 982574f095.
This is required to satisfy cross component dependencies with
kernel-5.4.

Change-Id: I979e0371973376c46f2a11659348df726be2679d
Signed-off-by: Tatenda Chipeperekwa <tatendac@codeaurora.org>
2020-03-04 17:48:27 -08:00
Linux Build Service Account
04db4e8a6b Merge "disp: msm: dp: use updated colorimetry and DSC definitions" into display-kernel.lnx.5.4 2020-03-04 12:41:31 -08:00
Tatenda Chipeperekwa
71436eec71 Revert "disp: msm: dp: use the correct checksum for EDID"
This reverts commit eaed3221fa
which uses a downstream implementation for checksum calculation.
This will be fixed once the upstream changes to address checksum
calculation are merged.

Change-Id: I7a6ed1c4d4baf52533485d59bcdcb6dd1009d626
Signed-off-by: Tatenda Chipeperekwa <tatendac@codeaurora.org>
2020-03-03 17:18:31 -08:00
Tatenda Chipeperekwa
c7d094b54b disp: msm: dp: update swing and pre-emphasis levels
Update the HBR and RBR swing and pre-emphasis levels as per the
latest published hardware programming guide.

Change-Id: If3b6713e0b6680f65539882221aae32b00bf0254
Signed-off-by: Tatenda Chipeperekwa <tatendac@codeaurora.org>
2020-03-03 16:50:54 -08:00
qctecmdr
8a690a0b80 Merge "disp: msm: sde: support fps based qos setting" 2020-03-03 13:40:02 -08:00
Tatenda Chipeperekwa
982574f095 disp: msm: dp: use updated colorimetry and DSC definitions
Update colorimetry definition usage and how we access DSC information
as per changes in the upstream DRM framework code.

Change-Id: Ie52aed2df2f6c3f2df1e4129f342a85256f8fae4
Signed-off-by: Tatenda Chipeperekwa <tatendac@codeaurora.org>
2020-03-03 10:35:12 -08:00
qctecmdr
f1c8d9f378 Merge "Revert "disp: msm: sde: remove colorspace property from connector"" 2020-03-03 09:08:48 -08:00
qctecmdr
ddc62cd51d Merge "disp: msm: sde: fix dsc/vdc register dump" 2020-03-02 20:47:39 -08:00
Satya Rama Aditya Pinapala
d97b665e1d disp: msm: move msm_drv probe to module level
With the introduction of sync state drivers, msm_drm probe can be
moved back to module level from late init.  It is now guaranteed
that the dependencies are probed before the actual driver is.

Change-Id: Ib7c3e0e3c3d32b37b7672b6119bcf5371783659d
Signed-off-by: Satya Rama Aditya Pinapala <psraditya30@codeaurora.org>
2020-03-02 11:38:00 -08:00
Dhaval Patel
2843f86793 disp: msm: sde: support fps based qos setting
Support different safe, danger and creq qos lut
configuration based on display fps. It also removes
the fill level calculations from sspp and wb block
because mdss hw supports simple configuration.

Change-Id: I203e4300c9eab27d3632c890bedd6383cca0e5a8
Signed-off-by: Dhaval Patel <pdhaval@codeaurora.org>
2020-03-02 09:52:47 -08:00
qctecmdr
466dcda345 Merge "disp: msm: sde: move ramdump node from reserve area" 2020-03-01 22:20:57 -08:00
Abhijit Kulkarni
e3a078c712 disp: msm: sde: fix dsc/vdc register dump
DSC and VDC-M sub-block registers are not on contiguous
address range. This change allows dumping the registers
for each individual sub-block.

Change-Id: I06dfc64562211370a0e29f6fc1134351c47722f6
Signed-off-by: Abhijit Kulkarni <kabhijit@codeaurora.org>
2020-02-28 12:43:22 -08:00
Dhaval Patel
876ea7de77 disp: msm: sde: move ramdump node from reserve area
Ramdump node only allocates portion of splash
buffer memory. It should not be within reserve
memory area because splash buffer is already reserving
these pages.

Change-Id: I7caa818b19cb993571e6bf0648a4dfbbc2ad9d71
Signed-off-by: Dhaval Patel <pdhaval@codeaurora.org>
2020-02-28 11:58:05 -08:00
Dhaval Patel
9438f3448b disp: msm: sde: add underrun line count information
Add underrun line count information for each underrun.

Change-Id: I34a740c33240fa8d444f4bbc3b8b014b0282fca1
Signed-off-by: Dhaval Patel <pdhaval@codeaurora.org>
2020-02-28 11:57:47 -08:00
qctecmdr
9d96e47c53 Merge "disp: msm: sde: add vbif axi port halt request support" 2020-02-27 14:37:43 -08:00
qctecmdr
65d27833bd Merge "disp: msm: sde: make sid programming optional" 2020-02-26 22:25:36 -08:00
qctecmdr
664e64b84b Merge "disp: msm: remove drm_connector usage for colorspace" 2020-02-21 10:28:36 -08:00
Tatenda Chipeperekwa
7470449242 Revert "disp: msm: sde: remove colorspace property from connector"
This reverts commit 483c9fdff4c611f250574fe6909cd8e5336808f5. It
is no longer needed on kernel-5.4 as all the upstream changes are
now available.

Change-Id: I11b0317c0e05ea2fe03fb1af734a79a1174b1922
Signed-off-by: Tatenda Chipeperekwa <tatendac@codeaurora.org>
2020-02-20 19:41:31 -08:00
qctecmdr
5d23842089 Merge "disp: msm: add colorimetry block parsing to SDE EDID parser" 2020-02-20 11:19:21 -08:00
qctecmdr
6f793b503f Merge "disp: msm: dp: fix null check in atomic_check" 2020-02-19 17:55:56 -08:00