According to HFI definition, HFI_PROP_CSC needs to be configured
on BITSTREAM port, but during msm_vidc_set_cap, CSC is being
configured on PORT_NONE leading to error in FW.
Added change to configure CSC always on BITSTREAM port.
Change-Id: I3e9511ec40cd25687048f0739c57d164dd7a1c43
Signed-off-by: Vedang Nagar <quic_vnagar@quicinc.com>
Fix warnings for vendor checker in vidc/inc folder.
[1] CHECK: Alignment should match open parenthesis.
[2] Lines should not end with a '('.
[3] Please use a blank line after.
Change-Id: Iac0591fc1e544e837a3c64c7a6e9b03cc9070ed2
Signed-off-by: Vedang Nagar <quic_vnagar@quicinc.com>
[1] Add the basic driver support for cliffs variant.
[2] Add platform specific files for cliffs.
Change-Id: If35f79fa1c72ce160d4ed4c0f1ba8babb7ce8a3d
Signed-off-by: Vedang Nagar <quic_vnagar@quicinc.com>
In driver num_comv value is coming more than expected
due to assumtion of default VPP delay as 2, which
is not needed now.
Change-Id: Ie24b5b30034cbc465aaa5952d80b6c0811cfe1a2
Signed-off-by: Ankush Mitra <quic_ankumitr@quicinc.com>
In vp9 splitmode cases, there is a possibility
fw reuses DPB buffers and hence does not return
these buffers as part of STOP command during
port reconfig. In this case, driver should not
destroy these DPB buffers. Added a fix for the
same.
Issue observed with: 1A1622D8_Dec_VP9_Argon_EOS0.
Change-Id: I81deded6a49290574ddda8d4f8efdfc0a9f733f3
Signed-off-by: Darshana Patil <quic_darshana@quicinc.com>
Signed-off-by: Maheshwar Ajja <quic_majja@quicinc.com>
- Fix Alignment should match open parenthesis and
Please use a blank line after
Change-Id: I5155f3037ab3b65a0456a18eb8c98b54760204f9
Signed-off-by: Megha Byahatti <quic_mbyahatt@quicinc.com>
Fix space and blank line required warning.
Change-Id: I2f754e52cdb36332a53b65ca248ae5d974a00ff4
Signed-off-by: Ankush Mitra <quic_ankumitr@quicinc.com>
[1] If request_fd enabled, msm_vb2_buf_queue() is not called
from v4l2_qbuf. Instead it's called as part of
msm_v4l2_request_queue(). Hence inst lock should be acquired
in common function i.e msm_vb2_buf_queue, to handle both
requests and non-request scenarios.
[2] If request_fd is disabled, inst_lock can be acquired in
v4l2_qbuf() call. Acquiring inst_lock from here will
ensure RO list insertion and updation i.e. attach/map will
happen under lock.
Currently, request_fd is disabled. Therefore, acquire inst_lock
from this function to ensure RO list insertion/updation is under
lock to avoid stability usecase.
Change-Id: I3cc1d4b8b5547fd5e34ce5eb06480380cb9200cc
Signed-off-by: Vedang Nagar <quic_vnagar@quicinc.com>
replace msm_vidc_vmem_alloc/free with direct calls to
vzalloc and vfree.
Change-Id: Iafde62dd7f54b99418207d10ff71589bf0efd5ed
Signed-off-by: Dikshita Agarwal <quic_dikshita@quicinc.com>
- Driver code gets the compression ratio(CR) from FW. This CR is used
to calculate the compression factor(CF) and used in BW calculations.
Perf. model code for BW calculations always assumes that CF will be in
fractional format. But, driver already converts the CR to integer format.
So, we need to remove the x100 multiplication in BW calculation code.
- As CF is used as division factor for BW calculations,
due to this x100 bump in CF values, we see very low calculated BW values.
Change-Id: Ifbddee68b6799b2fe0fc6d5ffa623514e1abd13f
Signed-off-by: Ashish Patil <quic_ashpat@quicinc.com>
fix the error condition for pm_runtime_get_sync
as it can return 1 as well in success case.
Change-Id: I958da05b1b979adae059181432a3d917012640b7
Signed-off-by: Dikshita Agarwal <quic_dikshita@quicinc.com>
fix copyright markings and have all markings in one
multiline comment.
Change-Id: I481c6213bb25e8c278956ad6a51df3fc5c1aabf2
Signed-off-by: Dikshita Agarwal <quic_dikshita@quicinc.com>
pineapple_technology.h contains multiple static array and it is
getting included from msm_vidc_bus.c & msm_vidc_clock.c files.
So in generated build is having 2 copies of static arrays in
code segment.
So added changes to avoid duplication in generated bin.
Change-Id: Ifcfa07331e868440d033d2c7d65555810ad4d1b3
Signed-off-by: Govindaraj Rajagopal <quic_grajagop@quicinc.com>
Residency print is not working for 2 cases-
1. when the prev session stopped in the middle without
setting clk->prev freq to 0, in next session
the residency stats
for the same clk freq will not come as the start time will be
reset to 0 during next session open.
2. when last session close and clk rate not changed to 0
but, before that print residency stats come,
then in residency print the residency for
the last clk freq will not come.
Change-Id: I63a59202ca145e83e0bc129105df0b0182d3cb1e
Signed-off-by: Ankush Mitra <quic_ankumitr@quicinc.com>
there is a WARN_ON in place which will print the warning
in case of error, hence no need to have additional if check
for the same.
Change-Id: I09ca91fecd6cb8df4586621bb066754e39576d12
Signed-off-by: Dikshita Agarwal <quic_dikshita@quicinc.com>
Treat NOC error (which is a result of pagefault) as
fatal error to and get more debug info to resolve the
pagefault issue.
Change-Id: I3a1cd99fea680a941788d1bc8ea586bf0ff29365
Signed-off-by: Maheshwar Ajja <quic_majja@quicinc.com>
There are many places in code where available helper
functions are not being used, fix it.
Change-Id: Id5b309837fd5847e280f7fab02820af1b08242a6
Signed-off-by: Dikshita Agarwal <quic_dikshita@quicinc.com>
