- remove truncation for frame rate and allow
fractional value as well
Change-Id: I7e48d3b4cb9ecf674fb17a08bbd8c3c0617d12a7
Signed-off-by: Deepa Guthyappa Madivalara <quic_dmadival@quicinc.com>
Remove inst check from all the functions in video driver.
Inst check is present in most of the functions in video
driver which is not required.
Keep check only at root level functions and remove
from rest all of the functions.
Change-Id: Ib310cd3df5e8612a9fc3a5aa654dff4203a12906
Signed-off-by: Vedang Nagar <quic_vnagar@quicinc.com>
Static tool reported few coding style related warnings. This patch
fixes the same.
Change-Id: If7c75d8ecf0e2c1128bdd6f3fd3fb6148fcd457d
Signed-off-by: Vikash Garodia <quic_vgarodia@quicinc.com>
1. use max of operating and frame rate for fps
2. vpp_cycles is considered close to frequency
corner if vpp_min_freq is greater than max
required frequency
Change-Id: I9dc995ca16e4eeae18497a8648dfef64e16dfbc2
Signed-off-by: Deepa Guthyappa Madivalara <quic_dmadival@quicinc.com>
In case of encoder drain followed by immediate
stop usecase, fw might send drain last flag info
packet instead of last flag buffer due to
insufficent output buffers. In this scenario, driver
signals EOS through an event. To avoid sending last
flag buffer in some usecases and EOS event in other
usecases, to maintain consistency, always send last
flag information via EOS event to client.
Change-Id: Ib816603fb171a5f3f72f163614588490514f8c59
Signed-off-by: Darshana Patil <quic_darshana@quicinc.com>
Adding new macro to enable bazel compilation by default
Change-Id: Id8b9682a99a693c80be65c09b8e4b3d492284b63
Signed-off-by: Rakshitha Shakamuri <quic_rshakamu@quicinc.com>
Add NULL check to fix kw issue of possible NULL dereference
Change-Id: Ia2518b43a855831277981a662d10f24e122748ba
Signed-off-by: Chen Sun <quic_chesun@quicinc.com>
1. allow any client set operating rate (less than 2^15)
2. remove operating rate dependency for admission control
3. allow turbo for low latency case as well
Change-Id: I4b0f29c3756a592a9baedec8996653e5cb5292d5
Signed-off-by: Deepa Guthyappa Madivalara <quic_dmadival@quicinc.com>
Amend frame rate or operating rate settings for encoder
to preserve precision value if numerator is greater than 1.
Change-Id: Idc84b07f7a5558b564efaac21d663a0deda207c2
Signed-off-by: Maheshwar Ajja <quic_majja@quicinc.com>
Update BaseLayerPriority ID as dynamic property for pineapple
Change-Id: Ib036c8c47190842dff76fa45d50a65385ef28dca
Signed-off-by: Vedang Nagar <quic_vnagar@quicinc.com>
- always execute noc reset sequnce in power off
- try to disable hw power always before power down
Change-Id: I76757cccea06a398d1a79310edb688608607a413
Signed-off-by: Deepa Guthyappa Madivalara <quic_dmadival@quicinc.com>
- In noc error handler do not clear
NOC_ERL_ErrorLogger_main_ErrorLogger_ErrClr_Low, to
avoid sending any pending transactions, move clearing
to power on
Change-Id: Ib620f3dcb93b92f2c03eb2126c47d5b97526556d
Signed-off-by: Deepa Guthyappa Madivalara <quic_dmadival@quicinc.com>
For decoder input buffers, firmware (BSE HW) needs 256 aligned
buffer size otherwise it will truncate or ignore the data after 256
aligned size which may lead to error concealment.
To resolve above issue, need to update buffer size aligned with 256
Change-Id: I7782d23e293a63ca9cb650fbefc574e5d4ad2f24
Signed-off-by: Gaviraju Doddabettahalli Bettegowda <quic_gdoddabe@quicinc.com>
print read index and write index in packet
log for easier debugging.
Change-Id: I4ba797ed141d74ba51941ef8a9f09db359b407e9
Signed-off-by: Darshana Patil <quic_darshana@quicinc.com>
- Instead of accumulating the residency stats for complete session,
the residency stats for previous instance of a particular clock
were overwritten by residency stats of next instance of that clock.
- Modified to the logic to accumulate the residency stats for
complete session.
Change-Id: Ic37579ba0c28f86cda41481b0615a0bb9a54846e
Signed-off-by: Ashish Patil <quic_ashpat@quicinc.com>
- program required NOC registers in power on
- update NOC error handling when fw raises HFI_SYS_ERROR_NOC
- skip reading NOC error log registers from smmu fault handler
as they are updated only when sys error from firmware is
processed and fault handling is completed
Change-Id: If396995d8bd6c77e6a92c0c2a8a7fb245be48854
Signed-off-by: Deepa Guthyappa Madivalara <quic_dmadival@quicinc.com>
This api should not call v4l2_colorformat_to_driver
in case of encode session.
Change-Id: Ibb702e427eef3f78a62213bb181750a1403679e5
Signed-off-by: Ankush Mitra <quic_ankumitr@quicinc.com>
Adjust the residency print to have more
closer integer value.
Change-Id: Idc9605bd6be8f65ab8ec7b61059660abbf2e85fb
Signed-off-by: Ankush Mitra <quic_ankumitr@quicinc.com>
During msm_vidc_close, we are trying to perform suspend which
will unload the firmware. This is done to reduce the latency
since it will power collapse after 1.5 seconds.
But, during bootup time, for each codec, framework tries to
open and close each session for each codec. As part of this,
it will try to do power collapse/power on each time, hence
increasing the bootup latency.
Therefore Removed suspend call from close to avoid bootup
latency because video fw will anyway power collapse the
video hardware and firmware will also go into WFI mode.
Change-Id: Idbe015a6a2ef4dd1573ef01fd69d638fea7be519
Signed-off-by: Vedang Nagar <quic_vnagar@quicinc.com>
- Introduce new control to set HEIC encoder tile size from HAL
- Support 1k x 1k tile encoding along with existing 512 x 512
tiling
Change-Id: Iaeffe421f8311d818695c3ae9af7cabcc8892043
Signed-off-by: Akshata Sahukar <quic_asahukar@quicinc.com>
- In s_fmt, there might be a codec change and here we are
free the ctrl handler, at the same time client may call
query ctrl and this will lead to null pointer access.
- To resolve null pointer access, do not free ctrl handler
and add new codec controls to the same ctrl handler.
Change-Id: Iee87d5cb4d65e31d405cb1fc9f82bebab696d027
Signed-off-by: Vedang Nagar <quic_vnagar@quicinc.com>
Move private controls from each platform source files to
common header file
Change-Id: I22d8aa7f81919d950eed6b1f4ccd020c803a7ce9
Signed-off-by: Ashish Patil <quic_ashpat@quicinc.com>
When fw sends FBD with release done flag,
reset driver pending_release flag. Without
this fix, a buffer will wrongly marked as
pending_release although release done was
already arrived from fw leading to issues
when trying to mark buffer as release_eligible
or when sending release command to fw.
Change-Id: Ib6b9f6233b133442057f3938159f6f0f33fc90f8
Signed-off-by: Darshana Patil <quic_darshana@quicinc.com>
For Decode batching enabled case, max_data_size is being calculated
as the average of the data_size for all the buffers.
These buffers may contains EBD as well having data_size as 0,
which may reduce the average value by significant numbers and
hence reducing vsp numbers which may lead to vote clock to low
corners.
This may lead to slow decoding and hence Framework may drop the
frames.
Therefore, compute Average data_size only for Queued/Deffered bufs.
Change-Id: I12f155852dd750701b9448d3900b75f470eac126
Signed-off-by: Vedang Nagar <quic_vnagar@quicinc.com>
