This is a qcacld-2.0 to qcacld-3.0 propagation.
Currently when processing the QCA_NL80211_VENDOR_SUBCMD_ROAM vendor
command, for the following roam commands there are input validation
issues:
QCA_WLAN_VENDOR_ATTR_ROAM_SUBCMD_SET_BSSID_PREFS
QCA_WLAN_VENDOR_ATTR_ROAM_SUBCMD_SET_BLACKLIST_BSSID
Both of these commands have a "number of BSSIDs" attribute as well as a
list of BSSIDs. However there is no validation that the number of
BSSIDs provided won't overflow the destination buffer. In addition
there is no validation that the number of BSSIDs actually provided
matches the number of BSSIDs expected.
To address these issues, for the above mentioned commands:
* Verify that the expected number of BSSIDs doesn't exceed the maximum
allowed number of BSSIDs
* Verify that the actual number of BSSIDs supplied doesn't exceed the
expected number of BSSIDs
* Only process the actual number of supplied BSSIDs if it is less than
the expected number of BSSIDs.
Change-Id: Ifa6121ee1b1441ec415198897ef815b40cb5aff6
CRs-Fixed: 1092497
Driver logs prints QTIMER ticks and it's difficult to co-relate with
logcat timestamp.
Add logcat timestamp so that driver and logcat logs can be co-related.
Change-Id: If770d4a9b48301adc3deb8f4c1d16099dfa8dd8d
CRs-Fixed: 1095195
Currently host driver does not send interface index to supplicant
after successful roaming, this leads to disconnection in DBS mode.
Add changes to update respective interface index
by passing wdev to cfg80211_vendor_event_alloc().
Change-Id: Ic22fdd56a26a27d42a3ac7aaaf67bfba273a2697
CRs-Fixed: 1094297
Fix enum numbers as per the expectation from upper layers
which are same across different projects.
Also add few enums which are missing.
Change-Id: I59bce332667ae6503fee8f94bcff6a8cd27d1a54
CRs-Fixed: 1094088
As per the design pre-cac adapter will be assigned temporary mac address
till it finishes the CAC operation. Once the cac operation finishes
with success or failure, pre-cac adapter's mac address needs to be released.
In failure case, pre-cac adapter's mac address is getting released but
in success case, it is not released which results in to error code -22 at upper
layer.
CRs-Fixed: 1108497
Change-Id: I95da8b20392548fa3482cb92046f79b3536709b0
Maintain source of driver as well as 11d hint. Use the source of
hint to correctly disable 11d if required.
CRs-Fixed: 1093565
Change-Id: Id0ccc44389836b72466b501f5ce024f1be4b5926
Implementation of Host driver support to collect chip power stats
from firmware and display the stats in
"adb shell cat /sys/kernel/debug/wlan0/power_stats".
Change-Id: I19595ebf5a6870a0ee4d3cc2ff47d18eb24d213c
CRs-Fixed: 1045057
In function sme_ps_fill_uapsd_req_params perform a logical AND rather than OR
between current UASPD bitmask and values received in ADDTS response, otherwise
existing UAPSD bitmask (if all set) will always override ADDTS rsp values.
Change-Id: I17872f62b1f073963d3c04ad72415acd395f1ca5
CRs-Fixed: 1095306
Do not invalidate the HDD context if roaming is in progress.
Move the condition outside of the validation check
Change-Id: Idd56cbbc63ce56000f03fc47b6f1b78d53cb170f
CRs-Fixed: 1094301
qcacld-2.0 to qcacld-3.0 propagation
sta_connected flag check may fail when handle WLAN_STA_CONNECT event.
This will cause enable-ipa operation get skipped for the connect
operation. If a disconnect operation follows, it will invoke fw to
disable the ipa. Fw considers ipa to be disabled by default, so fw
will consider it be double-disable and trigger the crash.
Change-Id: Iaf4855eb1776e8c8c3b027d0ee2beb644063ef75
CRs-Fixed: 1079051
propagation from qcacld-2.0 to qcacld-3.0
When assoc fail, send protocol reason code instead of generic
reason code. Customer complain that it just reports generic
reason for WPA2 AP and cause UI mismatch.
Change-Id: I1b237e70d30f08c364d5aa56182676affdfee105
CRs-Fixed: 1010832
Revert “If26f49386b72864730679e05559b7bba80b5487a” changes
to advertise max value configured as per the WFA certification
requirement 5.2.63 STAUT acting as MU Beamformee.
Change-Id: Ib11f1f5cad89579277eba2e0b9f0cbc3ea26de5c
CRs-Fixed: 1093901
qcacld-2.0 to qcacld-3.0 propogation.
When there is an get_station request from the upper layer during roaming,
the driver returns a cached rssi value but it dosent set the "sinfo->filled"
(station_info_flags) bit flag for the NL80211_STA_INFO_SIGNAL. If this flag
is not set the kernel dosen't update the cached rssi value to upper layer.
To mitigate this issue, set the "sinfo->filled" when returning the
cached value to the upper layer during roaming.
CRs-Fixed: 1084502
Change-Id: If62f7482c8153131daa2d0ea83596e5cd4e3f104
qcacld-2.0 to qcacld-3.0 propagation
Add new resultCode, 'eSIR_SME_JOIN_DEAUTH_FROM_AP_DURING_ADD_STA',
to make sure driver does DEL_STA follwed by DEL_BSS, if driver
receives DEAUTH frame when it's waiting for ADD_STA_RSP.
Change-Id: I697a8bf4e4f4d8b1063ad660395cea33031f1647
CRs-Fixed: 599416
propagation from qcacld-2.0 to qcacld-3.0
DUT is SAP + STA SBSC mode, it takes very long time to recover after
SSR. There are two problems:
1. It clear STA session and create new after SSR, but just clear SAP
session. With sessionId in SAP context, it wrongly use new STA session
to close SAP when terminate hostapd. This is the reason why host wait
stop_bss_event for 10 seconds in cfg80211 stop ap. Set sessionId to
invalid if adapter is SAP mode.
2. In dual-wifi mode, it will start second WLAN if SSR and
WLAN_SVC_FW_CRASHED_IND late. Send this event more earlier.
Change-Id: I10a3f300ac5621463fcce4d0a5e18b2cf1cb8491
CRs-Fixed: 1054612
qcacld-2.0 to qcacld-3.0 propagation
The tCsrRoamProfile memory is not initialized to 0 properly. For the
supported_rates field, it contains a rates array with max size 12
and an integer field numRates which is the actual length of the rates
array. If numRates is not initialized properly and value is unexpected.
it may cause memory access violation error.
CRs-Fixed: 1084846
Change-Id: Ic5b1a13356e835a1186c53768a1d8ab416c9365c
qcacld-2.0 to qcacld-3.0 propagation
In MDM ap+ap case, sometimes kernel issues two skb but has same mem
address of skb head and driver tx desc id is stored in skb head, so the
first id will be overwrote by the second one. Will hit crash when handle
the tx_desc.
The solution is storing tx desc id in sk_buff to avoid the case that two
skb has same tx desc id.
Change-Id: I2186a06ad3ec929683292c4c052904a18427cc64
CRs-Fixed: 951208
qcacld-2.0 to qcacld-3.0 propagation.
Supplicant may send PNO command as disconnection was already informed
to supplicant while disconnection might still be in progress in PE
layer(DEL_STA/DEL_BSS).
Fix to send disconnect indication to upper layers after complete
cleanup.
Change-Id: I976044186eb8e79f709bda618b38815827a3e0c5
CRs-Fixed: 951162
While preparing roam_scan_offload_request in csr, populate QoS parameters
from current sme_session.
Change-Id: I8ec26b61babf15b622d2a96b304f068c15f78795
CRs-Fixed: 1092258
In function csr_issue_11d_scan, num channels is fetched from mac_ctx
before being used to access channel list. Check it against
WNI_CFG_VALID_CHANNEL_LIST_LEN before accessing channel list.
Change-Id: I4ef21ca03e1227801aaed2d5598aba7b91fdf8d3
CRs-Fixed: 1091486
Function lim_send_sme_wm_status_change_ntf is generic function, where
input buffer length depends on status_change_code. Use same code while
checking as max length of input buffer in memcopy operation.
Change-Id: Ie0d761ce7f85c4be9b164d1a281119560d337e01
CRs-Fixed: 1091486
hif_ctx can be NULL and accessing it result in crash
Add NULL check for hif context to avoid crash
CRs-Fixed: 1072608
Change-Id: I979fd09fadb347585ae5a044277d3855d76f94ca
qcacld-2.0 to qcacld-3.0 propagation
1) BSS starting path and STA disassoc path should use
different events to perform synchronization
2) BSS starting event object should be reset before
BSS starting/restarting procedure is initiated
Change-Id: I96efd052fa19227c55c4f3af96afa8d590037c2d
CRs-Fixed: 1091108
Modified the ol_txrx_soc_attach function definition to accept scn
handle parameter which is useful for making function calls
necessary for multi-radio support.
Change-Id: I842d2f184923f019e086f5c6d9b758624a20c8ae
Add Support to configure multiple 'scan plans' for scheduled scan.
Each 'scan plan' defines the number of scan cycles and the interval
between scans. The scan plans are executed in the order they were
configured. The last scan plan will always run infinitely and thus
defines only the interval between scans
The maximum number of scan plans supported by the device and the
maximum number of iterations in a single scan plan are advertised
to userspace so it can configure the scan plans appropriately.
Change-Id: Ie4b76f84ac633f4328137283bdeb2829a942b3d0
CRs-Fixed: 1102402
Sometimes TXRX_PRINT is taking more time to process as
some other printks' are already in progress. As this TXRX_PRINT is
inside spinlock, so when some other core is also competing for
this spinlock, that core keeps iterating in a loop. After some
time spinlock bug is triggered as it is suspected that this core
is locked on this spinlock.
To fix this, move the TXRX_PRINT outside spinlock so that the other
core don't have to wait to acquire spinlock due to this TXRX_PRINT.
CRs-Fixed: 1107213
Change-Id: Ie6f8a7c8f9731883c2440641b8b9542f9d40c4a9
Many branches in the bus suspend/resume code path are missing
appropriate logging. Add error logging for failure cases, and
info logging for enter/exit points.
Change-Id: Ia1d82e2a3d48335b31772a0fa7532ec99c08de4d
CRs-Fixed: 1104790
Include missing header file to fix the undefined API compilation
error and removed unused variable.
CRs-Fixed: 1107859
Change-Id: I4dcf1b0bb19662ba2c1f3af197ca34b656be7d9a
propagation from qcacld-2.0 to qcacld-3.0
During re-association, host does not enable the netif queues
and does not reset the pause bit map from Data flow control
if queues are already paused due to lack of enough descriptors
which is not correct and lead to disconnection.
Host has now centralised mechanism to pause/unpause netif queues
using bitmap, so there is no need to keep the netif queues in paused
state from data flow control path.
To fix this, remove the tx queue unpause check when in reassociation
state.
Change-Id: I8484a18dafbe02e06394a05b409256c586f59908
CRs-Fixed: 1104919
Currently cnss_wlan_enable() and cnss_wlan_disable() APIs are only
used for a temporary emulation case for PCIe bus. Enable to compile
them for all cases for PCIe bus.
Change-Id: I27b1982f89e045564ed991c8a570ebf6a87bcf33
CRs-fixed: 1082183
The current driver inherited support for the "frame_xln_reqd" flag
from a prior version of the driver. In the prior version of the driver
this flag was used to communicate to hardware whether or not
hardware-assisted data frame translation was required. However the
current driver does not use this flag, so remove it from the code.
Change-Id: I41047864de374c12a89fa031c6d38729a285262a
CRs-Fixed: 1075631
We want to enable the compiler's -Wmissing-prototypes switch, but
there is existing code in ol_tx_queue.c which is generating warnings
because not all public APIs have prototypes defined. Define the
missing prototypes for:
ol_txrx_vdev_flush()
ol_txrx_vdev_pause()
ol_txrx_vdev_unpause()
ol_tx_throttle_set_level()
ol_tx_throttle_init_period()
In addition make the following private since they are now only called
internally to ol_tx_queue.c:
ol_tx_pdev_peer_bal_timer()
ol_tx_queue_log_alloc()
ol_tx_queue_display()
Change-Id: I4a3d767c650eefc39c3bf51ce102c8b5de391ec5
CRs-Fixed: 1104127
We want to enable the compiler's -Wmissing-prototypes switch, but
there is existing code which is generating warnings because not all
public APIs have prototypes defined. Define the missing prototype for
ol_txrx_flow_control_cb().
Change-Id: Ifb7fff891b237e6202cc96afd3ab2e21bc4f13aa
CRs-Fixed: 1104126
We want to enable the compiler's -Wmissing-prototypes switch, but
there is existing code in ol_tx.c which is generating warnings because
not all public APIs have prototypes defined. Define the missing
prototypes for:
ol_tx_send_ipa_data_frame()
ol_tx_non_std()
ol_txrx_mgmt_tx_cb_set()
ol_txrx_mgmt_send_ext()
In addition make the following private since they are now only called
internally to ol_tx.c:
ol_tx_non_std_ll()
ol_tx_non_std_hl()
Change-Id: I29f334de30ab492f2ef6c422352d11c059e40f1b
CRs-Fixed: 1104125
We want to enable the compiler's -Wmissing-prototypes switch, but
there is existing code in ol_cfg.c which is generating warnings
because not all public APIs have prototypes defined. Define the
missing prototypes for the following:
ol_pdev_cfg_attach()
ol_set_cfg_rx_fwd_disabled()
ol_set_cfg_packet_log_enabled()
Change-Id: I787d4d7954751cda2878229d1d8967e1c168f95c
CRs-Fixed: 1104124
Currently the qcacld-3.0 driver does not build cleanly when compiled
with the gcc -Wmissing-prototypes switch. One set of warnings is due
to the QCA_COMPUTE_TX_DELAY APIs not being exported properly. Address
the warnings by properly exporting these functions.
Change-Id: Ib0f8a43a4575caf5714709e7fab659aa0b6f3009
CRs-Fixed: 1103659
