فهرست منبع

qcacld-3.0: Properly export ol_cfg.c APIs

We want to enable the compiler's -Wmissing-prototypes switch, but
there is existing code in ol_cfg.c which is generating warnings
because not all public APIs have prototypes defined. Define the
missing prototypes for the following:
	ol_pdev_cfg_attach()
	ol_set_cfg_rx_fwd_disabled()
	ol_set_cfg_packet_log_enabled()

Change-Id: I787d4d7954751cda2878229d1d8967e1c168f95c
CRs-Fixed: 1104124
Jeff Johnson 8 سال پیش
والد
کامیت
bacec0978c
3فایلهای تغییر یافته به همراه35 افزوده شده و 37 حذف شده
  1. 34 1
      core/dp/ol/inc/ol_cfg.h
  2. 1 30
      core/dp/txrx/ol_cfg.c
  3. 0 6
      core/dp/txrx/ol_txrx.c

+ 34 - 1
core/dp/ol/inc/ol_cfg.h

@@ -1,5 +1,5 @@
 /*
- * Copyright (c) 2011-2016 The Linux Foundation. All rights reserved.
+ * Copyright (c) 2011-2017 The Linux Foundation. All rights reserved.
  *
  * Previously licensed under the ISC license by Qualcomm Atheros, Inc.
  *
@@ -114,6 +114,17 @@ void ol_tx_set_flow_control_parameters(struct txrx_pdev_cfg_t *cfg_ctx,
 }
 #endif
 
+/**
+ * ol_pdev_cfg_attach - setup configuration parameters
+ * @osdev: OS handle needed as an argument for some OS primitives
+ * @cfg_param: configuration parameters
+ *
+ * Allocation configuration context that will be used across data path
+ *
+ * Return: the control device object
+ */
+void *ol_pdev_cfg_attach(qdf_device_t osdev, void *pcfg_param);
+
 /**
  * @brief Specify whether the system is high-latency or low-latency.
  * @details
@@ -182,6 +193,28 @@ int ol_cfg_rx_pn_check(ol_pdev_handle pdev);
  */
 int ol_cfg_rx_fwd_check(ol_pdev_handle pdev);
 
+/**
+ * ol_set_cfg_rx_fwd_disabled - set rx fwd disable/enable
+ *
+ * @pdev - handle to the physical device
+ * @disable_rx_fwd 1 -> no rx->tx forward -> rx->tx forward
+ *
+ * Choose whether to forward rx frames to tx (where applicable) within the
+ * WLAN driver, or to leave all forwarding up to the operating system.
+ * Currently only intra-bss fwd is supported.
+ *
+ */
+void ol_set_cfg_rx_fwd_disabled(void *ppdev, uint8_t disable_rx_fwd);
+
+/**
+ * ol_set_cfg_packet_log_enabled - Set packet log config in HTT
+ * config based on CFG ini configuration
+ *
+ * @pdev - handle to the physical device
+ * @val - 0 - disable, 1 - enable
+ */
+void ol_set_cfg_packet_log_enabled(void *ppdev, uint8_t val);
+
 /**
  * @brief Check whether rx forwarding is enabled or disabled.
  * @details

+ 1 - 30
core/dp/txrx/ol_cfg.c

@@ -1,5 +1,5 @@
 /*
- * Copyright (c) 2011-2016 The Linux Foundation. All rights reserved.
+ * Copyright (c) 2011-2017 The Linux Foundation. All rights reserved.
  *
  * Previously licensed under the ISC license by Qualcomm Atheros, Inc.
  *
@@ -98,17 +98,6 @@ uint8_t ol_defrag_timeout_check(void)
  * Many of these should actually be determined dynamically instead.
  */
 
-/**
- * ol_pdev_cfg_attach - setup configuration parameters
- *
- *@osdev - OS handle needed as an argument for some OS primitives
- *@cfg_param - configuration parameters
- *
- * Allocation configuration context that will be used across data path
- *
- * Return: the control device object
- */
-
 void *ol_pdev_cfg_attach(qdf_device_t osdev, void *pcfg_param)
 {
 	struct txrx_pdev_cfg_param_t *cfg_param = pcfg_param;
@@ -191,17 +180,6 @@ int ol_cfg_rx_fwd_check(ol_pdev_handle pdev)
 	return cfg->pn_rx_fwd_check;
 }
 
-/**
- * ol_set_cfg_rx_fwd_disabled - set rx fwd disable/enable
- *
- * @pdev - handle to the physical device
- * @disable_rx_fwd 1 -> no rx->tx forward -> rx->tx forward
- *
- * Choose whether to forward rx frames to tx (where applicable) within the
- * WLAN driver, or to leave all forwarding up to the operating system.
- * Currently only intra-bss fwd is supported.
- *
- */
 void ol_set_cfg_rx_fwd_disabled(void *ppdev, uint8_t disable_rx_fwd)
 {
 	ol_pdev_handle pdev = ppdev;
@@ -209,13 +187,6 @@ void ol_set_cfg_rx_fwd_disabled(void *ppdev, uint8_t disable_rx_fwd)
 	cfg->rx_fwd_disabled = disable_rx_fwd;
 }
 
-/**
- * ol_set_cfg_packet_log_enabled - Set packet log config in HTT
- * config based on CFG ini configuration
- *
- * @pdev - handle to the physical device
- * @val - 0 - disable, 1 - enable
- */
 void ol_set_cfg_packet_log_enabled(void *ppdev, uint8_t val)
 {
 	ol_pdev_handle pdev = ppdev;

+ 0 - 6
core/dp/txrx/ol_txrx.c

@@ -108,12 +108,6 @@ extern void ol_tx_throttle_init_period(void *ppdev, int period,
 
 extern void ol_tx_throttle_set_level(void *ppdev, int level);
 
-extern void ol_set_cfg_rx_fwd_disabled(void *ppdev, uint8_t disable_rx_fwd);
-
-extern void ol_set_cfg_packet_log_enabled(void *ppdev, uint8_t val);
-
-extern void *ol_pdev_cfg_attach(qdf_device_t osdev, void *cfg_param);
-
 extern qdf_nbuf_t ol_tx_send_ipa_data_frame(void *vdev,
 			qdf_nbuf_t skb);