Michal Kubecek 1ae71d997a ethtool: fix error handling in linkstate_prepare_data() ...

When getting SQI or maximum SQI value fails in linkstate_prepare_data(), we
must not return without calling ethnl_ops_complete(dev) as that could
result in imbalance between ethtool_ops ->begin() and ->complete() calls.

Fixes: 8066021915 ("ethtool: provide UAPI for PHY Signal Quality Index (SQI)")
Signed-off-by: Michal Kubecek <mkubecek@suse.cz>
Signed-off-by: David S. Miller <davem@davemloft.net>

2020-06-25 16:17:16 -07:00

3.5 KiB

Raw Blame History

View Raw