Xi Wang 6448669777 libceph: fix overflow check in crush_decode() ...

The existing overflow check (n > ULONG_MAX / b) didn't work, because
n = ULONG_MAX / b would both bypass the check and still overflow the
allocation size a + n * b.

The correct check should be (n > (ULONG_MAX - a) / b).

Signed-off-by: Xi Wang <xi.wang@gmail.com>
Signed-off-by: Sage Weil <sage@newdream.net>

2012-03-22 10:47:45 -05:00

27 KiB

Raw Blame History

View Raw