Paul Kocialkowski
f236a2a2eb
rtc: hym8563: Return -EINVAL if the time is known to be invalid
...
The current code returns -EPERM when the voltage loss bit is set.
Since the bit indicates that the time value is not valid, return
-EINVAL instead, which is the appropriate error code for this
situation.
Fixes: dcaf038493 ("rtc: add hym8563 rtc-driver")
Signed-off-by: Paul Kocialkowski <paul.kocialkowski@bootlin.com >
Link: https://lore.kernel.org/r/20191212153111.966923-1-paul.kocialkowski@bootlin.com
Signed-off-by: Alexandre Belloni <alexandre.belloni@bootlin.com >
2019-12-23 11:18:04 +01:00
Nobuhiro Iwamatsu
aeedfe7f89
rtc: rx8010: Fix return code for rx8010_probe
...
In the current code, the return value of devm_request_threaded_irq may be
returned. This fixes it.
CC: Alessandro Zummo <a.zummo@towertech.it >
CC: Alexandre Belloni <alexandre.belloni@bootlin.com >
CC: Akshay Bhat <akshay.bhat@timesys.com >
Signed-off-by: Nobuhiro Iwamatsu <iwamatsu@nigauri.org >
Link: https://lore.kernel.org/r/20191217121231.2698817-2-iwamatsu@nigauri.org
Signed-off-by: Alexandre Belloni <alexandre.belloni@bootlin.com >
2019-12-23 11:16:23 +01:00
zhengbin
de0505660f
rtc: omap: Remove unneeded semicolon
...
Fixes coccicheck warning:
drivers/rtc/rtc-omap.c:619:2-3: Unneeded semicolon
Reported-by: Hulk Robot <hulkci@huawei.com >
Signed-off-by: zhengbin <zhengbin13@huawei.com >
Link: https://lore.kernel.org/r/1576466353-45384-1-git-send-email-zhengbin13@huawei.com
Signed-off-by: Alexandre Belloni <alexandre.belloni@bootlin.com >
2019-12-23 11:16:23 +01:00
Chuhong Yuan
62cbe63f58
rtc: asm9260: add the missed check for devm_clk_get
...
The driver misses a check for devm_clk_get().
Add the check to fix it.
Signed-off-by: Chuhong Yuan <hslester96@gmail.com >
Link: https://lore.kernel.org/r/20191214074528.16806-1-hslester96@gmail.com
Signed-off-by: Alexandre Belloni <alexandre.belloni@bootlin.com >
2019-12-23 11:16:23 +01:00
Alexandre Belloni
bd0d937928
rtc: rv3029: remove useless error messages
...
Remove redundant messages or messages that would not add any value because
the information is already conveyed properly using errno.
Link: https://lore.kernel.org/r/20191223100108.1083078-1-alexandre.belloni@bootlin.com
Signed-off-by: Alexandre Belloni <alexandre.belloni@bootlin.com >
2019-12-23 11:16:23 +01:00
Alexandre Belloni
fc219291ea
rtc: rv3029: annotate init and exit functions
...
rv30{2,4}9_register_driver and rv30{2,4}9_unregister_driver are only called
from the init and exit functions of the module. Annotate them properly.
Link: https://lore.kernel.org/r/20191223101430.1091572-1-alexandre.belloni@bootlin.com
Signed-off-by: Alexandre Belloni <alexandre.belloni@bootlin.com >
2019-12-23 11:16:23 +01:00
Alexandre Belloni
8e99106c92
rtc: rv3029: drop deprecated compatbiles
...
The compatibles have been marked obsolete for more that 2 years, drop them
now. Note that this doesn't currently prevent the driver from probing
because the i2c core will still match using the i2c_device_id table.
Link: https://lore.kernel.org/r/20191212230239.65784-1-alexandre.belloni@bootlin.com
Signed-off-by: Alexandre Belloni <alexandre.belloni@bootlin.com >
2019-12-23 11:13:50 +01:00
Alexandre Belloni
ec923fcccf
rtc: rv3029: add nvram support
...
Export the 8 byte RAM using nvmem.
Link: https://lore.kernel.org/r/20191214221022.622482-17-alexandre.belloni@bootlin.com
Signed-off-by: Alexandre Belloni <alexandre.belloni@bootlin.com >
2019-12-23 11:13:49 +01:00
Alexandre Belloni
cbc943eb37
rtc: rv3029: let the core handle rtc range
...
Despite the comment, the RV3029 uses a 7bit BCD register for the year,
making 2079 the last supported year.
Link: https://lore.kernel.org/r/20191214221022.622482-14-alexandre.belloni@bootlin.com
Signed-off-by: Alexandre Belloni <alexandre.belloni@bootlin.com >
2019-12-18 10:38:07 +01:00
Alexandre Belloni
9346f87066
rtc: rv3029: convert to devm_rtc_allocate_device
...
This allows further improvement of the driver.
Link: https://lore.kernel.org/r/20191214221022.622482-13-alexandre.belloni@bootlin.com
Signed-off-by: Alexandre Belloni <alexandre.belloni@bootlin.com >
2019-12-18 10:38:06 +01:00
Alexandre Belloni
cff2e4d278
rtc: rv3029: correctly handle PON and VLOW2
...
In case the data is invalid (PON or VLOW2 are set in STATUS, explicitly
tell userspace that the time is invalid. Only remove VLOW2 when setting a
new valid time.
Link: https://lore.kernel.org/r/20191214221022.622482-12-alexandre.belloni@bootlin.com
Signed-off-by: Alexandre Belloni <alexandre.belloni@bootlin.com >
2019-12-18 10:38:04 +01:00
Alexandre Belloni
f630f728a9
rtc: rv3029: add RTC_VL_READ and RTC_VL_CLEAR support
...
The RV3029 can report three different conditions: power on, voltage dropped
and data is lost and voltage is low and temperature compensation has
stopped. The first two conditions amount to the same status, the RTC data
is invalid.
VLOW1 has to be cleared manually to resume temperature compensation, this
is achieved using RTC_VL_CLEAR.
Link: https://lore.kernel.org/r/20191214221022.622482-11-alexandre.belloni@bootlin.com
Signed-off-by: Alexandre Belloni <alexandre.belloni@bootlin.com >
2019-12-18 10:38:02 +01:00
Alexandre Belloni
7518dd9a93
rtc: rv3029: drop rv3029_read_regs and rv3029_write_regs
...
rv3029_read_regs and rv3029_write_regs are simply calling
regmap_bulk_{read,write}. Drop them and call regmap_{,bulk}_{read,write} as
appropriate.
Link: https://lore.kernel.org/r/20191214221022.622482-10-alexandre.belloni@bootlin.com
Signed-off-by: Alexandre Belloni <alexandre.belloni@bootlin.com >
2019-12-18 10:38:01 +01:00
Alexandre Belloni
8fd3d609a5
rtc: rv3029: simplify rv3029_set_alarm
...
It is unecessay to test alarm->enabled before calling
rv3029_alarm_irq_enable.
Link: https://lore.kernel.org/r/20191214221022.622482-9-alexandre.belloni@bootlin.com
Signed-off-by: Alexandre Belloni <alexandre.belloni@bootlin.com >
2019-12-18 10:37:59 +01:00
Alexandre Belloni
38ce8e30f3
rtc: rv3029: simplify rv3029_alarm_irq_enable
...
Use regmap_update_bits instead of open coding it in
rv3029_alarm_irq_enable.
Link: https://lore.kernel.org/r/20191214221022.622482-8-alexandre.belloni@bootlin.com
Signed-off-by: Alexandre Belloni <alexandre.belloni@bootlin.com >
2019-12-18 10:37:57 +01:00
Alexandre Belloni
bb72dbba83
rtc: rv3029: get rid of rv3029_get_sr
...
There is no point in having 2 indirections before calling regmap_read,
especially since rv3029_get_sr also changes the return value without any
good reason. Call regmap_read directly.
Link: https://lore.kernel.org/r/20191214221022.622482-7-alexandre.belloni@bootlin.com
Signed-off-by: Alexandre Belloni <alexandre.belloni@bootlin.com >
2019-12-18 10:37:56 +01:00
Alexandre Belloni
35c2daaf55
rtc: rv3029: avoid reading the status register uselessly
...
RV3029_STATUS is read in multiple location but its value is never used
afterwards. Avoid this register access when not necessary.
Link: https://lore.kernel.org/r/20191214221022.622482-6-alexandre.belloni@bootlin.com
Signed-off-by: Alexandre Belloni <alexandre.belloni@bootlin.com >
2019-12-18 10:37:54 +01:00
Alexandre Belloni
54c5970df4
rtc: rv3029: remove race condition when update STATUS
...
There is no lock preventing concurrent access to the status register from
bth the rtc subsystem and the hwmon subsystem. Use regmap_update_bits to
ensure updating RV3029_STATUS is properly locked.
Link: https://lore.kernel.org/r/20191214221022.622482-5-alexandre.belloni@bootlin.com
Signed-off-by: Alexandre Belloni <alexandre.belloni@bootlin.com >
2019-12-18 10:37:52 +01:00
Alexandre Belloni
609e97fe31
rtc: rv3029: remove open coded regmap_update_bits
...
rv3029_update_bits open codes regmap_update_bits and forgets to properly
lock the register range while doing so. Use regmap_update_bits instead.
Link: https://lore.kernel.org/r/20191214221022.622482-4-alexandre.belloni@bootlin.com
Signed-off-by: Alexandre Belloni <alexandre.belloni@bootlin.com >
2019-12-18 10:37:51 +01:00
Alexandre Belloni
c509e4344b
rtc: rv3029: let regmap validate the register ranges
...
Instead of trying to validate the accessed registers in custom functions,
let regmap handle that. This allows to defines all the holes in the
register range and gives access to the regmap debugfs register dump.
Link: https://lore.kernel.org/r/20191214221022.622482-3-alexandre.belloni@bootlin.com
Signed-off-by: Alexandre Belloni <alexandre.belloni@bootlin.com >
2019-12-18 10:37:49 +01:00
Alexandre Belloni
9b45ef9774
rtc: rv3029: use proper name for the driver
...
The correct name for the rtc is rv3029. c2 is actually the package form
factor rv3029c3 exists and simply has a smaller form factor.
Link: https://lore.kernel.org/r/20191214221022.622482-2-alexandre.belloni@bootlin.com
Signed-off-by: Alexandre Belloni <alexandre.belloni@bootlin.com >
2019-12-18 10:37:47 +01:00
Alexandre Belloni
8049c11399
rtc: rx8010: return meaningful value for RTC_VL_READ
...
RX8010_FLAG_VLF means the voltage dropped too low and data has been lost.
Link: https://lore.kernel.org/r/20191214220259.621996-18-alexandre.belloni@bootlin.com
Signed-off-by: Alexandre Belloni <alexandre.belloni@bootlin.com >
2019-12-18 10:37:45 +01:00
Alexandre Belloni
894b043200
rtc: rx8010: remove RTC_VL_CLR handling
...
Remove RTC_VL_CLR handling because it is a disservice to userspace as it
removes the important information that the RTC data is invalid. This may
lead userspace to set an invalid system time later on.
Link: https://lore.kernel.org/r/20191214220259.621996-17-alexandre.belloni@bootlin.com
Signed-off-by: Alexandre Belloni <alexandre.belloni@bootlin.com >
2019-12-18 10:37:44 +01:00
Alexandre Belloni
bcd17c5082
rtc: rv8803: return meaningful value for RTC_VL_READ
...
RV8803_FLAG_V1F means the voltage is too low to keep the temperature
compensation running and the accuracy of the RTC is affected.
RV8803_FLAG_V2F means the voltage dropped so low that data is now invalid.
Link: https://lore.kernel.org/r/20191214220259.621996-16-alexandre.belloni@bootlin.com
Signed-off-by: Alexandre Belloni <alexandre.belloni@bootlin.com >
2019-12-18 10:37:42 +01:00
Alexandre Belloni
7e890a0f0e
rtc: rv8803: avoid clearing RV8803_FLAG_V2F in RTC_VL_CLR
...
Stop clearing RV8803_FLAG_V2F in RTC_VL_CLR because it is a disservice to
userspace as it removes the important information that the RTC data is
invalid. This may lead userspace to set an invalid system time later on.
Link: https://lore.kernel.org/r/20191214220259.621996-15-alexandre.belloni@bootlin.com
Signed-off-by: Alexandre Belloni <alexandre.belloni@bootlin.com >
2019-12-18 10:37:40 +01:00
Alexandre Belloni
86e655f9f3
rtc: rv3028: return meaningful value for RTC_VL_READ
...
RV3028_STATUS_PORF means the voltage dropped too low and data has been
lost.
Link: https://lore.kernel.org/r/20191214220259.621996-14-alexandre.belloni@bootlin.com
Signed-off-by: Alexandre Belloni <alexandre.belloni@bootlin.com >
2019-12-18 10:37:39 +01:00
Alexandre Belloni
92c02daaba
rtc: rv3028: remove RTC_VL_CLR handling
...
Remove RTC_VL_CLR handling because it is a disservice to userspace as it
removes the important information that the RTC data is invalid. This may
lead userspace to set an invalid system time later on.
Link: https://lore.kernel.org/r/20191214220259.621996-13-alexandre.belloni@bootlin.com
Signed-off-by: Alexandre Belloni <alexandre.belloni@bootlin.com >
2019-12-18 10:37:37 +01:00
Alexandre Belloni
f86dc5bde1
rtc: pcf85063: return meaningful value for RTC_VL_READ
...
PCF85063_REG_SC_OS means the voltage dropped too low and data has been
lost.
Link: https://lore.kernel.org/r/20191214220259.621996-12-alexandre.belloni@bootlin.com
Signed-off-by: Alexandre Belloni <alexandre.belloni@bootlin.com >
2019-12-18 10:37:35 +01:00
Alexandre Belloni
0295c27f90
rtc: pcf85063: remove RTC_VL_CLR handling
...
Remove RTC_VL_CLR handling because it is a disservice to userspace as it
removes the important information that the RTC data is invalid. This may
lead userspace to set an invalid system time later on.
Link: https://lore.kernel.org/r/20191214220259.621996-11-alexandre.belloni@bootlin.com
Signed-off-by: Alexandre Belloni <alexandre.belloni@bootlin.com >
2019-12-18 10:37:33 +01:00
Alexandre Belloni
b371b10e94
rtc: pcf8563: return meaningful value for RTC_VL_READ
...
PCF8563_SC_LV means the voltage dropped too low and data has been lost.
Link: https://lore.kernel.org/r/20191214220259.621996-10-alexandre.belloni@bootlin.com
Signed-off-by: Alexandre Belloni <alexandre.belloni@bootlin.com >
2019-12-18 10:37:32 +01:00
Alexandre Belloni
935272aade
rtc: pcf8563: stop caching voltage_low
...
voltage_low is only updated when reading the time, this means that using
RTC_VL_READ will miss the VL flag if the time has not been read before
using the ioctl. Always read the status from the hardware.
Link: https://lore.kernel.org/r/20191214220259.621996-9-alexandre.belloni@bootlin.com
Signed-off-by: Alexandre Belloni <alexandre.belloni@bootlin.com >
2019-12-18 10:37:30 +01:00
Alexandre Belloni
75d26f5c23
rtc: pcf8563: remove conditional compilation
...
Always compile pcf8563_rtc_ioctl as we are sure that CONFIG_RTC_INTF_DEV is
selected on actual kernel configurations.
Link: https://lore.kernel.org/r/20191214220259.621996-8-alexandre.belloni@bootlin.com
Signed-off-by: Alexandre Belloni <alexandre.belloni@bootlin.com >
2019-12-18 10:37:28 +01:00
Alexandre Belloni
d268f4bd42
rtc: pcf8563: remove RTC_VL_CLR handling
...
Remove RTC_VL_CLR handling because it is a disservice to userspace as it
removes the important information that the RTC data is invalid. This may
lead userspace to set an invalid system time later on.
Link: https://lore.kernel.org/r/20191214220259.621996-7-alexandre.belloni@bootlin.com
Signed-off-by: Alexandre Belloni <alexandre.belloni@bootlin.com >
2019-12-18 10:37:27 +01:00
Alexandre Belloni
244cf8f0ed
rtc: pcf8523: return meaningful value for RTC_VL_READ
...
REG_CONTROL3_BLF indicates the battery is low and needs to be replaced
soon.
Link: https://lore.kernel.org/r/20191214220259.621996-6-alexandre.belloni@bootlin.com
Signed-off-by: Alexandre Belloni <alexandre.belloni@bootlin.com >
2019-12-18 10:37:25 +01:00
Alexandre Belloni
af4273116d
rtc: pcf2127: return meaningful value for RTC_VL_READ
...
PCF2127_BIT_CTRL3_BLF indicates the battery is low and needs to be replaced
soon.
Link: https://lore.kernel.org/r/20191214220259.621996-5-alexandre.belloni@bootlin.com
Signed-off-by: Alexandre Belloni <alexandre.belloni@bootlin.com >
2019-12-18 10:37:23 +01:00
Alexandre Belloni
9f05342a97
rtc: abx80x: return meaningful value for RTC_VL_READ
...
ABX8XX_STATUS_BLF indicates the battery is low and needs to be replaced
soon.
Link: https://lore.kernel.org/r/20191214220259.621996-4-alexandre.belloni@bootlin.com
Signed-off-by: Alexandre Belloni <alexandre.belloni@bootlin.com >
2019-12-18 10:37:21 +01:00
Linus Walleij
3b52093dc9
rtc: ds1343: Do not hardcode SPI mode flags
...
The current use of mode flags to us SPI_MODE_3 and
SPI_CS_HIGH is fragile: it overwrites anything already
assigned by the SPI core. Change it thusly:
- Just |= the SPI_MODE_3 so we keep other flags
- Assign ^= SPI_CS_HIGH since we might be active high
already, and that is usually the case with GPIOs used
for chip select, even if they are in practice active low.
Add a comment clarifying why ^= SPI_CS_HIGH is the right
choice here.
Reported-by: Mark Brown <broonie@kernel.org >
Signed-off-by: Linus Walleij <linus.walleij@linaro.org >
Link: https://lore.kernel.org/r/20191204225731.20306-1-linus.walleij@linaro.org
Signed-off-by: Alexandre Belloni <alexandre.belloni@bootlin.com >
2019-12-10 17:47:16 +01:00
Jean-Francois Dagenais
519d63702d
rtc: zynqmp: re-use rtc_time64_to_tm operation
...
This allows a subsequent commit to spin_unlock sooner.
Signed-off-by: Jean-Francois Dagenais <jeff.dagenais@gmail.com >
Reviewed-by: Michal Simek <michal.simek@xilinx.com >
Link: https://lore.kernel.org/r/20191128015613.10003-1-jeff.dagenais@gmail.com
Signed-off-by: Alexandre Belloni <alexandre.belloni@bootlin.com >
2019-12-10 16:49:20 +01:00
Chuhong Yuan
cf33e911f5
rtc: stm32: add missed clk_disable_unprepare in error path of resume
...
The resume() forgets to call clk_disable_unprepare() when failed.
Add the missed call to fix it.
Signed-off-by: Chuhong Yuan <hslester96@gmail.com >
Reviewed-by: Amelie Delaunay <amelie.delaunay@st.com >
Link: https://lore.kernel.org/r/20191205160655.32188-1-hslester96@gmail.com
Signed-off-by: Alexandre Belloni <alexandre.belloni@bootlin.com >
2019-12-10 14:29:23 +01:00
Wei Yongjun
751438bc0f
rtc: mt6397: drop free_irq of devm_ allocated irq
...
The devm_request_threaded_irq function allocates irq that is
released when a driver detaches. Thus, there is no reason to
explicitly call free_irq in probe function.
Fixes: 851b87148a ("rtc: mt6397: improvements of rtc driver")
Reported-by: Hulk Robot <hulkci@huawei.com >
Signed-off-by: Wei Yongjun <weiyongjun1@huawei.com >
Link: https://lore.kernel.org/r/20191113021720.9527-1-weiyongjun1@huawei.com
Signed-off-by: Alexandre Belloni <alexandre.belloni@bootlin.com >
2019-12-10 14:25:34 +01:00
Linus Torvalds
4672c2f202
Merge tag 'rtc-5.5' of git://git.kernel.org/pub/scm/linux/kernel/git/abelloni/linux
...
Pull RTC updates from Alexandre Belloni:
"A lot of unnecessary code removal in here that ends up decreasing the
number of lines in the subsystem. The ds1343 and ds1347 drivers got
cleaned up. The rest are the usual fixes and new features.
Subsystem:
- fix warnings and errors with make W=1
- UIE are now disabled while setting the RTC time
- UIE are now disallowed when the RTC time is not set.
Drivers:
- remove unecessary .remove callbacks
- Set RTC range for cros-ec, ds1343, ds1347, m41t80, s35390a, vt8500
- Use devm_platform_ioremap_resource where applicable
- rv3028: add clock out support"
* tag 'rtc-5.5' of git://git.kernel.org/pub/scm/linux/kernel/git/abelloni/linux: (81 commits)
rtc: Fix Kconfig indentation
rtc: xgene: Remove unused struct device in struct xgene_rtc_dev
rtc: sun6i: Remove struct device from sun6i_rtc_dev
rtc: st-lpc: Remove struct resource from struct st_rtc
rtc: pcf8523: Remove struct pcf8523
rtc: meson: remove redundant assignment to variable retries
rtc: v3020: remove set but unused variable
rtc: tegra: remove set but unused variable
rtc: pm8xxx: update kerneldoc for struct pm8xxx_rtc
rtc: m41t80: remove excess kerneldoc
rtc: ds1685: fix build error with make W=1
rtc: ds1685: remove set but unused variables
rtc: ds1374: remove unused variable
rtc: sysfs: fix hctosys_show kerneldoc
rtc: interface: fix kerneldoc comments
rtc: msm6242: Remove unneeded msm6242_set()/msm6242_clear() functions
rtc: msm6242: Fix reading of 10-hour digit
rtc: tps65910: allow using RTC without alarm interrupt
rtc: fsl-ftm-alarm: remove select FSL_RCPM and default y from Kconfig
rtc: pcf8563: Constify clkout_rates
...
2019-12-03 13:31:08 -08:00
Linus Torvalds
37323918ca
Merge tag 'mfd-next-5.5' of git://git.kernel.org/pub/scm/linux/kernel/git/lee/mfd
...
Pull MFD updates from Lee Jones:
"Core Frameworks:
- Add support for a "resource managed strongly uncachable ioremap"
call
- Provide a collection of MFD helper macros
- Remove mfd_clone_cell() from MFD core
- Add NULL de-reference protection in MFD core
- Remove superfluous function fd_platform_add_cell() from MFD core
- Honour Device Tree's request to disable a device
New Drivers:
- Add support for MediaTek MT6323 PMIC
New Device Support:
- Add support for Gemini Lake to Intel LPSS PCI
- Add support for Cherry Trail Crystal Cover PMIC to Intel SoC PMIC
CRC
- Add support for PM{I}8950 to Qualcomm SPMI PMIC
- Add support for U8420 to ST-Ericsson DB8500
- Add support for Comet Lake PCH-H to Intel LPSS PCI
New Functionality:
- Add support for requested supply clocks; madera-core
Fix-ups:
- Lower interrupt priority; rk808
- Use provided helpers (macros, group functions, defines); rk808,
ipaq-micro, ab8500-core, db8500-prcmu, mt6397-core, cs5535-mfd
- Only allocate IRQs on request; max77620
- Use simplified API; arizona-core
- Remove redundant and/or duplicated code; wm8998-tables, arizona,
syscon
- Device Tree binding fix-ups; madera, max77650, max77693
- Remove mfd_cell->id abuse hack; cs5535-mfd
- Remove only user of mfd_clone_cell(); cs5535-mfd
- Make resources static; rohm-bd70528
Bug Fixes:
- Fix product ID for RK818; rk808
- Fix Power Key; rk808
- Fix booting on the BananaPi; mt6397-core
- Endian fix-ups; twl.h
- Fix static error checker warnings; ti_am335x_tscadc"
* tag 'mfd-next-5.5' of git://git.kernel.org/pub/scm/linux/kernel/git/lee/mfd: (47 commits)
Revert "mfd: syscon: Set name of regmap_config"
mfd: ti_am335x_tscadc: Fix static checker warning
mfd: bd70528: Staticize bit value definitions
mfd: mfd-core: Honour Device Tree's request to disable a child-device
dt-bindings: mfd: max77693: Fix missing curly brace
mfd: intel-lpss: Add Intel Comet Lake PCH-H PCI IDs
mfd: db8500-prcmu: Support U8420-sysclk firmware
dt-bindings: mfd: max77650: Convert the binding document to yaml
mfd: mfd-core: Move pdev->mfd_cell creation back into mfd_add_device()
mfd: mfd-core: Remove usage counting for .{en,dis}able() call-backs
x86: olpc-xo1-sci: Remove invocation of MFD's .enable()/.disable() call-backs
x86: olpc-xo1-pm: Remove invocation of MFD's .enable()/.disable() call-backs
mfd: mfd-core: Remove mfd_clone_cell()
mfd: mfd-core: Protect against NULL call-back function pointer
mfd: cs5535-mfd: Register clients using their own dedicated MFD cell entries
mfd: cs5535-mfd: Request shared IO regions centrally
mfd: cs5535-mfd: Remove mfd_cell->id hack
mfd: cs5535-mfd: Use PLATFORM_DEVID_* defines and tidy error message
mfd: intel_soc_pmic_crc: Add "cht_crystal_cove_pmic" cell to CHT cells
mfd: madera: Add support for requesting the supply clocks
...
2019-12-01 16:16:31 -08:00
Krzysztof Kozlowski
f830f7cf47
rtc: Fix Kconfig indentation
...
Adjust indentation from spaces to tab (+optional two spaces) as in
coding style with command like:
$ sed -e 's/^ /\t/' -i */Kconfig
Signed-off-by: Krzysztof Kozlowski <krzk@kernel.org >
Link: https://lore.kernel.org/r/20191120133940.13881-1-krzk@kernel.org
Signed-off-by: Alexandre Belloni <alexandre.belloni@bootlin.com >
2019-11-27 09:31:14 +01:00
Nobuhiro Iwamatsu
fa60b7e838
rtc: xgene: Remove unused struct device in struct xgene_rtc_dev
...
struct device in struct xgene_rtc_dev is not used, remove it.
Signed-off-by: Nobuhiro Iwamatsu <iwamatsu@nigauri.org >
Link: https://lore.kernel.org/r/20191123090234.32180-1-nobuhiro1.iwamatsu@toshiba.co.jp
Signed-off-by: Alexandre Belloni <alexandre.belloni@bootlin.com >
2019-11-27 09:31:14 +01:00
Nobuhiro Iwamatsu
8532bd5d3f
rtc: sun6i: Remove struct device from sun6i_rtc_dev
...
struct device in struct sun6i_rtc_dev is not used, remove it.
Signed-off-by: Nobuhiro Iwamatsu <iwamatsu@nigauri.org >
Link: https://lore.kernel.org/r/20191123090538.32364-1-nobuhiro1.iwamatsu@toshiba.co.jp
Signed-off-by: Alexandre Belloni <alexandre.belloni@bootlin.com >
2019-11-27 09:31:14 +01:00
Nobuhiro Iwamatsu
4f8aadea23
rtc: st-lpc: Remove struct resource from struct st_rtc
...
struct resource in struct st_rtc is not used, remove it.
Signed-off-by: Nobuhiro Iwamatsu <iwamatsu@nigauri.org >
Link: https://lore.kernel.org/r/20191123091241.1905-1-nobuhiro1.iwamatsu@toshiba.co.jp
Signed-off-by: Alexandre Belloni <alexandre.belloni@bootlin.com >
2019-11-27 09:31:14 +01:00
Nobuhiro Iwamatsu
93966243cf
rtc: pcf8523: Remove struct pcf8523
...
struct pcf8523 is referenced only by pcf8523_probe(). And member variable in
this is not referenced by any function. Remove struct pcf8523.
Signed-off-by: Nobuhiro Iwamatsu <iwamatsu@nigauri.org >
Link: https://lore.kernel.org/r/20191123090838.1619-1-nobuhiro1.iwamatsu@toshiba.co.jp
Signed-off-by: Alexandre Belloni <alexandre.belloni@bootlin.com >
2019-11-27 09:31:14 +01:00
Colin Ian King
60bd22fc90
rtc: meson: remove redundant assignment to variable retries
...
The variable retries is being initialized with a value that is never
read and it is being updated later with a new value in a for-loop.
The initialization is redundant and can be removed.
Addresses-Coverity: ("Unused value")
Signed-off-by: Colin Ian King <colin.king@canonical.com >
Reviewed-by: Martin Blumenstingl <martin.blumenstingl@googlemail.com >
Link: https://lore.kernel.org/r/20191122225210.109172-1-colin.king@canonical.com
Signed-off-by: Alexandre Belloni <alexandre.belloni@bootlin.com >
2019-11-27 09:31:13 +01:00
Alexandre Belloni
42397492fb
rtc: v3020: remove set but unused variable
...
Fix the following warning:
drivers/rtc/rtc-v3020.c: In function ‘rtc_probe’:
drivers/rtc/rtc-v3020.c:287:6: warning: variable ‘temp’ set but not used [-Wunused-but-set-variable]
Link: https://lore.kernel.org/r/20191122102212.400158-9-alexandre.belloni@bootlin.com
Signed-off-by: Alexandre Belloni <alexandre.belloni@bootlin.com >
2019-11-27 09:31:13 +01:00
Alexandre Belloni
8321c2ecb2
rtc: tegra: remove set but unused variable
...
Fix the following warning:
drivers/rtc/rtc-tegra.c: In function ‘tegra_rtc_read_time’:
drivers/rtc/rtc-tegra.c:106:11: warning: variable ‘msec’ set but not used [-Wunused-but-set-variable]
Cc: Thierry Reding <thierry.reding@gmail.com >
Cc: Jonathan Hunter <jonathanh@nvidia.com >
Acked-by: Thierry Reding <treding@nvidia.com >
Link: https://lore.kernel.org/r/20191122102212.400158-8-alexandre.belloni@bootlin.com
Signed-off-by: Alexandre Belloni <alexandre.belloni@bootlin.com >
2019-11-27 09:31:13 +01:00