Files
android_kernel_xiaomi_sm8450/drivers/rtc
Linus Walleij 3b52093dc9 rtc: ds1343: Do not hardcode SPI mode flags
The current use of mode flags to us SPI_MODE_3 and
SPI_CS_HIGH is fragile: it overwrites anything already
assigned by the SPI core. Change it thusly:

- Just |= the SPI_MODE_3 so we keep other flags
- Assign ^= SPI_CS_HIGH since we might be active high
  already, and that is usually the case with GPIOs used
  for chip select, even if they are in practice active low.

Add a comment clarifying why ^= SPI_CS_HIGH is the right
choice here.

Reported-by: Mark Brown <broonie@kernel.org>
Signed-off-by: Linus Walleij <linus.walleij@linaro.org>
Link: https://lore.kernel.org/r/20191204225731.20306-1-linus.walleij@linaro.org
Signed-off-by: Alexandre Belloni <alexandre.belloni@bootlin.com>
2019-12-10 17:47:16 +01:00
..
2019-11-27 09:31:14 +01:00
2019-11-08 16:14:09 +01:00
2019-11-08 16:14:09 +01:00
2019-04-16 18:06:54 +02:00
2019-04-04 10:07:10 +02:00
2016-05-20 12:33:51 +02:00
2019-10-19 23:16:57 +02:00
2019-10-19 22:33:05 +02:00
2019-11-08 16:14:09 +01:00
2019-11-08 16:14:09 +01:00
2019-05-23 17:44:52 +02:00
2019-11-27 09:31:13 +01:00
2019-05-08 22:14:36 +02:00