Omkar Sai Sandeep Katadi
d17f5a05b1
Merge remote-tracking branch into HEAD
...
* keystone/mirror-android12-5.10-2024-01: (31 commits)
FROMGIT: PM / devfreq: Synchronize devfreq_monitor_[start/stop]
UPSTREAM: dm verity: don't perform FEC for failed readahead IO
UPSTREAM: netfilter: nft_set_pipapo: skip inactive elements during set walk
UPSTREAM: ipv4: igmp: fix refcnt uaf issue when receiving igmp query packet
UPSTREAM: x86/sev: Check for user-space IOIO pointing to kernel space
UPSTREAM: x86/sev: Check IOBM for IOIO exceptions from user-space
UPSTREAM: nvmet-tcp: Fix a possible UAF in queue intialization setup
FROMLIST: binder: fix memory leaks of spam and pending work
ANDROID: Snapshot Mainline's version of checkpatch.pl
ANDROID: scsi: ufs: vendor check response and recovery addition
ANDROID: scsi: ufs: add perf heuristic design
ANDROID: ABI: Update symbol list for Mediatek
ANDROID: Add vendor hook for ufs perf heuristic and error recovery
UPSTREAM: io_uring/fdinfo: lock SQ thread while retrieving thread cpu/pid
UPSTREAM: ufs: core: wlun send SSU timeout recovery
ANDROID: GKI: db845c: Update symbols list and ABI on rpmsg_register_device_override
ANDROID: fix up rpmsg_device ABI break
ANDROID: fix up platform_device ABI break
UPSTREAM: rpmsg: Fix possible refcount leak in rpmsg_register_device_override()
UPSTREAM: rpmsg: glink: Release driver_override
...
Change-Id: Id3f746423cbd37cfd3c5067624b47d5862806306
2024-01-17 21:35:03 +00:00
keystone-kernel-automerger
8b95ddb951
Merge android12-5.10-2023-11_r3 into HEAD
...
* commit '347e22ab61eedb6b491c16dc69edfe09dd777efe':
ANDROID: ABI: Update symbol list for Mediatek
ANDROID: Add vendor hook for ufs perf heuristic and error recovery
ANDROID: scsi: ufs: add perf heuristic design
ANDROID: scsi: ufs: vendor check response and recovery addition
Change-Id: Icb614f76c3110e14e1f24608d08c496d64611ab3
Signed-off-by: keystone-kernel-automerger <keystone-kernel-automerger@google.com >
2024-01-09 18:30:40 +00:00
Viktor Martensson
26d1d50930
ANDROID: Initialize android12-5.10-2024-01
...
Bug: 317142228
Signed-off-by: Viktor Martensson <vmartensson@google.com >
Change-Id: I1c6e83ac5e853f5aa1aebc51af987098b29fcd60
2024-01-05 18:26:54 +00:00
Browse Zhang
347e22ab61
ANDROID: ABI: Update symbol list for Mediatek
...
Add below symbols into MTK symbol list
7 function symbols added
'int __tracepoint__android_vh_ufs_perf_huristic_ctrl(void*,
struct ufs_hba*, struct ufshcd_lrb*, int *)'
'int __tracepoint__android_vh_ufs_send_command_post_change(
void*, struct ufs_hba*, struct ufshcd_lrb*)'
'int __tracepoint__android_vh_ufs_abort_success_ctrl(void*,
struct ufs_hba*, struct ufshcd_lrb*)'
'int __tracepoint__android_vh_ufs_compl_rsp_check_done(void*,
struct ufs_hba*, struct ufshcd_lrb*, bool*)'
'int __tracepoint__android_vh_ufs_err_handler(void*, struct
ufs_hba*, bool*)'
'int __tracepoint__android_vh_ufs_err_check_ctrl(void*, struct
ufs_hba*, bool*)'
'int __tracepoint__android_vh_ufs_err_print_ctrl(void*, struct
ufs_hba*, bool*)'
7 variable symbols added
'struct __tracepoint__android_vh_ufs_perf_huristic_ctrl'
'struct __tracepoint__android_vh_ufs_send_command_post_change'
'struct __tracepoint__android_vh_ufs_abort_success_ctrl'
'struct __tracepoint__android_vh_ufs_compl_rsp_check_done'
'struct __tracepoint__android_vh_ufs_err_handler'
'struct __tracepoint__android_vh_ufs_err_check_ctrl'
'struct __tracepoint__android_vh_ufs_err_print_ctrl'
Bug: 312806167
Bug: 318440193
Change-Id: I0134d606c09f26e061439e5f179aab2b482fa10a
Signed-off-by: Sanjeev Yadav <sanjeev.y@mediatek.com >
Signed-off-by: Browse Zhang <browse.zhang@mediatek.com >
(cherry picked from commit 83578817d0
2024-01-05 10:02:31 +00:00
Browse Zhang
5c4229df61
ANDROID: Add vendor hook for ufs perf heuristic and error recovery
...
Added vendor hook to consider ufs host/device perf heuristic
and error recovery according to different platform/design
Vendor/Platform can take necessary action according to their
design/implementation
Added vendor hook before calling UFS command ops
- trace_android_vh_ufs_perf_huristic_ctrl
Added vendor hook after sending UFS command to host
- trace_android_vh_ufs_send_command_post_change
Added vendor hook for abort success case
- trace_android_vh_ufs_abort_success_ctrl
Added vendor hook for completion response check
- trace_android_vh_ufs_compl_rsp_check_done
Added vendor hook for vendor specific error handling
- trace_android_vh_ufs_err_handler
Added vendor hook for err logs printing control
- trace_android_vh_ufs_err_print_ctrl
Added vendor hook for error checking flow trigger
- trace_android_vh_ufs_err_check_ctrl
Bug: 312806167
Bug: 318440193
Change-Id: I2190afe62b60da9d47001307f858f10fc8a59986
Signed-off-by: Sanjeev Yadav <sanjeev.y@mediatek.com >
Signed-off-by: Browse Zhang <browse.zhang@mediatek.com >
(cherry picked from commit 85d8fb9163
2024-01-05 10:02:22 +00:00
Browse Zhang
b4e30faae0
ANDROID: scsi: ufs: add perf heuristic design
...
Added vendor hook to consider ufs host/device perf heuristic
according to different platform/design
Vendor/Platform can take necessary action according to their
design/implementation
Added vendor hook before calling UFS command ops
- trace_android_vh_ufs_perf_huristic_ctrl
Added vendor hook after sending UFS command to host
- trace_android_vh_ufs_send_command_post_change
Added vendor hook for abort success case
- trace_android_vh_ufs_abort_success_ctrl
Bug: 312806167
Bug: 318440193
Signed-off-by: Sanjeev Yadav <sanjeev.y@mediatek.com >
Signed-off-by: Browse Zhang <browse.zhang@mediatek.com >
Change-Id: Ibd07480d1086ec82f2ba6a52e21da08750796221
(cherry picked from commit 4246d242fa
2024-01-05 10:02:07 +00:00
Browse Zhang
850eb94047
ANDROID: scsi: ufs: vendor check response and recovery addition
...
As per Vendor HW design consideration,
added Vendor specific error handling flow
Under the error checking flow, Vendor can check errors as per their HW design/arch and recover
them accordingly.
Added vendor hook for completion response check
- trace_android_vh_ufs_compl_rsp_check_done
Added vendor hook for vendor specific error handling
- trace_android_vh_ufs_err_handler
Added vendor hook for err logs printing control
- trace_android_vh_ufs_err_print_ctrl
Added vendor hook for error checking flow trigger
- trace_android_vh_ufs_err_check_ctrl
Bug: 312806167
Bug: 318440193
Change-Id: I614737218537f197c68780f5b528b1948d5e29ea
Signed-off-by: Sanjeev Yadav <sanjeev.y@mediatek.com >
Signed-off-by: Browse Zhang <browse.zhang@mediatek.com >
(cherry picked from commit b39b9bde93
2024-01-03 02:43:35 +00:00
Mukesh Ojha
99512f1216
FROMGIT: PM / devfreq: Synchronize devfreq_monitor_[start/stop]
...
There is a chance if a frequent switch of the governor
done in a loop result in timer list corruption where
timer cancel being done from two place one from
cancel_delayed_work_sync() and followed by expire_timers()
can be seen from the traces[1].
while true
do
echo "simple_ondemand" > /sys/class/devfreq/1d84000.ufshc/governor
echo "performance" > /sys/class/devfreq/1d84000.ufshc/governor
done
It looks to be issue with devfreq driver where
device_monitor_[start/stop] need to synchronized so that
delayed work should get corrupted while it is either
being queued or running or being cancelled.
Let's use polling flag and devfreq lock to synchronize the
queueing the timer instance twice and work data being
corrupted.
[1]
...
..
<idle>-0 [003] 9436.209662: timer_cancel timer=0xffffff80444f0428
<idle>-0 [003] 9436.209664: timer_expire_entry timer=0xffffff80444f0428 now=0x10022da1c function=__typeid__ZTSFvP10timer_listE_global_addr baseclk=0x10022da1c
<idle>-0 [003] 9436.209718: timer_expire_exit timer=0xffffff80444f0428
kworker/u16:6-14217 [003] 9436.209863: timer_start timer=0xffffff80444f0428 function=__typeid__ZTSFvP10timer_listE_global_addr expires=0x10022da2b now=0x10022da1c flags=182452227
vendor.xxxyyy.ha-1593 [004] 9436.209888: timer_cancel timer=0xffffff80444f0428
vendor.xxxyyy.ha-1593 [004] 9436.216390: timer_init timer=0xffffff80444f0428
vendor.xxxyyy.ha-1593 [004] 9436.216392: timer_start timer=0xffffff80444f0428 function=__typeid__ZTSFvP10timer_listE_global_addr expires=0x10022da2c now=0x10022da1d flags=186646532
vendor.xxxyyy.ha-1593 [005] 9436.220992: timer_cancel timer=0xffffff80444f0428
xxxyyyTraceManag-7795 [004] 9436.261641: timer_cancel timer=0xffffff80444f0428
[2]
9436.261653][ C4] Unable to handle kernel paging request at virtual address dead00000000012a
[ 9436.261664][ C4] Mem abort info:
[ 9436.261666][ C4] ESR = 0x96000044
[ 9436.261669][ C4] EC = 0x25: DABT (current EL), IL = 32 bits
[ 9436.261671][ C4] SET = 0, FnV = 0
[ 9436.261673][ C4] EA = 0, S1PTW = 0
[ 9436.261675][ C4] Data abort info:
[ 9436.261677][ C4] ISV = 0, ISS = 0x00000044
[ 9436.261680][ C4] CM = 0, WnR = 1
[ 9436.261682][ C4] [dead00000000012a] address between user and kernel address ranges
[ 9436.261685][ C4] Internal error: Oops: 96000044 [#1 ] PREEMPT SMP
[ 9436.261701][ C4] Skip md ftrace buffer dump for: 0x3a982d0
...
[ 9436.262138][ C4] CPU: 4 PID: 7795 Comm: TraceManag Tainted: G S W O 5.10.149-android12-9-o-g17f915d29d0c #1
[ 9436.262141][ C4] Hardware name: Qualcomm Technologies, Inc. (DT)
[ 9436.262144][ C4] pstate: 22400085 (nzCv daIf +PAN -UAO +TCO BTYPE=--)
[ 9436.262161][ C4] pc : expire_timers+0x9c/0x438
[ 9436.262164][ C4] lr : expire_timers+0x2a4/0x438
[ 9436.262168][ C4] sp : ffffffc010023dd0
[ 9436.262171][ C4] x29: ffffffc010023df0 x28: ffffffd0636fdc18
[ 9436.262178][ C4] x27: ffffffd063569dd0 x26: ffffffd063536008
[ 9436.262182][ C4] x25: 0000000000000001 x24: ffffff88f7c69280
[ 9436.262185][ C4] x23: 00000000000000e0 x22: dead000000000122
[ 9436.262188][ C4] x21: 000000010022da29 x20: ffffff8af72b4e80
[ 9436.262191][ C4] x19: ffffffc010023e50 x18: ffffffc010025038
[ 9436.262195][ C4] x17: 0000000000000240 x16: 0000000000000201
[ 9436.262199][ C4] x15: ffffffffffffffff x14: ffffff889f3c3100
[ 9436.262203][ C4] x13: ffffff889f3c3100 x12: 00000000049f56b8
[ 9436.262207][ C4] x11: 00000000049f56b8 x10: 00000000ffffffff
[ 9436.262212][ C4] x9 : ffffffc010023e50 x8 : dead000000000122
[ 9436.262216][ C4] x7 : ffffffffffffffff x6 : ffffffc0100239d8
[ 9436.262220][ C4] x5 : 0000000000000000 x4 : 0000000000000101
[ 9436.262223][ C4] x3 : 0000000000000080 x2 : ffffff889edc155c
[ 9436.262227][ C4] x1 : ffffff8001005200 x0 : ffffff80444f0428
[ 9436.262232][ C4] Call trace:
[ 9436.262236][ C4] expire_timers+0x9c/0x438
[ 9436.262240][ C4] __run_timers+0x1f0/0x330
[ 9436.262245][ C4] run_timer_softirq+0x28/0x58
[ 9436.262255][ C4] efi_header_end+0x168/0x5ec
[ 9436.262265][ C4] __irq_exit_rcu+0x108/0x124
[ 9436.262274][ C4] __handle_domain_irq+0x118/0x1e4
[ 9436.262282][ C4] gic_handle_irq.30369+0x6c/0x2bc
[ 9436.262286][ C4] el0_irq_naked+0x60/0x6c
Bug: 317188938
Change-Id: I9a22325f6abbf28217c8f37b093cf77509b0139a
Link: https://lore.kernel.org/all/1700860318-4025-1-git-send-email-quic_mojha@quicinc.com/
Reported-by: Joyyoung Huang <huangzaiyang@oppo.com >
Acked-by: MyungJoo Ham <myungjoo.ham@samsung.com >
Signed-off-by: Mukesh Ojha <quic_mojha@quicinc.com >
Signed-off-by: Chanwoo Choi <cw00.choi@samsung.com >
(cherry picked from commit aed5ed595960c6d301dcd4ed31aeaa7a8054c0c6
https://git.kernel.org/pub/scm/linux/kernel/git/chanwoo/linux.git devfreq-next)
Signed-off-by: Srinivasarao Pathipati <quic_c_spathi@quicinc.com >
2023-12-22 22:47:40 +00:00
Wu Bo
d5552f63b8
UPSTREAM: dm verity: don't perform FEC for failed readahead IO
...
We found an issue under Android OTA scenario that many BIOs have to do
FEC where the data under dm-verity is 100% complete and no corruption.
Android OTA has many dm-block layers, from upper to lower:
dm-verity
dm-snapshot
dm-origin & dm-cow
dm-linear
ufs
DM tables have to change 2 times during Android OTA merging process.
When doing table change, the dm-snapshot will be suspended for a while.
During this interval, many readahead IOs are submitted to dm_verity
from filesystem. Then the kverity works are busy doing FEC process
which cost too much time to finish dm-verity IO. This causes needless
delay which feels like system is hung.
After adding debugging it was found that each readahead IO needed
around 10s to finish when this situation occurred. This is due to IO
amplification:
dm-snapshot suspend
erofs_readahead // 300+ io is submitted
dm_submit_bio (dm_verity)
dm_submit_bio (dm_snapshot)
bio return EIO
bio got nothing, it's empty
verity_end_io
verity_verify_io
forloop range(0, io->n_blocks) // each io->nblocks ~= 20
verity_fec_decode
fec_decode_rsb
fec_read_bufs
forloop range(0, v->fec->rsn) // v->fec->rsn = 253
new_read
submit_bio (dm_snapshot)
end loop
end loop
dm-snapshot resume
Readahead BIOs get nothing while dm-snapshot is suspended, so all of
them will cause verity's FEC.
Each readahead BIO needs to verify ~20 (io->nblocks) blocks.
Each block needs to do FEC, and every block needs to do 253
(v->fec->rsn) reads.
So during the suspend interval(~200ms), 300 readahead BIOs trigger
~1518000 (300*20*253) IOs to dm-snapshot.
As readahead IO is not required by userspace, and to fix this issue,
it is best to pass readahead errors to upper layer to handle it.
Cc: stable@vger.kernel.org
Fixes: a739ff3f54https://lore.kernel.org/dm-devel/b84fb49-bf63-3442-8c99-d565e134f2@redhat.com
Signed-off-by: Wu Bo <bo.wu@vivo.com >
Reviewed-by: Mikulas Patocka <mpatocka@redhat.com >
Signed-off-by: Mike Snitzer <snitzer@kernel.org >
Signed-off-by: Akilesh Kailash <akailash@google.com >
(cherry picked from commit 0193e3966ceeeef69e235975918b287ab093082b)
Change-Id: I73560e5660cebdc1997e1f9926cbb8888789eb46
2023-12-22 00:57:08 +00:00
Florian Westphal
2274751099
UPSTREAM: netfilter: nft_set_pipapo: skip inactive elements during set walk
...
commit 317eb9685095678f2c9f5a8189de698c5354316a upstream.
Otherwise set elements can be deactivated twice which will cause a crash.
Bug: 316310313
Reported-by: Xingyuan Mo <hdthky0@gmail.com >
Fixes: 3c4287f620fw@strlen.de >
Signed-off-by: Pablo Neira Ayuso <pablo@netfilter.org >
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org >
(cherry picked from commit 189c2a82933c67ad360c421258d5449f6647544a)
Signed-off-by: Lee Jones <joneslee@google.com >
Change-Id: I27fb6ee806642e23ca02700763a387341dd463e6
2023-12-21 13:56:13 +00:00
Zhengchao Shao
a72131befe
UPSTREAM: ipv4: igmp: fix refcnt uaf issue when receiving igmp query packet
...
[ Upstream commit e2b706c691905fe78468c361aaabc719d0a496f1 ]
When I perform the following test operations:
1.ip link add br0 type bridge
2.brctl addif br0 eth0
3.ip addr add 239.0.0.1/32 dev eth0
4.ip addr add 239.0.0.1/32 dev br0
5.ip addr add 224.0.0.1/32 dev br0
6.while ((1))
do
ifconfig br0 up
ifconfig br0 down
done
7.send IGMPv2 query packets to port eth0 continuously. For example,
./mausezahn ethX -c 0 "01 00 5e 00 00 01 00 72 19 88 aa 02 08 00 45 00 00
1c 00 01 00 00 01 02 0e 7f c0 a8 0a b7 e0 00 00 01 11 64 ee 9b 00 00 00 00"
The preceding tests may trigger the refcnt uaf issue of the mc list. The
stack is as follows:
refcount_t: addition on 0; use-after-free.
WARNING: CPU: 21 PID: 144 at lib/refcount.c:25 refcount_warn_saturate (lib/refcount.c:25)
CPU: 21 PID: 144 Comm: ksoftirqd/21 Kdump: loaded Not tainted 6.7.0-rc1-next-20231117-dirty #80
Hardware name: Red Hat KVM, BIOS 0.5.1 01/01/2011
RIP: 0010:refcount_warn_saturate (lib/refcount.c:25)
RSP: 0018:ffffb68f00657910 EFLAGS: 00010286
RAX: 0000000000000000 RBX: ffff8a00c3bf96c0 RCX: ffff8a07b6160908
RDX: 00000000ffffffd8 RSI: 0000000000000027 RDI: ffff8a07b6160900
RBP: ffff8a00cba36862 R08: 0000000000000000 R09: 00000000ffff7fff
R10: ffffb68f006577c0 R11: ffffffffb0fdcdc8 R12: ffff8a00c3bf9680
R13: ffff8a00c3bf96f0 R14: 0000000000000000 R15: ffff8a00d8766e00
FS: 0000000000000000(0000) GS:ffff8a07b6140000(0000) knlGS:0000000000000000
CS: 0010 DS: 0000 ES: 0000 CR0: 0000000080050033
CR2: 000055f10b520b28 CR3: 000000039741a000 CR4: 00000000000006f0
Call Trace:
<TASK>
igmp_heard_query (net/ipv4/igmp.c:1068)
igmp_rcv (net/ipv4/igmp.c:1132)
ip_protocol_deliver_rcu (net/ipv4/ip_input.c:205)
ip_local_deliver_finish (net/ipv4/ip_input.c:234)
__netif_receive_skb_one_core (net/core/dev.c:5529)
netif_receive_skb_internal (net/core/dev.c:5729)
netif_receive_skb (net/core/dev.c:5788)
br_handle_frame_finish (net/bridge/br_input.c:216)
nf_hook_bridge_pre (net/bridge/br_input.c:294)
__netif_receive_skb_core (net/core/dev.c:5423)
__netif_receive_skb_list_core (net/core/dev.c:5606)
__netif_receive_skb_list (net/core/dev.c:5674)
netif_receive_skb_list_internal (net/core/dev.c:5764)
napi_gro_receive (net/core/gro.c:609)
e1000_clean_rx_irq (drivers/net/ethernet/intel/e1000/e1000_main.c:4467)
e1000_clean (drivers/net/ethernet/intel/e1000/e1000_main.c:3805)
__napi_poll (net/core/dev.c:6533)
net_rx_action (net/core/dev.c:6735)
__do_softirq (kernel/softirq.c:554)
run_ksoftirqd (kernel/softirq.c:913)
smpboot_thread_fn (kernel/smpboot.c:164)
kthread (kernel/kthread.c:388)
ret_from_fork (arch/x86/kernel/process.c:153)
ret_from_fork_asm (arch/x86/entry/entry_64.S:250)
</TASK>
The root causes are as follows:
Thread A Thread B
... netif_receive_skb
br_dev_stop ...
br_multicast_leave_snoopers ...
__ip_mc_dec_group ...
__igmp_group_dropped igmp_rcv
igmp_stop_timer igmp_heard_query //ref = 1
ip_ma_put igmp_mod_timer
refcount_dec_and_test igmp_start_timer //ref = 0
... refcount_inc //ref increases from 0
When the device receives an IGMPv2 Query message, it starts the timer
immediately, regardless of whether the device is running. If the device is
down and has left the multicast group, it will cause the mc list refcount
uaf issue.
Bug: 316932391
Fixes: 1da177e4c3shaozhengchao@huawei.com >
Reviewed-by: Eric Dumazet <edumazet@google.com >
Reviewed-by: Hangbin Liu <liuhangbin@gmail.com >
Signed-off-by: David S. Miller <davem@davemloft.net >
Signed-off-by: Sasha Levin <sashal@kernel.org >
(cherry picked from commit 94445d9583079e0ccc5dde1370076ff24800d86e)
Signed-off-by: Lee Jones <joneslee@google.com >
Change-Id: I277be2304e564994e05b981ccd6cd8cbb9dc85be
2023-12-21 13:35:32 +00:00
Joerg Roedel
718225bcc1
UPSTREAM: x86/sev: Check for user-space IOIO pointing to kernel space
...
Upstream commit: 63e44bc52047f182601e7817da969a105aa1f721
Check the memory operand of INS/OUTS before emulating the instruction.
The #VC exception can get raised from user-space, but the memory operand
can be manipulated to access kernel memory before the emulation actually
begins and after the exception handler has run.
[ bp: Massage commit message. ]
Bug: 309733863
Fixes: 597cfe4821erbse.13@gmx.de >
Signed-off-by: Joerg Roedel <jroedel@suse.de >
Signed-off-by: Borislav Petkov (AMD) <bp@alien8.de >
Cc: <stable@kernel.org >
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org >
(cherry picked from commit 6550cbe25djoneslee@google.com >
Change-Id: Ie21d33ca750d1668244c9a954cb7ab6872066c2e
2023-12-21 13:08:52 +00:00
Joerg Roedel
5b118b5b1d
UPSTREAM: x86/sev: Check IOBM for IOIO exceptions from user-space
...
Upstream commit: b9cb9c45583b911e0db71d09caa6b56469eb2bdf
Check the IO permission bitmap (if present) before emulating IOIO #VC
exceptions for user-space. These permissions are checked by hardware
already before the #VC is raised, but due to the VC-handler decoding
race it needs to be checked again in software.
Bug: 309733863
Fixes: 25189d08e5erbse.13@gmx.de >
Signed-off-by: Joerg Roedel <jroedel@suse.de >
Signed-off-by: Borislav Petkov (AMD) <bp@alien8.de >
Tested-by: Tom Dohrmann <erbse.13@gmx.de >
Cc: <stable@kernel.org >
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org >
(cherry picked from commit 5bb9ba7dafjoneslee@google.com >
Change-Id: I559d1ee6aa0793f7bfd7b5e603cdaba2336d0562
2023-12-21 13:08:52 +00:00
Sagi Grimberg
0edf68775a
UPSTREAM: nvmet-tcp: Fix a possible UAF in queue intialization setup
...
commit d920abd1e7c4884f9ecd0749d1921b7ab19ddfbd upstream.
From Alon:
"Due to a logical bug in the NVMe-oF/TCP subsystem in the Linux kernel,
a malicious user can cause a UAF and a double free, which may lead to
RCE (may also lead to an LPE in case the attacker already has local
privileges)."
Hence, when a queue initialization fails after the ahash requests are
allocated, it is guaranteed that the queue removal async work will be
called, hence leave the deallocation to the queue removal.
Also, be extra careful not to continue processing the socket, so set
queue rcv_state to NVMET_TCP_RECV_ERR upon a socket error.
Bug: 310114968
Cc: stable@vger.kernel.org
Reported-by: Alon Zahavi <zahavi.alon@gmail.com >
Tested-by: Alon Zahavi <zahavi.alon@gmail.com >
Signed-off-by: Sagi Grimberg <sagi@grimberg.me >
Reviewed-by: Christoph Hellwig <hch@lst.de >
Reviewed-by: Chaitanya Kulkarni <kch@nvidia.com >
Signed-off-by: Keith Busch <kbusch@kernel.org >
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org >
(cherry picked from commit e985d78bdcjoneslee@google.com >
Change-Id: Ifd7ec8294182a6bf6d8c261aeda5d989e909f7ff
2023-12-21 13:05:32 +00:00
Carlos Llamas
f22c548c91
FROMLIST: binder: fix memory leaks of spam and pending work
...
commit 1aa3aaf8953c84bad398adf6c3cabc9d6685bf7d upstream
A transaction complete work is allocated and queued for each
transaction. Under certain conditions the work->type might be marked as
BINDER_WORK_TRANSACTION_ONEWAY_SPAM_SUSPECT to notify userspace about
potential spamming threads or as BINDER_WORK_TRANSACTION_PENDING when
the target is currently frozen.
However, these work types are not being handled in binder_release_work()
so they will leak during a cleanup. This was reported by syzkaller with
the following kmemleak dump:
BUG: memory leak
unreferenced object 0xffff88810e2d6de0 (size 32):
comm "syz-executor338", pid 5046, jiffies 4294968230 (age 13.590s)
hex dump (first 32 bytes):
e0 6d 2d 0e 81 88 ff ff e0 6d 2d 0e 81 88 ff ff .m-......m-.....
04 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 ................
backtrace:
[<ffffffff81573b75>] kmalloc_trace+0x25/0x90 mm/slab_common.c:1114
[<ffffffff83d41873>] kmalloc include/linux/slab.h:599 [inline]
[<ffffffff83d41873>] kzalloc include/linux/slab.h:720 [inline]
[<ffffffff83d41873>] binder_transaction+0x573/0x4050 drivers/android/binder.c:3152
[<ffffffff83d45a05>] binder_thread_write+0x6b5/0x1860 drivers/android/binder.c:4010
[<ffffffff83d486dc>] binder_ioctl_write_read drivers/android/binder.c:5066 [inline]
[<ffffffff83d486dc>] binder_ioctl+0x1b2c/0x3cf0 drivers/android/binder.c:5352
[<ffffffff816b25f2>] vfs_ioctl fs/ioctl.c:51 [inline]
[<ffffffff816b25f2>] __do_sys_ioctl fs/ioctl.c:871 [inline]
[<ffffffff816b25f2>] __se_sys_ioctl fs/ioctl.c:857 [inline]
[<ffffffff816b25f2>] __x64_sys_ioctl+0xf2/0x140 fs/ioctl.c:857
[<ffffffff84b30008>] do_syscall_x64 arch/x86/entry/common.c:50 [inline]
[<ffffffff84b30008>] do_syscall_64+0x38/0xb0 arch/x86/entry/common.c:80
[<ffffffff84c0008b>] entry_SYSCALL_64_after_hwframe+0x63/0xcd
Fix the leaks by kfreeing these work types in binder_release_work() and
handle them as a BINDER_WORK_TRANSACTION_COMPLETE cleanup.
Cc: stable@vger.kernel.org
Fixes: a7dc1e6f99df ("binder: tell userspace to dump current backtrace when detected oneway spamming")
Reported-by: syzbot+7f10c1653e35933c0f1e@syzkaller.appspotmail.com
Closes: https://syzkaller.appspot.com/bug?extid=7f10c1653e35933c0f1e
Suggested-by: Alice Ryhl <aliceryhl@google.com >
Signed-off-by: Carlos Llamas <cmllamas@google.com >
Reviewed-by: Alice Ryhl <aliceryhl@google.com >
Acked-by: Todd Kjos <tkjos@google.com >
Link: https://lore.kernel.org/r/20230922175138.230331-1-cmllamas@google.com
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org >
[cmllamas: backport to v5.15 by dropping BINDER_WORK_TRANSACTION_PENDING
as commit 0567461a7a6e is not present. Remove fixes tag accordingly.]
Signed-off-by: Carlos Llamas <cmllamas@google.com >
Signed-off-by: Sasha Levin <sashal@kernel.org >
Link: https://lore.kernel.org/all/20231208034842.997899-1-cmllamas@google.com/
Change-Id: I8e1ee7af87ef5706544e4f320e9498b8f4855a6b
[cmllamas: also backport to v5.10 to fix OOT 0493c72d6dcmllamas@google.com >
2023-12-15 13:22:07 +00:00
Lee Jones
5144c1c2e3
ANDROID: Snapshot Mainline's version of checkpatch.pl
...
Nothing fancy here. Keeping full history is not required.
`git checkout mainline/master -- scripts/checkpatch.pl`
This may need to be done periodically.
Bug: 316492624
Signed-off-by: Lee Jones <joneslee@google.com >
Change-Id: I4c90b50197ca7277c59e96bf332ecf795c4f3d12
2023-12-15 09:35:04 +00:00
Browse Zhang
b39b9bde93
ANDROID: scsi: ufs: vendor check response and recovery addition
...
As per Vendor HW design consideration,
added Vendor specific error handling flow
Under the error checking flow, Vendor can check errors as per their HW design/arch and recover
them accordingly.
Added vendor hook for completion response check
- trace_android_vh_ufs_compl_rsp_check_done
Added vendor hook for vendor specific error handling
- trace_android_vh_ufs_err_handler
Added vendor hook for err logs printing control
- trace_android_vh_ufs_err_print_ctrl
Added vendor hook for error checking flow trigger
- trace_android_vh_ufs_err_check_ctrl
Bug: 312806167
Change-Id: I614737218537f197c68780f5b528b1948d5e29ea
Signed-off-by: Sanjeev Yadav <sanjeev.y@mediatek.com >
Signed-off-by: Browse Zhang <browse.zhang@mediatek.com >
2023-12-12 22:03:30 +00:00
Browse Zhang
4246d242fa
ANDROID: scsi: ufs: add perf heuristic design
...
Added vendor hook to consider ufs host/device perf heuristic
according to different platform/design
Vendor/Platform can take necessary action according to their
design/implementation
Added vendor hook before calling UFS command ops
- trace_android_vh_ufs_perf_huristic_ctrl
Added vendor hook after sending UFS command to host
- trace_android_vh_ufs_send_command_post_change
Added vendor hook for abort success case
- trace_android_vh_ufs_abort_success_ctrl
Bug: 312806167
Signed-off-by: Sanjeev Yadav <sanjeev.y@mediatek.com >
Signed-off-by: Browse Zhang <browse.zhang@mediatek.com >
Change-Id: Ibd07480d1086ec82f2ba6a52e21da08750796221
2023-12-12 22:03:30 +00:00
Browse Zhang
83578817d0
ANDROID: ABI: Update symbol list for Mediatek
...
Add below symbols into MTK symbol list
7 function symbols added
'int __tracepoint__android_vh_ufs_perf_huristic_ctrl(void*,
struct ufs_hba*, struct ufshcd_lrb*, int *)'
'int __tracepoint__android_vh_ufs_send_command_post_change(
void*, struct ufs_hba*, struct ufshcd_lrb*)'
'int __tracepoint__android_vh_ufs_abort_success_ctrl(void*,
struct ufs_hba*, struct ufshcd_lrb*)'
'int __tracepoint__android_vh_ufs_compl_rsp_check_done(void*,
struct ufs_hba*, struct ufshcd_lrb*, bool*)'
'int __tracepoint__android_vh_ufs_err_handler(void*, struct
ufs_hba*, bool*)'
'int __tracepoint__android_vh_ufs_err_check_ctrl(void*, struct
ufs_hba*, bool*)'
'int __tracepoint__android_vh_ufs_err_print_ctrl(void*, struct
ufs_hba*, bool*)'
7 variable symbols added
'struct __tracepoint__android_vh_ufs_perf_huristic_ctrl'
'struct __tracepoint__android_vh_ufs_send_command_post_change'
'struct __tracepoint__android_vh_ufs_abort_success_ctrl'
'struct __tracepoint__android_vh_ufs_compl_rsp_check_done'
'struct __tracepoint__android_vh_ufs_err_handler'
'struct __tracepoint__android_vh_ufs_err_check_ctrl'
'struct __tracepoint__android_vh_ufs_err_print_ctrl'
Bug: 312806167
Change-Id: I0134d606c09f26e061439e5f179aab2b482fa10a
Signed-off-by: Sanjeev Yadav <sanjeev.y@mediatek.com >
Signed-off-by: Browse Zhang <browse.zhang@mediatek.com >
2023-12-12 22:03:30 +00:00
Browse Zhang
85d8fb9163
ANDROID: Add vendor hook for ufs perf heuristic and error recovery
...
Added vendor hook to consider ufs host/device perf heuristic
and error recovery according to different platform/design
Vendor/Platform can take necessary action according to their
design/implementation
Added vendor hook before calling UFS command ops
- trace_android_vh_ufs_perf_huristic_ctrl
Added vendor hook after sending UFS command to host
- trace_android_vh_ufs_send_command_post_change
Added vendor hook for abort success case
- trace_android_vh_ufs_abort_success_ctrl
Added vendor hook for completion response check
- trace_android_vh_ufs_compl_rsp_check_done
Added vendor hook for vendor specific error handling
- trace_android_vh_ufs_err_handler
Added vendor hook for err logs printing control
- trace_android_vh_ufs_err_print_ctrl
Added vendor hook for error checking flow trigger
- trace_android_vh_ufs_err_check_ctrl
Bug: 312806167
Change-Id: I2190afe62b60da9d47001307f858f10fc8a59986
Signed-off-by: Sanjeev Yadav <sanjeev.y@mediatek.com >
Signed-off-by: Browse Zhang <browse.zhang@mediatek.com >
2023-12-12 22:03:30 +00:00
Jens Axboe
7b8b02fa37
UPSTREAM: io_uring/fdinfo: lock SQ thread while retrieving thread cpu/pid
...
commit 7644b1a1c9a7ae8ab99175989bfc8676055edb46 upstream.
We could race with SQ thread exit, and if we do, we'll hit a NULL pointer
dereference when the thread is cleared. Grab the SQPOLL data lock before
attempting to get the task cpu and pid for fdinfo, this ensures we have a
stable view of it.
Bug: 309790656
Cc: stable@vger.kernel.org
Link: https://bugzilla.kernel.org/show_bug.cgi?id=218032
Reviewed-by: Gabriel Krisman Bertazi <krisman@suse.de >
Signed-off-by: Jens Axboe <axboe@kernel.dk >
Signed-off-by: He Gao <hegao@google.com >
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org >
(cherry picked from commit 3d7912710e5e187217313fea5c145881cfeaf952)
Signed-off-by: Lee Jones <joneslee@google.com >
Change-Id: I044e0285d4535440606ff593230b873e3145db91
2023-12-12 17:54:05 +00:00
Peter Wang
469a933a87
UPSTREAM: ufs: core: wlun send SSU timeout recovery
...
When runtime pm send SSU times out, the SCSI core invokes
eh_host_reset_handler, which hooks function ufshcd_eh_host_reset_handler
schedule eh_work and stuck at wait flush_work(&hba->eh_work).
However, ufshcd_err_handler hangs in wait rpm resume.
Do link recovery only in this case.
Below is IO hang stack dump in kernel-6.1
kworker/4:0 D
<ffffffd7d31f6fb4> __switch_to+0x180/0x344
<ffffffd7d31f779c> __schedule+0x5ec/0xa14
<ffffffd7d31f7c3c> schedule+0x78/0xe0
<ffffffd7d31fefbc> schedule_timeout+0xb0/0x15c
<ffffffd7d31f8120> io_schedule_timeout+0x48/0x70
<ffffffd7d31f8e40> do_wait_for_common+0x108/0x19c
<ffffffd7d31f837c> wait_for_completion_io_timeout+0x50/0x78
<ffffffd7d2876bc0> blk_execute_rq+0x1b8/0x218
<ffffffd7d2b4297c> scsi_execute_cmd+0x148/0x238
<ffffffd7d2da7358> ufshcd_set_dev_pwr_mode+0xe8/0x244
<ffffffd7d2da7e40> __ufshcd_wl_resume+0x1e0/0x45c
<ffffffd7d2da7b28> ufshcd_wl_runtime_resume+0x3c/0x174
<ffffffd7d2b4f290> scsi_runtime_resume+0x7c/0xc8
<ffffffd7d2ae1d48> __rpm_callback+0xa0/0x410
<ffffffd7d2ae0128> rpm_resume+0x43c/0x67c
<ffffffd7d2ae1e98> __rpm_callback+0x1f0/0x410
<ffffffd7d2ae014c> rpm_resume+0x460/0x67c
<ffffffd7d2ae1450> pm_runtime_work+0xa4/0xac
<ffffffd7d22e39ac> process_one_work+0x208/0x598
<ffffffd7d22e3fc0> worker_thread+0x228/0x438
<ffffffd7d22eb038> kthread+0x104/0x1d4
<ffffffd7d22171a0> ret_from_fork+0x10/0x20
scsi_eh_0 D
<ffffffd7d31f6fb4> __switch_to+0x180/0x344
<ffffffd7d31f779c> __schedule+0x5ec/0xa14
<ffffffd7d31f7c3c> schedule+0x78/0xe0
<ffffffd7d31fef50> schedule_timeout+0x44/0x15c
<ffffffd7d31f8e40> do_wait_for_common+0x108/0x19c
<ffffffd7d31f8234> wait_for_completion+0x48/0x64
<ffffffd7d22deb88> __flush_work+0x260/0x2d0
<ffffffd7d22de918> flush_work+0x10/0x20
<ffffffd7d2da4728> ufshcd_eh_host_reset_handler+0x88/0xcc
<ffffffd7d2b41da4> scsi_try_host_reset+0x48/0xe0
<ffffffd7d2b410fc> scsi_eh_ready_devs+0x934/0xa40
<ffffffd7d2b41618> scsi_error_handler+0x168/0x374
<ffffffd7d22eb038> kthread+0x104/0x1d4
<ffffffd7d22171a0> ret_from_fork+0x10/0x20
kworker/u16:5 D
<ffffffd7d31f6fb4> __switch_to+0x180/0x344
<ffffffd7d31f779c> __schedule+0x5ec/0xa14
<ffffffd7d31f7c3c> schedule+0x78/0xe0
<ffffffd7d2adfe00> rpm_resume+0x114/0x67c
<ffffffd7d2adfca8> __pm_runtime_resume+0x70/0xb4
<ffffffd7d2d9cf48> ufshcd_err_handler+0x1a0/0xe68
<ffffffd7d22e39ac> process_one_work+0x208/0x598
<ffffffd7d22e3fc0> worker_thread+0x228/0x438
<ffffffd7d22eb038> kthread+0x104/0x1d4
<ffffffd7d22171a0> ret_from_fork+0x10/0x20
(cherry picked from commit 971237b900c38f50e7865289a2aecb77dc7f09f3)
Link: https://lore.kernel.org/all/20230927033557.13801-1-peter.wang@mediatek.com/
Change-Id: I51d4ddec2be7ef71fd333ca7658539f38eeb8c31
Signed-off-by: Peter Wang <peter.wang@mediatek.com >
Reviewed-by: Bart Van Assche <bvanassche@acm.org >
Reviewed-by: Stanley Chu <stanley.chu@mediatek.com >
Signed-off-by: Peng Zhou <peng.zhou@mediatek.corp-partner.google.com >
2023-12-04 23:07:23 +00:00
Yongqin Liu
1b6cfcd1ed
ANDROID: GKI: db845c: Update symbols list and ABI on rpmsg_register_device_override
...
android12-5.10 is broken on Dragonboard 845c because of
recently added symbol, rpmsg_register_device_override.
So updated the symbols list by running:
"BUILD_CONFIG=common/build.config.db845c \
KMI_SYMBOL_LIST_ADD_ONLY=1 build/build_abi.sh -s"
And the abi_gki_aarch64 ABI by running:
"BUILD_CONFIG=common/build.config.gki.aarch64 \
ABI_DEFINITION=abi_gki_aarch64.xml KMI_SYMBOL_LIST_ADD_ONLY=1 \
build/build_abi.sh --update --print-report"
========================================================
Leaf changes summary: 1 artifact changed
Changed leaf types summary: 0 leaf type changed
Removed/Changed/Added functions summary: 0 Removed, 0 Changed, 1 Added function
Removed/Changed/Added variables summary: 0 Removed, 0 Changed, 0 Added variable
1 Added function:
[A] 'function int rpmsg_register_device_override(rpmsg_device*, const char*)'
========================================================
Bug: 313495196
Change-Id: I3a3504b6d2061bfce0abe9801e2ecb210c337b9f
Signed-off-by: Yongqin Liu <yongqin.liu@linaro.org >
Signed-off-by: Isaac J. Manjarres <isaacmanjarres@google.com >
2023-12-01 13:56:31 -08:00
Greg Kroah-Hartman
ced76f823f
ANDROID: fix up rpmsg_device ABI break
...
In commit e70898ae1a42 ("rpmsg: Fix kfree() of static memory on setting
driver_override") a pointer was changed to const, which messes with the
CRC and ABI checks. As the code is fine if this is left as not-const,
just put it back to preserve the abi.
Bug: 161946584
Fixes: e70898ae1a42 ("rpmsg: Fix kfree() of static memory on setting driver_override")
Change-Id: I9a87b9cf412191d9872b48f1f876a81df6701de0
Signed-off-by: Greg Kroah-Hartman <gregkh@google.com >
(cherry picked from commit 4f2270e2bca1854ebe8be23a82f665eaa27ee831)
Signed-off-by: Lee Jones <joneslee@google.com >
2023-11-28 18:00:10 +00:00
Greg Kroah-Hartman
72b5689f02
ANDROID: fix up platform_device ABI break
...
In commit 063444d66f90 ("driver: platform: Add helper for safer setting
of driver_override"), a pointer was changed to const, which messes with
the CRC and ABI checks. As the code is fine if this is left as
not-const, just put it back to preserve the abi.
Bug: 161946584
Fixes: 063444d66f90 ("driver: platform: Add helper for safer setting of driver_override")
Signed-off-by: Greg Kroah-Hartman <gregkh@google.com >
Change-Id: Ieb4a730a6a5767d31fbec2f1ba683617f5cda7a9
(cherry picked from commit c4dd1cfc1d5a7ce8ec37fe4ce11d3ce58bc6f3e9)
Signed-off-by: Lee Jones <joneslee@google.com >
2023-11-28 18:00:10 +00:00
Hangyu Hua
4172086503
UPSTREAM: rpmsg: Fix possible refcount leak in rpmsg_register_device_override()
...
commit d7bd416d35121c95fe47330e09a5c04adbc5f928 upstream.
rpmsg_register_device_override need to call put_device to free vch when
driver_set_override fails.
Fix this by adding a put_device() to the error path.
Bug: 295334746
Fixes: bb17d110cbf2 ("rpmsg: Fix calling device_lock() on non-initialized device")
Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org >
Signed-off-by: Hangyu Hua <hbh25y@gmail.com >
Link: https://lore.kernel.org/r/20220624024120.11576-1-hbh25y@gmail.com
Signed-off-by: Mathieu Poirier <mathieu.poirier@linaro.org >
Signed-off-by: Lee Jones <lee@kernel.org >
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org >
(cherry picked from commit d4c8bf5635c4bedaf2470761ced1f502b2d5434e)
Signed-off-by: Lee Jones <joneslee@google.com >
Change-Id: I10440a18479d5d207bafb706311c0467b853cf6c
2023-11-28 18:00:10 +00:00
Bjorn Andersson
0f4467ff35
UPSTREAM: rpmsg: glink: Release driver_override
...
commit fb80ef67e8ff6a00d3faad4cb348dafdb8eccfd8 upstream.
Upon termination of the rpmsg_device, driver_override needs to be freed
to avoid leaking the potentially assigned string.
Bug: 295334746
Fixes: 42cd402b8fd4 ("rpmsg: Fix kfree() of static memory on setting driver_override")
Fixes: 39e47767ecquic_clew@quicinc.com >
Signed-off-by: Bjorn Andersson <quic_bjorande@quicinc.com >
Signed-off-by: Bjorn Andersson <andersson@kernel.org >
Link: https://lore.kernel.org/r/20230109223931.1706429-1-quic_bjorande@quicinc.com
Signed-off-by: Lee Jones <lee@kernel.org >
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org >
(cherry picked from commit a82e0fda8a2f8561a6a6681e8b3557e60cad17da)
Signed-off-by: Lee Jones <joneslee@google.com >
Change-Id: I08b147ad640a8e2d71699a09815bbf048425a1fd
2023-11-28 18:00:10 +00:00
Krzysztof Kozlowski
fa6692abc2
BACKPORT: rpmsg: Fix calling device_lock() on non-initialized device
...
commit bb17d110cbf270d5247a6e261c5ad50e362d1675 upstream.
driver_set_override() helper uses device_lock() so it should not be
called before rpmsg_register_device() (which calls device_register()).
Effect can be seen with CONFIG_DEBUG_MUTEXES:
DEBUG_LOCKS_WARN_ON(lock->magic != lock)
WARNING: CPU: 3 PID: 57 at kernel/locking/mutex.c:582 __mutex_lock+0x1ec/0x430
...
Call trace:
__mutex_lock+0x1ec/0x430
mutex_lock_nested+0x44/0x50
driver_set_override+0x124/0x150
qcom_glink_native_probe+0x30c/0x3b0
glink_rpm_probe+0x274/0x350
platform_probe+0x6c/0xe0
really_probe+0x17c/0x3d0
__driver_probe_device+0x114/0x190
driver_probe_device+0x3c/0xf0
...
Refactor the rpmsg_register_device() function to use two-step device
registering (initialization + add) and call driver_set_override() in
proper moment.
This moves the code around, so while at it also NULL-ify the
rpdev->driver_override in error path to be sure it won't be kfree()
second time.
Bug: 295334746
Fixes: 42cd402b8fd4 ("rpmsg: Fix kfree() of static memory on setting driver_override")
Reported-by: Marek Szyprowski <m.szyprowski@samsung.com >
Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org >
Tested-by: Marek Szyprowski <m.szyprowski@samsung.com >
Link: https://lore.kernel.org/r/20220429195946.1061725-2-krzysztof.kozlowski@linaro.org
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org >
Signed-off-by: Lee Jones <lee@kernel.org >
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org >
(cherry picked from commit bfd4a664ddfbe12f008efb0b0ab6bf25a8ab2538)
[Lee: Git was confused that the hunk being removed had changed]
Signed-off-by: Lee Jones <joneslee@google.com >
Change-Id: Ic07d9ff669e88a50354ad8e978ae8e93316a2a5e
2023-11-28 18:00:10 +00:00
Krzysztof Kozlowski
20f1dfc0f7
BACKPORT: rpmsg: Fix kfree() of static memory on setting driver_override
...
commit 42cd402b8fd4672b692400fe5f9eecd55d2794ac upstream.
The driver_override field from platform driver should not be initialized
from static memory (string literal) because the core later kfree() it,
for example when driver_override is set via sysfs.
Use dedicated helper to set driver_override properly.
Bug: 295334746
Fixes: 950a7388f02b ("rpmsg: Turn name service into a stand alone driver")
Fixes: c0cdc19f84bjorn.andersson@linaro.org >
Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org >
Link: https://lore.kernel.org/r/20220419113435.246203-13-krzysztof.kozlowski@linaro.org
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org >
Signed-off-by: Lee Jones <lee@kernel.org >
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org >
(cherry picked from commit 2e76b4f6218c4db3ff00eb15d94d72f371736de4)
[Lee: Cater for name change s/rpmsg_chrdev/rpmsg_ctrl/ due to previous backport]
Signed-off-by: Lee Jones <joneslee@google.com >
Change-Id: Ib900ad13efcfdf7e50fb92bb45dff2b8aa8ff443
2023-11-28 18:00:10 +00:00
Krzysztof Kozlowski
68482b6bd9
UPSTREAM: rpmsg: Constify local variable in field store macro
...
commit e5f89131a06142e91073b6959d91cea73861d40e upstream.
Memory pointed by variable 'old' in field store macro is not modified,
so it can be made a pointer to const.
Bug: 295334746
Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org >
Link: https://lore.kernel.org/r/20220419113435.246203-12-krzysztof.kozlowski@linaro.org
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org >
Signed-off-by: Lee Jones <lee@kernel.org >
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org >
(cherry picked from commit 5c0da71871d3ac3f96d37067bf1a0ba9c25c2c72)
Signed-off-by: Lee Jones <joneslee@google.com >
Change-Id: If5610892601368e855ec1be57e01dbbe06ae046a
2023-11-28 18:00:10 +00:00
Krzysztof Kozlowski
66b73fb5b9
UPSTREAM: driver: platform: Add helper for safer setting of driver_override
...
commit 6c2f421174273de8f83cde4286d1c076d43a2d35 upstream.
Several core drivers and buses expect that driver_override is a
dynamically allocated memory thus later they can kfree() it.
However such assumption is not documented, there were in the past and
there are already users setting it to a string literal. This leads to
kfree() of static memory during device release (e.g. in error paths or
during unbind):
kernel BUG at ../mm/slub.c:3960!
Internal error: Oops - BUG: 0 [#1 ] PREEMPT SMP ARM
...
(kfree) from [<c058da50>] (platform_device_release+0x88/0xb4)
(platform_device_release) from [<c0585be0>] (device_release+0x2c/0x90)
(device_release) from [<c0a69050>] (kobject_put+0xec/0x20c)
(kobject_put) from [<c0f2f120>] (exynos5_clk_probe+0x154/0x18c)
(exynos5_clk_probe) from [<c058de70>] (platform_drv_probe+0x6c/0xa4)
(platform_drv_probe) from [<c058b7ac>] (really_probe+0x280/0x414)
(really_probe) from [<c058baf4>] (driver_probe_device+0x78/0x1c4)
(driver_probe_device) from [<c0589854>] (bus_for_each_drv+0x74/0xb8)
(bus_for_each_drv) from [<c058b48c>] (__device_attach+0xd4/0x16c)
(__device_attach) from [<c058a638>] (bus_probe_device+0x88/0x90)
(bus_probe_device) from [<c05871fc>] (device_add+0x3dc/0x62c)
(device_add) from [<c075ff10>] (of_platform_device_create_pdata+0x94/0xbc)
(of_platform_device_create_pdata) from [<c07600ec>] (of_platform_bus_create+0x1a8/0x4fc)
(of_platform_bus_create) from [<c0760150>] (of_platform_bus_create+0x20c/0x4fc)
(of_platform_bus_create) from [<c07605f0>] (of_platform_populate+0x84/0x118)
(of_platform_populate) from [<c0f3c964>] (of_platform_default_populate_init+0xa0/0xb8)
(of_platform_default_populate_init) from [<c01031f8>] (do_one_initcall+0x8c/0x404)
Provide a helper which clearly documents the usage of driver_override.
This will allow later to reuse the helper and reduce the amount of
duplicated code.
Convert the platform driver to use a new helper and make the
driver_override field const char (it is not modified by the core).
Bug: 95334746
Reviewed-by: Rafael J. Wysocki <rafael.j.wysocki@intel.com >
Acked-by: Rafael J. Wysocki <rafael.j.wysocki@intel.com >
Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org >
Link: https://lore.kernel.org/r/20220419113435.246203-2-krzysztof.kozlowski@linaro.org
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org >
Signed-off-by: Lee Jones <lee@kernel.org >
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org >
(cherry picked from commit 389190b25472627d010a9eb3c5a7227c3e92fa08)
Signed-off-by: Lee Jones <joneslee@google.com >
Change-Id: I1ef85ee1f3828e947adec4a45363d8434876aade
2023-11-28 18:00:10 +00:00
Biswarup Pal
525ecbbfda
FROMGIT: Input: uinput - allow injecting event times
...
Currently, uinput doesn't use the input_set_timestamp API, so any
event injected using uinput is not accurately timestamped in terms of
measuring when the actual event happened. Hence, call the
input_set_timestamp API from uinput in order to provide a more
accurate sense of time for the event. Propagate only the timestamps
which are a) positive, b) within a pre-defined offset (10 secs) from
the current time, and c) not in the future.
Bug: 271946580
Bug: 277040837
Change-Id: I928be61d0114b78e2098995ee49eeb0376bef2a3
(cherry picked from commit 3a2df60200a03f78173f1fd831aa54c08464dcde
https://git.kernel.org/pub/scm/linux/kernel/git/dtor/input.git master)
Signed-off-by: Biswarup Pal <biswarupp@google.com >
Reviewed-by: Peter Hutterer <peter.hutterer@who-t.net >
Reviewed-by: Siarhei Vishniakou <svv@google.com >
Link: https://lore.kernel.org/r/20230427000152.1407471-1-biswarupp@google.com
Signed-off-by: Dmitry Torokhov <dmitry.torokhov@gmail.com >
(cherry picked from commit ee1f5fc55cc7bf1bca78edbb8a1f9d989d4ea03e)
2023-11-24 11:42:46 +00:00
keystone-kernel-automerger
9a1e7741b4
Merge android12-5.10-2023-11_r2 into HEAD
...
* commit '226a9632f13d26e93fa416f6b003712b69118322':
BACKPORT: firmware_loader: Abort all upcoming firmware load request once reboot triggered
UPSTREAM: firmware_loader: Refactor kill_pending_fw_fallback_reqs()
UPSTREAM: kheaders: Have cpio unconditionally replace files
ANDROID: abi_gki_aarch64_qcom: Add android_gki_sysctl_vals
Change-Id: I6f07f48c1927d8905507202ea996e66ce45d4a89
Signed-off-by: keystone-kernel-automerger <keystone-kernel-automerger@google.com >
2023-11-24 06:53:02 +00:00
Mukesh Ojha
226a9632f1
BACKPORT: firmware_loader: Abort all upcoming firmware load request once reboot triggered
...
There could be following scenario where there is a ongoing reboot
is going from processA which tries to call all the reboot notifier
callback and one of them is firmware reboot call which tries to
abort all the ongoing firmware userspace request under fw_lock but
there could be another processB which tries to do request firmware,
which came just after abort done from ProcessA and ask for userspace
to load the firmware and this can stop the ongoing reboot ProcessA
to stall for next 60s(default timeout) which may not be expected
behaviour everyone like to see, instead we should abort any firmware
load request which came once firmware knows about the reboot through
notification.
ProcessA ProcessB
kernel_restart_prepare
blocking_notifier_call_chain
fw_shutdown_notify
kill_pending_fw_fallback_reqs
__fw_load_abort
fw_state_aborted request_firmware
__fw_state_set firmware_fallback_sysfs
... fw_load_from_user_helper
.. ...
. ..
usermodehelper_read_trylock
fw_load_sysfs_fallback
fw_sysfs_wait_timeout
usermodehelper_disable
__usermodehelper_disable
down_write()
Bug: 309378049
Bug: 312700424
Change-Id: I61eb91f21a01460f340f890b25c60de7597a87ff
Signed-off-by: Mukesh Ojha <quic_mojha@quicinc.com >
Acked-by: Luis Chamberlain <mcgrof@kernel.org >
Link: https://lore.kernel.org/r/1698330459-31776-2-git-send-email-quic_mojha@quicinc.com
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org >
(cherry picked from commit effd7c70eaa0440688b60b9d419243695ede3c45)
Signed-off-by: Srinivasarao Pathipati <quic_c_spathi@quicinc.com >
(cherry picked from commit ba88bbf1bb
2023-11-22 14:16:37 +00:00
Mukesh Ojha
4dbf047a83
UPSTREAM: firmware_loader: Refactor kill_pending_fw_fallback_reqs()
...
Rename 'only_kill_custom' and refactor logic related to it
to be more meaningful.
Bug: 309378049
Bug: 312700424
Change-Id: I119d2f8c29b9b624e6c1d8546c1533d76a2cc51d
Signed-off-by: Mukesh Ojha <quic_mojha@quicinc.com >
Acked-by: Luis Chamberlain <mcgrof@kernel.org >
Link: https://lore.kernel.org/r/1698330459-31776-1-git-send-email-quic_mojha@quicinc.com
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org >
(cherry picked from commit 87ffa98eeee8d62a56afdad80ea697e7a6e5c354)
Signed-off-by: Srinivasarao Pathipati <quic_c_spathi@quicinc.com >
(cherry picked from commit 10120b0270
2023-11-22 14:16:37 +00:00
Daniel Mentz
048c70af61
UPSTREAM: kheaders: Have cpio unconditionally replace files
...
For out-of-tree builds, this script invokes cpio twice to copy header
files from the srctree and subsequently from the objtree. According to a
comment in the script, there might be situations in which certain files
already exist in the destination directory when header files are copied
from the objtree:
"The second CPIO can complain if files already exist which can happen
with out of tree builds having stale headers in srctree. Just silence
CPIO for now."
GNU cpio might simply print a warning like "newer or same age version
exists", but toybox cpio exits with a non-zero exit code unless the
command line option "-u" is specified.
To improve compatibility with toybox cpio, add the command line option
"-u" to unconditionally replace existing files in the destination
directory.
Bug: 312397409
Bug: 312700424
Signed-off-by: Daniel Mentz <danielmentz@google.com >
Signed-off-by: Masahiro Yamada <masahiroy@kernel.org >
Change-Id: I1797f7ca3f36c71a313cccce1bc53fcc2d04ca65
Signed-off-by: Srinivasarao Pathipati <quic_c_spathi@quicinc.com >
(cherry picked from commit 1e8ca62b79dec20aeded4fe283f4890e5016767a)
2023-11-22 14:16:37 +00:00
Srinivasarao Pathipati
67bc129eec
ANDROID: abi_gki_aarch64_qcom: Add android_gki_sysctl_vals
...
The commit 44da38b39cquic_c_spathi@quicinc.com >
2023-11-22 14:12:35 +00:00
Srinivasarao Pathipati
e6278ff4b7
ANDROID: abi_gki_aarch64_qcom: Add android_gki_sysctl_vals
...
The commit 44da38b39cquic_c_spathi@quicinc.com >
2023-11-22 10:20:00 +05:30
Daniel Mentz
4194727e2c
UPSTREAM: kheaders: Have cpio unconditionally replace files
...
For out-of-tree builds, this script invokes cpio twice to copy header
files from the srctree and subsequently from the objtree. According to a
comment in the script, there might be situations in which certain files
already exist in the destination directory when header files are copied
from the objtree:
"The second CPIO can complain if files already exist which can happen
with out of tree builds having stale headers in srctree. Just silence
CPIO for now."
GNU cpio might simply print a warning like "newer or same age version
exists", but toybox cpio exits with a non-zero exit code unless the
command line option "-u" is specified.
To improve compatibility with toybox cpio, add the command line option
"-u" to unconditionally replace existing files in the destination
directory.
Bug: 312397409
Signed-off-by: Daniel Mentz <danielmentz@google.com >
Signed-off-by: Masahiro Yamada <masahiroy@kernel.org >
Change-Id: I1797f7ca3f36c71a313cccce1bc53fcc2d04ca65
Signed-off-by: Srinivasarao Pathipati <quic_c_spathi@quicinc.com >
(cherry picked from commit 1e8ca62b79dec20aeded4fe283f4890e5016767a)
2023-11-21 19:46:42 +00:00
lfc
efe30da3a3
ANDROID: ABI: Update oplus symbol list
...
Leaf changes summary: 12 artifacts changed
Changed leaf types summary: 0 leaf type changed
Removed/Changed/Added functions summary: 0 Removed, 0 Changed, 6 Added functions
Removed/Changed/Added variables summary: 0 Removed, 0 Changed, 6 Added variables
6 Added functions:
[A] 'function int __traceiter_android_vh_alloc_oem_binder_struct(void*, binder_transaction_data*, binder_transaction*, binder_proc*)'
[A] 'function int __traceiter_android_vh_binder_free_buf(void*, binder_proc*, binder_thread*, binder_buffer*)'
[A] 'function int __traceiter_android_vh_binder_proc_transaction_finish(void*, binder_proc*, binder_transaction*, task_struct*, bool, bool)'
[A] 'function int __traceiter_android_vh_binder_special_task(void*, binder_transaction*, binder_proc*, binder_thread*, binder_work*, list_head*, bool, bool*)'
[A] 'function int __traceiter_android_vh_binder_transaction_received(void*, binder_transaction*, binder_proc*, binder_thread*, uint32_t)'
[A] 'function int __traceiter_android_vh_free_oem_binder_struct(void*, binder_transaction*)'
6 Added variables:
[A] 'tracepoint __tracepoint_android_vh_alloc_oem_binder_struct'
[A] 'tracepoint __tracepoint_android_vh_binder_free_buf'
[A] 'tracepoint __tracepoint_android_vh_binder_proc_transaction_finish'
[A] 'tracepoint __tracepoint_android_vh_binder_special_task'
[A] 'tracepoint __tracepoint_android_vh_binder_transaction_received'
[A] 'tracepoint __tracepoint_android_vh_free_oem_binder_struct'
Bug: 308391339
Change-Id: Id46f5d977fa8f9bbc7496a115ec4683eb4c768ef
Signed-off-by: lfc <lfc@oppo.com >
2023-11-21 02:43:35 +00:00
lfc
464ef3ee59
ANDROID: vendor_hooks: Add hooks for binder
...
Add hooks to support oem's binder feature of improving binder_thread->task sched priority
1) Check if it is a specific task in trace_android_vh_alloc_oem_binder_struct() and store the flag to t->android_vendor_data1
2) If it is a specific binder task and binder_thread selected, raise the sched priority of binder_thread->task in runqueue.
3) If it is a specific binder task but no binder_thread selected (e.g pending_async or no free threads), insert t->work to the appropriate position in the list.
4) Reset the sched priority when BR_TRANSACTION or BC_FREE_BUFFER.
Some high-priority async binder task reset the sched priority when BC_FREE_BUFFER in trace_android_vh_binder_free_buf().
Some middle-priority async binder task reset the sched priority when driver return server "BR_TRANSACTION" in trace_android_vh_binder_transaction_received().
Bug: 308391339
Change-Id: Iab4939fe4a4881b31961aaa2fef500b51c944743
Signed-off-by: lfc <lfc@oppo.com >
2023-11-21 02:40:33 +00:00
Omkar Sai Sandeep Katadi
469da4ab8f
Merge remote-tracking branch into HEAD
...
* keystone/mirror-android12-5.10-2023-11: (1922 commits)
ANDROID: GKI: Update symbols to symbol list
ANDROID: Add Interrupt Hook for madvise Compression
UPSTREAM: netfilter: ipset: add the missing IP_SET_HASH_WITH_NET0 macro for ip_set_hash_netportnet.c
BACKPORT: ravb: Fix use-after-free issue in ravb_tx_timeout_work()
UPSTREAM: ravb: Fix up dma_free_coherent() call in ravb_remove()
Revert "netfilter: handle the connecting collision properly in nf_conntrack_proto_sctp"
Revert "net: bridge: use DEV_STATS_INC()"
Revert "configfs: fix a race in configfs_lookup()"
UPSTREAM: netfilter: ipset: Fix race between IPSET_CMD_CREATE and IPSET_CMD_SWAP
UPSTREAM: net: xfrm: Fix xfrm_address_filter OOB read
UPSTREAM: igb: set max size RX buffer when store bad packet is enabled
UPSTREAM: netfilter: nfnetlink_osf: avoid OOB read
ANDROID: abi_gki_aarch64_qcom: Add wait_for_device_probe symbol
UPSTREAM: netfilter: xt_sctp: validate the flag_info count
UPSTREAM: netfilter: xt_u32: validate user space input
UPSTREAM: net/sched: Retire rsvp classifier
UPSTREAM: ipv4: fix null-deref in ipv4_link_failure
UPSTREAM: netfilter: nf_tables: disallow rule removal from chain binding
UPSTREAM: netfilter: nf_tables: report use refcount overflow
FROMLIST: lib/test_meminit: fix off-by-one error in test_pages()
...
Change-Id: Id4fdaa634f2b047dd463cf698b5ea1e7ebf7a205
Signed-off-by: Omkar Sai Sandeep Katadi <okatadi@google.com >
2023-11-14 20:07:54 +00:00
Mukesh Ojha
ba88bbf1bb
BACKPORT: firmware_loader: Abort all upcoming firmware load request once reboot triggered
...
There could be following scenario where there is a ongoing reboot
is going from processA which tries to call all the reboot notifier
callback and one of them is firmware reboot call which tries to
abort all the ongoing firmware userspace request under fw_lock but
there could be another processB which tries to do request firmware,
which came just after abort done from ProcessA and ask for userspace
to load the firmware and this can stop the ongoing reboot ProcessA
to stall for next 60s(default timeout) which may not be expected
behaviour everyone like to see, instead we should abort any firmware
load request which came once firmware knows about the reboot through
notification.
ProcessA ProcessB
kernel_restart_prepare
blocking_notifier_call_chain
fw_shutdown_notify
kill_pending_fw_fallback_reqs
__fw_load_abort
fw_state_aborted request_firmware
__fw_state_set firmware_fallback_sysfs
... fw_load_from_user_helper
.. ...
. ..
usermodehelper_read_trylock
fw_load_sysfs_fallback
fw_sysfs_wait_timeout
usermodehelper_disable
__usermodehelper_disable
down_write()
Bug: 309378049
Change-Id: I61eb91f21a01460f340f890b25c60de7597a87ff
Signed-off-by: Mukesh Ojha <quic_mojha@quicinc.com >
Acked-by: Luis Chamberlain <mcgrof@kernel.org >
Link: https://lore.kernel.org/r/1698330459-31776-2-git-send-email-quic_mojha@quicinc.com
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org >
(cherry picked from commit effd7c70eaa0440688b60b9d419243695ede3c45)
Signed-off-by: Srinivasarao Pathipati <quic_c_spathi@quicinc.com >
2023-11-06 15:14:28 +05:30
Mukesh Ojha
10120b0270
UPSTREAM: firmware_loader: Refactor kill_pending_fw_fallback_reqs()
...
Rename 'only_kill_custom' and refactor logic related to it
to be more meaningful.
Bug: 309378049
Change-Id: I119d2f8c29b9b624e6c1d8546c1533d76a2cc51d
Signed-off-by: Mukesh Ojha <quic_mojha@quicinc.com >
Acked-by: Luis Chamberlain <mcgrof@kernel.org >
Link: https://lore.kernel.org/r/1698330459-31776-1-git-send-email-quic_mojha@quicinc.com
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org >
(cherry picked from commit 87ffa98eeee8d62a56afdad80ea697e7a6e5c354)
Signed-off-by: Srinivasarao Pathipati <quic_c_spathi@quicinc.com >
2023-11-06 14:52:33 +05:30
SzuWei Lin
409fe6c1ec
ANDROID: Initialize android12-5.10-2023-11
...
Bug: 308740277
Signed-off-by: SzuWei Lin <szuweilin@google.com >
Change-Id: I3dbe954d40632909279a9ec25245d663eabcb2fa
2023-11-04 16:02:55 +08:00
Treehugger Robot
f40707abde
Merge "Merge tag 'android12-5.10.198_r00' into android12-5.10" into android12-5.10
2023-11-03 21:00:44 +00:00
zihan ju
422887ef07
ANDROID: GKI: Update symbols to symbol list
...
Leaf changes summary: 2 artifacts changed
Changed leaf types summary: 0 leaf type changed
Removed/Changed/Added functions summary: 0 Removed, 0 Changed, 1 Added function
Removed/Changed/Added variables summary: 0 Removed, 0 Changed, 1 Added variable
1 Added function:
[A] 'function int __traceiter_android_vh_should_end_madvise(void*, mm_struct*, bool*, bool*)'
1 Added variable:
[A] 'tracepoint __tracepoint_android_vh_should_end_madvise'
Bug: 307846869
Change-Id: Ib0f337ae35bf7129d90561054f9a8e17ccbbd28b
Signed-off-by: zihan ju <zihan.ju@transsion.com >
2023-11-01 19:07:41 +00:00
zihan ju
91d2427218
ANDROID: Add Interrupt Hook for madvise Compression
...
We introduce an interrupt hook in Android to manage memory compression
using madvise, improving user experience.
Currently, when a user returns to the home screen, memory compression is
triggered using madvise. The vma and PAGEOUT flag are sent to
process_madvise, initiating page reclaim.
However, if an app is re-opened soon after starting compression, the
reclaim process can cause read delays, leading to potential lag.
To resolve this, we propose to skip pte range traversal. By comparing
the vma's task uid with the current app's uid, we can identify and
interrupt the madvise operation for that vma.
Implementing this requires a vendor hook for should_end_madvise. This
allows us to skip traversal, enhancing user experience.
Bug: 307846869
Change-Id: If2bdbc200b7305e92f836353b7356aa115e00705
Signed-off-by: zihan ju <zihan.ju@transsion.com >
2023-11-01 19:07:41 +00:00
Kyle Zeng
4e38f783da
UPSTREAM: netfilter: ipset: add the missing IP_SET_HASH_WITH_NET0 macro for ip_set_hash_netportnet.c
...
commit 050d91c03b28ca479df13dfb02bcd2c60dd6a878 upstream.
The missing IP_SET_HASH_WITH_NET0 macro in ip_set_hash_netportnet can
lead to the use of wrong `CIDR_POS(c)` for calculating array offsets,
which can lead to integer underflow. As a result, it leads to slab
out-of-bound access.
This patch adds back the IP_SET_HASH_WITH_NET0 macro to
ip_set_hash_netportnet to address the issue.
Bug: 302199939
Fixes: 886503f34dkadlec@netfilter.org >
Signed-off-by: Kyle Zeng <zengyhkyle@gmail.com >
Acked-by: Jozsef Kadlecsik <kadlec@netfilter.org >
Signed-off-by: Florian Westphal <fw@strlen.de >
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org >
(cherry picked from commit a9e6142e5f8f6ac7d1bca45c1b2b13b084ea9e14)
Signed-off-by: Lee Jones <joneslee@google.com >
Change-Id: I11cc1650e7df9d54041164b6bdb01f3a0de46de4
2023-10-31 15:55:55 +00:00
Greg Kroah-Hartman
1289e04b48
Merge tag 'android12-5.10.198_r00' into android12-5.10
...
This merges catches the android12-5.10 branch up with the 5.10.198 LTS
release. Included in here are the following commits:
* 9db823a19df95f372cf93e7bedcc0ea8d812240f660627c71b1e3d016a95a7d86a77c384f6b686dfc17446c008cfc333393a0d520cdb0c5a4a6a47e0626868282c7de0e4244436953b4da76ad972e668d7d8f1a679204c2d485fb74f12f98bccd87fe7a082d87c944e492241613cf876584938ff346b01eb677aaa261e6a24d0661fb9f1568ba33a5142f0170ba9348532b212f361a5dba849cc9830bc4d7aebd44346dda796b2e109032ea52a2fb86e3d9e5cab225cd4f67bd8f2ba9ec377f82df960a9430129d8725fd20805666cdc43df54a4faab2b93dd471d3a10a18c8bac8c15c1bcc5a5f643ab1133420a820681d03e251872fc02ebfc1aeff207e2f6f25930fab9c4b3ca9004b6b67a3ec2cf152e8bf94471c0cc0d6987d4a3d3d170c5fc3ceb306f9b7c4f11d73bd0952ce316c33d75a57a0ecde7dd762ad1a1d3d6ec4325e806598539f38c19f3d5d13b2cdec9c13fae03dafc378ec1abb59adc0bd0f2da531d9f6dbf99d308c319eaf449666272595dbfca6a80578bd4cbbfdb4babef47f25e98b7a0df4c08acc7fc82d0e3b8c9e0fcb664e9db8d25872c67de5a03b42ae17130a87ca3e14afa44506d5c88629314443223e0297c51c63f41de7a6b95831f18c735fb28f89d50e18216cd0e152b8ac83913b7d49f330d599a3f5797e148dcb971357c751f38f82cf86067025d5654b2788f6d4982756d8a23f8e8e72c58ef3c728ca0da91481c5dffc459a9308c2500228bf5bdbed036ebc91848060118244848f6cf19c1b32afd8fcee00decc581e1f44e66447ccee5151c542956e33fb49ccce21bd75dfcb9290538ef4b2e4d2081b2a15bf47efdffdcd967a9472b7b2440c2d6c793005999061f402753dd81e91b2eb317f69871be17dfdcc8a10bfbe599608af5511a3696261859eff55feb8b1bc8867196a2a592adad2d9c9589daef83f35ced12a28c379eafdc40a74a093a9a02d428e5423ad850789f37230fd5839e251d4d846e2aa8ee76d727d678c078f3a1f85bc9bc51d190cc988061c399c80156cce71f9f0d346630ed60b8014c10670abe1145b3eb6afc39546418b8af844ba799858ca192162d9ea86f3cc4cc1f690f4596fece3c3ed9d3dc24ebccb532324ccdeb68da6d3745bbc3995ef65e4b97eb0453867217ceb61ae492f81251677bff659f3fac8ce48fe51f30826b5e95c88e900a78bcc2d5f515112e83466e88548e78106529b3a8dd21118bac01a0dd79a8460ee6c8f1893feb20b44dd92e2a04cc361f021671dc1b25309af4a39bae806c74c0423ba1b3a51ec40ef6f74c5eaf6d8b441b61d742c463898b6e60d73c62e309a1c790e18689c9ace947907ebeb7a91861446fc4ecedf98078ef69b6e7388c9d3eef6dc85d848ca45632f99709c85f2d214deaf1316b26d0e4d632b796c4e4bfc323ed65f609f2dda1e5b71dcee2fc23292bdfdadc0b1f01954046f2b56e891ca5dfe3911dd3cdf177046cb008146c768667448be07748b15ea4017af8bf7706159b65bff30af8a86ab3c4c502b09d9be78e9f08a2cbf6a0f6545eaf4a1e0624a86315a3da1895f7316f5fc957df69c966583011d15a115c407bf1c1403f7df02fa025ae2b2fdb26db22a6393414e62421393e225fe8242c5740dd8768583b25f4fffa1abb3753e568d6993bb01d22f5e303fce396afb318aeb3183f5f05ec7eb8b064bb3e295a382cdcf6481c0c5d5f8e0d8db844077e7a8f285cb57390bb377b3d379dd109c6422e6f1768308b0a33634444dea87be3a38f0ed20beafaa67635020b9bf990052376ae889fffae82910aa550df380d6f5cab90a3930dcc87d2bb39e16f5f8cabc5609581274954c5a054b87d03ed6a5df5829158a3efb2b57ef354456f8dbbe3ff47bf6d3a1dd105890d10e6b72ae53dd15e578b67614aa9def3e9714a9763d2bcc7e5ac737d97fdbdb7506c01ef65de9f3b2b6668756747d4b46f8b3445894bff1d95ba7993cfc0415933cd61395475b8bea1d51d6c42d1fcfb71848e9726e8dcab672205c6f25bf52e431cf6f0a68754acf0019b93c7a8813d910fc7147c6903385b243b269eb4e1d508fdbe3790268a10c9eb8c19ddc215cfca20009b020ecfa7b6bfc747fe07dc01bfdc3d560014aefb3f72fdb20f55887adc76f8bab887a4625c12dc04a6f4129378b7c3cf2f6c69ddafc7a716aeda0b7dff0bfa8f232cc1f498625b4fcff94484ae70e787a8b0203a91cb5f0587c6734d166d62db08d2cf8273c7cc0b1e2b40885cdc92ecfcb0af8026d5839b5452d1be67d653c35de01d02ef8c8a2e18493c42606a0d8ff66edf82223fa5096cc6e703be4412d3687031788f33db24ad81ed584f1e721e90a93ac475f2de75c161054a8ddbd1c6c93c27fcb9e879a5d94aac13a17c8ddcdab115dabd02a9de20747ee681d06d191961fa6a16bbb5775b853041a660c2045c069bce2de7ed3585d00b55460c31c6dc2a2e11c07e4a4ef3b52a33a907d72b01d9f9d68f639dded00b031266c839a24d6ee76cef3dcdf2873a18c23856e7b1181d21b03f7735a3dec703b1d63e2bbd6612d5b53597ef9ba7df780f60dde2e89a361d9994a3117effe90e70343b2539b28a2b0878052579d878011b5d417b11433e9444881a3746f02fc7f6746a8df5e431e08e7fa690e32f81f9cf29b42766b401d7e48598e12d075cd47bc5023eab9796f43c160fdb411629039819c623d2651372895dc4c4718edced38dbab5c26dc5394d527c375a2d9d884e86909e28cf3aec02fba9928df38af3223ec6fc52c934d29b9fa84f99532156cc6f79b934185605cd02ccab9f827bf27518fb9972acd701b9214536728690a22d6c5b02d1fb74e3add85c9622a1cf9fe096bfa28f4414aade6c910db8b5a2254fd48544f3e931fadf9723694f18bea4d7da12483f271e3d64b9faa6d0677208858d4b06ffab754d226f9ccb7a006494cd4735103216b861c4c9191b3beba5051dd9d241c5d9a6ceffc2ecf3cef18d13f38e1f2ee82b97e3c5e97a1d2e2c67054d03dc5d1dc2f60de9a5b1f71c0b9a9864e126bc681d477c04b8a938e32a4f4a5b41a9f73fd69721f03e6dd199a0b35dc3a3d8d13a174c028e90e0d3cfdc448e8ffed0c8fcfbf67d43f0727dfaf2ee05a85727239b24bebcea58594605a04e2c77841cd35c56c487313264260eb5c5f02e16b5d27baee6c8c90c4e61961b918dfb6ab192e5e5d3e39008e9e8836c266205541827d13a1b711c37083091f8ac01186eaffd8504bb3fc66ea374bdf2327b75c7203cfe215a04aeb3392180640d8f9bffe71ac2ffd7f268fce6ec26739746f4b88813bd9bb3a890f993bc5d30d6aa8ee519526d515ec7cb55ee38a6f1268bdb3cd9dffd006f2cb3caa950b98359baf2278b30c6c0280f79cce8ef7a6356da2d5c0629079f5023534ae5f17a427ce197ecd7a0e391efaf1408a68e1552a0b992d29ce41de44c71cbe7c8f7de821583183b0cab74136094df5b374b039e0f8949c06c710bd5f8ceb19138f8cc6e621dbeb9fd7f21ef7411198a0e935d86d85e23e4ede2ee95b9a26aaea6c6232bd4dca6d65079c69b65b13d01b4df82c6d6e18d49266dd3ef17ca4768356a3ba10cc2d5cdb195a6f480b2e43c69dc9a31e5eac0022b6aca9f5ab0d383e555f6342206051d84e5d445a519b9e3e5c5e5a528c29d13a84874a656423cc5661bc9293dad8a8f75fce5865926da26dff92b3fe9d82a58d2a7bc36ac6713f1a2b0b2daaeac3a6b16d53616189f08944e3c646ff3bd14b953c54dfdce46cc0e42f9837d6a483924d1ab98737eecd5085ead3dbc92b2f8269ca80d45bf1528bad83d83dd8d8f5613c5c0d81a0546b69795c689ef647b8fe55ae52f8ba45ef8e561ddb344c16a844289f5a88f1b3a80429b1245759d9872aefe3ae0974a5f9755a2640d3be82c1ff788f7313623b966b6128288d8f8917591d72cd062ebe0cca7634e54943f561e809265515548698ef243d5969800bc5d77fcbaf4bdb9b89db24c69f4017cac7815e42029fa21e73a6d8524f23b082e2d1c9b397c02917e70af41c65f8d0883fdbbdbe5f0994e3f24a61d725858563d52a4fa15f309eb98e766a94ec36d3e4dedb0eea279e01ed4e48de8961ccdd2167e9875d2f25c4c72bf42fbbcea0924ba2d6c5e8e73f0d83994eb56309c77d8303282409031ab0f10e8415d803d8cfc4a78e7036d958ad40826ef15769967cbc8a2371d2d9aa2b1356531e924bf179f53686d89987f0af4ff47489905e316e5ea5da2849db53805176ecabd1c17ef4b08cc6c039ab04c731a1db7a3531663d36ba3f7e7cc9e1dcc1d4f79aa9ee50f89daf9ebef85d58f7cfce1973ffee72b2b1f591d92d897508a6e99a330c4240d23d0fe11dd3fed8f5415d4da97f22165197ccf9f19549729fc4727a970444779b812dcf2b88bc7122dbe87da6a0ac6668886ebe625bf86bf57545292d87323084d77da8d69658433fe3923d095120d93c241d6c3017ceca7ee1b75c791a12102e4d271804f5e6e11cbaa11d210321def24152c209b275f0ae35514116de91920b2f99bc133a1f45b93de36b8b9be06326ff3a08b1803bfcc0e1f9bddc0682fc175cf399938a91bf1f7aeb573ee719b3a0066fbd8bc9ac96370db7ac5a73b5d9644e93a790731f39e4a1755e86f28a6b5d585e235101e2c8a5ca8f04553e4ac54312f642714d3d704ded72985b0c0547d2a699d8d419dd21f47cc15a5cbc749d112bdd081a7dd11a4542887dd6ef1ced7a1a7f40add399b6ce1abb8a4a36320ff30413a70111b7bb51654e3d2779b23cbd3c25331d85f0bc357badc01ade0cdcceaa8964b32a676b953ee81a37121461ddbc2b0d4d370a584c07790c96df6913a5fd143673f7700e987fb7cd83cfff16c1134267afa2dbd7d1efa372af6b2f13007fbe92704dd0559d9cdc32bfa8ba2b6959678a88ac026895499b22614c27dfded45e2a3d2e977baccbbdf1d637b63d0e11bb5ad3734c6d3dc7da5dc81ed29fda2319012f982ce208bd0ed45dd6c709c7ca02746b363befb074fb0fa065bfaf5f9d542c6147075c4996c229d44fa38193df6696e42ef71b0b4a4992de8497c31aeb76ffdfd90e5956c0c1112a2b548c599aa78c397f70b65c006d584764d93ba6e46e3e22624f8f9190c1f0aead4f8c117b268e92252279ea9eb723be4ccafc07df3427204fb59cfee8d8943ed7dc5eecd62c8512feb0269d543acf914de44566606fe3b3ac2c1d727f92be110c32f71ef62720c2db79f1406166a3ac749630ce910df5eaab037592a392b391cbf41a9d148a86651c5d02f4320ad643d3f322c7b26063fc2d69f68ad44603c2a104c9546921a45ac05ce568b950133d9a312713e3eab2125926baae4f109b95c7e91047d34bc6a4fca19e0c0b4ce58735d1c66cff0639b222da4e9eff0fd2540b5f5a851f686ed03b9a61570b72e4a5a28eee1d443eef0c6da1d8496f5d10c0ac7c09590883480f2a129d0dbedf9afea54c2048cd7c262127d2f3c5697aaec9a0e31d92f979b92db10a809e0157ffde5f9e88615ea2603dc8e1e17dee7b79dabd63d64cdb9cb65db1249c703847137cd1fa7d7a7f0070dfdbba3067c8d7ef5492b20b15690b39e3070a8162b73eef403cc3e625005b6572d0b8205dfed69c2ceffd4e04981073945f169752332547026bb8145248ebe061c303cfb1b964eb37c07e11c58b268c3a4c3b644fdfd3d2f0570f52137e31131cce24209a84a14c188edaaaad61913b303bbda55fb5cac3a1c4d996d5039198951652bcbf9ee850cd32df7b44c1f383cd689b5912e8275721528a64aadc29c6aecc29d24d68de3b8c9577f310ce13fda7dc0e63caeeae27b23fd871be1599cb60ba0e8139f92323e598746526e3f7690c88e16ce7f869712baf2462ebfeb0dc91b349289ed2be58f92106597b650be0f50b0e410676a392538b0ff83e8a20e24c8b4cbbbe1b23c7bd3d12e6fd043d3bfe0ad5b3c88d155962f64ed298c7fe38c49aead733f5c080cee9307aa165d761e62de63c639022e9e62d6e74926edea04ac0c318bd70d0b28003a7f213afb7d1c71984e761b7e90ad23dd8590370626b93d67ba9ac0b5afba59a4b5577806f63c31411c3e86eeb5b1e932c73990370d60a593e8a9d51bc052db8773075d38a0a9040dedeabe68922d7526d42c558a7653eaea049f57a9087c8d0d3811e86517421f4614811692ebd30aa9c7f0b4d69539fec23b25e56bafa2363800f89909c808b92d03cfc7e50815d29549e4e167abd7bef82ce483d713ba2869ce5e5980ba7f969bec5f59de362268cc9bc543ff54d904fb1fe05cc513b76d92636265a979deda890545353e8a41b4a5050ed76c9e0d523ce6f51939a12f29a01dfc61f723e2b5d66e9f5c11b45f3a461bcfb36a64f5fe4930704666c57372f1752b777944a6f3cf7389126151cacbb711e436b423253aeecd8d97df6576d48519d16098245d2ba1f40fcc5e580831bbb70fdbfa266a3b2a121dd5a12cdf29f9eed45117a21c2e474b870b9a47ff19add5c772958cf9f8004bb8af40a7c5b2649f6e8f3d960517a3a7c6fa02caeb722f099d6afa19de52de26cb35c094ca9942a3f20efe6e778c8b0a9911b48eec44503f6fc95a2966e043673311dd83119312bc3ff04bd3a362d04e774fb67cbaebbba728a4f4d47b8df907501ba940ccc291cb2882c51e6dbe0f607f810459ffd569f4dd39696751c5b6a23e6825b30d3e6c0a9728e81cc91bba4ba2e27e510e77ef78741ecf0e627fbb630367a60412095349fda742ebfa03b55ce96efdb9d161a044af122b5d73bb05745caaa9a76d5ff58889d5ad7a370e2d6531678408d08267ad381c2039ce5eb6b93b3195d379ad83e3e61200ae5fa0bbd3175f9d5c91d8221279024873b94d4750cea76879750c6a7f8510dfa95e8d349408a70660e6faab564f32fb30d3573811833c677d1e013f7752f4a6d701c95ee6d0bd7b7b35850c391fdb3b6b9331acafe399d4d4f1d1cc16a501e3de09afe8fac37aa44a47be97c0a93fa240d7e6af9c133e731ad5221cba47d0c9598eaa12c9609f78fc4425258281a93eda9f8ffcacb1eefc046df8d390a21598ccdb92dfe7c3a445dd7e5e2b87f0439ce5aefaa425ee2273720724087a16c66baa4a5eff7259704499d2c97db0e1e2abda73d999fdf188e8e25ae6b6839e440002cde0b788362ad53677328c5319eb1a3e27d6b4af2d9ddb71952a4d5e47ca3e7459f2474ec58b96796c2a0c5f327f463c7890ac460b0e06ad3b48e918b4c2c761c80a01fc270435a8ac90dd121e0e606fab437d7df0f5bd7a8ec585727b6b6fc2fbf8998b7ab5e8d14f2e2ac73f1c928496dc0e7123e8937fad83ae5b85c7882fd381f7df0f3bd3bdb9e0de0d192a40286e4e949ea9a320469ad48d1d0ce077d949774e7662735bc11173d9c7090c08de20e70fbb66570371f09d67d39027710952bd328849fb67e4e87ec56ec0d0be41706f87c96217f740bc696426656e8dd4f86da9abed39971d902c9c78b91c73048cb0dc033a339e7175ea23f1cb68d104bfd418625802a1b82dc2bffeaddf7cc702979d16a84eaa4b2673e3cb5b39ff691513bfdde8a181274d2f36d9f5f3d8905d1dc88c4079afb181557bcbbb208289091eef3420aad608f80e9488ece7a634336a0c6505976471683124129c33d5a5c5b8e309f43d06d4f24736d216092963c20fe059c1da0e42f4bd4aaa71c4e8aa8d478200bb4256c99a7268b29ef19ad417bab9d11e0590af3dc20f7bada427c611d84c7ebe08f4014db69381dd163337befe68929f11beb8031b7ceabb0172fa86b93c510682cf67912071651598547ef3d0a732db4bdcbc0e34241cfc97394f8447ab8832a4d4cdb3f7395c382a883b98dc7058c0cbd25edc2ac7c72f07f3938c82b5afe25f5ba7d1dae9f2c57553a7741db23bad9ff97a14c8a5601d812c87a413fa0474d360a81949164e27c5af0acd6c3a2a241fc02f1ad938dd2af4148f28f98c0f2b2b020aae65b17934f669618c9c837f121bc276738b3823d10481a90fc511ae405223ecf871b836b131683c710ff06127fc51da40b96c73bc9ef90cd5ab95157b8db5800b1867cddd75be81139d24a871fcebcc5c797ccc35e0e4e72ca7c6df7f0fc8fc0eabaa7caac4b6c15baef414b1c0d5b23743b65cd02e3c3b0fd110578d0b588bbe466a622275a96c433aff505b201de4475ad45cef6bf468806b6d5db33a66781c54eef1dfca2a74eeec704cb21131037ee1dbf6209a7383d9e671a611668e6287ac6da1b105dc6a6d2fd17030efbdbc453e410839c0c82ce0ae87ad6a1cf4ee5a43c761a7ed82bfe9686ab6d14bc4094bac776cdb0100bdb9d62a8a4cafa5c9e03b86708aa5a52979d1fd118bcd03de937763661bab5aff40f7a858b3ed3729a6a6227b46154308a43f152ab5a97a94b7782ce022f893cb3c35189060b831c75f57acda3de982f46beb2712c4bfc0cd74fbd3bb55a2b34b15a3c929682ad249aa3c36f26f14573d2741769d5076f786f04344b7c0003111b6993008a6cc852f639c789c957fb1db97904ffebc22bddf34090579aceba255a79ed3d841f2fe3454b438cb306d09967840ce9cfc88996b130515f6d5b58c51815d9bf020f6741acfd7931233310838d6e86ec9f283ca643ffc0ee491f9fd349c885a7ab5d7943ec954a4ab004b114067841e90f0e5052df40a5c752403c3dad3069fc032622786d53818e635da0e0gregkh@google.com >
2023-10-31 10:18:41 +00:00
Omkar Sai Sandeep Katadi