Qiang Yu
4836cf044d
drm/lima: add lima_devfreq_resume/suspend
...
Used for device resume/suspend in the following commits.
Tested-by: Bhushan Shah <bshah@kde.org >
Reviewed-by: Vasily Khoruzhick <anarsoul@gmail.com >
Signed-off-by: Qiang Yu <yuq825@gmail.com >
Link: https://patchwork.freedesktop.org/patch/msgid/20200421133551.31481-6-yuq825@gmail.com
2020-04-24 20:50:57 +08:00
Qiang Yu
4eb70cd3f2
drm/lima: always set page directory when switch vm
...
We need to flush TLB anyway before every task start, and the
page directory will be set to empty vm after suspend/resume,
so always set it to the task vm even no ctx switch happens.
Tested-by: Bhushan Shah <bshah@kde.org >
Reviewed-by: Vasily Khoruzhick <anarsoul@gmail.com >
Signed-off-by: Qiang Yu <yuq825@gmail.com >
Link: https://patchwork.freedesktop.org/patch/msgid/20200421133551.31481-5-yuq825@gmail.com
2020-04-24 20:50:51 +08:00
Qiang Yu
24943269e5
drm/lima: check vm != NULL in lima_vm_put
...
No need to handle this check before calling lima_vm_put.
Tested-by: Bhushan Shah <bshah@kde.org >
Reviewed-by: Vasily Khoruzhick <anarsoul@gmail.com >
Signed-off-by: Qiang Yu <yuq825@gmail.com >
Link: https://patchwork.freedesktop.org/patch/msgid/20200421133551.31481-4-yuq825@gmail.com
2020-04-24 20:50:46 +08:00
Qiang Yu
d04f2a8e5b
drm/lima: print process name and pid when task error
...
When error task list is full, print the process info where
the error task come from for debug usage.
Tested-by: Bhushan Shah <bshah@kde.org >
Reviewed-by: Vasily Khoruzhick <anarsoul@gmail.com >
Signed-off-by: Qiang Yu <yuq825@gmail.com >
Link: https://patchwork.freedesktop.org/patch/msgid/20200421133551.31481-3-yuq825@gmail.com
2020-04-24 20:50:40 +08:00
Qiang Yu
4eda21d619
drm/lima: use module_platform_driver helper
...
Simplify module init/exit with module_platform_driver.
Tested-by: Bhushan Shah <bshah@kde.org >
Reviewed-by: Vasily Khoruzhick <anarsoul@gmail.com >
Signed-off-by: Qiang Yu <yuq825@gmail.com >
Link: https://patchwork.freedesktop.org/patch/msgid/20200421133551.31481-2-yuq825@gmail.com
2020-04-24 20:47:16 +08:00
Robin Murphy
2ce216edf2
drm/lima: Clean up redundant pdev pointer
...
There's no point explicitly tracking the platform device when it can be
trivially derived from the regular device pointer in the couple of
places it's ever used.
Signed-off-by: Robin Murphy <robin.murphy@arm.com >
Signed-off-by: Qiang Yu <yuq825@gmail.com >
Link: https://patchwork.freedesktop.org/patch/msgid/8d9073cc91c10fc70910587fd1794e0e8f32b467.1587509150.git.robin.murphy@arm.com
2020-04-24 20:47:11 +08:00
Robin Murphy
21d81f8882
drm/lima: Clean up IRQ warnings
...
Use the optional form of platform_get_irq() for blocks that legitimately
may not be present, to avoid getting an annoying barrage of spurious
warnings for non-existent PPs on configurations like Mali-450 MP2.
Signed-off-by: Robin Murphy <robin.murphy@arm.com >
Signed-off-by: Qiang Yu <yuq825@gmail.com >
Link: https://patchwork.freedesktop.org/patch/msgid/de475904091400ef6c123285f221094654d96d35.1587509150.git.robin.murphy@arm.com
2020-04-24 20:47:00 +08:00
Lyude Paul
973a5909e9
Revert "drm/dp_mst: Remove single tx msg restriction."
...
This reverts commit 6bb0942e8f
.
Unfortunately it would appear that the rumors we've heard of sideband
message interleaving not being very well supported are true. On the
Lenovo ThinkPad Thunderbolt 3 dock that I have, interleaved messages
appear to just get dropped:
[drm:drm_dp_mst_wait_tx_reply [drm_kms_helper]] timedout msg send
00000000571ddfd0 2 1
[dp_mst] txmsg cur_offset=2 cur_len=2 seqno=1 state=SENT path_msg=1 dst=00
[dp_mst] type=ENUM_PATH_RESOURCES contents:
[dp_mst] port=2
DP descriptor for this hub:
OUI 90-cc-24 dev-ID SYNA3 HW-rev 1.0 SW-rev 3.12 quirks 0x0008
It would seem like as well that this is a somewhat well known issue in
the field. From section 5.4.2 of the DisplayPort 2.0 specification:
There are MST Sink/Branch devices in the field that do not handle
interleaved message transactions.
To facilitate message transaction handling by downstream devices, an
MST Source device shall generate message transactions in an atomic
manner (i.e., the MST Source device shall not concurrently interleave
multiple message transactions). Therefore, an MST Source device shall
clear the Message_Sequence_No value in the Sideband_MSG_Header to 0.
MST Source devices that support field policy updates by way of
software should update the policy to forego the generation of
interleaved message transactions.
This is a bit disappointing, as features like HDCP require that we send
a sideband request every ~2 seconds for each active stream. However,
there isn't really anything in the specification that allows us to
accurately probe for interleaved messages.
If it ends up being that we -really- need this in the future, we might
be able to whitelist hubs where interleaving is known to work-or maybe
try some sort of heuristics. But for now, let's just play it safe and
not use it.
Signed-off-by: Lyude Paul <lyude@redhat.com >
Fixes: 6bb0942e8f
("drm/dp_mst: Remove single tx msg restriction.")
Cc: Wayne Lin <Wayne.Lin@amd.com >
Cc: Sean Paul <seanpaul@chromium.org >
Link: https://patchwork.freedesktop.org/patch/msgid/20200423164225.680178-1-lyude@redhat.com
Reviewed-by: Sean Paul <sean@poorly.run >
2020-04-23 13:18:17 -04:00
Gal Pressman
776d58823a
dma-buf: Couple of documentation typo fixes
...
Fix a couple of typos: "as" -> "has" and "int" -> "in".
Signed-off-by: Gal Pressman <galpress@amazon.com >
Signed-off-by: Daniel Vetter <daniel.vetter@ffwll.ch >
Link: https://patchwork.freedesktop.org/patch/msgid/20200420074115.23931-1-galpress@amazon.com
2020-04-21 14:37:51 +02:00
Souptick Joarder
871c60156d
drm/gma500: Remove dead code
...
These are dead code since 3.7. If there is no plan to use them further,
these can be removed forever.
Signed-off-by: Souptick Joarder <jrdr.linux@gmail.com >
Signed-off-by: Patrik Jakobsson <patrik.r.jakobsson@gmail.com >
Link: https://patchwork.freedesktop.org/patch/msgid/1587406337-32317-1-git-send-email-jrdr.linux@gmail.com
2020-04-21 09:02:29 +02:00
YueHaibing
1cf6c1a74e
drm/gma500: remove unused variable 'hdmi_ids'
...
drivers/gpu/drm/gma500/oaktrail_hdmi.c:676:35: warning: ‘hdmi_ids’ defined but not used [-Wunused-const-variable=]
static const struct pci_device_id hdmi_ids[] = {
^~~~~~~~
It is never used, remove it.
Reported-by: Hulk Robot <hulkci@huawei.com >
Signed-off-by: YueHaibing <yuehaibing@huawei.com >
Signed-off-by: Daniel Vetter <daniel.vetter@ffwll.ch >
Link: https://patchwork.freedesktop.org/patch/msgid/20200417101032.8140-1-yuehaibing@huawei.com
2020-04-21 08:15:03 +02:00
Geert Uytterhoeven
add0aff201
drm: Fix misspellings of "Analog Devices"
...
According to https://www.analog.com/ , the company name is spelled
"Analog Devices".
Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be >
Signed-off-by: Daniel Vetter <daniel.vetter@ffwll.ch >
Link: https://patchwork.freedesktop.org/patch/msgid/20200416103058.15269-4-geert+renesas@glider.be
2020-04-21 08:15:03 +02:00
Thomas Zimmermann
f0adbc382b
drm/ast: Allocate initial CRTC state of the correct size
...
The ast driver inherits from DRM's CRTC state, but still uses the atomic
helper for struct drm_crtc_funcs.reset, drm_atomic_helper_crtc_reset().
The helper only allocates enough memory for the core CRTC state. That
results in an out-ouf-bounds access when duplicating the initial CRTC
state. Simplified backtrace shown below:
[ 21.469321] ==================================================================
[ 21.469434] BUG: KASAN: slab-out-of-bounds in ast_crtc_atomic_duplicate_state+0x84/0x100 [ast]
[ 21.469445] Read of size 8 at addr ffff888036c1c5f8 by task systemd-udevd/382
[ 21.469451]
[ 21.469464] CPU: 2 PID: 382 Comm: systemd-udevd Tainted: G E 5.5.0-rc6-1-default+ #214
[ 21.469473] Hardware name: Sun Microsystems SUN FIRE X2270 M2/SUN FIRE X2270 M2, BIOS 2.05 07/01/2010
[ 21.469480] Call Trace:
[ 21.469501] dump_stack+0xb8/0x110
[ 21.469528] print_address_description.constprop.0+0x1b/0x1e0
[ 21.469557] ? ast_crtc_atomic_duplicate_state+0x84/0x100 [ast]
[ 21.469581] ? ast_crtc_atomic_duplicate_state+0x84/0x100 [ast]
[ 21.469597] __kasan_report.cold+0x1a/0x35
[ 21.469640] ? ast_crtc_atomic_duplicate_state+0x84/0x100 [ast]
[ 21.469665] kasan_report+0xe/0x20
[ 21.469693] ast_crtc_atomic_duplicate_state+0x84/0x100 [ast]
[ 21.469733] drm_atomic_get_crtc_state+0xbf/0x1c0
[ 21.469768] __drm_atomic_helper_set_config+0x81/0x5a0
[ 21.469803] ? drm_atomic_plane_check+0x690/0x690
[ 21.469843] ? drm_client_rotation+0xae/0x240
[ 21.469876] drm_client_modeset_commit_atomic+0x230/0x390
[ 21.469888] ? __mutex_lock+0x8f0/0xbe0
[ 21.469929] ? drm_client_firmware_config.isra.0+0xa60/0xa60
[ 21.469948] ? drm_client_modeset_commit_force+0x28/0x230
[ 21.470031] ? memset+0x20/0x40
[ 21.470078] drm_client_modeset_commit_force+0x90/0x230
[ 21.470110] drm_fb_helper_restore_fbdev_mode_unlocked+0x5f/0xc0
[ 21.470132] drm_fb_helper_set_par+0x59/0x70
[ 21.470155] fbcon_init+0x61d/0xad0
[ 21.470185] ? drm_fb_helper_restore_fbdev_mode_unlocked+0xc0/0xc0
[ 21.470232] visual_init+0x187/0x240
[ 21.470266] do_bind_con_driver+0x2e3/0x460
[ 21.470321] do_take_over_console+0x20a/0x290
[ 21.470371] do_fbcon_takeover+0x85/0x100
[ 21.470402] register_framebuffer+0x2fd/0x490
[ 21.470425] ? kzalloc.constprop.0+0x10/0x10
[ 21.470503] __drm_fb_helper_initial_config_and_unlock+0xf2/0x140
[ 21.470533] drm_fbdev_client_hotplug+0x162/0x250
[ 21.470563] drm_fbdev_generic_setup+0xd2/0x155
[ 21.470602] ast_driver_load+0x688/0x850 [ast]
<...>
[ 21.472625] ==================================================================
Allocating enough memory for struct ast_crtc_state in a custom ast CRTC
reset handler fixes the problem.
v2:
* implement according to drm_atomic_helper_crtc_reset()
* update state with __drm_atomic_helper_crtc_reset()
Signed-off-by: Thomas Zimmermann <tzimmermann@suse.de >
Fixes: 83be6a3ceb
("drm/ast: Introduce struct ast_crtc_state")
Reviewed-by: Daniel Vetter <daniel.vetter@ffwll.ch >
Cc: Gerd Hoffmann <kraxel@redhat.com >
Cc: Dave Airlie <airlied@redhat.com >
Cc: Daniel Vetter <daniel.vetter@ffwll.ch >
Cc: Alex Deucher <alexander.deucher@amd.com >
Cc: "Noralf Trønnes" <noralf@tronnes.org >
Cc: Sam Ravnborg <sam@ravnborg.org >
Cc: Laurent Pinchart <laurent.pinchart@ideasonboard.com >
Link: https://patchwork.freedesktop.org/patch/msgid/20200130094012.32140-1-tzimmermann@suse.de
2020-04-20 15:48:23 +02:00
Johan Jonker
8eea6e26fc
dt-bindings: display: convert rockchip rk3066 hdmi bindings to yaml
...
Current dts files with 'hdmi' nodes for rk3066 are manually verified.
In order to automate this process rockchip,rk3066-hdmi.txt
has to be converted to yaml.
Signed-off-by: Johan Jonker <jbx6244@gmail.com >
Reviewed-by: Rob Herring <robh@kernel.org >
Signed-off-by: Heiko Stuebner <heiko@sntech.de >
Link: https://patchwork.freedesktop.org/patch/msgid/20200403133630.7377-1-jbx6244@gmail.com
2020-04-19 14:17:19 +02:00
Linus Walleij
ac2caae61e
drm/tegra: Clean up GPIO includes
...
The Tegra DRM drivers includes the legacy GPIO headers
<linux/gpio.h> and <linux/of_gpio.h> but what it really
uses is <linux/gpio/consumer.h> since only gpio_desc
structs are ever referenced.
Include the right header on the top level tegra/drm.h
file and drop all the surplus includes.
Signed-off-by: Linus Walleij <linus.walleij@linaro.org >
Acked-by: Daniel Vetter <daniel.vetter@ffwll.ch >
Link: https://patchwork.freedesktop.org/patch/msgid/20200415122427.111769-1-linus.walleij@linaro.org
2020-04-17 17:16:22 +02:00
Chuhong Yuan
6937749955
video: fbdev: vesafb: add missed release_region
...
The driver forgets to free the I/O region in remove and probe
failure.
Add the missed calls to fix it.
Since the success of request_region() is optional, add the "region" field
in vesafb_par to represent whether request_region() succeeds.
Then only call release_region() when "region" is not null.
Signed-off-by: Chuhong Yuan <hslester96@gmail.com >
Signed-off-by: Bartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com >
Link: https://patchwork.freedesktop.org/patch/msgid/20200329145839.20076-1-hslester96@gmail.com
2020-04-17 15:50:14 +02:00
Chuhong Yuan
fbe3d80df8
video: fbdev: arcfb: add missed free_irq and fix the order of request_irq
...
The driver forgets to free irq in remove which is requested in
probe.
Add the missed call to fix it.
Also, the position of request_irq() in probe should be put before
register_framebuffer().
Signed-off-by: Chuhong Yuan <hslester96@gmail.com >
Signed-off-by: Bartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com >
Link: https://patchwork.freedesktop.org/patch/msgid/20200324132353.21785-1-hslester96@gmail.com
2020-04-17 15:50:13 +02:00
Chuhong Yuan
8213fb4187
fbdev: s1d13xxxfb: add missed unregister_framebuffer in remove
...
The driver calls register_framebuffer() in probe but does not call
unregister_framebuffer() in remove.
Rename current remove to __s1d13xxxfb_remove() for error handler.
Then add a new remove to call unregister_framebuffer().
Signed-off-by: Chuhong Yuan <hslester96@gmail.com >
Cc: Kristoffer Ericson <kristoffer.ericson@gmail.com >
[b.zolnierkie: ported over recent s1d13xxxfb changes]
[b.zolnierkie: removed extra newline]
Signed-off-by: Bartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com >
Link: https://patchwork.freedesktop.org/patch/msgid/20200324132311.21729-1-hslester96@gmail.com
2020-04-17 15:50:12 +02:00
Linus Walleij
5e4096ef03
ARM/fbdev: sa11x0: Switch to use GPIO descriptors
...
This converts the SA11x0 frame buffer driver to use
GPIO descriptors. Get the GPIO optional and register
a look-up table specifically for the Shannon machine.
Signed-off-by: Linus Walleij <linus.walleij@linaro.org >
Cc: Russell King <linux@armlinux.org.uk >
Signed-off-by: Bartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com >
Link: https://patchwork.freedesktop.org/patch/msgid/20200415165055.193113-1-linus.walleij@linaro.org
2020-04-17 15:50:11 +02:00
Jason Yan
7066fcd553
video: fbdev: aty128fb: remove unused 'sdr_64'
...
Fix the following gcc warning:
drivers/video/fbdev/aty/aty128fb.c:337:36: warning: ‘sdr_64’ defined but
not used [-Wunused-const-variable=]
static const struct aty128_meminfo sdr_64 = {
^~~~~~
Reported-by: Hulk Robot <hulkci@huawei.com >
Signed-off-by: Jason Yan <yanaijie@huawei.com >
Cc: Paul Mackerras <paulus@samba.org >
Cc: Daniel Vetter <daniel.vetter@ffwll.ch >
Signed-off-by: Bartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com >
Link: https://patchwork.freedesktop.org/patch/msgid/20200417092318.13978-1-yanaijie@huawei.com
2020-04-17 15:50:10 +02:00
YueHaibing
fff1ac9e28
omapfb/dss: remove unused variable 'venc_config_pal_bdghi'
...
drivers/video/fbdev/omap2/omapfb/dss/venc.c:212:33:
warning: ‘venc_config_pal_bdghi’ defined but not used [-Wunused-const-variable=]
static const struct venc_config venc_config_pal_bdghi = {
^~~~~~~~~~~~~~~~~~~~~
Reported-by: Hulk Robot <hulkci@huawei.com >
Signed-off-by: YueHaibing <yuehaibing@huawei.com >
Cc: Allison Randal <allison@lohutok.net >
[b.zolnierkie: fixed typo in the patch summary]
Signed-off-by: Bartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com >
Link: https://patchwork.freedesktop.org/patch/msgid/20200415132350.33088-1-yuehaibing@huawei.com
2020-04-17 15:50:09 +02:00
Sam Ravnborg
1c49f35e9e
video: vt8500lcdfb: fix fallthrough warning
...
Fix following warning:
vt8500lcdfb.c: In function 'vt8500lcd_blank':
vt8500lcdfb.c:229:6: warning: this statement may fall through [-Wimplicit-fallthrough=]
if (info->fix.visual == FB_VISUAL_PSEUDOCOLOR ||
^
vt8500lcdfb.c:233:2: note: here
case FB_BLANK_UNBLANK:
^~~~
Adding a simple "fallthrough;" fixed the warning.
The fix was build tested.
Signed-off-by: Sam Ravnborg <sam@ravnborg.org >
Reported-by: kbuild test robot <lkp@intel.com >
Fixes: e41f1a9894
("fbdev: Implement simple blanking in pseudocolor modes for vt8500lcdfb")
Cc: Alexey Charkov <alchark@gmail.com >
Cc: Paul Mundt <lethal@linux-sh.org >
Cc: <stable@vger.kernel.org > # v2.6.38+
Signed-off-by: Bartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com >
Link: https://patchwork.freedesktop.org/patch/msgid/20200412202143.GA26948@ravnborg.org
2020-04-17 15:50:08 +02:00
Uwe Kleine-König
5c694f8094
video: fbdev: imxfb: ensure balanced regulator usage
...
The fbdev framework doesn't care to call the .set_power callback only on
changes. So the driver has to care for itself that the regulator doesn't
get disabled more often than enabled.
This fixes the regulator warning
unbalanced disables for lcd supply
which can be triggered by doing
echo 4 > /sys/class/lcd/imxfb-lcd/lcd_power
twice.
Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de >
Cc: Sascha Hauer <s.hauer@pengutronix.de >
Cc: Pengutronix Kernel Team <kernel@pengutronix.de >
Cc: Shawn Guo <shawnguo@kernel.org >
Cc: Fabio Estevam <festevam@gmail.com >
Cc: NXP Linux Team <linux-imx@nxp.com >
Signed-off-by: Bartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com >
Link: https://patchwork.freedesktop.org/patch/msgid/20200323211626.24812-1-u.kleine-koenig@pengutronix.de
2020-04-17 15:50:07 +02:00
Bartlomiej Zolnierkiewicz
04dff10ffb
video: fbdev: controlfb: remove function prototypes part #3
...
Reorder code a bit and then remove no longer needed function
prototypes.
Acked-by: Sam Ravnborg <sam@ravnborg.org >
Signed-off-by: Bartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com >
Link: https://patchwork.freedesktop.org/patch/msgid/20200324134508.25120-7-b.zolnierkie@samsung.com
2020-04-17 15:50:06 +02:00
Bartlomiej Zolnierkiewicz
a57eb14ebb
video: fbdev: controlfb: remove function prototypes part #2
...
Reorder code a bit and then remove no longer needed function
prototypes.
Acked-by: Sam Ravnborg <sam@ravnborg.org >
Signed-off-by: Bartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com >
Link: https://patchwork.freedesktop.org/patch/msgid/20200324134508.25120-6-b.zolnierkie@samsung.com
2020-04-17 15:50:05 +02:00
Bartlomiej Zolnierkiewicz
946e8fd4fb
video: fbdev: controlfb: remove function prototypes part #1
...
Reorder code a bit and then remove no longer needed function
prototypes.
Acked-by: Sam Ravnborg <sam@ravnborg.org >
Signed-off-by: Bartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com >
Link: https://patchwork.freedesktop.org/patch/msgid/20200324134508.25120-5-b.zolnierkie@samsung.com
2020-04-17 15:50:04 +02:00
Bartlomiej Zolnierkiewicz
72155824e1
video: fbdev: controlfb: remove obsolete module support
...
CONFIG_FB_CONTROL is bool, hence the Apple "control" frame buffer
driver cannot be built as a module.
Replace module_init() by device_initcall().
Acked-by: Sam Ravnborg <sam@ravnborg.org >
Signed-off-by: Bartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com >
Link: https://patchwork.freedesktop.org/patch/msgid/20200324134508.25120-4-b.zolnierkie@samsung.com
2020-04-17 15:50:03 +02:00
Bartlomiej Zolnierkiewicz
a07a63b0e2
video: fbdev: controlfb: add COMPILE_TEST support
...
Add COMPILE_TEST support to controlfb driver for better compile
testing coverage.
While at it:
- convert driver to use eieio() and dcbf() helpers instead of
open-coding them
- add invalid_vram_cache() helper to avoid code duplication
Acked-by: Sam Ravnborg <sam@ravnborg.org >
Signed-off-by: Bartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com >
Link: https://patchwork.freedesktop.org/patch/msgid/20200324134508.25120-3-b.zolnierkie@samsung.com
2020-04-17 15:50:02 +02:00
Bartlomiej Zolnierkiewicz
38bf1077cf
video: fbdev: controlfb: fix sparse warning about using incorrect type
...
Use in_le32() instead of le32_to_cpup() to fix sparse warning about
improper type of the argument.
Also drop inline keyword from control_par_to_var() prototype
(to match function definition).
Acked-by: Sam Ravnborg <sam@ravnborg.org >
Signed-off-by: Bartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com >
Link: https://patchwork.freedesktop.org/patch/msgid/20200324134508.25120-2-b.zolnierkie@samsung.com
2020-04-17 15:50:01 +02:00
Andy Shevchenko
304d63d4d8
video: ssd1307fb: Remove redundant forward declaration
...
There is no need to have forward declaration of struct ssd1307fb_par.
Drop it for good.
Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com >
Signed-off-by: Bartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com >
Link: https://patchwork.freedesktop.org/patch/msgid/20200324170532.44384-5-andriy.shevchenko@linux.intel.com
2020-04-17 15:50:00 +02:00
Andy Shevchenko
479382360d
video: ssd1307fb: Convert to atomic PWM API
...
Use the atomic API wherever appropriate and get rid of pwm_apply_args()
call (the reference period and polarity are now explicitly set when
calling pwm_apply_state()).
We also make use of the pwm_set_relative_duty_cycle() helper to ease
relative to absolute duty_cycle conversion.
Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com >
Signed-off-by: Bartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com >
Link: https://patchwork.freedesktop.org/patch/msgid/20200324170532.44384-4-andriy.shevchenko@linux.intel.com
2020-04-17 15:49:59 +02:00
Andy Shevchenko
72915994e0
video: ssd1307fb: Make use of device properties
...
Device property API allows to gather device resources from different sources,
such as ACPI. Convert the drivers to unleash the power of device property API.
Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com >
Signed-off-by: Bartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com >
Link: https://patchwork.freedesktop.org/patch/msgid/20200324170532.44384-3-andriy.shevchenko@linux.intel.com
2020-04-17 15:49:58 +02:00
Andy Shevchenko
fa64c6bade
video: ssd1307fb: Introduce temporary variable to increase readability
...
Introduce temporary variable to increase readability of the code.
Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com >
[b.zolnierkie: fix lines over 80 characters]
Signed-off-by: Bartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com >
Link: https://patchwork.freedesktop.org/patch/msgid/20200324170532.44384-2-andriy.shevchenko@linux.intel.com
2020-04-17 15:49:57 +02:00
Andy Shevchenko
59d961c597
video: ssd1307fb: Convert driver to use ->probe_new()
...
Use the ->probe_new() callback.
The driver does not use const struct i2c_device_id * argument,
so convert it to utilise the simplified I²C driver registration.
Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com >
Signed-off-by: Bartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com >
Link: https://patchwork.freedesktop.org/patch/msgid/20200324170532.44384-1-andriy.shevchenko@linux.intel.com
2020-04-17 15:49:56 +02:00
Thomas Zimmermann
948565468c
Merge tag 'topic/phy-compliance-2020-04-08' of git://anongit.freedesktop.org/drm/drm-misc into drm-misc-next
...
Topic pull request for topic/phy-compliance:
- Standardize DP_PHY_TEST_PATTERN name.
- Add support for setting/getting test pattern from sink.
- Implement DP PHY compliance to i915.
Signed-off-by: Thomas Zimmermann <tzimmermann@suse.de >
# gpg: Signatur vom Mi 08 Apr 2020 14:46:42 CEST
# gpg: mittels RSA-Schlüssel B97BD6A80CAC4981091AE547FE558C72A67013C3
# gpg: Signatur kann nicht geprüft werden: Kein öffentlicher Schlüssel
From: Maarten Lankhorst <maarten.lankhorst@linux.intel.com >
Link: https://patchwork.freedesktop.org/patch/msgid/efb3d0d9-2cf7-046b-3a9b-2548d086258e@linux.intel.com
2020-04-17 08:52:39 +02:00
Thomas Zimmermann
08d99b2c23
Merge drm/drm-next into drm-misc-next
...
Backmerging required to pull topic/phy-compliance.
Signed-off-by: Thomas Zimmermann <tzimmermann@suse.de >
2020-04-17 08:12:22 +02:00
Andrzej Pietrasiewicz
13e3d94110
drm: Don't free a struct never allocated by drm_gem_fb_init()
...
drm_gem_fb_init() is passed the fb and never allocates it, so it should be
not the one freeing it. As it is now the second call to kfree() is possible
with the same fb. Coverity reported the following:
*** CID 1492613: Memory - corruptions (USE_AFTER_FREE)
/drivers/gpu/drm/drm_gem_framebuffer_helper.c: 230 in drm_gem_fb_create_with_funcs()
224 fb = kzalloc(sizeof(*fb), GFP_KERNEL);
225 if (!fb)
226 return ERR_PTR(-ENOMEM);
227
228 ret = drm_gem_fb_init_with_funcs(dev, fb, file, mode_cmd, funcs);
229 if (ret) {
vvv CID 1492613: Memory - corruptions (USE_AFTER_FREE)
vvv Calling "kfree" frees pointer "fb" which has already been freed. [Note: The source code implementation of the function has been overridden by a user model.]
230 kfree(fb);
231 return ERR_PTR(ret);
232 }
233
234 return fb;
235 }
drm_gem_fb_init_with_funcs() calls drm_gem_fb_init()
drm_gem_fb_init() calls kfree(fb)
Reported-by: coverity-bot <keescook+coverity-bot@chromium.org >
Addresses-Coverity-ID: 1492613 ("Memory - corruptions")
Fixes: f2b816d78a
("drm/core: Allow drivers allocate a subclass of struct drm_framebuffer")
Signed-off-by: Andrzej Pietrasiewicz <andrzej.p@collabora.com >
Reviewed-by: Daniel Vetter <daniel.vetter@ffwll.ch >
Link: https://patchwork.freedesktop.org/patch/msgid/20200415172024.24004-1-andrzej.p@collabora.com
2020-04-16 13:44:29 +02:00
Sam Ravnborg
702a21425a
dt-bindings: display: move DSI panels to panel-simple-dsi
...
Tomi noticed that several DSI panels was wrongly
described in panel-simple.yaml.
Move them to panel-simple-dsi.yaml where they belong.
Signed-off-by: Sam Ravnborg <sam@ravnborg.org >
Reviewed-by: Rob Herring <robh@kernel.org >
Cc: Tomi Valkeinen <tomi.valkeinen@ti.com >
Link: https://patchwork.freedesktop.org/patch/msgid/20200408195109.32692-37-sam@ravnborg.org
2020-04-15 18:05:46 +02:00
Sam Ravnborg
8b9e7ace12
dt-bindings: display: convert olimex,lcd-olinuxino to DT Schema
...
v2:
- use "ic2" node name in example (Rob)
Signed-off-by: Sam Ravnborg <sam@ravnborg.org >
Reviewed-by: Rob Herring <robh@kernel.org >
Cc: Rob Herring <robh@kernel.org >
Cc: Stefan Mavrodiev <stefan@olimex.com >
Cc: Thierry Reding <thierry.reding@gmail.com >
Cc: Sam Ravnborg <sam@ravnborg.org >
Link: https://patchwork.freedesktop.org/patch/msgid/20200408195109.32692-36-sam@ravnborg.org
2020-04-15 18:05:46 +02:00
Sam Ravnborg
5717f3b80d
dt-bindings: display: convert lgphilips,lb035q02 to DT Schema
...
v2:
- drop use of spi-slave.yaml (Maxime)
- added unevaluatedProperties (maxime)
Signed-off-by: Sam Ravnborg <sam@ravnborg.org >
Reviewed-by: Rob Herring <robh@kernel.org >
Cc: Maxime Ripard <mripard@kernel.org >
Cc: Tomi Valkeinen <tomi.valkeinen@ti.com >
Cc: Thierry Reding <thierry.reding@gmail.com >
Cc: Sam Ravnborg <sam@ravnborg.org >
Link: https://patchwork.freedesktop.org/patch/msgid/20200408195109.32692-35-sam@ravnborg.org
2020-04-15 18:05:46 +02:00
Sam Ravnborg
90c8466e37
dt-bindings: display: convert seiko,43wvf1g to DT Schema
...
Signed-off-by: Sam Ravnborg <sam@ravnborg.org >
Reviewed-by: Marco Franchi <marco.franchi@nxp.com >
Reviewed-by: Rob Herring <robh@kernel.org >
Cc: Marco Franchi <marco.franchi@nxp.com >
Cc: Thierry Reding <thierry.reding@gmail.com >
Cc: Sam Ravnborg <sam@ravnborg.org >
Link: https://patchwork.freedesktop.org/patch/msgid/20200408195109.32692-34-sam@ravnborg.org
2020-04-15 18:05:46 +02:00
Sam Ravnborg
236623c09c
dt-bindings: display: convert sharp,lq150x1lg11 to DT Schema
...
Signed-off-by: Sam Ravnborg <sam@ravnborg.org >
Reviewed-by: Rob Herring <robh@kernel.org >
Cc: Peter Rosin <peda@axentia.se >
Cc: Thierry Reding <thierry.reding@gmail.com >
Cc: Sam Ravnborg <sam@ravnborg.org >
Link: https://patchwork.freedesktop.org/patch/msgid/20200408195109.32692-33-sam@ravnborg.org
2020-04-15 18:05:46 +02:00
Sam Ravnborg
e437b61b21
dt-bindings: display: convert sharp,ls037v7dw01 to DT Schema
...
v2:
- Add min/maxItems to mode-gpios (Rob)
- Fix bug in description, mode is up to three gpios (Rob)
Signed-off-by: Sam Ravnborg <sam@ravnborg.org >
Reviewed-by: Rob Herring <robh@kernel.org >
Cc: Rob Herring <robh@kernel.org >
Cc: Tony Lindgren <tony@atomide.com >
Cc: Thierry Reding <thierry.reding@gmail.com >
Cc: Sam Ravnborg <sam@ravnborg.org >
Link: https://patchwork.freedesktop.org/patch/msgid/20200408195109.32692-32-sam@ravnborg.org
2020-04-15 18:05:46 +02:00
Sam Ravnborg
a965584dd0
dt-bindings: display: convert sharp,ls043t1le01 to DT Schema
...
The txt binding specified the property "power-supply".
But the example and the actual implementation in the linux-kernel
uses "avdd-supply".
So the binding is adjusted to use avdd-supply as this seems
to be the correct choice.
There are no DT files in the linux kernel to check.
Signed-off-by: Sam Ravnborg <sam@ravnborg.org >
Reviewed-by: Rob Herring <robh@kernel.org >
Cc: Werner Johansson <werner.johansson@sonymobile.com >
Cc: Thierry Reding <thierry.reding@gmail.com >
Cc: Sam Ravnborg <sam@ravnborg.org >
Link: https://patchwork.freedesktop.org/patch/msgid/20200408195109.32692-30-sam@ravnborg.org
2020-04-15 18:05:45 +02:00
Sam Ravnborg
6b3ee820b5
dt-bindings: display: drop unused simple-panel.txt
...
There are no more references to simple-panel.txt.
Delete it.
Signed-off-by: Sam Ravnborg <sam@ravnborg.org >
Reviewed-by: Rob Herring <robh@kernel.org >
Cc: Thierry Reding <thierry.reding@gmail.com >
Cc: Sam Ravnborg <sam@ravnborg.org >
Link: https://patchwork.freedesktop.org/patch/msgid/20200408195109.32692-29-sam@ravnborg.org
2020-04-15 18:05:45 +02:00
Sam Ravnborg
6c424e6862
dt-bindings: display: convert sitronix,st7789v to DT Schema
...
v2:
- dropped use of spi-slave.yaml (Maxime)
- added unevaluatedProperties (Maxime)
Signed-off-by: Sam Ravnborg <sam@ravnborg.org >
Reviewed-by: Rob Herring <robh@kernel.org >
Cc: Maxime Ripard <mripard@kernel.org >
Cc: Thierry Reding <thierry.reding@gmail.com >
Cc: Sam Ravnborg <sam@ravnborg.org >
Link: https://patchwork.freedesktop.org/patch/msgid/20200408195109.32692-28-sam@ravnborg.org
2020-04-15 18:05:45 +02:00
Sam Ravnborg
c907477e12
dt-bindings: display: convert sony,acx565akm to DT Schema
...
v2:
- drop use of spi-slave.yaml (Maxime)
- add unevaluatedProperties (Maxime)
- rename node in example to panel (Rob)
Signed-off-by: Sam Ravnborg <sam@ravnborg.org >
Reviewed-by: Tomi Valkeinen <tomi.valkeinen@ti.com >
Reviewed-by: Rob Herring <robh@kernel.org >
Cc: Tomi Valkeinen <tomi.valkeinen@ti.com >
Cc: Rob Herring <robh@kernel.org >
Cc: Maxime Ripard <mripard@kernel.org >
Cc: Thierry Reding <thierry.reding@gmail.com >
Cc: Sam Ravnborg <sam@ravnborg.org >
Link: https://patchwork.freedesktop.org/patch/msgid/20200408195109.32692-27-sam@ravnborg.org
2020-04-15 18:05:45 +02:00
Sam Ravnborg
8d1f9345ea
dt-bindings: display: convert startek,startek-kd050c to DT Schema
...
Signed-off-by: Sam Ravnborg <sam@ravnborg.org >
Reviewed-by: Rob Herring <robh@kernel.org >
Cc: Marek Belisko <marek@goldelico.com >
Cc: Thierry Reding <thierry.reding@gmail.com >
Cc: Sam Ravnborg <sam@ravnborg.org >
Link: https://patchwork.freedesktop.org/patch/msgid/20200408195109.32692-26-sam@ravnborg.org
2020-04-15 18:05:45 +02:00
Sam Ravnborg
77aeb2d794
dt-bindings: display: convert toppoly panels to DT Schema
...
v2:
- dropped use of spi-slave.yaml (Maxime)
- added unevaluatedProperties (Maxime)
Signed-off-by: Sam Ravnborg <sam@ravnborg.org >
Reviewed-by: Rob Herring <robh@kernel.org >
Cc: Maxime Ripard <mripard@kernel.org >
Cc: Marek Belisko <marek@goldelico.com >
Cc: H. Nikolaus Schaller <hns@goldelico.com >
Cc: Thierry Reding <thierry.reding@gmail.com >
Cc: Sam Ravnborg <sam@ravnborg.org >
Link: https://patchwork.freedesktop.org/patch/msgid/20200408195109.32692-25-sam@ravnborg.org
2020-04-15 18:05:45 +02:00
Sam Ravnborg
f9f2ae6282
dt-bindings: display: convert samsung,ld9040 to DT Schema
...
v2:
- drop use of spi-slave.yaml (Maxime)
- added unevaluatedProperties (Maxime)
- added type to width/height properties (Rob)
Signed-off-by: Sam Ravnborg <sam@ravnborg.org >
Reviewed-by: Rob Herring <robh@kernel.org >
Cc: Maxime Ripard <mripard@kernel.org >
Cc: Rob Herring <robh@kernel.org >
Cc: Andrzej Hajda <a.hajda@samsung.com >
Cc: Thierry Reding <thierry.reding@gmail.com >
Cc: Sam Ravnborg <sam@ravnborg.org >
Link: https://patchwork.freedesktop.org/patch/msgid/20200408195109.32692-23-sam@ravnborg.org
2020-04-15 18:05:45 +02:00