Some variables are never used after assignment,
so they are removed.
CRs-Fixed: 3394193
Change-Id: I3e475f96e6ff419aaa67ef0910c886dc707fc93b
Signed-off-by: Atiya Kailany <quic_akailany@quicinc.com>
Some dead code was removed and a memory leak issue was resolved
This solves issues related to VA_UNUSED.GEN and MLK.MIGHT.
CRs-Fixed: 3394193
Change-Id: I387587a3e359df9ad44a15e3e3f58b3422c81ad9
Signed-off-by: Atiya Kailany <quic_akailany@quicinc.com>
Enable config for clock update calls that vote the cesta hw client
votes. Update existing ddr drv flags to include spectra for camera
specific flags.
CRs-Fixed: 3315013
Change-Id: I63e0107a517d3c71f8fac7f2d631e2c37f62f8b3
Signed-off-by: Mukund Madhusudan Atre <quic_matre@quicinc.com>
Signed-off-by: Pavan Kumar Chilamkurthi <quic_pchilamk@quicinc.com>
Since OFE config IO opcode has the same value as BPS config IO opcode,
generic handling function for config io ack msg cannot distinguish
BPS or OFE based on the opcode. So, instead, this change handles
the OFE IO config ack msg with the help of command type in the packet.
CRs-Fixed: 3406414
Change-Id: I847bf82cec8cdd86b387c75805060d6a7e44fcb6
Signed-off-by: Sokchetra Eung <quic_eung@quicinc.com>
Added log to print wq_name and callback info to understand
which task is delayed and to aid in debugging.
CRs-Fixed: 3381768
Change-Id: I74f1f5d3312c9163cfbafa4bc15a96c973ef2ba5
Signed-off-by: Karthik Dillibabu <quic_kard@quicinc.com>
Several bits for path based error IRQs are not subscribed
and few shift values are missing. Add missing info and fix
incorrect info in csid headers. Add hbi vbi printing in
format measure logging to give complete info at once.
CRs-Fixed: 3388992, 3376293
Change-Id: I9eb7ee7a4f3384774688184742300d66930ffa0c
Signed-off-by: Mukund Madhusudan Atre <quic_matre@quicinc.com>
The change addresses race conditions stemming from releasing
internal row lock prior to invoking synx APIs. The change
also deregisters dma/synx callbacks if the corresponding
fences are signaled when the associated sync object is signaled.
The change also cleans up & reorganizes functions.
CRs-Fixed: 3403341
Change-Id: I32995900e31ba73eac6b44d2238808f8e6c23f9a
Signed-off-by: Karthik Anantha Ram <quic_kartanan@quicinc.com>
Adding support for LLCC sys cache notify stalling feature.
To influence the cache replacement policy in real time in order to,
improve cache performance and reduce DDR bandwidth.
CRs-Fixed: 3376264
Change-Id: Id82f60fb856b3548bad77670c7c45c81ea1e904f
Signed-off-by: Soumen Ghosh <quic_soumeng@quicinc.com>
On flush specific request, update last flush request ID for
the link.
CRs-Fixed: 3404872
Change-Id: I05eade5792a891c78fa279895b8053ecb1ae9f95
Signed-off-by: Karthik Anantha Ram <quic_kartanan@quicinc.com>
Number of CCI masters index validation to avoid
out of bound array indices access.
CRs-Fixed: 3381768
Change-Id: I14d4a111cc5c7dab17d071446cddccd7651389a3
Signed-off-by: Abhilash Mahapatra <quic_abhmah@quicinc.com>
This change fixes some VA_UNUSED.GEN and MLK.MIGHT issues reported
by KW analysis tool. In addition to a functional fix related to
handle_type not being assigned properly.
CRs-Fixed: 3394193
Change-Id: Id28a06f3a65c639c0968dd1858d16a547f4d4959
Signed-off-by: Atiya Kailany <quic_akailany@quicinc.com>
This change removes some unused variables,
tnis fixes issues related to VA_UNUSED.GEN
reported by KW analysis tool.
CRs-Fixed: 3394193
Change-Id: I456485d06cac6e9d66ea67fed01c8ae0e44e8f68
Signed-off-by: Atiya Kailany <quic_akailany@quicinc.com>
Add OFE AXI path data type to string translations.
Add OFE data path Macros to be used in DTSI.
CRs-Fixed: 3375045
Change-Id: Ia7bc06869c771c34888ee141a53da2c060c6b162
Signed-off-by: Sokchetra Eung <quic_eung@quicinc.com>
When streaming off, issue a reset and then maskout all CSID
IRQs together as opposed to manipulating the mask bit by bit.
There is no atomic way to maskout all IRQs, in the process of
masking out IRQ bits an IRQ could still fire. This change ensures
we maskout the IRQs in a clean way post that unsubscribe for
those events from the IRQ controller. The change also ensures
the rx input is cut off prior to issuing a SW reset, this is
to rule out any spurious activity in HW caused due to incoming
data. At the time of the SW reset we are certain, we are not
in the middle of processing frames.
CRs-Fixed: 3336496
Change-Id: I1f714d290d31bb744809b2df9e2a4245b59641fe
Signed-off-by: Karthik Anantha Ram <quic_kartanan@quicinc.com>
This change enables FW ramdump by default, can be disabled
by using icp debugfs.
CRs-Fixed: 3393159
Change-Id: I8e66fe1f8ddba935bb27b6ee72ea36f38b384bf3
Signed-off-by: Karthik Anantha Ram <quic_kartanan@quicinc.com>
Monitor sync object operations such as create, register callback,
signal, unregister callback which is useful in debugging. Introduce
debugfs to dynamically set the monitor mask. Apply dump on error
when CAM_GENERIC_FENCE_TYPE_xx is set in cam_sync_monitor_mask and
apply dump on release when CAM_GENERIC_FENCE_TYPE_xx_DUMP is also set
at the same time. Apply dynamic memory allocation for monitor data
in synx and dma. Refactor APIs into generic ones and add memory
checkings.
CRs-Fixed: 3350863
Change-Id: I70cfdc1215be5f6bf564c672a874e6ba7997cdfa
Signed-off-by: Pavan Kumar Chilamkurthi <quic_pchilamk@quicinc.com>
Signed-off-by: Haochen Yang <quic_haocyang@quicinc.com>
Problem Description:
Missing context details in logs and mapping of
hw_mgr context id with isp context id during acquire.
Solution:
Add context id and link handle in ife_hw_mgr and isp_context
files. Add hw_id in csid, vfe top and vfe bus files. Also
add hw_mgr context id in isp_context file to map ISP context
with IFE hw mgr context during acquire, for better debuggability.
CRs-Fixed: 3354324
Change-Id: I455d5a6a5d6ec892899f6f84d73459faab0ceef2
Signed-off-by: Stuti Saxena <quic_stutsaxe@quicinc.com>
Configuring sensor pd to 1 for hfr usecase, then the setting
of sensor can reflect on next batch.
CRs-Fixed: 3376953
Change-Id: I4a78e087aec0e46f78f40ae8c37f1086125558de
Signed-off-by: Depeng Shao <quic_depengs@quicinc.com>
Get svs clock rate from IPE hw for ICP that controls IPE and
svs clock rate from OFE hw for ICP that controls OFE. If neither
IPE or OFE HW exists, it logs error and bails out.
CRs-Fixed: 3367277
Change-Id: I9834843a407e575af46ece0b482306f089a3e25d
Signed-off-by: Sokchetra Eung <quic_eung@quicinc.com>
Change aon_camera_id to uint32 to read correct value from dtsi
Since more than one aon cameras are present.
CRs-Fixed: 3355901
Change-Id: I2a7723fa5b4f6c3a9a27d7119bdab2c65c4e620d
Signed-off-by: Ridhi Shah <quic_ridhshah@quicinc.com>
The current secure camera implementation suffers with a few
issues in terms of typecasting, error handling and in
populating the information in the right data structures when
the new SCM API is used on the targets without domain ID support.
In addition, we needed to be explicit in failing to acquire
if dual IFE is required in secure camera use cases as it is
not a supported feature as of now.
CRs-Fixed: 3317248
Change-Id: Idb762158b0ff0e0a0d6d51de4770fc3d9d9072c8
Signed-off-by: Vijay Kumar Tumati <quic_vtumati@quicinc.com>
Avoid resetting the registers before halting the pipeline
to make sure that the invalid domain ID is not used for
pending bus transactions.
CRs-Fixed: 3377014
Change-Id: I417c8be54dd24d628b45cac7c5bc1ae4fbb8fc97
Signed-off-by: Vijay Kumar Tumati <quic_vtumati@quicinc.com>
Adds support for new mink call to configure secure
camera sessions. This new mink call takes in additional
parameters to support the new domain-id based
security scheme. The additional parameters are in the
form of csid_hw_idx_mask, cdm_hw_idx_mask and
vc_mask. These are in addition to the existing PHY idx
and CPHY/DPHY lanes info.
The introduction of this new mink call deprecates the
existing SCM call used to service secure camera sessions.
What this means is that on all subsequent versions of this
driver, all secure camera sessions will be serviced by this
mink call, which is able to accommodate older and newer targets,
and their programming of different register sets.
This design enables the cam_csiphy_notify_secure_mode
wrapper to remain the same, with the underlying mink call
made in the cam_compat layer, depending on camera driver
version.
CRs-Fixed: 3317248
Change-Id: I05511f4380ce5467b104675c07c9c8faa5318af8
Signed-off-by: Li Sha Lim <quic_lishlim@quicinc.com>
Mode switch delay is an inherent property of a sensor.
Similarly IFE has a static switch delay of 1. For sensors
with switch delay > 1 need special handling on certain
occasions. It is possible that switch settings was applied
to sensor, and on the next frame if there is a flash inject
delay or a packet delay, sensor & IFE are bound to go out of sync.
To address such cases, IFE will decide if it needs to apply
MUP on a dropped frame or not, along with any corresponding
IQ settings.
CRs-Fixed: 3320774
Change-Id: I355fa0f8b767d44bd3fb87c91b3cbf56fb9c3933
Signed-off-by: Karthik Anantha Ram <quic_kartanan@quicinc.com>
If there is a genuine bubble followed by an out of sync,
handle bubble once. If the out of sync continues to happen,
try for internal recovery.
CRs-Fixed: 3336466
Change-Id: Ib697ac1b8907459d06313a9f301cb00a480bd858
Signed-off-by: Karthik Anantha Ram <quic_kartanan@quicinc.com>
Signed-off-by: Depeng Shao <quic_depengs@quicinc.com>
If active/wait request lists are empty resume internal recovery
from the first request in the pending list.
CRs-Fixed: 3317349
Change-Id: Ib708d696065e2dc81deb1d27687d7afd191b0838
Signed-off-by: Karthik Anantha Ram <quic_kartanan@quicinc.com>
In current targets composite groups are statically mapped
to vfe output ports but still we assign them everytime we acquire
the device, here we map comp_grp to vfe_out_port while vfe_out_init
this will render use of list for used and free_comp_grp useless
thereby saving memory and time as we need not acquire comp_grp
on every acquire and release on every release.This also fixes a
memory leak in sfe deinit.
CRs-Fixed: 3321317
Change-Id: I8f4da9e1fd25b123e0081fdefa5ab99e0758c6b3
Signed-off-by: Ashish Bhimanpalliwar <quic_abhiman@quicinc.com>
This change is to validate session and device handle.
Also, checks whether the device handle belongs to
correct session handle or not.
CRs-Fixed: 3350595
Change-Id: If1e06607ccaa99d3288ddca6a263d54315b14caa
Signed-off-by: Karthik Dillibabu <quic_kard@quicinc.com>
Fix a compilation error that occurs if CONFIG_CAM_TEST_IRQ_LINE flag
is enabled.
CRs-Fixed: 3366261
Change-Id: I83ef05bb51fe74e669dbcd6315ce916e9cf5c14a
Signed-off-by: Sokchetra Eung <quic_eung@quicinc.com>
