In driver num_comv value is coming more than expected
due to assumtion of default VPP delay as 2, which
is not needed now.
Change-Id: Ie24b5b30034cbc465aaa5952d80b6c0811cfe1a2
Signed-off-by: Ankush Mitra <quic_ankumitr@quicinc.com>
Fix space and blank line required warning.
Change-Id: I2f754e52cdb36332a53b65ca248ae5d974a00ff4
Signed-off-by: Ankush Mitra <quic_ankumitr@quicinc.com>
- Driver code gets the compression ratio(CR) from FW. This CR is used
to calculate the compression factor(CF) and used in BW calculations.
Perf. model code for BW calculations always assumes that CF will be in
fractional format. But, driver already converts the CR to integer format.
So, we need to remove the x100 multiplication in BW calculation code.
- As CF is used as division factor for BW calculations,
due to this x100 bump in CF values, we see very low calculated BW values.
Change-Id: Ifbddee68b6799b2fe0fc6d5ffa623514e1abd13f
Signed-off-by: Ashish Patil <quic_ashpat@quicinc.com>
fix copyright markings and have all markings in one
multiline comment.
Change-Id: I481c6213bb25e8c278956ad6a51df3fc5c1aabf2
Signed-off-by: Dikshita Agarwal <quic_dikshita@quicinc.com>
pineapple_technology.h contains multiple static array and it is
getting included from msm_vidc_bus.c & msm_vidc_clock.c files.
So in generated build is having 2 copies of static arrays in
code segment.
So added changes to avoid duplication in generated bin.
Change-Id: Ifcfa07331e868440d033d2c7d65555810ad4d1b3
Signed-off-by: Govindaraj Rajagopal <quic_grajagop@quicinc.com>
Treat NOC error (which is a result of pagefault) as
fatal error to and get more debug info to resolve the
pagefault issue.
Change-Id: I3a1cd99fea680a941788d1bc8ea586bf0ff29365
Signed-off-by: Maheshwar Ajja <quic_majja@quicinc.com>
There are many places in code where available helper
functions are not being used, fix it.
Change-Id: Id5b309837fd5847e280f7fab02820af1b08242a6
Signed-off-by: Dikshita Agarwal <quic_dikshita@quicinc.com>
Remove core check from all the functions in video driver.
ore check is present in most of the functions in video
driver which is not required.
Keep check only at root level functions and remove
the check from rest all of the functions.
Change-Id: I5f6374b68dd739b7ab563f32f64bb90e368c4085
Signed-off-by: Vedang Nagar <quic_vnagar@quicinc.com>
Incase of split mode(either for linear color format
or AV1 film grain usecases), dpb and opb(output)
buffers are allocated in same context bank. In high
memory consumption usecases like 8k, it can lead to
OOM issues. To avoid this, for split mode, when both
dpb and opb buffers are used, honor fw min count for
dpb buffers, whereas for opb buffers choose an optimal
min count to ensure performance.
Change-Id: I287aff862d2fe36a690c1393d64f8095578baf34
Signed-off-by: Darshana Patil <quic_darshana@quicinc.com>
Remove deinit sequence calls and register devm
managed callbacks, so that kernel can invoke
then, when dev scope ends and cleansup all
associated resources.
Change-Id: I729fd21fe32d9f39240d0b743f910409d93a00c5
Signed-off-by: Govindaraj Rajagopal <quic_grajagop@quicinc.com>
This is resolve some of this kind of checker err.
Change-Id: Ief665e17045c3b6a6ff636ab6404c6e0c93e9460
Signed-off-by: Ankush Mitra <quic_ankumitr@quicinc.com>
This will fix some static code checker err.
Change-Id: I664e96dd2d65f694c3f2523e1f4aeb08a40f660a
Signed-off-by: Ankush Mitra <quic_ankumitr@quicinc.com>
This change will resolve some of the static code
checker err.
Change-Id: I62edcbc8740dd932f5662b0bad1548374a0c9188
Signed-off-by: Ankush Mitra <quic_ankumitr@quicinc.com>
Remove inst check from all the functions in video driver.
Inst check is present in most of the functions in video
driver which is not required.
Keep check only at root level functions and remove
from rest all of the functions.
Change-Id: Ib310cd3df5e8612a9fc3a5aa654dff4203a12906
Signed-off-by: Vedang Nagar <quic_vnagar@quicinc.com>
1. use max of operating and frame rate for fps
2. vpp_cycles is considered close to frequency
corner if vpp_min_freq is greater than max
required frequency
Change-Id: I9dc995ca16e4eeae18497a8648dfef64e16dfbc2
Signed-off-by: Deepa Guthyappa Madivalara <quic_dmadival@quicinc.com>
1. allow any client set operating rate (less than 2^15)
2. remove operating rate dependency for admission control
3. allow turbo for low latency case as well
Change-Id: I4b0f29c3756a592a9baedec8996653e5cb5292d5
Signed-off-by: Deepa Guthyappa Madivalara <quic_dmadival@quicinc.com>
- always execute noc reset sequnce in power off
- try to disable hw power always before power down
Change-Id: I76757cccea06a398d1a79310edb688608607a413
Signed-off-by: Deepa Guthyappa Madivalara <quic_dmadival@quicinc.com>
- In noc error handler do not clear
NOC_ERL_ErrorLogger_main_ErrorLogger_ErrClr_Low, to
avoid sending any pending transactions, move clearing
to power on
Change-Id: Ib620f3dcb93b92f2c03eb2126c47d5b97526556d
Signed-off-by: Deepa Guthyappa Madivalara <quic_dmadival@quicinc.com>
- program required NOC registers in power on
- update NOC error handling when fw raises HFI_SYS_ERROR_NOC
- skip reading NOC error log registers from smmu fault handler
as they are updated only when sys error from firmware is
processed and fault handling is completed
Change-Id: If396995d8bd6c77e6a92c0c2a8a7fb245be48854
Signed-off-by: Deepa Guthyappa Madivalara <quic_dmadival@quicinc.com>
- program required NOC registers in power on
- update NOC error handling when fw raises HFI_SYS_ERROR_NOC
- skip reading NOC error log registers from smmu fault handler
as they are updated only when sys error from firmware is
processed and fault handling is completed
Change-Id: I0195515ff1640aabe8e6db85803b49fde645808f
Signed-off-by: Deepa Guthyappa Madivalara <quic_dmadival@quicinc.com>
read the av1 uniform tile handling propert from fw
and display it. Required in debugging av1 usecases for
power calculation
Change-Id: I443e5afd591a8131c667c64cebb417fc022693ac
Signed-off-by: Ashish Patil <quic_ashpat@quicinc.com>
If the av1 tile rows and columns are greater than recommended decoder
av1 settings,vote for higher frequency.
Change-Id: Iea9f542e0b925a9ecb063c11b1827f31164f5a7b
Signed-off-by: Ashish Patil <quic_ashpat@quicinc.com>
