Commit Graph

615 Commits

Author SHA1 Message Date
Anand Ravi
aadc0947af msm: camera: isp: Add last consumed address check for 680 hardware
Enable verifying last consumed address on 680 hardware.

CRs-Fixed: 2846451
Change-Id: I217e11a5fc7b56aeebd41ee06a7cf913e0cf18de
Signed-off-by: Anand Ravi <ananravi@codeaurora.org>
2021-03-24 15:35:29 -07:00
Savita Patted
75f34dc77d Merge "msm: camera: isp: Print the faulting IFE/SFE module" into camera-kernel.lnx.5.0 2021-03-23 18:47:12 -07:00
Savita Patted
93be89f6f5 Merge "msm: camera: isp: Assign max hw update entries based on stream type" into camera-kernel.lnx.5.0 2021-03-23 18:46:51 -07:00
Savita Patted
dd01debce6 Merge "msm: camera: common: Use pdev name for soc dev name" into camera-kernel.lnx.5.0 2021-03-23 18:46:30 -07:00
Savita Patted
1258f67a3c Merge "msm: camera: isp: Address SFE BW issues" into camera-kernel.lnx.5.0 2021-03-23 18:45:54 -07:00
Haritha Chintalapati
48101628b5 Merge "msm: camera: isp: Remove unnecessary bound check in bw update path" into camera-kernel.lnx.5.0 2021-03-22 16:35:51 -07:00
Karthik Anantha Ram
8ed5423b26 msm: camera: isp: Print the faulting IFE/SFE module
In case of a module hang apart from printing the debug status
registers print the faulting module name as well.

CRs-Fixed: 2841729
Change-Id: I43c34df1d667e77827fce50b312741449c1c4e17
Signed-off-by: Karthik Anantha Ram <kartanan@codeaurora.org>
2021-03-21 20:32:33 -07:00
Karthik Anantha Ram
a17df881bf msm: camera: isp: Address SFE BW issues
Fix the logic classifying BW vote from userspace.
Correct log strings for SFE usage data.

CRs-Fixed: 2841729
Change-Id: Ife7eb5635e97b376a05696c1c5406972bcf4a7c8
Signed-off-by: Karthik Anantha Ram <kartanan@codeaurora.org>
2021-03-21 20:27:17 -07:00
Pavan Kumar Chilamkurthi
7f750a59f0 msm: camera: common: Use pdev name for soc dev name
Having a global variable and using the same for all devices
will overwrite the name of previous device. Use pdev name
to be consistent and helps in debugging logs.

CRs-Fixed: 2901925
Change-Id: I086f3dbd12e720c5e6497355eae40ca242d3d408
Signed-off-by: Pavan Kumar Chilamkurthi <pchilamk@codeaurora.org>
2021-03-20 19:48:08 -07:00
Karthik Anantha Ram
1f9c10f9c8 msm: camera: isp: Assign max hw update entries based on stream type
In case of SFE/CSID cmd buffer update, more number of hw update entries
is needed. Assign and allocate this memory dynamically based
on stream type. Also the change makes cdm cmd memory allocation
based on the stream.

CRs-Fixed: 2841729
Change-Id: Iaaa3ce7152a103ace25b24d84776f5a665603994
Signed-off-by: Karthik Anantha Ram <kartanan@codeaurora.org>
2021-03-20 11:54:01 -07:00
Haritha Chintalapati
536d5a9599 Merge "msm: camera: reqmgr: Handle flash properly" into camera-kernel.lnx.5.0 2021-03-19 17:41:32 -07:00
Haritha Chintalapati
1e7f567b94 Merge "msm: camera: isp: SFE cleanup change" into camera-kernel.lnx.5.0 2021-03-18 20:12:17 -07:00
Haritha Chintalapati
9f29459fc2 Merge "msm: camera: isp: Change last_dump_err_req field to a bool" into camera-kernel.lnx.5.0 2021-03-18 20:11:54 -07:00
Haritha Chintalapati
f4e1d02d37 Merge "msm: camera: reqmgr: Improve CRM logging" into camera-kernel.lnx.5.0 2021-03-18 20:11:28 -07:00
Depeng Shao
a8fce31f3f msm: camera: reqmgr: Handle flash properly
Apply the flash at EOF and apply the other devices
at the EPOCH of next frame, then the flash can
cover all the exposure zone of current request.
Add the inject delay for SOF and EOF separate,
then we can use inject delay for more flexible
frame skip control.

CRs-Fixed: 2820683
Change-Id: Ic6a58327a0ae44c54190884ba42ea7926ec7c90e
Signed-off-by: Depeng Shao <depengs@codeaurora.org>
2021-03-18 15:30:48 +08:00
Mukund Madhusudan Atre
32e2da9905 msm: camera: isp: Remove unnecessary bound check in bw update path
Currently, iterating through all the possible split indexes will
always hit the check for max value at the end. Remove the check
as the KW error corresponding to it is false positive.

CRs-Fixed: 2841729
Change-Id: I8b555ab3c4680e348d3af1169d95b79e0d8572a9
Signed-off-by: Mukund Madhusudan Atre <matre@codeaurora.org>
2021-03-17 23:16:12 -07:00
Karthik Anantha Ram
3e53f494b8 msm: camera: isp: Change last_dump_err_req field to a bool
In case of streams with no ePCR, and if error happens on the
very first frame reg dump on error is not triggered since
last_dump_err_req_id and applied_req_id both are 0x0. Change
it to a flag instead to avoid this scenario and reset the flag
at stream off/release.

CRs-Fixed: 2841729
Change-Id: Ieaee68c42fb2228dfa966a0ef158802a10694dca
Signed-off-by: Karthik Anantha Ram <kartanan@codeaurora.org>
2021-03-17 10:45:57 -07:00
Savita Patted
0626095cbc Merge "msm: camera: isp: Re-assign WMs for UAPI port names" into camera-kernel.lnx.5.0 2021-03-16 17:42:58 -07:00
Savita Patted
6ad996f234 Merge "msm: camera: isp: Update debug cfg for all paths" into camera-kernel.lnx.5.0 2021-03-16 17:41:59 -07:00
Savita Patted
ef326026ba Merge "msm: camera: isp: Remove IFE top core cfg in KMD for v4" into camera-kernel.lnx.5.0 2021-03-16 17:41:40 -07:00
Karthik Anantha Ram
f561198bac msm: camera: isp: SFE cleanup change
Remove bus read blob config for SFE. Also correct
loop condition when printing SFE bus wr violation info.

CRs-Fixed: 2841729
Change-Id: Ia080da6e81ef7836a3ca013d78a2a3621daa547f
Signed-off-by: Karthik Anantha Ram <kartanan@codeaurora.org>
2021-03-16 12:02:39 -07:00
Depeng Shao
1edfd82801 msm: camera: reqmgr: Mask re-apply for SHDR usecase
SHDR case has two ISP instances, if one of them
apply req failed sometimes, but the other one is
good and the buf done has been handled successfully,
then we don't need to apply the req again for the
successful ISP.

CRs-Fixed: 2842495
Change-Id: I3dfbb455244daa0d155858dd59f4a661fd3b87cd
Signed-off-by: Depeng Shao <depengs@codeaurora.org>
2021-03-12 23:42:05 -08:00
Jigar Agrawal
cd5e3f033d msm: camera: reqmgr: Improve CRM logging
Add CSID hw index in crm logging for better debugging.

CRs-Fixed: 2898319
Change-Id: Ia378a2eaf51f9306b5f693ba7180dd44fc6ef74d
Signed-off-by: Jigar Agrawal <jigar@codeaurora.org>
2021-03-11 16:03:54 -08:00
Karthik Anantha Ram
c4eac8ce8d msm: camera: isp: Update debug cfg for all paths
Currently debug_cfg_en is listed only for IPP, update
the value for rest of the paths as well.

CRs-Fixed: 2841729
Change-Id: I19d8489d71468e49a594274f9198e9cb2841003c
Signed-off-by: Karthik Anantha Ram <kartanan@codeaurora.org>
2021-03-11 16:02:33 -08:00
Karthik Anantha Ram
84a590926a msm: camera: isp: Remove IFE top core cfg in KMD for v4
The core config is programmed via CDM by userspace. Remove
the programming of these registers in kernel to avoid
any discrepancy.

CRs-Fixed: 2841729
Change-Id: Iea8b0843c8283dd6be2c98b4e5de9de7f8312b7e
Signed-off-by: Karthik Anantha Ram <kartanan@codeaurora.org>
2021-03-11 15:56:36 -08:00
Karthik Anantha Ram
5ce6aebaad msm: camera: isp: Re-assign WMs for UAPI port names
Switch WMs for current 2PD and 2PD_STATS ports. Rename
2PD_STATS to PREPROCESS_2PD inline with UMD notion.

CRs-Fixed: 2841729
Change-Id: I735ef397cfd6328aa2fef73970def0b64044fe2e
Signed-off-by: Karthik Anantha Ram <kartanan@codeaurora.org>
2021-03-11 15:52:10 -08:00
Haritha Chintalapati
fdf216909b Merge "msm: camera: isp: Add VFE/SFE overflow debug info" into camera-kernel.lnx.5.0 2021-03-11 14:58:27 -08:00
Haritha Chintalapati
afaa34315b Merge "msm: camera: isp: Reset the CSID debug info on release" into camera-kernel.lnx.5.0 2021-03-11 14:58:08 -08:00
Savita Patted
90fb1ebc6c Merge "msm: camera: isp: Allocate max map entries based on the stream type" into camera-kernel.lnx.5.0 2021-03-10 16:10:01 -08:00
Savita Patted
b3a6000ae7 Merge "msm: camera: common: Support compilation for new code base" into camera-kernel.lnx.5.0 2021-03-10 16:09:33 -08:00
Gaurav Jindal
b1bb0805a9 msm: camera: isp: Reset the CSID debug info on release
Reset the CSID debug info on release. Without releasing the
IRQ enabled for previous session will be trigerred in next session
as well.

Change-Id: I3d4dec4446926f60ba772a9608c96513a9919a4f
CRs-Fixed: 2830502
Signed-off-by: Gaurav Jindal <gjindal@codeaurora.org>
2021-03-10 15:36:28 +05:30
Gaurav Jindal
ee3a268ce0 msm: camera: isp: Add VFE/SFE overflow debug info
For new targets, VFE/SFE overflow errors are back pressured to
CSID recovery module. Error IRQs are not available with VFE/SFE
blocks for such errors.
Above errors are to be propagated from CSID driver to downstream
module drivers to print the relevant debug data and handle
the error.
This commit implements propagation of error and
printing the debug info in VFE and SFE.

CRs-Fixed: 2830502
Change-Id: I24ecd7433b3324505e92d9d55576ca3107e66fdd
Signed-off-by: Gaurav Jindal <gjindal@codeaurora.org>
2021-03-10 15:20:46 +05:30
Savita Patted
782ae622ba Merge "msm: camera: isp: Fix for disable UBWC case" into camera-kernel.lnx.5.0 2021-03-09 20:19:04 -08:00
Savita Patted
1ee4bca76c Merge "msm: camera: ope: Handle OPE smmu fault with pid info" into camera-kernel.lnx.5.0 2021-03-09 20:18:26 -08:00
Savita Patted
b2062b243b Merge "msm: camera: isp: Add new packer format to support LSB alignment" into camera-kernel.lnx.5.0 2021-03-09 20:18:07 -08:00
Savita Patted
8c78eb99d6 Merge "msm: camera: tfe: Change debug fs directory name" into camera-kernel.lnx.5.0 2021-03-09 20:17:44 -08:00
Savita Patted
780e1ba3a7 Merge "msm: camera: isp: increase number of hw entries" into camera-kernel.lnx.5.0 2021-03-09 20:17:26 -08:00
Savita Patted
369d0f775c Merge "msm: camera: isp: Fix TPG for future usecase" into camera-kernel.lnx.5.0 2021-03-09 20:15:08 -08:00
Savita Patted
99644ac3dd Merge "msm: camera: isp: IFE Lite top debug registers print functionality" into camera-kernel.lnx.5.0 2021-03-09 01:32:10 -08:00
Savita Patted
d85b43959c Merge "msm: camera: isp: Fix type mismatch arguments in indirect function calls" into camera-kernel.lnx.5.0 2021-03-09 01:31:56 -08:00
Savita Patted
7074fb8996 Merge "msm: camera: isp: Reset num_deferred_acks when re-applying bubble req" into camera-kernel.lnx.5.0 2021-03-09 01:30:36 -08:00
Savita Patted
72d6f26c7a Merge "msm: camera: common: Add common wait and poll interface" into camera-kernel.lnx.5.0 2021-03-09 01:29:50 -08:00
Wyes Karny
616fd64c12 msm: camera: isp: Fix for disable UBWC case
Sometimes multiple io cofigs comes before start_dev. Therefore even we
force disable UBWC compression at start_dev time it can be override by
those io configs. Therefore moving disable UBWC comp logic to acquire
time. Acquire time a flag is sent if we have to enable or disable ubwc
compression, based on this we set bus side ubwc_disable flag. When ever
we start the WM or update the WM UBWC config  we check this flag and
based on this flag we override the ubwc_mode_cfg register.

CRs-Fixed: 2833514
Change-Id: I8efc3f7abd53e0757f8e77ac0788e303f7c695b9
Signed-off-by: Wyes Karny <wkarny@codeaurora.org>
2021-03-08 21:28:23 +05:30
Jigar Agrawal
d68785ea9d msm: camera: isp: Fix TPG for future usecase
Fix the TPG ver3 reserve function for future concurrent camera
use case.

CRs-Fixed: 2823940
Change-Id: I2e8be13d10dbdd475aff2edf343d487ff7ccf802
Signed-off-by: Jigar Agrawal <jigar@codeaurora.org>
2021-03-05 18:29:35 -08:00
Karthik Anantha Ram
b15d7e1415 msm: camera: isp: Allocate max map entries based on the stream type
Allocate context map entries based on the chipset and also
the underlying HW acquired for the given context.

CRs-Fixed: 2841729
Change-Id: Ieeb442c74bd3b6c9c32fbe47b59f40a8485963b3
Signed-off-by: Karthik Anantha Ram <kartanan@codeaurora.org>
2021-03-05 16:12:07 -08:00
Shravya Samala
9d37c961f3 msm: camera: isp: Fix type mismatch arguments in indirect function calls
To avoid CFI failures, fix type mismatch arguments in
callback functions.

CRs-Fixed: 2836088
Change-Id: Ib1d79ca3f4489081c909aeb9ead2e66ef20aed64
Signed-off-by: Shravya Samala <shravyas@codeaurora.org>
2021-03-05 18:40:49 +05:30
Anand Ravi
2440e8c0c9 msm: camera: isp: IFE Lite top debug registers print functionality
This change extends the VFE top debug print functionality including
printing the module descriptions upon violation for IFE lite.

CRs-Fixed: 2846451
Change-Id: I6ba390892abd398ed48ac71a0910e227a787e09b
Signed-off-by: Anand Ravi <ananravi@codeaurora.org>
2021-03-04 10:39:54 -08:00
Wyes Karny
1e3a1316ed msm: camera: isp: Reset num_deferred_acks when re-applying bubble req
When re-applying bubble request after 2 frames reset num_deferred_acks
also.

CRs-Fixed: 2824276
Change-Id: I57e7ac89da69a2d65546c6f9a7f1d3c9f2c7e58f
Signed-off-by: Wyes Karny <wkarny@codeaurora.org>
2021-03-03 20:37:54 -08:00
Haritha Chintalapati
ea8a7f5347 Merge "msm: camera: common: Program scratch buffers for sHDR" into camera-kernel.lnx.5.0 2021-03-02 18:52:32 -08:00
Haritha Chintalapati
62590f374a Merge "msm: camera: isp: Extend reg dump support for Waipio" into camera-kernel.lnx.5.0 2021-03-02 18:52:24 -08:00