Reverse the order of assignment and null check to ensure proper working
of the top half function.
CRs-Fixed: 2906822
Change-Id: Ie4aadd0dfb5b6f1da6167abb07ceb0aee52afb12
Signed-off-by: Anand Ravi <ananravi@codeaurora.org>
For new arch, packer format alignment bit has changed. Move it
to header to allow different values for targets.
CRs-Fixed: 2841729
Change-Id: I55d0347963c367d9cc814a583e5009b41c9efd59
Signed-off-by: Mukund Madhusudan Atre <matre@codeaurora.org>
Currently, the order in which we read the camera bus nodes
is dependent of the order camera device tree is laid out,
which causes issues if the arragement is changed. Update DT
parsing logic to read node levels independent of arrangement.
CRs-Fixed: 2841729
Change-Id: I73f2aa27a71d6521fe4e1fc9af95293411bd75c2
Signed-off-by: Mukund Madhusudan Atre <matre@codeaurora.org>
We will get invalid req from flush_list if the
flush list is empty when we get each req by
list API list_for_each_entry_safe. This change
checks whether flush list is empty before
accessing this list.
CRs-Fixed: 2885145
Change-Id: I9b2828b03706a0f7412828905cc0a9e28d15fd76
Signed-off-by: Depeng Shao <depengs@codeaurora.org>
global-out-of-bounds issue on:
msm_cam_hw_cdm_dt_match
Due to no null-terminating struct in the array.
CRs-Fixed: 2883523
Change-Id: I36e4811f239993e1e6de158df959157217c28bfe
Signed-off-by: Karthik Jayakumar <kjayakum@codeaurora.org>
In case of a module hang apart from printing the debug status
registers print the faulting module name as well.
CRs-Fixed: 2841729
Change-Id: I43c34df1d667e77827fce50b312741449c1c4e17
Signed-off-by: Karthik Anantha Ram <kartanan@codeaurora.org>
Having a global variable and using the same for all devices
will overwrite the name of previous device. Use pdev name
to be consistent and helps in debugging logs.
CRs-Fixed: 2901925
Change-Id: I086f3dbd12e720c5e6497355eae40ca242d3d408
Signed-off-by: Pavan Kumar Chilamkurthi <pchilamk@codeaurora.org>
In case of SFE/CSID cmd buffer update, more number of hw update entries
is needed. Assign and allocate this memory dynamically based
on stream type. Also the change makes cdm cmd memory allocation
based on the stream.
CRs-Fixed: 2841729
Change-Id: Iaaa3ce7152a103ace25b24d84776f5a665603994
Signed-off-by: Karthik Anantha Ram <kartanan@codeaurora.org>
Add Main/Aon camera switch support for image sensor
and it's submodule. This change detects the AON support
from image sensor hw information from it's respective
device tree support. Also sensor needs to call csiphy
to do the cpas top level operation in order to program
the register for Main/AON mux operation, so add API
export from csiphy hw for sensor domain to perform
the operation.
CRs-Fixed: 2899541
Change-Id: Ibde3ce86c15cfd7e7f445f6461565f78a668b812
Signed-off-by: Jigarkumar Zala <jzala@codeaurora.org>
Priority of debug logs allows for better control of which debug logs are
printed. Debug logs default to lowest priority.
CRs-Fixed: 2899680
Change-Id: I59de2d60aac80052b8c7219f866e242d9b475b4d
Signed-off-by: Anand Ravi <ananravi@codeaurora.org>
Apply the flash at EOF and apply the other devices
at the EPOCH of next frame, then the flash can
cover all the exposure zone of current request.
Add the inject delay for SOF and EOF separate,
then we can use inject delay for more flexible
frame skip control.
CRs-Fixed: 2820683
Change-Id: Ic6a58327a0ae44c54190884ba42ea7926ec7c90e
Signed-off-by: Depeng Shao <depengs@codeaurora.org>
Currently, iterating through all the possible split indexes will
always hit the check for max value at the end. Remove the check
as the KW error corresponding to it is false positive.
CRs-Fixed: 2841729
Change-Id: I8b555ab3c4680e348d3af1169d95b79e0d8572a9
Signed-off-by: Mukund Madhusudan Atre <matre@codeaurora.org>
Print status of CSID debug registers info in case of error.
CRs-Fixed: 2880899
Change-Id: I23fdf8f4950cf3f70fdae216c87aff4b87f6771a
Signed-off-by: Chandan Kumar Jha <cjha@codeaurora.org>
In case of streams with no ePCR, and if error happens on the
very first frame reg dump on error is not triggered since
last_dump_err_req_id and applied_req_id both are 0x0. Change
it to a flag instead to avoid this scenario and reset the flag
at stream off/release.
CRs-Fixed: 2841729
Change-Id: Ieaee68c42fb2228dfa966a0ef158802a10694dca
Signed-off-by: Karthik Anantha Ram <kartanan@codeaurora.org>
While csiphy is shutdown abnormally, we also need to
program off csiphy hw common register, to avoid the
residual of active csiphy hw cnt during monkey test.
CRs-Fixed: 2861912
Change-Id: I1767c729b205a96e5f298265e65b37150dac03b6
Signed-off-by: chengxue <chengxue@codeaurora.org>
Add qosgen values and update existing values to match the
recommendation.
CRs-Fixed: 2841729
Change-Id: Ie1f331f9a30bba91d636fcdcca7507b5b4fce237
Signed-off-by: Mukund Madhusudan Atre <matre@codeaurora.org>
In sHDR case, the trigger cnt may be different when one of the IFE
meet bubble or irq delay issue, then reset the trigger cnt when
we find the trigger cnt is different.
CRs-Fixed: 2857614
Change-Id: Ie02fd7204bebd16d32d7a277ac1f2e45f8357dd9
Signed-off-by: Depeng Shao <depengs@codeaurora.org>
SHDR case has two ISP instances, if one of them
apply req failed sometimes, but the other one is
good and the buf done has been handled successfully,
then we don't need to apply the req again for the
successful ISP.
CRs-Fixed: 2842495
Change-Id: I3dfbb455244daa0d155858dd59f4a661fd3b87cd
Signed-off-by: Depeng Shao <depengs@codeaurora.org>
Allocate memory for flush req array dynamically based
on the list count, in case the req count bigger than
the size of req list.
CRs-Fixed: 2835525
Change-Id: I7e48fb9dc7815cb991c84195e761a3c3f1c26b48
Signed-off-by: Depeng Shao <depengs@codeaurora.org>
