qcacmn: Clean active serialization timers on vdev destroy

In the current implementation, if there are any active commands
in the vdev queues then on vdev destroy we remove the commands from
the respective queue and return the command to the global pool.
We should also stop the timers for the corresponding active commands,
otherwise the timeout cb may be called after the destroy is executed.

Change-Id: I51a1049e952073d83b5caee3835e4f9adca2bb9e
CRs-Fixed: 2365411

umac/cmn_services/serialization/src/wlan_serialization_main.c

@@ -927,9 +927,13 @@ static QDF_STATUS wlan_serialization_vdev_destroy_handler(
 		ser_err("ser_vdev_obj NULL");
 		return QDF_STATUS_E_INVAL;
 	}
+
 	status = wlan_objmgr_vdev_component_obj_detach(
 			vdev, WLAN_UMAC_COMP_SERIALIZATION, ser_vdev_obj);
 
+	/*Clean up serialization timers if any for this vdev*/
+	wlan_serialization_cleanup_vdev_timers(vdev);
+
 	for (index = 0; index < SER_VDEV_QUEUE_COMP_MAX; index++) {
 		vdev_q = &ser_vdev_obj->vdev_q[index];
 		wlan_serialization_destroy_vdev_list(&vdev_q->pending_list);

umac/cmn_services/serialization/src/wlan_serialization_utils.c

@@ -1125,6 +1125,52 @@ wlan_serialization_stop_timer(struct wlan_serialization_timer *ser_timer)
 	return QDF_STATUS_SUCCESS;
 }
 
+QDF_STATUS wlan_serialization_cleanup_vdev_timers(
+			struct wlan_objmgr_vdev *vdev)
+{
+	struct wlan_ser_psoc_obj *psoc_ser_obj;
+	struct wlan_serialization_timer *ser_timer;
+	QDF_STATUS status = QDF_STATUS_SUCCESS;
+	uint32_t i = 0;
+
+	ser_enter();
+	psoc_ser_obj = wlan_serialization_get_psoc_obj(
+			wlan_vdev_get_psoc(vdev));
+
+	if (!psoc_ser_obj) {
+		ser_err("Invalid psoc_ser_obj");
+		status = QDF_STATUS_E_FAILURE;
+		goto error;
+	}
+
+	wlan_serialization_acquire_lock(&psoc_ser_obj->timer_lock);
+
+	for (i = 0; psoc_ser_obj->max_active_cmds > i; i++) {
+		ser_timer = &psoc_ser_obj->timers[i];
+		if (!ser_timer->cmd)
+			continue;
+		/*
+		 * Check if the timer is for the given vdev
+		 */
+		if (ser_timer->cmd->vdev != vdev)
+			continue;
+
+		ser_debug("Stopping the timer for vdev id[%d]",
+			  wlan_vdev_get_id(vdev));
+
+		status = wlan_serialization_stop_timer(ser_timer);
+		if (QDF_STATUS_SUCCESS != status) {
+			/* lets not break the loop but report error */
+			ser_err("some error in stopping timer");
+		}
+	}
+
+	wlan_serialization_release_lock(&psoc_ser_obj->timer_lock);
+error:
+	ser_exit();
+	return status;
+}
+
 QDF_STATUS wlan_serialization_cleanup_all_timers(
 			struct wlan_ser_psoc_obj *psoc_ser_obj)
 {

umac/cmn_services/serialization/src/wlan_serialization_utils_i.h

@@ -895,6 +895,21 @@ QDF_STATUS wlan_serialization_get_cmd_from_queue(
  */
 QDF_STATUS
 wlan_serialization_stop_timer(struct wlan_serialization_timer *ser_timer);
+/**
+ * wlan_serialization_cleanup_vdev_timers() - clean-up all timers for a vdev
+ *
+ * @vdev: pointer to vdev object
+ *
+ * This API is to cleanup all the timers for a vdev.
+ * It can be used when serialization vdev destroy is called.
+ * It will make sure that if timer is running then it will
+ * stop and destroys the timer
+ *
+ * Return: QDF_STATUS
+ */
+
+QDF_STATUS wlan_serialization_cleanup_vdev_timers(
+			struct wlan_objmgr_vdev *vdev);
 
 /**
  * wlan_serialization_cleanup_all_timers() - to clean-up all timers