Эх сурвалжийг харах

qcacmn: Rename pAddPeriodicTxPtrnParams

Per the Linux coding style both mixed-case names and so-called
Hungarian notation are frowned upon, therefore replace the identifier
pAddPeriodicTxPtrnParams everywhere it occurs.

Change-Id: Id80fc4cd22a8e4af125f01b937e03eea0b898283
CRs-Fixed: 2371906
Jeff Johnson 6 жил өмнө
parent
commit
da8409437e

+ 6 - 6
wmi/inc/wmi_unified_priv.h

@@ -821,14 +821,14 @@ QDF_STATUS (*send_aggr_qos_cmd)(wmi_unified_t wmi_handle,
 QDF_STATUS (*send_add_ts_cmd)(wmi_unified_t wmi_handle,
 		 struct add_ts_param *msg);
 
-QDF_STATUS (*send_process_add_periodic_tx_ptrn_cmd)(wmi_unified_t wmi_handle,
-						struct periodic_tx_pattern  *
-						pAddPeriodicTxPtrnParams,
-						uint8_t vdev_id);
+QDF_STATUS (*send_process_add_periodic_tx_ptrn_cmd)(
+					wmi_unified_t wmi_handle,
+					struct periodic_tx_pattern *pattern,
+					uint8_t vdev_id);
 
 QDF_STATUS (*send_process_del_periodic_tx_ptrn_cmd)(wmi_unified_t wmi_handle,
-						uint8_t vdev_id,
-						uint8_t pattern_id);
+						    uint8_t vdev_id,
+						    uint8_t pattern_id);
 
 QDF_STATUS (*send_set_auto_shutdown_timer_cmd)(wmi_unified_t wmi_handle,
 						  uint32_t timer_val);

+ 10 - 9
wmi/inc/wmi_unified_sta_api.h

@@ -304,24 +304,25 @@ QDF_STATUS wmi_unified_add_ts_cmd(void *wmi_hdl,
 				  struct add_ts_param *msg);
 
 /**
- * wmi_unified_process_add_periodic_tx_ptrn_cmd - add periodic tx ptrn
+ * wmi_unified_process_add_periodic_tx_ptrn_cmd() - add periodic tx pattern
  * @wmi_handle: wmi handle
- * @pAddPeriodicTxPtrnParams: tx ptrn params
+ * @pattern: tx pattern parameters
+ * @vdev_id: vdev id
  *
- * Retrun: QDF_STATUS_SUCCESS on success and QDF_STATUS_E_FAILURE for failure
+ * Return: QDF_STATUS_SUCCESS on success and QDF_STATUS_E_FAILURE for failure
  */
-QDF_STATUS wmi_unified_process_add_periodic_tx_ptrn_cmd(void *wmi_hdl,
-						struct periodic_tx_pattern  *
-						pAddPeriodicTxPtrnParams,
-						uint8_t vdev_id);
+QDF_STATUS wmi_unified_process_add_periodic_tx_ptrn_cmd(
+					wmi_unified_t wmi_handle,
+					struct periodic_tx_pattern *pattern,
+					uint8_t vdev_id);
 
 /**
- * wmi_unified_process_del_periodic_tx_ptrn_cmd - del periodic tx ptrn
+ * wmi_unified_process_del_periodic_tx_ptrn_cmd() - del periodic tx ptrn
  * @wmi_handle: wmi handle
  * @vdev_id: vdev id
  * @pattern_id: pattern id
  *
- * Retrun: QDF_STATUS_SUCCESS on success and QDF_STATUS_E_FAILURE for failure
+ * Return: QDF_STATUS_SUCCESS on success and QDF_STATUS_E_FAILURE for failure
  */
 QDF_STATUS wmi_unified_process_del_periodic_tx_ptrn_cmd(void *wmi_hdl,
 							uint8_t vdev_id,

+ 5 - 9
wmi/src/wmi_unified_sta_api.c

@@ -323,18 +323,14 @@ QDF_STATUS wmi_unified_add_ts_cmd(void *wmi_hdl,
 	return QDF_STATUS_E_FAILURE;
 }
 
-QDF_STATUS wmi_unified_process_add_periodic_tx_ptrn_cmd(void *wmi_hdl,
-						struct periodic_tx_pattern  *
-						pAddPeriodicTxPtrnParams,
-						uint8_t vdev_id)
+QDF_STATUS wmi_unified_process_add_periodic_tx_ptrn_cmd(
+					wmi_unified_t wmi_handle,
+					struct periodic_tx_pattern *pattern,
+					uint8_t vdev_id)
 {
-	wmi_unified_t wmi_handle = (wmi_unified_t) wmi_hdl;
-
 	if (wmi_handle->ops->send_process_add_periodic_tx_ptrn_cmd)
 		return wmi_handle->ops->send_process_add_periodic_tx_ptrn_cmd(
-				wmi_handle,
-				pAddPeriodicTxPtrnParams,
-				vdev_id);
+						wmi_handle, pattern, vdev_id);
 
 	return QDF_STATUS_E_FAILURE;
 }

+ 18 - 16
wmi/src/wmi_unified_sta_tlv.c

@@ -1705,16 +1705,17 @@ static QDF_STATUS send_add_ts_cmd_tlv(wmi_unified_t wmi_handle,
 }
 
 /**
- * send_process_add_periodic_tx_ptrn_cmd_tlv - add periodic tx ptrn
+ * send_process_add_periodic_tx_ptrn_cmd_tlv() - add periodic tx pattern
  * @wmi_handle: wmi handle
- * @pAddPeriodicTxPtrnParams: tx ptrn params
+ * @pattern: tx pattern params
+ * @vdev_id: vdev id
  *
- * Retrun: CDF status
+ * Return: QDF status
  */
-static QDF_STATUS send_process_add_periodic_tx_ptrn_cmd_tlv(wmi_unified_t wmi_handle,
-						struct periodic_tx_pattern  *
-						pAddPeriodicTxPtrnParams,
-						uint8_t vdev_id)
+static QDF_STATUS send_process_add_periodic_tx_ptrn_cmd_tlv(
+					wmi_unified_t wmi_handle,
+					struct periodic_tx_pattern *pattern,
+					uint8_t vdev_id)
 {
 	WMI_ADD_PROACTIVE_ARP_RSP_PATTERN_CMD_fixed_param *cmd;
 	wmi_buf_t wmi_buf;
@@ -1723,7 +1724,7 @@ static QDF_STATUS send_process_add_periodic_tx_ptrn_cmd_tlv(wmi_unified_t wmi_ha
 	uint32_t ptrn_len, ptrn_len_aligned;
 	int j;
 
-	ptrn_len = pAddPeriodicTxPtrnParams->ucPtrnSize;
+	ptrn_len = pattern->ucPtrnSize;
 	ptrn_len_aligned = roundup(ptrn_len, sizeof(uint32_t));
 	len = sizeof(WMI_ADD_PROACTIVE_ARP_RSP_PATTERN_CMD_fixed_param) +
 	      WMI_TLV_HDR_SIZE + ptrn_len_aligned;
@@ -1743,16 +1744,16 @@ static QDF_STATUS send_process_add_periodic_tx_ptrn_cmd_tlv(wmi_unified_t wmi_ha
 
 	/* Pass the pattern id to delete for the corresponding vdev id */
 	cmd->vdev_id = vdev_id;
-	cmd->pattern_id = pAddPeriodicTxPtrnParams->ucPtrnId;
-	cmd->timeout = pAddPeriodicTxPtrnParams->usPtrnIntervalMs;
-	cmd->length = pAddPeriodicTxPtrnParams->ucPtrnSize;
+	cmd->pattern_id = pattern->ucPtrnId;
+	cmd->timeout = pattern->usPtrnIntervalMs;
+	cmd->length = pattern->ucPtrnSize;
 
 	/* Pattern info */
 	buf_ptr += sizeof(WMI_ADD_PROACTIVE_ARP_RSP_PATTERN_CMD_fixed_param);
 	WMITLV_SET_HDR(buf_ptr, WMITLV_TAG_ARRAY_BYTE, ptrn_len_aligned);
 	buf_ptr += WMI_TLV_HDR_SIZE;
-	qdf_mem_copy(buf_ptr, pAddPeriodicTxPtrnParams->ucPattern, ptrn_len);
-	for (j = 0; j < pAddPeriodicTxPtrnParams->ucPtrnSize; j++)
+	qdf_mem_copy(buf_ptr, pattern->ucPattern, ptrn_len);
+	for (j = 0; j < pattern->ucPtrnSize; j++)
 		WMI_LOGD("%s: Add Ptrn: %02x", __func__, buf_ptr[j] & 0xff);
 
 	WMI_LOGD("%s: Add ptrn id: %d vdev_id: %d",
@@ -1770,14 +1771,15 @@ static QDF_STATUS send_process_add_periodic_tx_ptrn_cmd_tlv(wmi_unified_t wmi_ha
 }
 
 /**
- * send_process_del_periodic_tx_ptrn_cmd_tlv - del periodic tx ptrn
+ * send_process_del_periodic_tx_ptrn_cmd_tlv() - del periodic tx pattern
  * @wmi_handle: wmi handle
  * @vdev_id: vdev id
  * @pattern_id: pattern id
  *
- * Retrun: CDF status
+ * Return: QDF status
  */
-static QDF_STATUS send_process_del_periodic_tx_ptrn_cmd_tlv(wmi_unified_t wmi_handle,
+static QDF_STATUS send_process_del_periodic_tx_ptrn_cmd_tlv(
+						wmi_unified_t wmi_handle,
 						uint8_t vdev_id,
 						uint8_t pattern_id)
 {