qcacmn: Fix umac/mlme documentation

The kernel-doc script identified some documentation errors in the
umac/mlme folder, so fix them.

Change-Id: I84617fe2007e51dcb009801ebc6cdf87c0d0a686
CRs-Fixed: 3381478

umac/mlme/include/wlan_mlme_cmn.h

@@ -28,7 +28,7 @@
 #include "wlan_twt_public_structs.h"
 
 /**
- * mlme_cm_ops: connection manager osif callbacks
+ * struct mlme_cm_ops: connection manager osif callbacks
  * @mlme_cm_connect_complete_cb: Connect done callback
  * @vdev: vdev pointer
  * @rsp: connect response
@@ -59,6 +59,12 @@
  * @index: index
  * @preauth: preauth flag
  *
+ * @mlme_cm_send_keys_cb:
+ * @vdev: vdev pointer
+ * @key_index: key index
+ * @pairwise: true if a pairwise key
+ * @cipher_type: key cipher type
+ *
  * @mlme_cm_roam_start_cb: Roam start callback
  * @vdev: vdev pointer
  *
@@ -185,6 +191,12 @@ struct mlme_vdev_mgr_ops {
  * @mlme_twt_notify_complete_cb: TWT notify complete callback
  * @psoc: psoc pointer
  * @event: response
+ *
+ * @mlme_twt_vdev_create_cb: TWT vdev create callback
+ * @vdev: vdev pointer
+ *
+ * @mlme_twt_vdev_destroy_cb: TWT vdev destroy callback
+ * @vdev: vdev pointer
  */
 struct mlme_twt_ops {
 	QDF_STATUS (*mlme_twt_enable_complete_cb)(
@@ -235,7 +247,7 @@ struct mlme_twt_ops {
 };
 
 /**
- * struct vdev_mlme_ext_ops - VDEV MLME legacy callbacks structure
+ * struct mlme_ext_ops - MLME legacy callbacks structure
  * @mlme_psoc_ext_hdl_create:               callback to invoke creation of
  *                                          legacy psoc object
  * @mlme_psoc_ext_hdl_destroy:              callback to invoke destroy of legacy
@@ -259,6 +271,7 @@ struct mlme_twt_ops {
  * @mlme_vdev_enqueue_exp_cmd:              callback to enqueue exception
  *                                          command
  *                                          required by serialization
+ * @mlme_vdev_ext_delete_rsp:               callback to process vdev ext delete
  * @mlme_multi_vdev_restart_resp:           callback to process multivdev
  *                                          restart response
  * @mlme_cm_ext_hdl_create_cb:              callback to create ext cm context
@@ -285,6 +298,8 @@ struct mlme_twt_ops {
  *                                          VDEV/PEER SM
  * @mlme_vdev_send_set_mac_addr:            callback to send set MAC address
  *                                          request to FW
+ * @mlme_ext_get_acs_inprogress:            callback to determine if ACS is
+ *                                          in progress on a given vdev
  */
 struct mlme_ext_ops {
 	QDF_STATUS (*mlme_psoc_ext_hdl_create)(
@@ -367,6 +382,10 @@ struct mlme_ext_ops {
 						bool *is_acs_inprogress);
 };
 
+enum wlan_mlme_peer_param;
+enum wlan_mlme_vdev_param;
+enum wlan_mlme_pdev_param;
+
 /**
  * struct mlme_external_tx_ops - MLME external callbacks structure
  * @peer_ops:             callback to invoke peer mlme ops from external module
@@ -374,9 +393,6 @@ struct mlme_ext_ops {
  * @pdev_ops:             callback to invoke pdev mlme ops from external module
  * @scan_db_iterate:      callback to invoke scan database iterate
  */
-enum wlan_mlme_peer_param;
-enum wlan_mlme_vdev_param;
-enum wlan_mlme_pdev_param;
 struct mlme_external_tx_ops {
 	QDF_STATUS (*peer_ops)(
 		struct wlan_objmgr_peer *peer,
@@ -419,7 +435,7 @@ QDF_STATUS mlme_psoc_ops_ext_hdl_destroy(struct psoc_mlme_obj *psoc_mlme);
 
 /**
  * mlme_pdev_ops_ext_hdl_create - Alloc PDEV mlme ext handle
- * @pdev_mlme_obj:  PDEV MLME comp object
+ * @pdev_mlme:  PDEV MLME comp object
  *
  * API to allocate PDEV MLME ext handle
  *
@@ -430,7 +446,7 @@ QDF_STATUS mlme_pdev_ops_ext_hdl_create(struct pdev_mlme_obj *pdev_mlme);
 
 /**
  * mlme_pdev_ops_ext_hdl_destroy - Destroy PDEV mlme ext handle
- * @pdev_mlme_obj:  PDEV MLME comp object
+ * @pdev_mlme:  PDEV MLME comp object
  *
  * API to free pdev MLME ext handle
  *
@@ -441,7 +457,7 @@ QDF_STATUS mlme_pdev_ops_ext_hdl_destroy(struct pdev_mlme_obj *pdev_mlme);
 
 /**
  * mlme_vdev_ops_ext_hdl_create - Alloc VDEV mlme ext handle
- * @vdev_mlme_obj:  VDEV MLME comp object
+ * @vdev_mlme:  VDEV MLME comp object
  *
  * API to allocate VDEV MLME ext handle
  *
@@ -453,7 +469,7 @@ QDF_STATUS mlme_vdev_ops_ext_hdl_create(struct vdev_mlme_obj *vdev_mlme);
 /**
  * mlme_vdev_ops_ext_hdl_post_create - Perform post VDEV mlme ext handle alloc
  *                                     operations
- * @vdev_mlme_obj:  VDEV MLME comp object
+ * @vdev_mlme:  VDEV MLME comp object
  *
  * API to perform post vdev MLME ext handle allocation operations
  *
@@ -464,7 +480,7 @@ QDF_STATUS mlme_vdev_ops_ext_hdl_post_create(struct vdev_mlme_obj *vdev_mlme);
 
 /**
  * mlme_vdev_ops_ext_hdl_destroy - Destroy VDEV mlme ext handle
- * @vdev_mlme_obj:  VDEV MLME comp object
+ * @vdev_mlme:  VDEV MLME comp object
  *
  * API to free vdev MLME ext handle
  *
@@ -475,7 +491,7 @@ QDF_STATUS mlme_vdev_ops_ext_hdl_destroy(struct vdev_mlme_obj *vdev_mlme);
 
 /**
  * mlme_vdev_enqueue_exp_ser_cmd - Enqueue exception serialization cmd
- * @vdev_mlme_obj:  VDEV MLME comp object
+ * @vdev_mlme:  VDEV MLME comp object
  * @cmd_type: Serialization command type
  *
  * API to enqueue the exception serialization command, used by
@@ -490,6 +506,7 @@ QDF_STATUS mlme_vdev_enqueue_exp_ser_cmd(struct vdev_mlme_obj *vdev_mlme,
 /**
  * mlme_vdev_ops_start_fw_send - Send WMI START/RESTART command to FW
  * @vdev:  VDEV object
+ * @restart: send start vs restart
  *
  * API to send WMI start/restart command to FW
  *
@@ -534,7 +551,7 @@ QDF_STATUS mlme_vdev_ops_stop_fw_send(struct wlan_objmgr_vdev *vdev);
  */
 QDF_STATUS mlme_vdev_ops_down_fw_send(struct wlan_objmgr_vdev *vdev);
 
-/*
+/**
  * mlme_vdev_ops_ext_hdl_multivdev_restart_resp() - Handler multivdev restart
  * response event
  * @psoc: PSOC object manager handle
@@ -547,6 +564,13 @@ QDF_STATUS mlme_vdev_ops_ext_hdl_multivdev_restart_resp(
 		struct wlan_objmgr_psoc *psoc,
 		struct multi_vdev_restart_resp *resp);
 
+/*
+ * typedef mlme_get_global_ops_cb() - callback to get MLME ext ops
+ *
+ * NB: kernel-doc Cannot parse typedef
+ */
+typedef struct mlme_ext_ops *(*mlme_get_global_ops_cb)(void);
+
 /**
  * mlme_set_ops_register_cb - Sets ops registration callback
  * @ops_cb:  Function pointer
@@ -555,7 +579,6 @@ QDF_STATUS mlme_vdev_ops_ext_hdl_multivdev_restart_resp(
  *
  * Return: void
  */
-typedef struct mlme_ext_ops *(*mlme_get_global_ops_cb)(void);
 void mlme_set_ops_register_cb(mlme_get_global_ops_cb ops_cb);
 
 /**
@@ -749,7 +772,7 @@ QDF_STATUS mlme_cm_disconnect_complete_ind(struct wlan_objmgr_vdev *vdev,
 					   struct wlan_cm_discon_rsp *rsp);
 
 /**
- * mlme_cm_vdev_down() - Connection manager ext req to send vdev down to FW
+ * mlme_cm_vdev_down_req() - Connection manager ext req to send vdev down to FW
  * @vdev: VDEV object
  *
  * Return: QDF_STATUS
@@ -801,7 +824,7 @@ QDF_STATUS mlme_cm_osif_update_id_and_src(struct wlan_objmgr_vdev *vdev,
 /**
  * mlme_cm_osif_disconnect_complete() - Disconnect complete osif response
  * @vdev: vdev pointer
- * @cm_conn_rsp: Connect response
+ * @rsp: Disconnect response
  *
  * Return: QDF_STATUS
  */
@@ -812,7 +835,6 @@ mlme_cm_osif_disconnect_complete(struct wlan_objmgr_vdev *vdev,
 /**
  * mlme_cm_osif_disconnect_start_ind() - osif Disconnect start indication
  * @vdev: vdev pointer
- * @cm_conn_rsp: Connect response
  *
  * Return: QDF_STATUS
  */
@@ -857,7 +879,7 @@ QDF_STATUS mlme_cm_osif_pmksa_candidate_notify(struct wlan_objmgr_vdev *vdev,
  * @vdev: vdev pointer
  * @key_index: key index value
  * @pairwise: pairwise bool value
- * @ciipher_type: cipher enum value
+ * @cipher_type: cipher enum value
  *
  * Return: QDF_STATUS
  */
@@ -953,14 +975,18 @@ mlme_cm_osif_cckm_preauth_complete(struct wlan_objmgr_vdev *vdev,
 #endif /* FEATURE_WLAN_ESE */
 #endif /* WLAN_FEATURE_PREAUTH_ENABLE */
 
-/**
+/*
  * typedef osif_cm_get_global_ops_cb() - Callback to get connection manager
  * global ops
+ *
+ * NB: kernel-doc Cannot parse typedef
  */
 typedef struct mlme_cm_ops *(*osif_cm_get_global_ops_cb)(void);
 
-/**
+/*
  * typedef osif_twt_get_global_ops_cb() - Callback to get twt global ops
+ *
+ * NB: kernel-doc Cannot parse typedef
  */
 typedef struct mlme_twt_ops *(*osif_twt_get_global_ops_cb)(void);
 
@@ -974,9 +1000,11 @@ typedef struct mlme_twt_ops *(*osif_twt_get_global_ops_cb)(void);
  */
 void mlme_set_osif_cm_cb(osif_cm_get_global_ops_cb cm_osif_ops);
 
-/**
+/*
  * typedef osif_vdev_mgr_get_global_ops_cb() - Callback to get vdev manager
  * global ops
+ *
+ * NB: kernel-doc Cannot parse typedef
  */
 typedef struct mlme_vdev_mgr_ops *(*osif_vdev_mgr_get_global_ops_cb)(void);
 
@@ -1003,7 +1031,7 @@ void mlme_set_osif_twt_cb(osif_twt_get_global_ops_cb twt_osif_ops);
 
 /**
  * mlme_max_chan_switch_is_set() - Get if max chan switch IE is enabled
- * @vdev: Object manager vdev pointer
+ * @psoc: Object manager psoc pointer
  *
  * Return: True if max chan switch is enabled else false
  */
@@ -1043,6 +1071,7 @@ void mlme_vdev_mgr_notify_set_mac_addr_response(uint8_t vdev_id,
  * mlme_twt_osif_enable_complete_ind() - enable complete resp to osif
  * @psoc: psoc pointer
  * @event: enable complete response
+ * @context: context registered by OSIF
  *
  * Return: QDF_STATUS
  */
@@ -1055,6 +1084,7 @@ mlme_twt_osif_enable_complete_ind(struct wlan_objmgr_psoc *psoc,
  * mlme_twt_osif_disable_complete_ind() - disable complete resp to osif
  * @psoc: psoc pointer
  * @event: disable complete response
+ * @context: context registered by OSIF
  *
  * Return: QDF_STATUS
  */
@@ -1067,6 +1097,7 @@ mlme_twt_osif_disable_complete_ind(struct wlan_objmgr_psoc *psoc,
  * mlme_twt_osif_ack_complete_ind() - ack complete resp to osif
  * @psoc: psoc pointer
  * @event: ack complete response
+ * @context: context registered by OSIF
  *
  * Return: QDF_STATUS
  */

umac/mlme/include/wlan_pdev_mlme.h

@@ -1,5 +1,6 @@
 /*
  * Copyright (c) 2019-2020 The Linux Foundation. All rights reserved.
+ * Copyright (c) 2023 Qualcomm Innovation Center, Inc. All rights reserved.
  *
  * Permission to use, copy, modify, and/or distribute this software for any
  * purpose with or without fee is hereby granted, provided that the above
@@ -28,13 +29,16 @@
  * struct pdev_restart_attr - Pdev restart attributes
  * @vdev: vdev on which the pdev restart cmd was enqueued
  * @restart_bmap: Bitmap for vdev requesting multivdev restart
+ *
+ * NB: Not using kernel-doc comment since the kernel-doc script
+ *     doesn't handle the qdf_bitmap() macro.
  */
 struct pdev_restart_attr {
 	struct wlan_objmgr_vdev *vdev;
 	qdf_bitmap(restart_bmap, WLAN_UMAC_PSOC_MAX_VDEVS);
 };
 
-/**
+/*
  * struct pdev_mlme_obj -  PDEV MLME component object
  * @pdev:                  PDEV object
  * @ext_pdev_ptr:          PDEV MLME legacy pointer
@@ -44,6 +48,11 @@ struct pdev_restart_attr {
  * @restart_pend_vdev_bmap: Bitmap for VDEV RESTART command pending
  * @restart_send_vdev_bmap: Bitmap for VDEV RESTART command sending
  * @start_send_vdev_arr:   Bitmap for VDEV START command sending
+ * @pdev_restart:
+ * @multivdev_restart_wait_cnt:
+ *
+ * NB: Not using kernel-doc comment since the kernel-doc script
+ *     doesn't handle the qdf_bitmap() macro.
  */
 struct pdev_mlme_obj {
 	struct wlan_objmgr_pdev *pdev;

umac/mlme/include/wlan_psoc_mlme.h

@@ -1,6 +1,6 @@
 /*
  * Copyright (c) 2019-2021 The Linux Foundation. All rights reserved.
- * Copyright (c) 2021-2022 Qualcomm Innovation Center, Inc. All rights reserved.
+ * Copyright (c) 2021-2023 Qualcomm Innovation Center, Inc. All rights reserved.
  *
  * Permission to use, copy, modify, and/or distribute this software for any
  * purpose with or without fee is hereby granted, provided that the above
@@ -35,7 +35,7 @@
 			+ 2   /* RNR header bytes */)
 
 /**
- * struct wlan_rnr_global_cache - RNR cache buffer per soc
+ * struct wlan_6ghz_rnr_global_cache - 6 GHz RNR cache buffer per soc
  * @rnr_buf: RNR cache buffer
  * @rnr_cnt: Count of APs in cache
  * @rnr_size: Size of RNR cache (RNR IE)

umac/mlme/include/wlan_vdev_mlme.h

@@ -223,6 +223,9 @@ struct vdev_mlme_he_ops_info {
  * @eht_phycap_mubfmrlt80mhz         : MU Beamformer (BW <= 80 MHz)
  * @eht_phycap_mubfmr160mhz          : MU Beamformer (BW = 160 MHz)
  * @eht_phycap_mubfmr320mhz          : MU Beamformer (BW = 320 MHz)
+ * @eht_phycap_tb_sounding_feedback_rl:
+ * @eht_phycap_rx1024qamwiderbwdlofdma:
+ * @eht_phycap_rx4096qamwiderbwdlofdma:
  */
 struct vdev_mlme_eht_caps_info {
 	uint32_t eht_maccap_epcspriaccess_support :1,
@@ -291,11 +294,11 @@ struct vdev_mlme_eht_ops_info {
 
 /**
  * enum mlme_vdev_dot11_mode - Dot11 mode of the vdev
- * MLME_VDEV_DOT11_MODE_AUTO: vdev uses mlme_dot11_mode
- * MLME_VDEV_DOT11_MODE_11N: vdev supports 11N mode
- * MLME_VDEV_DOT11_MODE_11AC: vdev supports 11AC mode
- * MLME_VDEV_DOT11_MODE_11AX: vdev supports 11AX mode
- * MLME_VDEV_DOT11_MODE_11BE: vdev supports 11BE mode
+ * @MLME_VDEV_DOT11_MODE_AUTO: vdev uses mlme_dot11_mode
+ * @MLME_VDEV_DOT11_MODE_11N: vdev supports 11N mode
+ * @MLME_VDEV_DOT11_MODE_11AC: vdev supports 11AC mode
+ * @MLME_VDEV_DOT11_MODE_11AX: vdev supports 11AX mode
+ * @MLME_VDEV_DOT11_MODE_11BE: vdev supports 11BE mode
  */
 enum mlme_vdev_dot11_mode {
 	MLME_VDEV_DOT11_MODE_AUTO,
@@ -306,7 +309,7 @@ enum mlme_vdev_dot11_mode {
 };
 
 /**
- * struct vdev_mlme_he_ops_info - vdev protocol structure holding information
+ * struct vdev_mlme_proto - vdev protocol structure holding information
  * that is used in frames
  * @vdev_dot11_mode: supported dot11 mode
  * @generic: generic protocol information
@@ -341,7 +344,7 @@ struct vdev_mlme_proto {
  * @probe_delay: time in msec for delaying to send first probe request
  * @repeat_probe_time: probe request transmission time
  * @drop_unencry: drop unencrypted status
- * @ tx_pwrlimit: Tx power limit
+ * @tx_pwrlimit: Tx power limit
  * @tx_power: Tx power
  * @minpower: Min power
  * @maxpower: Max power
@@ -353,7 +356,7 @@ struct vdev_mlme_proto {
  * @ssid: service set identifier
  * @ssid_len: ssid length
  * @type: vdev type
- * @sub_type: vdev subtype
+ * @subtype: vdev subtype
  * @rx_decap_type: rx decap type
  * @tx_encap_type: tx encap type
  * @disable_hw_ack: disable ha ack flag
@@ -366,6 +369,7 @@ struct vdev_mlme_proto {
  * @he_spr_srg_min_pd_offset: SRG PD min offset
  * @he_spr_enabled:     Spatial reuse enabled or not
  * @he_spr_disabled_due_conc: spr disabled due to concurrency
+ * @sr_prohibit_enabled:
  * @srg_bss_color: srg bss color
  * @srg_partial_bssid: srg partial bssid
  * @he_curr_non_srg_pd_threshold: current configured NON-SRG PD threshold
@@ -414,11 +418,14 @@ struct vdev_mlme_mgmt_generic {
 };
 
 /*
- * struct wlan_vdev_aid_mgr – AID manager
+ * struct wlan_vdev_aid_mgr - AID manager
  * @aid_bitmap: AID bitmap array
  * @start_aid: start of AID index
  * @max_aid: Max allowed AID
  * @ref_cnt:  to share AID across VDEVs for MBSSID
+ *
+ * NB: Not using kernel-doc comment since the kernel-doc script
+ *     doesn't handle the qdf_bitmap() macro.
  */
 struct wlan_vdev_aid_mgr {
 	qdf_bitmap(aid_bitmap, WLAN_UMAC_MAX_AID);
@@ -477,7 +484,8 @@ struct vdev_mlme_inactivity_params {
  * @WLAN_VDEV_RATEMASK_TYPE_CCK: phy type CCK
  * @WLAN_VDEV_RATEMASK_TYPE_HT: phy type ht
  * @WLAN_VDEV_RATEMASK_TYPE_VHT: phy type vht
- * WLAN_VDEV_RATEMASK_TYPE_HE: phy type he
+ * @WLAN_VDEV_RATEMASK_TYPE_HE: phy type he
+ * @WLAN_VDEV_RATEMASK_TYPE_MAX: Maximum enumeration
  */
 enum vdev_ratemask_type {
 	WLAN_VDEV_RATEMASK_TYPE_CCK,
@@ -510,6 +518,7 @@ struct vdev_ratemask_params {
  * @tx_mgmt_rate: Tx Mgmt rate
  * @bcn_tx_rate: beacon Tx rate
  * @bcn_tx_rate_code: beacon Tx rate code
+ * @rtscts_tx_rate: RTS/CTS Tx rate
  * @ratemask_params: vdev ratemask params per phy type
  * @half_rate: Half rate
  * @quarter_rate: quarter rate
@@ -574,10 +583,9 @@ struct vdev_mlme_beacon_info {
  * struct vdev_mlme_mbss_11ax - mbss 11ax fields required for up cmd
  * @profile_idx: profile index of the connected non-trans ap (mbssid case).
  *              0  means invalid.
- * @profile_num: the total profile numbers of non-trans aps (mbssid
- * case).
+ * @profile_num: the total profile numbers of non-trans aps (mbssid case).
  *              0 means non-MBSS AP.
- * @mbssid-flags: MBSS IE flags indicating vdev type
+ * @mbssid_flags: MBSS IE flags indicating vdev type
  * @vdevid_trans: id of transmitting vdev for MBSS IE
  * @vdev_bmap: vdev bitmap of VAPs in MBSS group
  * @is_cmn_param: flag to check mbss common param
@@ -674,6 +682,7 @@ enum vdev_start_resp_type {
  * @mlme_vdev_start_continue:           callback to initiate operations on
  *                                      LMAC/FW start response
  * @mlme_vdev_sta_conn_start:           callback to initiate STA connection
+ * @mlme_vdev_start_req_failed:
  * @mlme_vdev_up_send:                  callback to initiate actions of VDEV
  *                                      MLME up operation
  * @mlme_vdev_notify_up_complete:       callback to notify VDEV MLME on moving
@@ -691,6 +700,9 @@ enum vdev_start_resp_type {
  *                                      peer delete completion
  * @mlme_vdev_down_send:                callback to initiate actions of VDEV
  *                                      MLME down operation
+ * @mlme_vdev_notify_down_complete:
+ * @mlme_vdev_ext_stop_rsp:
+ * @mlme_vdev_ext_start_rsp:
  * @mlme_vdev_notify_start_state_exit:  callback to notify on vdev start
  *                                      start state exit
  * @mlme_vdev_is_newchan_no_cac:        callback to check CAC is required
@@ -701,6 +713,7 @@ enum vdev_start_resp_type {
  * @mlme_vdev_sta_disconn_start:        callback to initiate STA disconnection
  * @mlme_vdev_reconfig_timer_complete:  callback to process ml reconfing
  *                                      operation
+ * @mlme_vdev_notify_mlo_sync_wait_entry:
  */
 struct vdev_mlme_ops {
 	QDF_STATUS (*mlme_vdev_validate_basic_params)(
@@ -829,8 +842,8 @@ struct vdev_mlme_obj {
  *
  * Caller need to acquire lock with wlan_vdev_obj_lock()
  *
- * Return: SUCCESS, if update is done
- *          FAILURE, if ssid length is > max ssid len
+ * Return: QDF_STATUS_SUCCESS, if update is done
+ *         QDF_STATUS error, if ssid length is > max ssid len
  */
 static inline QDF_STATUS wlan_vdev_mlme_set_ssid(
 				struct wlan_objmgr_vdev *vdev,
@@ -916,8 +929,7 @@ static inline void wlan_vdev_mlme_set_nss(
  *
  * API to get the Number of Spatial Streams
  *
- * Return:
- * @nss: nss value
+ * Return: nss value
  */
 static inline uint8_t wlan_vdev_mlme_get_nss(
 				struct wlan_objmgr_vdev *vdev)
@@ -960,8 +972,7 @@ static inline void wlan_vdev_mlme_set_txchainmask(
  *
  * API to get the Tx chainmask
  *
- * Return:
- * @chainmask : Tx chainmask either configured by user or max supported
+ * Return: Tx chainmask either configured by user or max supported
  */
 static inline uint8_t wlan_vdev_mlme_get_txchainmask(
 				struct wlan_objmgr_vdev *vdev)
@@ -1003,8 +1014,7 @@ static inline void wlan_vdev_mlme_set_rxchainmask(
  *
  * API to get the Rx chainmask
  *
- * Return:
- * @chainmask : Rx chainmask either configured by user or max supported
+ * Return: Rx chainmask either configured by user or max supported
  */
 static inline uint8_t wlan_vdev_mlme_get_rxchainmask(
 				struct wlan_objmgr_vdev *vdev)
@@ -1047,8 +1057,7 @@ static inline void wlan_vdev_mlme_set_txpower(
  *
  * API to get the tx power
  *
- * Return:
- * @txpow: tx power either configured by used or max allowed
+ * Return: tx power either configured by used or max allowed
  */
 static inline uint8_t wlan_vdev_mlme_get_txpower(
 				struct wlan_objmgr_vdev *vdev)
@@ -1090,8 +1099,7 @@ static inline void wlan_vdev_mlme_set_maxrate(
  *
  * API to get the max rate the vdev supports
  *
- * Return:
- * @maxrate: configured by used or based on configured mode
+ * Return: configured by used or based on configured mode
  */
 static inline uint32_t wlan_vdev_mlme_get_maxrate(
 				struct wlan_objmgr_vdev *vdev)
@@ -1133,8 +1141,7 @@ static inline void wlan_vdev_mlme_set_txmgmtrate(
  *
  * API to get Mgmt Tx rate
  *
- * Return:
- * @txmgmtrate: Tx Mgmt rate
+ * Return: Tx Mgmt rate
  */
 static inline uint32_t wlan_vdev_mlme_get_txmgmtrate(
 				struct wlan_objmgr_vdev *vdev)
@@ -1200,8 +1207,7 @@ static inline void wlan_vdev_mlme_set_he_mcs_12_13_map(
  *
  * API to get he mcs12/13 support capability
  *
- * Return:
- * @he_mcs_12_13_map: he mcs12/13 map
+ * Return: he mcs12/13 map
  */
 static inline uint16_t wlan_vdev_mlme_get_he_mcs_12_13_map(
 				struct wlan_objmgr_vdev *vdev)
@@ -1224,8 +1230,7 @@ static inline uint16_t wlan_vdev_mlme_get_he_mcs_12_13_map(
  *
  * Caller need to acquire lock with wlan_vdev_obj_lock()
  *
- * Return:
- * @he_spr_sr_ctrl: SR control
+ * Return: SR control
  */
 static inline uint8_t wlan_vdev_mlme_get_sr_ctrl(struct wlan_objmgr_vdev *vdev)
 {
@@ -1244,8 +1249,7 @@ static inline uint8_t wlan_vdev_mlme_get_sr_ctrl(struct wlan_objmgr_vdev *vdev)
  *
  * API to retrieve the spatial reuse pd offset from VDEV
  *
- * Return:
- * @he_spr_non_srg_pd_max_offset: max non srg pd offset
+ * Return: max non srg pd offset
  */
 static inline uint8_t wlan_vdev_mlme_get_non_srg_pd_offset(
 						struct wlan_objmgr_vdev *vdev)
@@ -1265,8 +1269,7 @@ static inline uint8_t wlan_vdev_mlme_get_non_srg_pd_offset(
  *
  * API to check whether the spatial reuse enabled or not
  *
- * Return:
- * @he_spr_enabled: Spatial reuse enabled or not
+ * Return: true if Spatial reuse enabled, false if not
  */
 static inline bool wlan_vdev_mlme_get_he_spr_enabled(
 						struct wlan_objmgr_vdev *vdev)
@@ -1313,8 +1316,7 @@ bool wlan_vdev_mlme_is_sr_disable_due_conc(struct wlan_objmgr_vdev *vdev)
  *
  * Caller need to acquire lock with wlan_vdev_obj_lock()
  *
- * Return:
- * @sr_prohibit_enabled: Spatial reuse PD prohibit enabled / disabled
+ * Return: true/false: Spatial reuse PD prohibit enabled / disabled
  */
 static inline
 bool wlan_vdev_mlme_is_sr_prohibit_en(struct wlan_objmgr_vdev *vdev)
@@ -1331,6 +1333,7 @@ bool wlan_vdev_mlme_is_sr_prohibit_en(struct wlan_objmgr_vdev *vdev)
 /**
  * wlan_vdev_mlme_set_sr_ctrl() - set spatial reuse SR control
  * @vdev: VDEV object
+ * @sr_ctrl: value to set
  *
  * API to set the spatial reuse SR control
  *
@@ -1354,6 +1357,7 @@ static inline void wlan_vdev_mlme_set_sr_ctrl(struct wlan_objmgr_vdev *vdev,
  * wlan_vdev_mlme_set_non_srg_pd_offset() - set spatial reuse non srg
  * pd max offset
  * @vdev: VDEV object
+ * @non_srg_pd_max_offset: value to set
  *
  * API to set the spatial reuse pd max offset
  *
@@ -1376,6 +1380,7 @@ wlan_vdev_mlme_set_non_srg_pd_offset(struct wlan_objmgr_vdev *vdev,
 /**
  * wlan_vdev_mlme_set_he_spr_enabled() - set spatial reuse enabled
  * @vdev: VDEV object
+ * @enable_he_spr: value to set
  *
  * API to set the spatial reuse enabled
  *
@@ -1398,6 +1403,7 @@ static inline void wlan_vdev_mlme_set_he_spr_enabled(
  * wlan_vdev_mlme_set_sr_disable_due_conc() - set spatial reuse disabled due
  *					      to concurrency
  * @vdev: VDEV object
+ * @he_spr_disabled_due_conc: value to set
  *
  * API to set the spatial reuse disabled due to concurrency
  *
@@ -1495,8 +1501,8 @@ void wlan_vdev_mlme_get_srg_pd_offset(struct wlan_objmgr_vdev *vdev,
 }
 
 /**
- * wlan_vdev_mlme_set_srg_bss_color() - set spatial reuse bss
- *					colorbitmap
+ * wlan_vdev_mlme_set_srg_bss_color_bit_map() - set spatial reuse bss
+ *					        color bitmap
  * @vdev: VDEV object
  * @srg_bss_color: SRG BSS color bitmap
  *