qcacmn: Fix umac/mlme documentation

The kernel-doc script identified some documentation errors in the
umac/mlme folder, so fix them.

Change-Id: I84617fe2007e51dcb009801ebc6cdf87c0d0a686
CRs-Fixed: 3381478

umac/mlme/connection_mgr/core/src/wlan_cm_bss_scoring.c

@@ -15,7 +15,7 @@
  * OR IN CONNECTION WITH THE USE OR PERFORMANCE OF THIS SOFTWARE.
  */
 
-/*
+/**
  * DOC: contains bss scoring logic
  */
 
@@ -84,7 +84,7 @@
 #define CM_MAX_INDEX_PER_INI 4
 #define CM_SLO_CONGESTION_MAX_SCORE 80
 
-/**
+/*
  * This macro give percentage value of security_weightage to be used as per
  * security Eg if AP security is WPA 10% will be given for AP.
  *
@@ -250,7 +250,6 @@ static int32_t cm_calculate_rssi_score(struct rssi_config_score *score_param,
 /**
  * cm_rssi_is_same_bucket() - check if both rssi fall in same bucket
  * @rssi_top_thresh: high rssi threshold of the the window
- * @low_rssi_threshold: low rssi of the window
  * @rssi_ref1: rssi ref one
  * @rssi_ref2: rssi ref two
  * @bucket_size: bucket size of the window
@@ -392,6 +391,7 @@ static int32_t cm_get_congestion_pct(struct scan_cache_entry *entry)
  * @entry: bss information
  * @score_params: bss score params
  * @congestion_pct: congestion pct
+ * @rssi_bad_zone:
  *
  * Return: congestion score
  */
@@ -460,6 +460,7 @@ static int32_t cm_calculate_congestion_score(struct scan_cache_entry *entry,
  * @score_config: scoring config
  * @ap_nss: ap nss
  * @prorated_pct: prorated % to return dependent on RSSI
+ * @sta_nss: Sta NSS
  *
  * Return: nss score
  */
@@ -1396,7 +1397,7 @@ cm_calculate_etp_score(struct wlan_objmgr_psoc *psoc,
 
 /**
  * cm_get_band_score() - Get band preference weightage
- * freq: Operating frequency of the AP
+ * @freq: Operating frequency of the AP
  * @score_config: Score configuration
  *
  * Return: Band score for AP.
@@ -1586,6 +1587,7 @@ static struct mlo_rssi_pct mlo_rssi_pcnt[CM_RSSI_BUCKET_NUM] = {
  * @rssi_weightage: rssi weightage
  * @link1_rssi: link1 rssi
  * @link2_rssi: link2 rssi
+ * @prorate_pcnt: pointer to store RSSI prorated percent
  *
  * Return: MLO AP joint rssi score
  */
@@ -1686,6 +1688,7 @@ static inline bool is_freq_dbs_or_sbs(struct wlan_objmgr_psoc *psoc,
  * cm_bss_mlo_type() - Get mlo type of bss scan entry
  * @psoc: Pointer of psoc object
  * @entry: Bss scan entry
+ * @scan_list:
  *
  * Return: MLO AP type: SLO, MLMR or EMLSR.
  */

umac/mlme/connection_mgr/core/src/wlan_cm_main.h

@@ -183,6 +183,7 @@ struct cm_req {
  * @CM_REQ_DEL_ACTIVE: Remove request from active queue
  * @CM_REQ_DEL_PENDING: Remove request from pending queue
  * @CM_REQ_DEL_FLUSH: Request removed due to request list flush
+ * @CM_REQ_DEL_MAX: Maximum enumeration
  */
 enum cm_req_del_type {
 	CM_REQ_DEL_ACTIVE,
@@ -247,7 +248,9 @@ struct cm_req_history {
  * @scan_requester_id: scan requester id.
  * @disconnect_complete: disconnect completion wait event
  * @ext_cm_ptr: connection manager ext pointer
- * @history: Holds the connection manager history
+ * @req_history: Holds the connection manager history
+ * @cm_candidate_advance_filter:
+ * @cm_candidate_list_custom_sort:
  */
 struct cnx_mgr {
 	struct wlan_objmgr_vdev *vdev;
@@ -294,7 +297,7 @@ struct vdev_op_search_arg {
 
 /**
  * wlan_cm_init() - Invoke connection manager init
- * @vdev_mlme_obj:  VDEV MLME comp object
+ * @vdev_mlme:  VDEV MLME comp object
  *
  * API allocates CM and init
  *
@@ -305,7 +308,7 @@ QDF_STATUS wlan_cm_init(struct vdev_mlme_obj *vdev_mlme);
 
 /**
  * wlan_cm_deinit() - Invoke connection manager deinit
- * @vdev_mlme_obj:  VDEV MLME comp object
+ * @vdev_mlme:  VDEV MLME comp object
  *
  * API destroys CM
  *

umac/mlme/connection_mgr/core/src/wlan_cm_main_api.h

@@ -137,6 +137,7 @@ QDF_STATUS cm_connect_scan_start(struct cnx_mgr *cm_ctx,
 /**
  * cm_connect_scan_resp() - Handle the connect scan resp and next action
  * scan if no candidate are found in scan db.
+ * @cm_ctx: connection manager context
  * @scan_id: scan id of the req
  * @status: Connect scan status
  *
@@ -270,7 +271,7 @@ QDF_STATUS cm_connect_complete(struct cnx_mgr *cm_ctx,
 /**
  * cm_add_connect_req_to_list() - add connect req to the connection manager
  * req list
- * @vdev: vdev on which connect is received
+ * @cm_ctx: connection manager context
  * @req: Connection req provided
  *
  * Return: QDF status
@@ -386,7 +387,7 @@ QDF_STATUS cm_disconnect_complete(struct cnx_mgr *cm_ctx,
 /**
  * cm_add_disconnect_req_to_list() - add disconnect req to the connection
  * manager req list
- * @vdev: vdev on which connect is received
+ * @cm_ctx: connection manager context
  * @req: Disconnection req provided
  *
  * Return: QDF status
@@ -451,9 +452,9 @@ QDF_STATUS cm_vdev_down_req(struct wlan_objmgr_vdev *vdev, uint32_t status);
 /**
  * cm_disconnect_rsp() - Connection manager api to post connect event
  * @vdev: VDEV object
- * @cm_discon_rsp: Disconnect response
+ * @resp: Disconnect response
  *
- * This function is called when disconnecte response is received, to deliver
+ * This function is called when disconnect response is received, to deliver
  * disconnect event to SM
  *
  * Context: Any context.
@@ -855,6 +856,7 @@ cm_fill_disconnect_resp_from_cm_id(struct cnx_mgr *cm_ctx, wlan_cm_id cm_id,
  * @cm_ctx: connection manager context
  * @bcn_probe: beacon or probe resp received during connect
  * @len: beacon or probe resp length
+ * @freq: scan frequency in MHz
  * @rssi: rssi of the beacon or probe resp
  * @cm_id: cm id of connect/disconnect req
  *
@@ -1025,7 +1027,7 @@ bool cm_get_active_connect_req(struct wlan_objmgr_vdev *vdev,
 bool cm_get_active_disconnect_req(struct wlan_objmgr_vdev *vdev,
 				  struct wlan_cm_vdev_discon_req *req);
 
-/*
+/**
  * cm_connect_handle_event_post_fail() - initiate connect failure if msg posting
  * to SM fails
  * @cm_ctx: connection manager context
@@ -1132,7 +1134,7 @@ void cm_req_history_del(struct cnx_mgr *cm_ctx,
 			enum cm_req_del_type del_type);
 
 /**
- * cm_history_init() - Initialize the history data struct
+ * cm_req_history_init() - Initialize the history data struct
  * @cm_ctx: Connection manager context
  *
  * Return: void
@@ -1140,7 +1142,7 @@ void cm_req_history_del(struct cnx_mgr *cm_ctx,
 void cm_req_history_init(struct cnx_mgr *cm_ctx);
 
 /**
- * cm_history_deinit() - Deinitialize the history data struct
+ * cm_req_history_deinit() - Deinitialize the history data struct
  * @cm_ctx: Connection manager context
  *
  * Return: void
@@ -1148,7 +1150,7 @@ void cm_req_history_init(struct cnx_mgr *cm_ctx);
 void cm_req_history_deinit(struct cnx_mgr *cm_ctx);
 
 /**
- * cm_history_print() - Print the history data struct
+ * cm_req_history_print() - Print the history data struct
  * @cm_ctx: Connection manager context
  *
  * Return: void

umac/mlme/connection_mgr/core/src/wlan_cm_roam.h

@@ -1,6 +1,6 @@
 /*
  * Copyright (c) 2011-2021 The Linux Foundation. All rights reserved.
- * Copyright (c) 2022 Qualcomm Innovation Center, Inc. All rights reserved.
+ * Copyright (c) 2022-2023 Qualcomm Innovation Center, Inc. All rights reserved.
  *
  * Permission to use, copy, modify, and/or distribute this software for any
  * purpose with or without fee is hereby granted, provided that the above
@@ -63,7 +63,7 @@ QDF_STATUS cm_reassoc_rsp(struct wlan_objmgr_vdev *vdev,
 /**
  * cm_roam_disconnect_rsp() - Connection manager api to post connect event
  * @vdev: VDEV object
- * @cm_discon_rsp: Disconnect response
+ * @resp: Disconnect response
  *
  * Context: Any context.
  *
@@ -89,7 +89,7 @@ QDF_STATUS cm_reassoc_complete(struct cnx_mgr *cm_ctx,
  * cm_get_active_reassoc_req() - Get copy of active reassoc request
  * @vdev: vdev pointer
  * @req: pointer to the copy of the active reassoc request
- * *
+ *
  * Context: Should be called only in the context of the
  * cm request activation
  *
@@ -214,7 +214,7 @@ cm_send_reassoc_start_fail(struct cnx_mgr *cm_ctx,
 			   bool sync);
 
 #ifdef CONN_MGR_ADV_FEATURE
-/*
+/**
  * cm_update_advance_roam_scan_filter() - fill scan filter for roam
  * @vdev: vdev
  * @filter: scan filter
@@ -226,7 +226,7 @@ QDF_STATUS cm_update_advance_roam_scan_filter(
 #endif
 
 #ifdef WLAN_FEATURE_PREAUTH_ENABLE
-/*
+/**
  * cm_host_roam_preauth_start() - start preauth process
  * @cm_ctx: Connection manager context
  * @cm_req: Struct containing the roam request
@@ -250,7 +250,7 @@ QDF_STATUS cm_preauth_active(struct cnx_mgr *cm_ctx, wlan_cm_id *cm_id);
  * cm_preauth_done_resp() - This API would be called when preauth
  * response msg handling
  * @cm_ctx: connection manager context
- * @cm_id: Connection mgr ID assigned to this preauth request.
+ * @rsp: Preauth resp
  *
  * Return: void
  */
@@ -361,7 +361,7 @@ void cm_free_roam_req_mem(struct cm_roam_req *roam_req);
 /**
  * cm_add_roam_req_to_list() - add connect req to the connection manager
  * req list
- * @vdev: vdev on which connect is received
+ * @cm_ctx: connection manager context
  * @cm_req: Roam req provided
  *
  * Return: QDF status
@@ -465,7 +465,7 @@ struct cm_roam_req *cm_get_first_roam_command(struct wlan_objmgr_vdev *vdev);
 /**
  * cm_prepare_roam_cmd() - Prepare roam req
  * @cm_ctx: connection mgr context
- * @cm_req: connection mgr req
+ * @roam_req: connection mgr req
  * @source: connection mgr req source
  *
  * This function prepares roam request when roam start ind is received

umac/mlme/connection_mgr/core/src/wlan_cm_sm.c

@@ -82,6 +82,9 @@ static void cm_state_init_exit(void *ctx)
 /**
  * cm_state_init_event() - Init State event handler for connection mgr
  * @ctx: connection manager ctx
+ * @event: event
+ * @data_len: length of @data
+ * @data: event data
  *
  * API to handle events in INIT state
  *
@@ -176,6 +179,9 @@ static void cm_state_connecting_exit(void *ctx)
  * cm_state_connecting_event() - Connecting State event handler for
  * connection mgr
  * @ctx: connection manager ctx
+ * @event: event
+ * @data_len: length of @data
+ * @data: event data
  *
  * API to handle events in CONNECTING state
  *
@@ -333,6 +339,9 @@ bool cm_handle_roam_connected_event(struct cnx_mgr *cm_ctx, uint16_t event,
  * cm_state_connected_event() - Connected State event handler for
  * connection mgr
  * @ctx: connection manager ctx
+ * @event: event
+ * @data_len: length of @data
+ * @data: event data
  *
  * API to handle events in CONNECTED state
  *
@@ -427,9 +436,12 @@ static void cm_state_disconnecting_exit(void *ctx)
 }
 
 /**
- * cm_state_connected_event() - Disconnecting State event handler for
+ * cm_state_disconnecting_event() - Disconnecting State event handler for
  * connection mgr
  * @ctx: connection manager ctx
+ * @event: event
+ * @data_len: length of @data
+ * @data: event data
  *
  * API to handle events in Disconnecting state
  *
@@ -523,6 +535,9 @@ static void cm_subst_join_pending_exit(void *ctx)
  * cm_subst_join_pending_event() - Join pending sub-state event handler for
  * connection mgr
  * @ctx: connection manager ctx
+ * @event: event
+ * @data_len: length of @data
+ * @data: event data
  *
  * API to handle events in Join pending sub-state
  *
@@ -680,6 +695,9 @@ static void cm_subst_scan_exit(void *ctx)
  * cm_subst_scan_event() - Scan sub-state event handler for
  * connection mgr
  * @ctx: connection manager ctx
+ * @event: event
+ * @data_len: length of @data
+ * @data: event data
  *
  * API to handle events in scan sub-state
  *
@@ -783,6 +801,9 @@ static void cm_subst_join_active_exit(void *ctx)
  * cm_subst_join_active_event() - Join active sub-state event handler for
  * connection mgr
  * @ctx: connection manager ctx
+ * @event: event
+ * @data_len: length of @data
+ * @data: event data
  *
  * API to handle events in join active sub-state
  *

umac/mlme/connection_mgr/core/src/wlan_cm_sm.h

@@ -1,6 +1,6 @@
 /*
  * Copyright (c) 2012-2015,2020-2021 The Linux Foundation. All rights reserved.
- * Copyright (c) 2021-2022 Qualcomm Innovation Center, Inc. All rights reserved.
+ * Copyright (c) 2021-2023 Qualcomm Innovation Center, Inc. All rights reserved.
  *
  * Permission to use, copy, modify, and/or distribute this software for any
  * purpose with or without fee is hereby granted, provided that the above
@@ -66,7 +66,7 @@
  * @WLAN_CM_SM_EV_ROAM_DONE:              Roam done
  * @WLAN_CM_SM_EV_PREAUTH_ACTIVE:         Preauth active
  * @WLAN_CM_SM_EV_PREAUTH_RESP:           Preauth response
- * @WLAN_CM_SM_EV_REASSOC_TIMER：         Reassoc timer expired
+ * @WLAN_CM_SM_EV_REASSOC_TIMER:          Reassoc timer expired
  * @WLAN_CM_SM_EV_HO_ROAM_DISCONNECT_DONE: Disconnect done for hands off/roaming
  * @WLAN_CM_SM_EV_RSO_STOP_RSP:           Event to continue disconnect after
  *                                        RSO stop response is received
@@ -138,7 +138,7 @@ QDF_STATUS cm_sm_destroy(struct cnx_mgr *cm_ctx);
 
 /**
  * cm_sm_history_print() - Prints SM history
- * @cm_ctx:  connection manager ctx
+ * @vdev:  vdev object
  *
  * API to print CM SM history
  *
@@ -154,7 +154,7 @@ void cm_sm_history_print(struct wlan_objmgr_vdev *vdev)
 
 #ifdef WLAN_CM_USE_SPINLOCK
 /**
- * cm_lock_create - Create CM SM mutex/spinlock
+ * cm_lock_create() - Create CM SM mutex/spinlock
  * @cm_ctx:  connection manager ctx
  *
  * Creates CM SM mutex/spinlock
@@ -168,7 +168,7 @@ cm_lock_create(struct cnx_mgr *cm_ctx)
 }
 
 /**
- * cm_lock_destroy - Destroy CM SM mutex/spinlock
+ * cm_lock_destroy() - Destroy CM SM mutex/spinlock
  * @cm_ctx:  connection manager ctx
  *
  * Destroy CM SM mutex/spinlock
@@ -182,7 +182,7 @@ cm_lock_destroy(struct cnx_mgr *cm_ctx)
 }
 
 /**
- * cm_lock_acquire - acquire CM SM mutex/spinlock
+ * cm_lock_acquire() - acquire CM SM mutex/spinlock
  * @cm_ctx:  connection manager ctx
  *
  * acquire CM SM mutex/spinlock
@@ -195,7 +195,7 @@ static inline void cm_lock_acquire(struct cnx_mgr *cm_ctx)
 }
 
 /**
- * cm_lock_release - release CM SM mutex/spinlock
+ * cm_lock_release() - release CM SM mutex/spinlock
  * @cm_ctx:  connection manager ctx
  *
  * release CM SM mutex/spinlock
@@ -275,6 +275,7 @@ enum wlan_cm_sm_state cm_get_sub_state(struct cnx_mgr *cm_ctx);
  * Return: void
  */
 void cm_set_state(struct cnx_mgr *cm_ctx, enum wlan_cm_sm_state state);
+
 /**
  * cm_set_substate() - set cm mlme sub state
  * @cm_ctx: connection manager SM ctx

umac/mlme/connection_mgr/dispatcher/inc/cfg_mlme_score_params.h

@@ -1315,7 +1315,7 @@
 #endif
 
 #ifdef WLAN_FEATURE_11BE_MLO
-/**
+/*
  * <ini>
  * eht_caps_weightage - EHT caps Weightage to calculate best candidate
  * @Min: 0
@@ -1342,7 +1342,7 @@
 	CFG_VALUE_OR_DEFAULT, \
 	"EHT Caps Weightage")
 
-/**
+/*
  * <ini>
  * mlo_weightage - MLO Weightage to calculate best candidate
  * @Min: 0
@@ -1369,7 +1369,7 @@
 	CFG_VALUE_OR_DEFAULT, \
 	"MLO Weightage")
 
-/**
+/*
  * <ini>
  * emlsr_weightage - eMLSR Weightage to calculate best candidate
  * @Min: 0
@@ -1396,7 +1396,7 @@
 	CFG_VALUE_OR_DEFAULT, \
 	"eMLSR Weightage")
 
-/**
+/*
  * <ini>
  * wlm_indication_weightage - WLM indication Weightage to calculate best
  *                            candidate
@@ -1424,7 +1424,7 @@
 	CFG_VALUE_OR_DEFAULT, \
 	"WLM indication Weightage")
 
-/**
+/*
  * <ini>
  * mlsr_link_selection - MLSR link selection criteria
  * @Min: 0
@@ -1453,7 +1453,7 @@
 	CFG_VALUE_OR_DEFAULT, \
 	"MLSR link selection")
 
-/**
+/*
  * <ini>
  * joint_rssi_alpha - Joint RSSI alpha to select best ML candidate
  * @Min: 0
@@ -1482,7 +1482,7 @@
 	CFG_VALUE_OR_DEFAULT, \
 	"Joint RSSI alpha")
 
-/**
+/*
  * <ini>
  * low_band_rssi_boost - Low band RSSI boost in joint RSSI calculation
  * @Min: 0
@@ -1514,7 +1514,7 @@
 				1, \
 				"Low band RSSI boost ")
 
-/**
+/*
  * <ini>
  * joint_esp_alpha - Joint ESP alpha to select best ML candidate
  * @Min: 0
@@ -1543,7 +1543,7 @@
 	CFG_VALUE_OR_DEFAULT, \
 	"Joint ESP alpha")
 
-/**
+/*
  * <ini>
  * low_band_esp_boost - Low band ESP boost in joint ESP calculation
  * @Min: 0
@@ -1575,7 +1575,7 @@
 				1, \
 				"Low band ESP boost ")
 
-/**
+/*
  * <ini>
  * joint_oce_alpha - Joint OCE alpha to select best ML candidate
  * @Min: 0
@@ -1604,7 +1604,7 @@
 	CFG_VALUE_OR_DEFAULT, \
 	"Joint OCE alpha")
 
-/**
+/*
  * <ini>
  * low_band_oce_boost - Low band OCE boost in joint OCE calculation
  * @Min: 0

umac/mlme/connection_mgr/dispatcher/inc/wlan_cm_api.h

@@ -503,7 +503,7 @@ QDF_STATUS wlan_cm_sta_set_chan_param(struct wlan_objmgr_vdev *vdev,
 				      struct ch_params *chan_param);
 
 /**
- * wlan_cm_sta_update_puncture() - update puncture and channel width for sta
+ * wlan_cm_sta_update_bw_puncture() - update puncture and channel width for sta
  * @vdev: vdev
  * @peer_mac: peer mac address
  * @ori_punc: original puncture bitmap from EHT operation IE

umac/mlme/connection_mgr/dispatcher/inc/wlan_cm_bss_score_param.h

@@ -49,6 +49,7 @@
  * @low_band_rssi_boost: Flag to assign higher alpha weightage low band RSSI
  * @low_band_esp_boost: Flag to assign higher alpha weightage low band esp
  * @low_band_oce_boost: Flag to assign higher alpha weightage low band oce
+ * @reserved: reserved/unused bits
  * @wlm_indication_weightage: WLM indication weightage
  * @emlsr_weightage: eMLSR weightage
  * @security_weightage: Security weightage
@@ -111,26 +112,26 @@ struct rssi_config_score  {
 /**
  * struct per_slot_score - define % score for different slots for a
  *                               scoring param.
- * num_slot: number of slots in which the param will be divided.
+ * @num_slot: number of slots in which the param will be divided.
  *           Max 15. index 0 is used for 'not_present. Num_slot will
  *           equally divide 100. e.g, if num_slot = 4 slot 0 = 0-25%, slot
  *           1 = 26-50% slot 2 = 51-75%, slot 3 = 76-100%
- * score_pcnt3_to_0: Contains score percentage for slot 0-3
+ * @score_pcnt3_to_0: Contains score percentage for slot 0-3
  *             BITS 0-7   :- the scoring pcnt when not present
  *             BITS 8-15  :- SLOT_1
  *             BITS 16-23 :- SLOT_2
  *             BITS 24-31 :- SLOT_3
- * score_pcnt7_to_4: Contains score percentage for slot 4-7
+ * @score_pcnt7_to_4: Contains score percentage for slot 4-7
  *             BITS 0-7   :- SLOT_4
  *             BITS 8-15  :- SLOT_5
  *             BITS 16-23 :- SLOT_6
  *             BITS 24-31 :- SLOT_7
- * score_pcnt11_to_8: Contains score percentage for slot 8-11
+ * @score_pcnt11_to_8: Contains score percentage for slot 8-11
  *             BITS 0-7   :- SLOT_8
  *             BITS 8-15  :- SLOT_9
  *             BITS 16-23 :- SLOT_10
  *             BITS 24-31 :- SLOT_11
- * score_pcnt15_to_12: Contains score percentage for slot 12-15
+ * @score_pcnt15_to_12: Contains score percentage for slot 12-15
  *             BITS 0-7   :- SLOT_12
  *             BITS 8-15  :- SLOT_13
  *             BITS 16-23 :- SLOT_14
@@ -222,7 +223,7 @@ enum cm_security_idx {
 
 /**
  * struct scoring_cfg - Scoring related configuration
- * @weight_cfg: weigtage config for config
+ * @weight_config: weightage config for scoring config
  * @rssi_score: Rssi related config for scoring config
  * @esp_qbss_scoring: esp and qbss related scoring config
  * @oce_wan_scoring: oce related scoring config
@@ -232,10 +233,10 @@ enum cm_security_idx {
  * @is_bssid_hint_priority: True if bssid_hint is given priority
  * @check_assoc_disallowed: Should assoc be disallowed if MBO OCE IE indicate so
  * @vendor_roam_score_algorithm: Preferred ETP vendor roam score algorithm
- * @check_6ghz_security: check security for 6Ghz candidate
- * @relaxed_6ghz_conn_policy: check for 6Ghz relaxed connection policy
+ * @check_6ghz_security: check security for 6 GHz candidate
+ * @relaxed_6ghz_conn_policy: check for 6 GHz relaxed connection policy
  * @standard_6ghz_conn_policy: check for 6 GHz standard connection policy
- * @key_mgmt_mask_6ghz: user configurable mask for 6ghz AKM
+ * @key_mgmt_mask_6ghz: user configurable mask for 6 GHz AKM
  * @mlsr_link_selection: MLSR link selection config
  * @roam_tgt_score_cap: Roam score capability
  * @security_weight_per_index: security weight per index
@@ -324,7 +325,7 @@ wlan_denylist_action_on_bssid(struct wlan_objmgr_pdev *pdev,
 /**
  * wlan_cm_calculate_bss_score() - calculate bss score for the scan list
  * @pdev: pointer to pdev object
- * @pcl_list: pcl list for scoring
+ * @pcl_lst: pcl list for scoring
  * @scan_list: scan list, contains the input list and after the
  *             func it will have sorted list
  * @bssid_hint: bssid hint
@@ -347,7 +348,8 @@ void wlan_cm_init_score_config(struct wlan_objmgr_psoc *psoc,
 			       struct scoring_cfg *score_cfg);
 
 /**
- * wlan_cm_6ghz_allowed_for_akm() - check if 6Ghz channel can be allowed for AKM
+ * wlan_cm_6ghz_allowed_for_akm() - check if 6 GHz channel can be allowed
+ *                                  for AKM
  * @psoc: pointer to psoc object
  * @key_mgmt: key mgmt used
  * @rsn_caps: rsn caps
@@ -364,7 +366,7 @@ bool wlan_cm_6ghz_allowed_for_akm(struct wlan_objmgr_psoc *psoc,
 				  bool is_wps);
 
 /**
- * wlan_cm_set_check_6ghz_security() - Set check 6Ghz security
+ * wlan_cm_set_check_6ghz_security() - Set check 6 GHz security
  * @psoc: pointer to psoc object
  * @value: value to be set
  *
@@ -374,8 +376,8 @@ void wlan_cm_set_check_6ghz_security(struct wlan_objmgr_psoc *psoc,
 				     bool value);
 
 /**
- * wlan_cm_reset_check_6ghz_security() - reset check 6Ghz security to original
- * value
+ * wlan_cm_reset_check_6ghz_security() - reset check 6 GHz security to original
+ *                                       value
  * @psoc: pointer to psoc object
  *
  * Return: void
@@ -383,17 +385,17 @@ void wlan_cm_set_check_6ghz_security(struct wlan_objmgr_psoc *psoc,
 void wlan_cm_reset_check_6ghz_security(struct wlan_objmgr_psoc *psoc);
 
 /**
- * wlan_cm_get_check_6ghz_security() - Get 6Ghz allowed AKM mask
+ * wlan_cm_get_check_6ghz_security() - Get 6 GHz allowed AKM mask
  * @psoc: pointer to psoc object
- * @value: value to be set
  *
  * Return: value
  */
 bool wlan_cm_get_check_6ghz_security(struct wlan_objmgr_psoc *psoc);
 
 /**
- * wlan_cm_set_6ghz_key_mgmt_mask() - Set 6Ghz allowed AKM mask
+ * wlan_cm_set_6ghz_key_mgmt_mask() - Set 6 GHz allowed AKM mask
  * @psoc: pointer to psoc object
+ * @value: value to be set
  *
  * Return: void
  */
@@ -401,7 +403,7 @@ void wlan_cm_set_6ghz_key_mgmt_mask(struct wlan_objmgr_psoc *psoc,
 				    uint32_t value);
 
 /**
- * wlan_cm_get_6ghz_key_mgmt_mask() - Get 6Ghz allowed AKM mask
+ * wlan_cm_get_6ghz_key_mgmt_mask() - Get 6 GHz allowed AKM mask
  * @psoc: pointer to psoc object
  *
  * Return: value
@@ -409,7 +411,7 @@ void wlan_cm_set_6ghz_key_mgmt_mask(struct wlan_objmgr_psoc *psoc,
 uint32_t wlan_cm_get_6ghz_key_mgmt_mask(struct wlan_objmgr_psoc *psoc);
 
 /**
- * wlan_cm_set_relaxed_6ghz_conn_policy() - Set 6Ghz relaxed connection policy
+ * wlan_cm_set_relaxed_6ghz_conn_policy() - Set 6 GHz relaxed connection policy
  * @psoc: pointer to psoc object
  * @value: value to be set
  *
@@ -418,7 +420,7 @@ uint32_t wlan_cm_get_6ghz_key_mgmt_mask(struct wlan_objmgr_psoc *psoc);
 void wlan_cm_set_relaxed_6ghz_conn_policy(struct wlan_objmgr_psoc *psoc,
 					  bool value);
 /**
- * wlan_cm_get_relaxed_6ghz_conn_policy() - Get 6Ghz relaxed connection policy
+ * wlan_cm_get_relaxed_6ghz_conn_policy() - Get 6 GHz relaxed connection policy
  *                                          flag
  * @psoc: pointer to psoc object
  *

umac/mlme/connection_mgr/dispatcher/inc/wlan_cm_public_struct.h

@@ -114,6 +114,7 @@ enum wlan_fils_auth_type {
  * @next_seq_num: next seq number
  * @rrk_len: rrk length
  * @rrk: rrk
+ * @auth_type: FILS authentication type
  */
 struct wlan_fils_con_info {
 	bool is_fils_connection;
@@ -310,6 +311,7 @@ struct wlan_cm_roam_req {
  * @vdev_id: vdev id
  * @cm_id: Connect manager id
  * @self_reassoc: if self reassoc
+ * @prev_bssid: previous BSSID
  * @bss: scan entry for the candidate
  */
 struct wlan_cm_vdev_reassoc_req {
@@ -429,12 +431,13 @@ struct fils_connect_rsp_params {
 #endif
 
 /**
- * struct connect_rsp_ies - connect rsp ies stored in vdev filled during connect
+ * struct wlan_connect_rsp_ies - connect rsp ies stored in vdev filled during
+ *                               connect
  * @bcn_probe_rsp: Raw beacon or probe rsp of connected AP
  * @link_bcn_probe_rsp: Raw beacon or probe rsp of connected non-assoc link
  * @assoc_req: assoc req IE pointer send during connect
- * @assoc_rsq: assoc rsp IE received during connection
- * @fills_ie: fills connection ie received during connection
+ * @assoc_rsp: assoc rsp IE received during connection
+ * @fils_ie: fills connection ie received during connection
  */
 struct wlan_connect_rsp_ies {
 	struct element_info bcn_probe_rsp;
@@ -485,7 +488,7 @@ struct wlan_roam_sync_info {
 #endif
 
 /**
- * struct wlan_cm_connect_rsp - connect resp from VDEV mgr and will be sent to
+ * struct wlan_cm_connect_resp - connect resp from VDEV mgr and will be sent to
  * OSIF
  * @vdev_id: vdev id
  * @is_wps_connection: if its wps connection

umac/mlme/connection_mgr/utf/inc/wlan_cm_utf.h

@@ -1,6 +1,6 @@
 /*
  * Copyright (c) 2020, The Linux Foundation. All rights reserved.
- * Copyright (c) 2022 Qualcomm Innovation Center, Inc. All rights reserved.
+ * Copyright (c) 2022-2023 Qualcomm Innovation Center, Inc. All rights reserved.
  *
  * Permission to use, copy, modify, and/or distribute this software for any
  * purpose with or without fee is hereby granted, provided that the above
@@ -76,6 +76,7 @@
  * @CM_UTF_ID_DISCONNECT_SER_TIMEOUT: Ser Active Cmd Timeout for Disconnect
  * @CM_UTF_ID_CONNECT_SER_FAILED: Serialization Cmd Queue Failure for Connect
  * @CM_UTF_ID_DISCONNECT_SER_FAILED: Ser Cmd Queue Failure for Disconnect
+ * @CM_UTF_ID_MAX: Maximum enumeration
  */
 enum wlan_cm_utf_test {
 	CM_UTF_ID_CONNECT_SUCCESS,
@@ -112,8 +113,8 @@ enum wlan_cm_utf_evt {
 };
 
 /**
- * struct wlan_cm_utf_node- CM UTF node to hold CM req info
- * @wlan_cm_utf_evt: CM UTF Resp event
+ * struct wlan_cm_utf_node - CM UTF node to hold CM req info
+ * @evt_id: CM UTF event id
  * @peer_mac: Peer Mac
  * @conn_req: Connect Request
  * @disconn_req: Disconnect Request
@@ -126,7 +127,8 @@ struct wlan_cm_utf_node {
 };
 
 /**
- * struct wlan_cm_utf- CM UTF handle
+ * struct wlan_cm_utf - CM UTF handle
+ * @cm_utf_node: linked list node for linking entries
  * @vdev: Vdev object
  * @debugfs_de: debugfs entry
  * @test_id: Test case Id
@@ -134,6 +136,8 @@ struct wlan_cm_utf_node {
  * @cm_utf_timer: CM UTF timer
  * @cm_utf_test_timer: CM UTF timer for each test
  * @utf_node: CM UTF node to hold CM req info
+ * @last_cmd_id: last command id
+ * @last_cmd_source: last command source
  * @cm_utf_work: CM UTF work queue for processing events
  */
 struct wlan_cm_utf {
@@ -164,7 +168,6 @@ int wlan_cm_utf_scan_db_update_show(qdf_debugfs_file_t m, void *v);
 
 /**
  * wlan_cm_utf_cm_test_id_write() - debugfs write to start CM UTF test
- *
  * @file: file handler to access cm utf handle
  * @buf: received data buffer
  * @count: length of received buffer
@@ -178,7 +181,6 @@ ssize_t wlan_cm_utf_cm_test_id_write(struct file *file,
 
 /**
  * wlan_cm_utf_scan_db_update_write() - debugfs write to add manual scan entry
- *
  * @file: file handler to access cm utf handle
  * @buf: received data buffer
  * @count: length of received buffer
@@ -191,7 +193,7 @@ ssize_t wlan_cm_utf_scan_db_update_write(struct file *file,
 					 size_t count, loff_t *ppos);
 
 /**
- * wlan_cm_utf_attach: Connection manager UTF init API
+ * wlan_cm_utf_attach() - Connection manager UTF init API
  * @vdev: Vdev object
  *
  * Return: QDF_STATUS
@@ -199,7 +201,7 @@ ssize_t wlan_cm_utf_scan_db_update_write(struct file *file,
 QDF_STATUS wlan_cm_utf_attach(struct wlan_objmgr_vdev *vdev);
 
 /**
- * wlan_cm_utf_detach: Connection manager UTF deinit API
+ * wlan_cm_utf_detach() - Connection manager UTF deinit API
  * @vdev: Vdev object
  *
  * Return: QDF_STATUS
@@ -207,7 +209,7 @@ QDF_STATUS wlan_cm_utf_attach(struct wlan_objmgr_vdev *vdev);
 void wlan_cm_utf_detach(struct wlan_objmgr_vdev *vdev);
 
 /**
- * wlan_cm_utf_bss_peer_create_req: Connection manager UTF bss peer
+ * wlan_cm_utf_bss_peer_create_req() - Connection manager UTF bss peer
  * create request handler
  * @vdev: VDEV object
  * @peer_mac: Peer mac address
@@ -218,7 +220,7 @@ QDF_STATUS wlan_cm_utf_bss_peer_create_req(struct wlan_objmgr_vdev *vdev,
 					   struct qdf_mac_addr *peer_mac);
 
 /**
- * wlan_cm_utf_connect_req_active: Connection manager UTF handler when connect
+ * wlan_cm_utf_connect_req_active() - Connection manager UTF handler when connect
  * request is activated
  * @vdev: VDEV object
  * @vdev_connect_req: Vdev connect request
@@ -230,7 +232,7 @@ QDF_STATUS wlan_cm_utf_connect_req_active(
 			struct wlan_cm_vdev_connect_req *vdev_connect_req);
 
 /**
- * wlan_cm_utf_connect_req: Connection manager UTF connect request handler
+ * wlan_cm_utf_connect_req() - Connection manager UTF connect request handler
  * @vdev: VDEV object
  * @vdev_connect_req: Vdev connect request
  *
@@ -241,10 +243,10 @@ QDF_STATUS wlan_cm_utf_connect_req(
 			struct wlan_cm_vdev_connect_req *vdev_connect_req);
 
 /**
- * wlan_cm_utf_disconnect_req: Connection manager UTF disconnect
+ * wlan_cm_utf_disconnect_req() - Connection manager UTF disconnect
  * request handler
  * @vdev: VDEV object
- * @vdev_connect_req: Vdev connect request
+ * @vdev_disconnect_req: Vdev disconnect request
  *
  * Return: QDF_STATUS
  */
@@ -253,7 +255,7 @@ QDF_STATUS wlan_cm_utf_disconnect_req(
 		struct wlan_cm_vdev_discon_req *vdev_disconnect_req);
 
 /**
- * wlan_cm_utf_bss_peer_delete_req: Connection manager UTF bss peer
+ * wlan_cm_utf_bss_peer_delete_req() - Connection manager UTF bss peer
  * delete request handler
  * @vdev: VDEV object
  *
@@ -262,7 +264,7 @@ QDF_STATUS wlan_cm_utf_disconnect_req(
 QDF_STATUS wlan_cm_utf_bss_peer_delete_req(struct wlan_objmgr_vdev *vdev);
 
 /**
- * wlan_cm_utf_vdev_down: Connection manager UTF vdev down request handler
+ * wlan_cm_utf_vdev_down() - Connection manager UTF vdev down request handler
  * @vdev: VDEV object
  *
  * Return: QDF_STATUS

umac/mlme/connection_mgr/utf/src/wlan_cm_utf_main.c

@@ -1,5 +1,6 @@
 /*
  * Copyright (c) 2020-2021, The Linux Foundation. All rights reserved.
+ * Copyright (c) 2023 Qualcomm Innovation Center, Inc. All rights reserved.
  *
  * Permission to use, copy, modify, and/or distribute this software for any
  * purpose with or without fee is hereby granted, provided that the above
@@ -14,7 +15,7 @@
  * OR IN CONNECTION WITH THE USE OR PERFORMANCE OF THIS SOFTWARE.
  */
 
-/*
+/**
  * DOC: Implements CM UTF
  */
 
@@ -88,7 +89,7 @@ struct cm_utf_debugfs_info cm_utf_debugfs_infos[NUM_UTF_DEBUGFS_INFOS] = {
 };
 
 /**
- * wlan_cm_debugfs_create() - Create debugfs entry for cm db
+ * wlan_cm_utf_debugfs_create() - Create debugfs entry for cm db
  * @cm_utf: CM UTF object
  *
  * Return: QDF_STATUS
@@ -724,7 +725,8 @@ static QDF_STATUS wlan_cm_utf_osif_disconnect_cb(
  * wlan_cm_utf_update_conn_id_and_src_cb: Connection manager UTF
  * callback to update connect id and source of the connect request
  * @vdev: VDEV object
- * @cm_disconn_rsp: Disconnect Response
+ * @source: connect source
+ * @cm_id: connect id
  *
  * Return: None
  */
@@ -887,7 +889,7 @@ wlan_cm_utf_update_connect_param(struct wlan_cm_utf *cm_utf, char *buffer)
 /**
  * wlan_cm_utf_start_test: Connection manager UTF entry function
  * @cm_utf: Connection Manager UTF object
- * *test_id: Test ID requested by user
+ * @buffer: test command buffer
  *
  */
 static void wlan_cm_utf_start_test(struct wlan_cm_utf *cm_utf, void *buffer)

umac/mlme/include/wlan_mlme_cmn.h

@@ -28,7 +28,7 @@
 #include "wlan_twt_public_structs.h"
 
 /**
- * mlme_cm_ops: connection manager osif callbacks
+ * struct mlme_cm_ops: connection manager osif callbacks
  * @mlme_cm_connect_complete_cb: Connect done callback
  * @vdev: vdev pointer
  * @rsp: connect response
@@ -59,6 +59,12 @@
  * @index: index
  * @preauth: preauth flag
  *
+ * @mlme_cm_send_keys_cb:
+ * @vdev: vdev pointer
+ * @key_index: key index
+ * @pairwise: true if a pairwise key
+ * @cipher_type: key cipher type
+ *
  * @mlme_cm_roam_start_cb: Roam start callback
  * @vdev: vdev pointer
  *
@@ -185,6 +191,12 @@ struct mlme_vdev_mgr_ops {
  * @mlme_twt_notify_complete_cb: TWT notify complete callback
  * @psoc: psoc pointer
  * @event: response
+ *
+ * @mlme_twt_vdev_create_cb: TWT vdev create callback
+ * @vdev: vdev pointer
+ *
+ * @mlme_twt_vdev_destroy_cb: TWT vdev destroy callback
+ * @vdev: vdev pointer
  */
 struct mlme_twt_ops {
 	QDF_STATUS (*mlme_twt_enable_complete_cb)(
@@ -235,7 +247,7 @@ struct mlme_twt_ops {
 };
 
 /**
- * struct vdev_mlme_ext_ops - VDEV MLME legacy callbacks structure
+ * struct mlme_ext_ops - MLME legacy callbacks structure
  * @mlme_psoc_ext_hdl_create:               callback to invoke creation of
  *                                          legacy psoc object
  * @mlme_psoc_ext_hdl_destroy:              callback to invoke destroy of legacy
@@ -259,6 +271,7 @@ struct mlme_twt_ops {
  * @mlme_vdev_enqueue_exp_cmd:              callback to enqueue exception
  *                                          command
  *                                          required by serialization
+ * @mlme_vdev_ext_delete_rsp:               callback to process vdev ext delete
  * @mlme_multi_vdev_restart_resp:           callback to process multivdev
  *                                          restart response
  * @mlme_cm_ext_hdl_create_cb:              callback to create ext cm context
@@ -285,6 +298,8 @@ struct mlme_twt_ops {
  *                                          VDEV/PEER SM
  * @mlme_vdev_send_set_mac_addr:            callback to send set MAC address
  *                                          request to FW
+ * @mlme_ext_get_acs_inprogress:            callback to determine if ACS is
+ *                                          in progress on a given vdev
  */
 struct mlme_ext_ops {
 	QDF_STATUS (*mlme_psoc_ext_hdl_create)(
@@ -367,6 +382,10 @@ struct mlme_ext_ops {
 						bool *is_acs_inprogress);
 };
 
+enum wlan_mlme_peer_param;
+enum wlan_mlme_vdev_param;
+enum wlan_mlme_pdev_param;
+
 /**
  * struct mlme_external_tx_ops - MLME external callbacks structure
  * @peer_ops:             callback to invoke peer mlme ops from external module
@@ -374,9 +393,6 @@ struct mlme_ext_ops {
  * @pdev_ops:             callback to invoke pdev mlme ops from external module
  * @scan_db_iterate:      callback to invoke scan database iterate
  */
-enum wlan_mlme_peer_param;
-enum wlan_mlme_vdev_param;
-enum wlan_mlme_pdev_param;
 struct mlme_external_tx_ops {
 	QDF_STATUS (*peer_ops)(
 		struct wlan_objmgr_peer *peer,
@@ -419,7 +435,7 @@ QDF_STATUS mlme_psoc_ops_ext_hdl_destroy(struct psoc_mlme_obj *psoc_mlme);
 
 /**
  * mlme_pdev_ops_ext_hdl_create - Alloc PDEV mlme ext handle
- * @pdev_mlme_obj:  PDEV MLME comp object
+ * @pdev_mlme:  PDEV MLME comp object
  *
  * API to allocate PDEV MLME ext handle
  *
@@ -430,7 +446,7 @@ QDF_STATUS mlme_pdev_ops_ext_hdl_create(struct pdev_mlme_obj *pdev_mlme);
 
 /**
  * mlme_pdev_ops_ext_hdl_destroy - Destroy PDEV mlme ext handle
- * @pdev_mlme_obj:  PDEV MLME comp object
+ * @pdev_mlme:  PDEV MLME comp object
  *
  * API to free pdev MLME ext handle
  *
@@ -441,7 +457,7 @@ QDF_STATUS mlme_pdev_ops_ext_hdl_destroy(struct pdev_mlme_obj *pdev_mlme);
 
 /**
  * mlme_vdev_ops_ext_hdl_create - Alloc VDEV mlme ext handle
- * @vdev_mlme_obj:  VDEV MLME comp object
+ * @vdev_mlme:  VDEV MLME comp object
  *
  * API to allocate VDEV MLME ext handle
  *
@@ -453,7 +469,7 @@ QDF_STATUS mlme_vdev_ops_ext_hdl_create(struct vdev_mlme_obj *vdev_mlme);
 /**
  * mlme_vdev_ops_ext_hdl_post_create - Perform post VDEV mlme ext handle alloc
  *                                     operations
- * @vdev_mlme_obj:  VDEV MLME comp object
+ * @vdev_mlme:  VDEV MLME comp object
  *
  * API to perform post vdev MLME ext handle allocation operations
  *
@@ -464,7 +480,7 @@ QDF_STATUS mlme_vdev_ops_ext_hdl_post_create(struct vdev_mlme_obj *vdev_mlme);
 
 /**
  * mlme_vdev_ops_ext_hdl_destroy - Destroy VDEV mlme ext handle
- * @vdev_mlme_obj:  VDEV MLME comp object
+ * @vdev_mlme:  VDEV MLME comp object
  *
  * API to free vdev MLME ext handle
  *
@@ -475,7 +491,7 @@ QDF_STATUS mlme_vdev_ops_ext_hdl_destroy(struct vdev_mlme_obj *vdev_mlme);
 
 /**
  * mlme_vdev_enqueue_exp_ser_cmd - Enqueue exception serialization cmd
- * @vdev_mlme_obj:  VDEV MLME comp object
+ * @vdev_mlme:  VDEV MLME comp object
  * @cmd_type: Serialization command type
  *
  * API to enqueue the exception serialization command, used by
@@ -490,6 +506,7 @@ QDF_STATUS mlme_vdev_enqueue_exp_ser_cmd(struct vdev_mlme_obj *vdev_mlme,
 /**
  * mlme_vdev_ops_start_fw_send - Send WMI START/RESTART command to FW
  * @vdev:  VDEV object
+ * @restart: send start vs restart
  *
  * API to send WMI start/restart command to FW
  *
@@ -534,7 +551,7 @@ QDF_STATUS mlme_vdev_ops_stop_fw_send(struct wlan_objmgr_vdev *vdev);
  */
 QDF_STATUS mlme_vdev_ops_down_fw_send(struct wlan_objmgr_vdev *vdev);
 
-/*
+/**
  * mlme_vdev_ops_ext_hdl_multivdev_restart_resp() - Handler multivdev restart
  * response event
  * @psoc: PSOC object manager handle
@@ -547,6 +564,13 @@ QDF_STATUS mlme_vdev_ops_ext_hdl_multivdev_restart_resp(
 		struct wlan_objmgr_psoc *psoc,
 		struct multi_vdev_restart_resp *resp);
 
+/*
+ * typedef mlme_get_global_ops_cb() - callback to get MLME ext ops
+ *
+ * NB: kernel-doc Cannot parse typedef
+ */
+typedef struct mlme_ext_ops *(*mlme_get_global_ops_cb)(void);
+
 /**
  * mlme_set_ops_register_cb - Sets ops registration callback
  * @ops_cb:  Function pointer
@@ -555,7 +579,6 @@ QDF_STATUS mlme_vdev_ops_ext_hdl_multivdev_restart_resp(
  *
  * Return: void
  */
-typedef struct mlme_ext_ops *(*mlme_get_global_ops_cb)(void);
 void mlme_set_ops_register_cb(mlme_get_global_ops_cb ops_cb);
 
 /**
@@ -749,7 +772,7 @@ QDF_STATUS mlme_cm_disconnect_complete_ind(struct wlan_objmgr_vdev *vdev,
 					   struct wlan_cm_discon_rsp *rsp);
 
 /**
- * mlme_cm_vdev_down() - Connection manager ext req to send vdev down to FW
+ * mlme_cm_vdev_down_req() - Connection manager ext req to send vdev down to FW
  * @vdev: VDEV object
  *
  * Return: QDF_STATUS
@@ -801,7 +824,7 @@ QDF_STATUS mlme_cm_osif_update_id_and_src(struct wlan_objmgr_vdev *vdev,
 /**
  * mlme_cm_osif_disconnect_complete() - Disconnect complete osif response
  * @vdev: vdev pointer
- * @cm_conn_rsp: Connect response
+ * @rsp: Disconnect response
  *
  * Return: QDF_STATUS
  */
@@ -812,7 +835,6 @@ mlme_cm_osif_disconnect_complete(struct wlan_objmgr_vdev *vdev,
 /**
  * mlme_cm_osif_disconnect_start_ind() - osif Disconnect start indication
  * @vdev: vdev pointer
- * @cm_conn_rsp: Connect response
  *
  * Return: QDF_STATUS
  */
@@ -857,7 +879,7 @@ QDF_STATUS mlme_cm_osif_pmksa_candidate_notify(struct wlan_objmgr_vdev *vdev,
  * @vdev: vdev pointer
  * @key_index: key index value
  * @pairwise: pairwise bool value
- * @ciipher_type: cipher enum value
+ * @cipher_type: cipher enum value
  *
  * Return: QDF_STATUS
  */
@@ -953,14 +975,18 @@ mlme_cm_osif_cckm_preauth_complete(struct wlan_objmgr_vdev *vdev,
 #endif /* FEATURE_WLAN_ESE */
 #endif /* WLAN_FEATURE_PREAUTH_ENABLE */
 
-/**
+/*
  * typedef osif_cm_get_global_ops_cb() - Callback to get connection manager
  * global ops
+ *
+ * NB: kernel-doc Cannot parse typedef
  */
 typedef struct mlme_cm_ops *(*osif_cm_get_global_ops_cb)(void);
 
-/**
+/*
  * typedef osif_twt_get_global_ops_cb() - Callback to get twt global ops
+ *
+ * NB: kernel-doc Cannot parse typedef
  */
 typedef struct mlme_twt_ops *(*osif_twt_get_global_ops_cb)(void);
 
@@ -974,9 +1000,11 @@ typedef struct mlme_twt_ops *(*osif_twt_get_global_ops_cb)(void);
  */
 void mlme_set_osif_cm_cb(osif_cm_get_global_ops_cb cm_osif_ops);
 
-/**
+/*
  * typedef osif_vdev_mgr_get_global_ops_cb() - Callback to get vdev manager
  * global ops
+ *
+ * NB: kernel-doc Cannot parse typedef
  */
 typedef struct mlme_vdev_mgr_ops *(*osif_vdev_mgr_get_global_ops_cb)(void);
 
@@ -1003,7 +1031,7 @@ void mlme_set_osif_twt_cb(osif_twt_get_global_ops_cb twt_osif_ops);
 
 /**
  * mlme_max_chan_switch_is_set() - Get if max chan switch IE is enabled
- * @vdev: Object manager vdev pointer
+ * @psoc: Object manager psoc pointer
  *
  * Return: True if max chan switch is enabled else false
  */
@@ -1043,6 +1071,7 @@ void mlme_vdev_mgr_notify_set_mac_addr_response(uint8_t vdev_id,
  * mlme_twt_osif_enable_complete_ind() - enable complete resp to osif
  * @psoc: psoc pointer
  * @event: enable complete response
+ * @context: context registered by OSIF
  *
  * Return: QDF_STATUS
  */
@@ -1055,6 +1084,7 @@ mlme_twt_osif_enable_complete_ind(struct wlan_objmgr_psoc *psoc,
  * mlme_twt_osif_disable_complete_ind() - disable complete resp to osif
  * @psoc: psoc pointer
  * @event: disable complete response
+ * @context: context registered by OSIF
  *
  * Return: QDF_STATUS
  */
@@ -1067,6 +1097,7 @@ mlme_twt_osif_disable_complete_ind(struct wlan_objmgr_psoc *psoc,
  * mlme_twt_osif_ack_complete_ind() - ack complete resp to osif
  * @psoc: psoc pointer
  * @event: ack complete response
+ * @context: context registered by OSIF
  *
  * Return: QDF_STATUS
  */

umac/mlme/include/wlan_pdev_mlme.h

@@ -1,5 +1,6 @@
 /*
  * Copyright (c) 2019-2020 The Linux Foundation. All rights reserved.
+ * Copyright (c) 2023 Qualcomm Innovation Center, Inc. All rights reserved.
  *
  * Permission to use, copy, modify, and/or distribute this software for any
  * purpose with or without fee is hereby granted, provided that the above
@@ -28,13 +29,16 @@
  * struct pdev_restart_attr - Pdev restart attributes
  * @vdev: vdev on which the pdev restart cmd was enqueued
  * @restart_bmap: Bitmap for vdev requesting multivdev restart
+ *
+ * NB: Not using kernel-doc comment since the kernel-doc script
+ *     doesn't handle the qdf_bitmap() macro.
  */
 struct pdev_restart_attr {
 	struct wlan_objmgr_vdev *vdev;
 	qdf_bitmap(restart_bmap, WLAN_UMAC_PSOC_MAX_VDEVS);
 };
 
-/**
+/*
  * struct pdev_mlme_obj -  PDEV MLME component object
  * @pdev:                  PDEV object
  * @ext_pdev_ptr:          PDEV MLME legacy pointer
@@ -44,6 +48,11 @@ struct pdev_restart_attr {
  * @restart_pend_vdev_bmap: Bitmap for VDEV RESTART command pending
  * @restart_send_vdev_bmap: Bitmap for VDEV RESTART command sending
  * @start_send_vdev_arr:   Bitmap for VDEV START command sending
+ * @pdev_restart:
+ * @multivdev_restart_wait_cnt:
+ *
+ * NB: Not using kernel-doc comment since the kernel-doc script
+ *     doesn't handle the qdf_bitmap() macro.
  */
 struct pdev_mlme_obj {
 	struct wlan_objmgr_pdev *pdev;

umac/mlme/include/wlan_psoc_mlme.h

@@ -1,6 +1,6 @@
 /*
  * Copyright (c) 2019-2021 The Linux Foundation. All rights reserved.
- * Copyright (c) 2021-2022 Qualcomm Innovation Center, Inc. All rights reserved.
+ * Copyright (c) 2021-2023 Qualcomm Innovation Center, Inc. All rights reserved.
  *
  * Permission to use, copy, modify, and/or distribute this software for any
  * purpose with or without fee is hereby granted, provided that the above
@@ -35,7 +35,7 @@
 			+ 2   /* RNR header bytes */)
 
 /**
- * struct wlan_rnr_global_cache - RNR cache buffer per soc
+ * struct wlan_6ghz_rnr_global_cache - 6 GHz RNR cache buffer per soc
  * @rnr_buf: RNR cache buffer
  * @rnr_cnt: Count of APs in cache
  * @rnr_size: Size of RNR cache (RNR IE)

umac/mlme/include/wlan_vdev_mlme.h

@@ -223,6 +223,9 @@ struct vdev_mlme_he_ops_info {
  * @eht_phycap_mubfmrlt80mhz         : MU Beamformer (BW <= 80 MHz)
  * @eht_phycap_mubfmr160mhz          : MU Beamformer (BW = 160 MHz)
  * @eht_phycap_mubfmr320mhz          : MU Beamformer (BW = 320 MHz)
+ * @eht_phycap_tb_sounding_feedback_rl:
+ * @eht_phycap_rx1024qamwiderbwdlofdma:
+ * @eht_phycap_rx4096qamwiderbwdlofdma:
  */
 struct vdev_mlme_eht_caps_info {
 	uint32_t eht_maccap_epcspriaccess_support :1,
@@ -291,11 +294,11 @@ struct vdev_mlme_eht_ops_info {
 
 /**
  * enum mlme_vdev_dot11_mode - Dot11 mode of the vdev
- * MLME_VDEV_DOT11_MODE_AUTO: vdev uses mlme_dot11_mode
- * MLME_VDEV_DOT11_MODE_11N: vdev supports 11N mode
- * MLME_VDEV_DOT11_MODE_11AC: vdev supports 11AC mode
- * MLME_VDEV_DOT11_MODE_11AX: vdev supports 11AX mode
- * MLME_VDEV_DOT11_MODE_11BE: vdev supports 11BE mode
+ * @MLME_VDEV_DOT11_MODE_AUTO: vdev uses mlme_dot11_mode
+ * @MLME_VDEV_DOT11_MODE_11N: vdev supports 11N mode
+ * @MLME_VDEV_DOT11_MODE_11AC: vdev supports 11AC mode
+ * @MLME_VDEV_DOT11_MODE_11AX: vdev supports 11AX mode
+ * @MLME_VDEV_DOT11_MODE_11BE: vdev supports 11BE mode
  */
 enum mlme_vdev_dot11_mode {
 	MLME_VDEV_DOT11_MODE_AUTO,
@@ -306,7 +309,7 @@ enum mlme_vdev_dot11_mode {
 };
 
 /**
- * struct vdev_mlme_he_ops_info - vdev protocol structure holding information
+ * struct vdev_mlme_proto - vdev protocol structure holding information
  * that is used in frames
  * @vdev_dot11_mode: supported dot11 mode
  * @generic: generic protocol information
@@ -341,7 +344,7 @@ struct vdev_mlme_proto {
  * @probe_delay: time in msec for delaying to send first probe request
  * @repeat_probe_time: probe request transmission time
  * @drop_unencry: drop unencrypted status
- * @ tx_pwrlimit: Tx power limit
+ * @tx_pwrlimit: Tx power limit
  * @tx_power: Tx power
  * @minpower: Min power
  * @maxpower: Max power
@@ -353,7 +356,7 @@ struct vdev_mlme_proto {
  * @ssid: service set identifier
  * @ssid_len: ssid length
  * @type: vdev type
- * @sub_type: vdev subtype
+ * @subtype: vdev subtype
  * @rx_decap_type: rx decap type
  * @tx_encap_type: tx encap type
  * @disable_hw_ack: disable ha ack flag
@@ -366,6 +369,7 @@ struct vdev_mlme_proto {
  * @he_spr_srg_min_pd_offset: SRG PD min offset
  * @he_spr_enabled:     Spatial reuse enabled or not
  * @he_spr_disabled_due_conc: spr disabled due to concurrency
+ * @sr_prohibit_enabled:
  * @srg_bss_color: srg bss color
  * @srg_partial_bssid: srg partial bssid
  * @he_curr_non_srg_pd_threshold: current configured NON-SRG PD threshold
@@ -414,11 +418,14 @@ struct vdev_mlme_mgmt_generic {
 };
 
 /*
- * struct wlan_vdev_aid_mgr – AID manager
+ * struct wlan_vdev_aid_mgr - AID manager
  * @aid_bitmap: AID bitmap array
  * @start_aid: start of AID index
  * @max_aid: Max allowed AID
  * @ref_cnt:  to share AID across VDEVs for MBSSID
+ *
+ * NB: Not using kernel-doc comment since the kernel-doc script
+ *     doesn't handle the qdf_bitmap() macro.
  */
 struct wlan_vdev_aid_mgr {
 	qdf_bitmap(aid_bitmap, WLAN_UMAC_MAX_AID);
@@ -477,7 +484,8 @@ struct vdev_mlme_inactivity_params {
  * @WLAN_VDEV_RATEMASK_TYPE_CCK: phy type CCK
  * @WLAN_VDEV_RATEMASK_TYPE_HT: phy type ht
  * @WLAN_VDEV_RATEMASK_TYPE_VHT: phy type vht
- * WLAN_VDEV_RATEMASK_TYPE_HE: phy type he
+ * @WLAN_VDEV_RATEMASK_TYPE_HE: phy type he
+ * @WLAN_VDEV_RATEMASK_TYPE_MAX: Maximum enumeration
  */
 enum vdev_ratemask_type {
 	WLAN_VDEV_RATEMASK_TYPE_CCK,
@@ -510,6 +518,7 @@ struct vdev_ratemask_params {
  * @tx_mgmt_rate: Tx Mgmt rate
  * @bcn_tx_rate: beacon Tx rate
  * @bcn_tx_rate_code: beacon Tx rate code
+ * @rtscts_tx_rate: RTS/CTS Tx rate
  * @ratemask_params: vdev ratemask params per phy type
  * @half_rate: Half rate
  * @quarter_rate: quarter rate
@@ -574,10 +583,9 @@ struct vdev_mlme_beacon_info {
  * struct vdev_mlme_mbss_11ax - mbss 11ax fields required for up cmd
  * @profile_idx: profile index of the connected non-trans ap (mbssid case).
  *              0  means invalid.
- * @profile_num: the total profile numbers of non-trans aps (mbssid
- * case).
+ * @profile_num: the total profile numbers of non-trans aps (mbssid case).
  *              0 means non-MBSS AP.
- * @mbssid-flags: MBSS IE flags indicating vdev type
+ * @mbssid_flags: MBSS IE flags indicating vdev type
  * @vdevid_trans: id of transmitting vdev for MBSS IE
  * @vdev_bmap: vdev bitmap of VAPs in MBSS group
  * @is_cmn_param: flag to check mbss common param
@@ -674,6 +682,7 @@ enum vdev_start_resp_type {
  * @mlme_vdev_start_continue:           callback to initiate operations on
  *                                      LMAC/FW start response
  * @mlme_vdev_sta_conn_start:           callback to initiate STA connection
+ * @mlme_vdev_start_req_failed:
  * @mlme_vdev_up_send:                  callback to initiate actions of VDEV
  *                                      MLME up operation
  * @mlme_vdev_notify_up_complete:       callback to notify VDEV MLME on moving
@@ -691,6 +700,9 @@ enum vdev_start_resp_type {
  *                                      peer delete completion
  * @mlme_vdev_down_send:                callback to initiate actions of VDEV
  *                                      MLME down operation
+ * @mlme_vdev_notify_down_complete:
+ * @mlme_vdev_ext_stop_rsp:
+ * @mlme_vdev_ext_start_rsp:
  * @mlme_vdev_notify_start_state_exit:  callback to notify on vdev start
  *                                      start state exit
  * @mlme_vdev_is_newchan_no_cac:        callback to check CAC is required
@@ -701,6 +713,7 @@ enum vdev_start_resp_type {
  * @mlme_vdev_sta_disconn_start:        callback to initiate STA disconnection
  * @mlme_vdev_reconfig_timer_complete:  callback to process ml reconfing
  *                                      operation
+ * @mlme_vdev_notify_mlo_sync_wait_entry:
  */
 struct vdev_mlme_ops {
 	QDF_STATUS (*mlme_vdev_validate_basic_params)(
@@ -829,8 +842,8 @@ struct vdev_mlme_obj {
  *
  * Caller need to acquire lock with wlan_vdev_obj_lock()
  *
- * Return: SUCCESS, if update is done
- *          FAILURE, if ssid length is > max ssid len
+ * Return: QDF_STATUS_SUCCESS, if update is done
+ *         QDF_STATUS error, if ssid length is > max ssid len
  */
 static inline QDF_STATUS wlan_vdev_mlme_set_ssid(
 				struct wlan_objmgr_vdev *vdev,
@@ -916,8 +929,7 @@ static inline void wlan_vdev_mlme_set_nss(
  *
  * API to get the Number of Spatial Streams
  *
- * Return:
- * @nss: nss value
+ * Return: nss value
  */
 static inline uint8_t wlan_vdev_mlme_get_nss(
 				struct wlan_objmgr_vdev *vdev)
@@ -960,8 +972,7 @@ static inline void wlan_vdev_mlme_set_txchainmask(
  *
  * API to get the Tx chainmask
  *
- * Return:
- * @chainmask : Tx chainmask either configured by user or max supported
+ * Return: Tx chainmask either configured by user or max supported
  */
 static inline uint8_t wlan_vdev_mlme_get_txchainmask(
 				struct wlan_objmgr_vdev *vdev)
@@ -1003,8 +1014,7 @@ static inline void wlan_vdev_mlme_set_rxchainmask(
  *
  * API to get the Rx chainmask
  *
- * Return:
- * @chainmask : Rx chainmask either configured by user or max supported
+ * Return: Rx chainmask either configured by user or max supported
  */
 static inline uint8_t wlan_vdev_mlme_get_rxchainmask(
 				struct wlan_objmgr_vdev *vdev)
@@ -1047,8 +1057,7 @@ static inline void wlan_vdev_mlme_set_txpower(
  *
  * API to get the tx power
  *
- * Return:
- * @txpow: tx power either configured by used or max allowed
+ * Return: tx power either configured by used or max allowed
  */
 static inline uint8_t wlan_vdev_mlme_get_txpower(
 				struct wlan_objmgr_vdev *vdev)
@@ -1090,8 +1099,7 @@ static inline void wlan_vdev_mlme_set_maxrate(
  *
  * API to get the max rate the vdev supports
  *
- * Return:
- * @maxrate: configured by used or based on configured mode
+ * Return: configured by used or based on configured mode
  */
 static inline uint32_t wlan_vdev_mlme_get_maxrate(
 				struct wlan_objmgr_vdev *vdev)
@@ -1133,8 +1141,7 @@ static inline void wlan_vdev_mlme_set_txmgmtrate(
  *
  * API to get Mgmt Tx rate
  *
- * Return:
- * @txmgmtrate: Tx Mgmt rate
+ * Return: Tx Mgmt rate
  */
 static inline uint32_t wlan_vdev_mlme_get_txmgmtrate(
 				struct wlan_objmgr_vdev *vdev)
@@ -1200,8 +1207,7 @@ static inline void wlan_vdev_mlme_set_he_mcs_12_13_map(
  *
  * API to get he mcs12/13 support capability
  *
- * Return:
- * @he_mcs_12_13_map: he mcs12/13 map
+ * Return: he mcs12/13 map
  */
 static inline uint16_t wlan_vdev_mlme_get_he_mcs_12_13_map(
 				struct wlan_objmgr_vdev *vdev)
@@ -1224,8 +1230,7 @@ static inline uint16_t wlan_vdev_mlme_get_he_mcs_12_13_map(
  *
  * Caller need to acquire lock with wlan_vdev_obj_lock()
  *
- * Return:
- * @he_spr_sr_ctrl: SR control
+ * Return: SR control
  */
 static inline uint8_t wlan_vdev_mlme_get_sr_ctrl(struct wlan_objmgr_vdev *vdev)
 {
@@ -1244,8 +1249,7 @@ static inline uint8_t wlan_vdev_mlme_get_sr_ctrl(struct wlan_objmgr_vdev *vdev)
  *
  * API to retrieve the spatial reuse pd offset from VDEV
  *
- * Return:
- * @he_spr_non_srg_pd_max_offset: max non srg pd offset
+ * Return: max non srg pd offset
  */
 static inline uint8_t wlan_vdev_mlme_get_non_srg_pd_offset(
 						struct wlan_objmgr_vdev *vdev)
@@ -1265,8 +1269,7 @@ static inline uint8_t wlan_vdev_mlme_get_non_srg_pd_offset(
  *
  * API to check whether the spatial reuse enabled or not
  *
- * Return:
- * @he_spr_enabled: Spatial reuse enabled or not
+ * Return: true if Spatial reuse enabled, false if not
  */
 static inline bool wlan_vdev_mlme_get_he_spr_enabled(
 						struct wlan_objmgr_vdev *vdev)
@@ -1313,8 +1316,7 @@ bool wlan_vdev_mlme_is_sr_disable_due_conc(struct wlan_objmgr_vdev *vdev)
  *
  * Caller need to acquire lock with wlan_vdev_obj_lock()
  *
- * Return:
- * @sr_prohibit_enabled: Spatial reuse PD prohibit enabled / disabled
+ * Return: true/false: Spatial reuse PD prohibit enabled / disabled
  */
 static inline
 bool wlan_vdev_mlme_is_sr_prohibit_en(struct wlan_objmgr_vdev *vdev)
@@ -1331,6 +1333,7 @@ bool wlan_vdev_mlme_is_sr_prohibit_en(struct wlan_objmgr_vdev *vdev)
 /**
  * wlan_vdev_mlme_set_sr_ctrl() - set spatial reuse SR control
  * @vdev: VDEV object
+ * @sr_ctrl: value to set
  *
  * API to set the spatial reuse SR control
  *
@@ -1354,6 +1357,7 @@ static inline void wlan_vdev_mlme_set_sr_ctrl(struct wlan_objmgr_vdev *vdev,
  * wlan_vdev_mlme_set_non_srg_pd_offset() - set spatial reuse non srg
  * pd max offset
  * @vdev: VDEV object
+ * @non_srg_pd_max_offset: value to set
  *
  * API to set the spatial reuse pd max offset
  *
@@ -1376,6 +1380,7 @@ wlan_vdev_mlme_set_non_srg_pd_offset(struct wlan_objmgr_vdev *vdev,
 /**
  * wlan_vdev_mlme_set_he_spr_enabled() - set spatial reuse enabled
  * @vdev: VDEV object
+ * @enable_he_spr: value to set
  *
  * API to set the spatial reuse enabled
  *
@@ -1398,6 +1403,7 @@ static inline void wlan_vdev_mlme_set_he_spr_enabled(
  * wlan_vdev_mlme_set_sr_disable_due_conc() - set spatial reuse disabled due
  *					      to concurrency
  * @vdev: VDEV object
+ * @he_spr_disabled_due_conc: value to set
  *
  * API to set the spatial reuse disabled due to concurrency
  *
@@ -1495,8 +1501,8 @@ void wlan_vdev_mlme_get_srg_pd_offset(struct wlan_objmgr_vdev *vdev,
 }
 
 /**
- * wlan_vdev_mlme_set_srg_bss_color() - set spatial reuse bss
- *					colorbitmap
+ * wlan_vdev_mlme_set_srg_bss_color_bit_map() - set spatial reuse bss
+ *					        color bitmap
  * @vdev: VDEV object
  * @srg_bss_color: SRG BSS color bitmap
  *

umac/mlme/mlme_objmgr/dispatcher/inc/wlan_vdev_mlme_main.h

@@ -1,6 +1,6 @@
 /*
  * Copyright (c) 2018-2021 The Linux Foundation. All rights reserved.
- * Copyright (c) 2021-2022 Qualcomm Innovation Center, Inc. All rights reserved.
+ * Copyright (c) 2021-2023 Qualcomm Innovation Center, Inc. All rights reserved.
  *
  * Permission to use, copy, modify, and/or distribute this software for any
  * purpose with or without fee is hereby granted, provided that the above
@@ -171,7 +171,7 @@ enum wlan_vdev_sm_evt {
 };
 
 /**
- * wlan_vdev_mlme_init - Initializes VDEV MLME component
+ * wlan_vdev_mlme_init() - Initializes VDEV MLME component
  *
  * Registers callbacks with object manager for create/destroy
  *
@@ -181,7 +181,7 @@ enum wlan_vdev_sm_evt {
 QDF_STATUS wlan_vdev_mlme_init(void);
 
 /**
- * wlan_vdev_mlme_deinit - Uninitializes VDEV MLME component
+ * wlan_vdev_mlme_deinit() - Uninitializes VDEV MLME component
  *
  * Unregisters callbacks with object manager for create/destroy
  *
@@ -191,9 +191,10 @@ QDF_STATUS wlan_vdev_mlme_init(void);
 QDF_STATUS wlan_vdev_mlme_deinit(void);
 
 /**
- * wlan_mlme_psoc_enable - MLME initializations on PSOC enable
+ * wlan_mlme_psoc_enable() - MLME initializations on PSOC enable
+ * @psoc: pointer to psoc object
  *
- * Initializes MLME params on PSOC eable
+ * Initializes MLME params on PSOC enable
  *
  * Return: SUCCESS on successful initialization
  *         FAILURE, if initialization fails
@@ -201,9 +202,10 @@ QDF_STATUS wlan_vdev_mlme_deinit(void);
 QDF_STATUS wlan_mlme_psoc_enable(struct wlan_objmgr_psoc *psoc);
 
 /**
- * wlan_mlme_psoc_disable - MLME clean up on PSOC disable
+ * wlan_mlme_psoc_disable() - MLME clean up on PSOC disable
+ * @psoc: pointer to psoc object
  *
- * cleanup MLME params on PSOC eable
+ * cleanup MLME params on PSOC disable
  *
  * Return: SUCCESS on successful cleanup
  *         FAILURE, if cleanup fails

umac/mlme/mlme_utils/wlan_vdev_mlme_ser_if.c

@@ -1,6 +1,6 @@
 /*
  * Copyright (c) 2018-2020 The Linux Foundation. All rights reserved.
- * Copyright (c) 2022 Qualcomm Innovation Center, Inc. All rights reserved.
+ * Copyright (c) 2022-2023 Qualcomm Innovation Center, Inc. All rights reserved.
  *
  * Permission to use, copy, modify, and/or distribute this software for any
  * purpose with or without fee is hereby granted, provided that the above
@@ -16,7 +16,7 @@
  */
 
 /**
- * @file wlan_vdev_mlme_ser.c
+ * DOC: wlan_vdev_mlme_ser.c
  * This file contains the APIs to support interface between vdev_mlme and
  * serialization module
  */

umac/mlme/mlme_utils/wlan_vdev_mlme_ser_if.h

@@ -1,5 +1,6 @@
 /*
  * Copyright (c) 2018-2020 The Linux Foundation. All rights reserved.
+ * Copyright (c) 2023 Qualcomm Innovation Center, Inc. All rights reserved.
  *
  * Permission to use, copy, modify, and/or distribute this software for
  * any purpose with or without fee is hereby granted, provided that the
@@ -17,7 +18,7 @@
  */
 
 /**
- * @file wlan_vdev_mlme_ser.h
+ * DOC: wlan_vdev_mlme_ser.h
  * This file implements the APIs to support interface between vdev_mlme and
  * serialization module
  */

umac/mlme/psoc_mgr/dispatcher/inc/wlan_psoc_mlme_api.h

@@ -1,6 +1,6 @@
 /*
  * Copyright (c) 2019-2020 The Linux Foundation. All rights reserved.
- * Copyright (c) 2022 Qualcomm Innovation Center, Inc. All rights reserved.
+ * Copyright (c) 2022-2023 Qualcomm Innovation Center, Inc. All rights reserved.
  *
  * Permission to use, copy, modify, and/or distribute this software for any
  * purpose with or without fee is hereby granted, provided that the above
@@ -50,7 +50,7 @@ mlme_psoc_ext_t *wlan_psoc_mlme_get_ext_hdl(struct wlan_objmgr_psoc *psoc);
 /**
  * wlan_psoc_mlme_set_ext_hdl() - Set legacy handle
  * @psoc_mlme: psoc_mlme object
- * psoc_ext_hdl: PSOC level legacy handle
+ * @psoc_ext_hdl: PSOC level legacy handle
  *
  * Sets legacy handle in psoc mlme component object
  *

umac/mlme/vdev_mgr/core/src/vdev_mgr_ops.c

@@ -1,6 +1,6 @@
 /*
  * Copyright (c) 2019-2021 The Linux Foundation. All rights reserved.
- * Copyright (c) 2021-2022 Qualcomm Innovation Center, Inc. All rights reserved.
+ * Copyright (c) 2021-2023 Qualcomm Innovation Center, Inc. All rights reserved.
  *
  * Permission to use, copy, modify, and/or distribute this software for
  * any purpose with or without fee is hereby granted, provided that the
@@ -45,8 +45,8 @@
 #ifdef QCA_VDEV_STATS_HW_OFFLOAD_SUPPORT
 /**
  * vdev_mgr_alloc_vdev_stats_id() - Allocate vdev stats id for vdev
- * @vdev - pointer to vdev
- * @param - pointer to vdev create params
+ * @vdev: pointer to vdev
+ * @param: pointer to vdev create params
  *
  * Return: none
  */
@@ -78,8 +78,8 @@ static void vdev_mgr_alloc_vdev_stats_id(struct wlan_objmgr_vdev *vdev,
 
 /**
  * vdev_mgr_reset_vdev_stats_id() -Reset vdev stats id
- * @vdev - pointer to vdev
- * @vdev_stats_id - Value of vdev_stats_id
+ * @vdev: pointer to vdev
+ * @vdev_stats_id: Value of vdev_stats_id
  *
  * Return: none
  */

umac/mlme/vdev_mgr/core/src/vdev_mgr_ops.h

@@ -1,6 +1,6 @@
 /*
  * Copyright (c) 2019-2020 The Linux Foundation. All rights reserved.
- * Copyright (c) 2021 Qualcomm Innovation Center, Inc. All rights reserved.
+ * Copyright (c) 2021, 2023 Qualcomm Innovation Center, Inc. All rights reserved.
  *
  * Permission to use, copy, modify, and/or distribute this software for
  * any purpose with or without fee is hereby granted, provided that the
@@ -33,7 +33,7 @@
 #include "include/wlan_vdev_mlme.h"
 
 /**
- * vdev_mgr_create_send() – MLME API to create command to
+ * vdev_mgr_create_send() - MLME API to create command to
  * target_if
  * @mlme_obj: pointer to vdev_mlme_obj
  *
@@ -42,7 +42,7 @@
 QDF_STATUS vdev_mgr_create_send(struct vdev_mlme_obj *mlme_obj);
 
 /**
- * vdev_mgr_start_send() – MLME API to send start request to
+ * vdev_mgr_start_send() - MLME API to send start request to
  * target_if
  * @mlme_obj: pointer to vdev_mlme_obj
  * @restart: flag to indicate type of request START/RESTART
@@ -52,7 +52,7 @@ QDF_STATUS vdev_mgr_create_send(struct vdev_mlme_obj *mlme_obj);
 QDF_STATUS vdev_mgr_start_send(struct vdev_mlme_obj *mlme_obj, bool restart);
 
 /**
- * vdev_mgr_delete_send() – MLME API to send delete request to
+ * vdev_mgr_delete_send() - MLME API to send delete request to
  * target_if
  * @mlme_obj: pointer to vdev_mlme_obj
  *
@@ -61,7 +61,7 @@ QDF_STATUS vdev_mgr_start_send(struct vdev_mlme_obj *mlme_obj, bool restart);
 QDF_STATUS vdev_mgr_delete_send(struct vdev_mlme_obj *mlme_obj);
 
 /**
- * vdev_mgr_peer_flush_tids_send () – MLME API to setup peer flush tids
+ * vdev_mgr_peer_flush_tids_send () - MLME API to setup peer flush tids
  * @mlme_obj: pointer to vdev_mlme_obj
  * @mac: pointer to peer mac address
  * @peer_tid_bitmap: peer tid bitmap
@@ -72,7 +72,7 @@ QDF_STATUS vdev_mgr_peer_flush_tids_send(struct vdev_mlme_obj *mlme_obj,
 					 uint8_t *mac,
 					 uint32_t peer_tid_bitmap);
 /**
- * vdev_mgr_stop_send () – MLME API to send STOP request
+ * vdev_mgr_stop_send () - MLME API to send STOP request
  * @mlme_obj: pointer to vdev_mlme_obj
  *
  * Return: QDF_STATUS - Success or Failure
@@ -80,7 +80,7 @@ QDF_STATUS vdev_mgr_peer_flush_tids_send(struct vdev_mlme_obj *mlme_obj,
 QDF_STATUS vdev_mgr_stop_send(struct vdev_mlme_obj *mlme_obj);
 
 /**
- * vdev_mgr_up_send () – MLME API to send UP command
+ * vdev_mgr_up_send () - MLME API to send UP command
  * @mlme_obj: pointer to vdev_mlme_obj
  *
  * Return: QDF_STATUS - Success or Failure
@@ -88,7 +88,7 @@ QDF_STATUS vdev_mgr_stop_send(struct vdev_mlme_obj *mlme_obj);
 QDF_STATUS vdev_mgr_up_send(struct vdev_mlme_obj *mlme_obj);
 
 /**
- * vdev_mgr_down_send () – MLME API to send down command
+ * vdev_mgr_down_send () - MLME API to send down command
  * @mlme_obj: pointer to vdev_mlme_obj
  *
  * Return: QDF_STATUS - Success or Failure
@@ -96,7 +96,7 @@ QDF_STATUS vdev_mgr_up_send(struct vdev_mlme_obj *mlme_obj);
 QDF_STATUS vdev_mgr_down_send(struct vdev_mlme_obj *mlme_obj);
 
 /**
- * vdev_mgr_set_param_send() – MLME API to send vdev param
+ * vdev_mgr_set_param_send() - MLME API to send vdev param
  * @mlme_obj: pointer to vdev_mlme_obj
  * @param_id: parameter id
  * @param_value: value corresponding to parameter id
@@ -108,7 +108,7 @@ QDF_STATUS vdev_mgr_set_param_send(struct vdev_mlme_obj *mlme_obj,
 				   uint32_t param_value);
 
 /**
- * vdev_mgr_set_neighbour_rx_cmd_send() – MLME API to send neighbour Rx
+ * vdev_mgr_set_neighbour_rx_cmd_send() - MLME API to send neighbour Rx
  * cmd
  * @mlme_obj: pointer to vdev_mlme_obj
  * @param: pointer to set neighbour rx params
@@ -120,7 +120,7 @@ QDF_STATUS vdev_mgr_set_neighbour_rx_cmd_send(
 				struct set_neighbour_rx_params *param);
 
 /**
- * vdev_mgr_set_nac_rssi_send() – MLME API to send nac rssi
+ * vdev_mgr_nac_rssi_send() - MLME API to send nac rssi
  * @mlme_obj: pointer to vdev_mlme_obj
  * @param: pointer to vdev_scan_nac_rssi_params
  *
@@ -131,7 +131,7 @@ QDF_STATUS vdev_mgr_nac_rssi_send(
 			struct vdev_scan_nac_rssi_params *param);
 
 /**
- * vdev_mgr_sifs_trigger_send() – MLME API to send SIFS trigger
+ * vdev_mgr_sifs_trigger_send() - MLME API to send SIFS trigger
  * @mlme_obj: pointer to vdev_mlme_obj
  * @param_value: parameter value
  *
@@ -142,8 +142,7 @@ QDF_STATUS vdev_mgr_sifs_trigger_send(
 			uint32_t param_value);
 
 /**
- * vdev_mgr_set_custom_aggr_size_cmd_send() – MLME API to send custom aggr
- * size
+ * vdev_mgr_set_custom_aggr_size_send() - MLME API to send custom aggr size
  * @mlme_obj: pointer to vdev_mlme_obj
  * @is_amsdu: boolean to indicate value corresponds to amsdu/ampdu
  *
@@ -153,7 +152,7 @@ QDF_STATUS vdev_mgr_set_custom_aggr_size_send(
 			struct vdev_mlme_obj *mlme_obj, bool is_amsdu);
 
 /**
- * vdev_mgr_onfig_ratemask_cmd_send() – MLME API to send ratemask
+ * vdev_mgr_config_ratemask_cmd_send() - MLME API to send ratemask
  * @mlme_obj: pointer to vdev_mlme_obj
  * @type: type of ratemask configuration
  * @lower32: Lower 32 bits in the 1st 64-bit value
@@ -170,7 +169,7 @@ QDF_STATUS vdev_mgr_config_ratemask_cmd_send(
 				uint32_t lower32_2);
 
 /**
- * vdev_mgr_beacon_stop() – MLME API to stop beacon
+ * vdev_mgr_beacon_stop() - MLME API to stop beacon
  * @mlme_obj: pointer to vdev_mlme_obj
  *
  * Return: QDF_STATUS - Success or Failure
@@ -178,7 +177,7 @@ QDF_STATUS vdev_mgr_config_ratemask_cmd_send(
 QDF_STATUS vdev_mgr_beacon_stop(struct vdev_mlme_obj *mlme_obj);
 
 /**
- * vdev_mgr_beacon_free() – MLME API to free beacon
+ * vdev_mgr_beacon_free() - MLME API to free beacon
  * @mlme_obj: pointer to vdev_mlme_obj
  *
  * Return: QDF_STATUS - Success or Failure
@@ -186,7 +185,7 @@ QDF_STATUS vdev_mgr_beacon_stop(struct vdev_mlme_obj *mlme_obj);
 QDF_STATUS vdev_mgr_beacon_free(struct vdev_mlme_obj *mlme_obj);
 
 /**
- * vdev_mgr_beacon_send() – MLME API to send beacon
+ * vdev_mgr_beacon_send() - MLME API to send beacon
  * @mlme_obj: pointer to vdev_mlme_obj
  * @param: pointer to beacon_params
  *
@@ -196,7 +195,7 @@ QDF_STATUS vdev_mgr_beacon_send(struct vdev_mlme_obj *mlme_obj,
 				struct beacon_params *param);
 
 /**
- * vdev_mgr_beacon_tmpl_send() – MLME API to send beacon template
+ * vdev_mgr_beacon_tmpl_send() - MLME API to send beacon template
  * @mlme_obj: pointer to vdev_mlme_obj
  * @param: pointer to beacon_tmpl_params
  *
@@ -206,7 +205,7 @@ QDF_STATUS vdev_mgr_beacon_tmpl_send(struct vdev_mlme_obj *mlme_obj,
 				     struct beacon_tmpl_params *param);
 
 /**
- * vdev_mgr_bcn_miss_offload_send() – MLME API to send bcn miss offload
+ * vdev_mgr_bcn_miss_offload_send() - MLME API to send bcn miss offload
  * @mlme_obj: pointer to vdev_mlme_obj
  *
  * Return: QDF_STATUS - Success or Failure
@@ -214,7 +213,7 @@ QDF_STATUS vdev_mgr_beacon_tmpl_send(struct vdev_mlme_obj *mlme_obj,
 QDF_STATUS vdev_mgr_bcn_miss_offload_send(struct vdev_mlme_obj *mlme_obj);
 
 /**
- * vdev_mgr_multiple_restart_send() – MLME API to send multiple vdev restart
+ * vdev_mgr_multiple_restart_send() - MLME API to send multiple vdev restart
  * @pdev: pointer to pdev object
  * @chan: pointer to channel param structure
  * @disable_hw_ack: ddisable hw ack value
@@ -233,7 +232,7 @@ QDF_STATUS vdev_mgr_multiple_restart_send(
 					struct vdev_mlme_mvr_param *mvr_param);
 
 /**
- * vdev_mgr_peer_delete_all_send() – MLME API to send peer delete all request
+ * vdev_mgr_peer_delete_all_send() - MLME API to send peer delete all request
  * @mlme_obj: pointer to vdev_mlme_obj
  *
  * Return: QDF_STATUS - Success or Failure

umac/mlme/vdev_mgr/core/src/vdev_mlme_sm.c

@@ -140,6 +140,9 @@ static void mlme_vdev_state_init_exit(void *ctx)
 /**
  * mlme_vdev_state_init_event() - Init State event handler
  * @ctx: VDEV MLME object
+ * @event: MLME event
+ * @event_data_len: data size
+ * @event_data: event data
  *
  * API to handle events in INIT state
  *
@@ -256,6 +259,9 @@ static void mlme_vdev_state_start_exit(void *ctx)
 /**
  * mlme_vdev_state_start_event() - Start State event handler
  * @ctx: VDEV MLME object
+ * @event: MLME event
+ * @event_data_len: data size
+ * @event_data: event data
  *
  * API to handle events in START state
  *
@@ -335,6 +341,9 @@ static void mlme_vdev_state_dfs_cac_wait_exit(void *ctx)
 /**
  * mlme_vdev_state_dfs_cac_wait_event() - DFS CAC WAIT State event handler
  * @ctx: VDEV MLME object
+ * @event: MLME event
+ * @event_data_len: data size
+ * @event_data: event data
  *
  * API to handle events in DFS CAC WAIT state
  *
@@ -443,6 +452,9 @@ static void mlme_vdev_state_up_exit(void *ctx)
 /**
  * mlme_vdev_state_up_event() - UP State event handler
  * @ctx: VDEV MLME object
+ * @event: MLME event
+ * @event_data_len: data size
+ * @event_data: event data
  *
  * API to handle events in UP state
  *
@@ -545,6 +557,9 @@ static void mlme_vdev_state_suspend_exit(void *ctx)
 /**
  * mlme_vdev_state_suspend_event() - Suspend State event handler
  * @ctx: VDEV MLME object
+ * @event: MLME event
+ * @event_data_len: data size
+ * @event_data: event data
  *
  * API to handle events in SUSPEND state
  *
@@ -640,6 +655,9 @@ static void mlme_vdev_state_stop_exit(void *ctx)
 /**
  * mlme_vdev_state_stop_event() - Stop State event handler
  * @ctx: VDEV MLME object
+ * @event: MLME event
+ * @event_data_len: data size
+ * @event_data: event data
  *
  * API to handle events in STOP state
  *
@@ -694,6 +712,9 @@ static void mlme_vdev_subst_start_start_progress_exit(void *ctx)
  * mlme_vdev_subst_start_start_progress_event() - Event handler API for Start
  *                                                Progress substate
  * @ctx: VDEV MLME object
+ * @event: MLME event
+ * @event_data_len: data size
+ * @event_data: event data
  *
  * API to handle events in START-PROGRESS substate
  *
@@ -798,6 +819,9 @@ static void mlme_vdev_subst_start_restart_progress_exit(void *ctx)
  * mlme_vdev_subst_start_restart_progress_event() - Event handler API for
  *                                                  Restart Progress substate
  * @ctx: VDEV MLME object
+ * @event: MLME event
+ * @event_data_len: data size
+ * @event_data: event data
  *
  * API to handle events in RESTART-PROGRESS substate
  *
@@ -905,6 +929,9 @@ static void mlme_vdev_subst_start_conn_progress_exit(void *ctx)
  * mlme_vdev_subst_start_conn_progress_event() - Event handler API for Conn.
  *                                                Progress substate
  * @ctx: VDEV MLME object
+ * @event: MLME event
+ * @event_data_len: data size
+ * @event_data: event data
  *
  * API to handle events in CONN-PROGRESS substate
  *
@@ -1030,6 +1057,9 @@ static void mlme_vdev_subst_start_disconn_progress_exit(void *ctx)
  * mlme_vdev_subst_start_disconn_progress_event() - Event handler API for Discon
  *                                                Progress substate
  * @ctx: VDEV MLME object
+ * @event: MLME event
+ * @event_data_len: data size
+ * @event_data: event data
  *
  * API to handle events in DISCONN-PROGRESS substate
  *
@@ -1120,6 +1150,9 @@ static void mlme_vdev_subst_suspend_suspend_down_exit(void *ctx)
  * mlme_vdev_subst_suspend_suspend_down_event() - Event handler API for Suspend
  *                                                down substate
  * @ctx: VDEV MLME object
+ * @event: MLME event
+ * @event_data_len: data size
+ * @event_data: event data
  *
  * API to handle events in SUSPEND-DOWN substate
  *
@@ -1196,6 +1229,9 @@ static void mlme_vdev_subst_suspend_suspend_restart_exit(void *ctx)
  * mlme_vdev_subst_suspend_suspend_restart_event() - Event handler API for
  *                                                   Suspend restart substate
  * @ctx: VDEV MLME object
+ * @event: MLME event
+ * @event_data_len: data size
+ * @event_data: event data
  *
  * API to handle events in SUSPEND-RESTART substate
  *
@@ -1284,9 +1320,12 @@ static void mlme_vdev_subst_suspend_host_restart_exit(void *ctx)
 }
 
 /**
- * mlme_vdev_subst_suspend_host_restart_entry() - Event handler API for Host
+ * mlme_vdev_subst_suspend_host_restart_event() - Event handler API for Host
  *                                                restart substate
  * @ctx: VDEV MLME object
+ * @event: MLME event
+ * @event_data_len: data size
+ * @event_data: event data
  *
  * API to handle events in HOST-RESTART substate
  *
@@ -1377,6 +1416,9 @@ static void mlme_vdev_subst_suspend_csa_restart_exit(void *ctx)
  * mlme_vdev_subst_suspend_csa_restart_event() - Event handler API for CSA
  *                                               restart substate
  * @ctx: VDEV MLME object
+ * @event: MLME event
+ * @event_data_len: data size
+ * @event_data: event data
  *
  * API to handle events in CSA-RESTART substate
  *
@@ -1492,6 +1534,9 @@ static void mlme_vdev_subst_stop_stop_progress_exit(void *ctx)
  * mlme_vdev_subst_stop_stop_progress_event() - Event handler API for Stop
  *                                                Progress substate
  * @ctx: VDEV MLME object
+ * @event: MLME event
+ * @event_data_len: data size
+ * @event_data: event data
  *
  * API to handle events in STOP-PROGRESS substate
  *
@@ -1590,6 +1635,9 @@ static void mlme_vdev_subst_stop_down_progress_exit(void *ctx)
  * mlme_vdev_subst_stop_down_progress_event() - Event handler API for Down
  *                                                Progress substate
  * @ctx: VDEV MLME object
+ * @event: MLME event
+ * @event_data_len: data size
+ * @event_data: event data
  *
  * API to handle events in DOWN-PROGRESS substate
  *
@@ -1678,6 +1726,9 @@ static void mlme_vdev_subst_mlo_sync_wait_exit(void *ctx)
  * mlme_vdev_subst_mlo_sync_wait_event() - Event handler API for mlo sync wait
  *                                         substate
  * @ctx: VDEV MLME object
+ * @event: MLME event
+ * @event_data_len: data size
+ * @event_data: event data
  *
  * API to handle events in MLO-SYNC-WAIT substate
  *
@@ -1769,6 +1820,9 @@ static void mlme_vdev_subst_up_active_exit(void *ctx)
 /**
  * mlme_vdev_subst_up_active_event() - Event handler API for up active substate
  * @ctx: VDEV MLME object
+ * @event: MLME event
+ * @event_data_len: data size
+ * @event_data: event data
  *
  * API to handle events in UP-ACTIVE substate
  *

umac/mlme/vdev_mgr/core/src/vdev_mlme_sm.h

@@ -1,6 +1,6 @@
 /*
  * Copyright (c) 2018-2021 The Linux Foundation. All rights reserved.
- * Copyright (c) 2022 Qualcomm Innovation Center, Inc. All rights reserved.
+ * Copyright (c) 2022-2023 Qualcomm Innovation Center, Inc. All rights reserved.
  *
  * Permission to use, copy, modify, and/or distribute this software for
  * any purpose with or without fee is hereby granted, provided that the
@@ -83,8 +83,8 @@ void mlme_vdev_sm_history_print(struct vdev_mlme_obj *vdev_mlme);
 #endif
 
 /**
- * mlme_vdev_sm_create - Invoke SME creation for VDEV
- * @vdev_mlme_obj:  VDEV MLME comp object
+ * mlme_vdev_sm_create() - Invoke SME creation for VDEV
+ * @vdev_mlme:  VDEV MLME comp object
  *
  * API allocates VDEV MLME SM and initializes SM lock
  *
@@ -94,8 +94,8 @@ void mlme_vdev_sm_history_print(struct vdev_mlme_obj *vdev_mlme);
 QDF_STATUS mlme_vdev_sm_create(struct vdev_mlme_obj *vdev_mlme);
 
 /**
- * mlme_vdev_sm_destroy - Invoke SME destroy for VDEV
- * @vdev_mlme_obj:  VDEV MLME comp object
+ * mlme_vdev_sm_destroy() - Invoke SME destroy for VDEV
+ * @vdev_mlme:  VDEV MLME comp object
  *
  * API frees VDEV MLME SM and destroys the SM lock
  *
@@ -105,8 +105,8 @@ QDF_STATUS mlme_vdev_sm_create(struct vdev_mlme_obj *vdev_mlme);
 QDF_STATUS mlme_vdev_sm_destroy(struct vdev_mlme_obj *vdev_mlme);
 
 /**
- * mlme_vdev_validate_basic_params - Validate basic params
- * @vdev_mlme_obj:  VDEV MLME comp object
+ * mlme_vdev_validate_basic_params() - Validate basic params
+ * @vdev_mlme:  VDEV MLME comp object
  * @event_data_len: data size
  * @event_data: event data
  *
@@ -129,8 +129,8 @@ static inline QDF_STATUS mlme_vdev_validate_basic_params(
 }
 
 /**
- * mlme_vdev_reset_proto_params - Reset VDEV protocol params
- * @vdev_mlme_obj:  VDEV MLME comp object
+ * mlme_vdev_reset_proto_params() - Reset VDEV protocol params
+ * @vdev_mlme:  VDEV MLME comp object
  * @event_data_len: data size
  * @event_data: event data
  *
@@ -153,8 +153,8 @@ static inline QDF_STATUS mlme_vdev_reset_proto_params(
 }
 
 /**
- * mlme_vdev_start_send - Invokes VDEV start operation
- * @vdev_mlme_obj:  VDEV MLME comp object
+ * mlme_vdev_start_send() - Invokes VDEV start operation
+ * @vdev_mlme:  VDEV MLME comp object
  * @event_data_len: data size
  * @event_data: event data
  *
@@ -177,8 +177,8 @@ static inline QDF_STATUS mlme_vdev_start_send(
 }
 
 /**
- * mlme_vdev_restart_send - Invokes VDEV restart operation
- * @vdev_mlme_obj:  VDEV MLME comp object
+ * mlme_vdev_restart_send() - Invokes VDEV restart operation
+ * @vdev_mlme:  VDEV MLME comp object
  * @event_data_len: data size
  * @event_data: event data
  *
@@ -201,8 +201,8 @@ static inline QDF_STATUS mlme_vdev_restart_send(
 }
 
 /**
- * mlme_vdev_stop_start_send - Invoke block VDEV restart operation
- * @vdev_mlme_obj:  VDEV MLME comp object
+ * mlme_vdev_stop_start_send() - Invoke block VDEV restart operation
+ * @vdev_mlme:  VDEV MLME comp object
  * @restart: restart req/start req
  * @event_data_len: data size
  * @event_data: event data
@@ -226,8 +226,8 @@ static inline QDF_STATUS mlme_vdev_stop_start_send(
 }
 
 /**
- * mlme_vdev_start_continue - VDEV start response handling
- * @vdev_mlme_obj:  VDEV MLME comp object
+ * mlme_vdev_start_continue() - VDEV start response handling
+ * @vdev_mlme:  VDEV MLME comp object
  * @event_data_len: data size
  * @event_data: event data
  *
@@ -250,8 +250,8 @@ static inline QDF_STATUS mlme_vdev_start_continue(
 }
 
 /**
- * mlme_vdev_start_req_failed - Invoke Station VDEV connection, if it pause
- * @vdev_mlme_obj:  VDEV MLME comp object
+ * mlme_vdev_start_req_failed() - Invoke Station VDEV connection, if it pause
+ * @vdev_mlme:  VDEV MLME comp object
  * @event_data_len: data size
  * @event_data: event data
  *
@@ -274,8 +274,8 @@ static inline QDF_STATUS mlme_vdev_start_req_failed(
 }
 
 /**
- * mlme_vdev_sta_conn_start - Invoke Station VDEV connection, if it pause
- * @vdev_mlme_obj:  VDEV MLME comp object
+ * mlme_vdev_sta_conn_start() - Invoke Station VDEV connection, if it pause
+ * @vdev_mlme:  VDEV MLME comp object
  * @event_data_len: data size
  * @event_data: event data
  *
@@ -298,8 +298,8 @@ static inline QDF_STATUS mlme_vdev_sta_conn_start(
 }
 
 /**
- * mlme_vdev_sta_disconn_start - Invoke Station VDEV disconnection
- * @vdev_mlme_obj:  VDEV MLME comp object
+ * mlme_vdev_sta_disconn_start() - Invoke Station VDEV disconnection
+ * @vdev_mlme:  VDEV MLME comp object
  * @event_data_len: data size
  * @event_data: event data
  *
@@ -322,8 +322,8 @@ static inline QDF_STATUS mlme_vdev_sta_disconn_start(
 }
 
 /**
- * mlme_vdev_up_send - VDEV up operation
- * @vdev_mlme_obj:  VDEV MLME comp object
+ * mlme_vdev_up_send() - VDEV up operation
+ * @vdev_mlme:  VDEV MLME comp object
  * @event_data_len: data size
  * @event_data: event data
  *
@@ -346,8 +346,8 @@ static inline QDF_STATUS mlme_vdev_up_send(
 }
 
 /**
- * mlme_vdev_notify_up_complete - VDEV up state transition notification
- * @vdev_mlme_obj:  VDEV MLME comp object
+ * mlme_vdev_notify_up_complete() - VDEV up state transition notification
+ * @vdev_mlme:  VDEV MLME comp object
  * @event_data_len: data size
  * @event_data: event data
  *
@@ -371,8 +371,8 @@ QDF_STATUS mlme_vdev_notify_up_complete(struct vdev_mlme_obj *vdev_mlme,
 }
 
 /**
- * mlme_vdev_notify_roam_start - VDEV Roaming notification
- * @vdev_mlme_obj:  VDEV MLME comp object
+ * mlme_vdev_notify_roam_start() - VDEV Roaming notification
+ * @vdev_mlme:  VDEV MLME comp object
  * @event_len: data size
  * @event_data: event data
  *
@@ -396,8 +396,8 @@ QDF_STATUS mlme_vdev_notify_roam_start(struct vdev_mlme_obj *vdev_mlme,
 }
 
 /**
- * mlme_vdev_update_beacon - Updates beacon
- * @vdev_mlme_obj:  VDEV MLME comp object
+ * mlme_vdev_update_beacon() - Updates beacon
+ * @vdev_mlme:  VDEV MLME comp object
  * @op: beacon update type
  * @event_data_len: data size
  * @event_data: event data
@@ -422,8 +422,8 @@ QDF_STATUS mlme_vdev_update_beacon(struct vdev_mlme_obj *vdev_mlme,
 }
 
 /**
- * mlme_vdev_disconnect_peers - Disconnect peers
- * @vdev_mlme_obj:  VDEV MLME comp object
+ * mlme_vdev_disconnect_peers() - Disconnect peers
+ * @vdev_mlme:  VDEV MLME comp object
  * @event_data_len: data size
  * @event_data: event data
  *
@@ -447,8 +447,8 @@ static inline QDF_STATUS mlme_vdev_disconnect_peers(
 }
 
 /**
- * mlme_vdev_dfs_cac_timer_stop - Stop CAC timer
- * @vdev_mlme_obj:  VDEV MLME comp object
+ * mlme_vdev_dfs_cac_timer_stop() - Stop CAC timer
+ * @vdev_mlme:  VDEV MLME comp object
  * @event_data_len: data size
  * @event_data: event data
  *
@@ -471,8 +471,8 @@ static inline QDF_STATUS mlme_vdev_dfs_cac_timer_stop(
 }
 
 /**
- * mlme_vdev_stop_send - Invokes VDEV stop operation
- * @vdev_mlme_obj:  VDEV MLME comp object
+ * mlme_vdev_stop_send() - Invokes VDEV stop operation
+ * @vdev_mlme:  VDEV MLME comp object
  * @event_data_len: data size
  * @event_data: event data
  *
@@ -495,8 +495,8 @@ static inline QDF_STATUS mlme_vdev_stop_send(
 }
 
 /**
- * mlme_vdev_stop_continue - VDEV stop response handling
- * @vdev_mlme_obj:  VDEV MLME comp object
+ * mlme_vdev_stop_continue() - VDEV stop response handling
+ * @vdev_mlme:  VDEV MLME comp object
  * @event_data_len: data size
  * @event_data: event data
  *
@@ -520,8 +520,8 @@ static inline QDF_STATUS mlme_vdev_stop_continue(
 }
 
 /**
- * mlme_vdev_down_send - VDEV down operation
- * @vdev_mlme_obj:  VDEV MLME comp object
+ * mlme_vdev_down_send() - VDEV down operation
+ * @vdev_mlme:  VDEV MLME comp object
  * @event_data_len: data size
  * @event_data: event data
  *
@@ -544,8 +544,8 @@ static inline QDF_STATUS mlme_vdev_down_send(
 }
 
 /**
- * mlme_vdev_notify_down_complete - VDEV init state transition notification
- * @vdev_mlme_obj:  VDEV MLME comp object
+ * mlme_vdev_notify_down_complete() - VDEV init state transition notification
+ * @vdev_mlme:  VDEV MLME comp object
  * @event_data_len: data size
  * @event_data: event data
  *
@@ -568,8 +568,8 @@ static inline QDF_STATUS mlme_vdev_notify_down_complete(
 }
 
 /**
- * mlme_vdev_notify_start_state_exit - VDEV SM start state exit notification
- * @vdev_mlme_obj:  VDEV MLME comp object
+ * mlme_vdev_notify_start_state_exit() - VDEV SM start state exit notification
+ * @vdev_mlme:  VDEV MLME comp object
  *
  * API notifies on start state exit
  *
@@ -590,8 +590,8 @@ static inline QDF_STATUS mlme_vdev_notify_start_state_exit(
 }
 
 /**
- * mlme_vdev_is_newchan_no_cac - Checks new channel requires CAC
- * @vdev_mlme_obj:  VDEV MLME comp object
+ * mlme_vdev_is_newchan_no_cac() - Checks new channel requires CAC
+ * @vdev_mlme:  VDEV MLME comp object
  *
  * API checks whether Channel needs CAC period,
  * if yes, it moves to SUSPEND_RESTART to disconnect stations before
@@ -612,8 +612,8 @@ static inline QDF_STATUS mlme_vdev_is_newchan_no_cac(
 }
 
 /**
- * mlme_vdev_dfs_cac_wait_notify - Notifies DFS CAC wait state
- * @vdev_mlme_obj:  VDEV MLME comp object
+ * mlme_vdev_dfs_cac_wait_notify() - Notifies DFS CAC wait state
+ * @vdev_mlme:  VDEV MLME comp object
  *
  * Return: NO_SUPPORT if the callback is not supported.
  *         SUCCESS if DFS CAC Wait notification handled by caller
@@ -630,7 +630,7 @@ static inline QDF_STATUS mlme_vdev_dfs_cac_wait_notify(
 }
 
 /**
- * mlme_vdev_chan_switch_disable_notify_dfs - Notifies DFS when channel
+ * mlme_vdev_chan_switch_disable_notify_dfs() - Notifies DFS when channel
  * switch is disabled
  * @vdev_mlme: VDEV MLME comp object
  *
@@ -643,7 +643,7 @@ static inline QDF_STATUS mlme_vdev_chan_switch_disable_notify_dfs(
 }
 #ifdef WLAN_FEATURE_11BE_MLO
 /**
- * mlme_vdev_up_notify_mlo_mgr - notify mlo link is ready to up
+ * mlme_vdev_up_notify_mlo_mgr() - notify mlo link is ready to up
  * @vdev_mlme:  VDEV MLME comp object
  *
  * Return: true if MLO_SYNC_COMPLETE is posted, else false
@@ -657,8 +657,8 @@ static inline bool mlme_vdev_up_notify_mlo_mgr(struct vdev_mlme_obj *vdev_mlme)
 }
 
 /**
- * mlme_vdev_start_rsp_notify_mlo_mgr - notify mlo link is started
- * @vdev_mlme_obj:  VDEV MLME comp object
+ * mlme_vdev_start_rsp_notify_mlo_mgr() - notify mlo link is started
+ * @vdev_mlme:  VDEV MLME comp object
  *
  * Return: VOID.
  */
@@ -670,8 +670,8 @@ static inline void mlme_vdev_start_rsp_notify_mlo_mgr(
 }
 
 /**
- * mlme_vdev_down_cmpl_notify_mlo_mgr - notify mlo link is down complete
- * @vdev_mlme_obj:  VDEV MLME comp object
+ * mlme_vdev_down_cmpl_notify_mlo_mgr() - notify mlo link is down complete
+ * @vdev_mlme:  VDEV MLME comp object
  *
  * Return: VOID.
  */
@@ -683,8 +683,8 @@ static inline void mlme_vdev_down_cmpl_notify_mlo_mgr(
 }
 
 /**
- * mlme_vdev_up_active_notify_mlo_mgr - notify mlo link is up active
- * @vdev_mlme_obj:  VDEV MLME comp object
+ * mlme_vdev_up_active_notify_mlo_mgr() - notify mlo link is up active
+ * @vdev_mlme:  VDEV MLME comp object
  *
  * Return: VOID.
  */
@@ -697,8 +697,8 @@ static inline void mlme_vdev_up_active_notify_mlo_mgr(
 }
 
 /**
- * mlme_vdev_notify_mlo_sync_wait_entry - Notifies mlo sync wait state
- * @vdev_mlme_obj:  VDEV MLME comp object
+ * mlme_vdev_notify_mlo_sync_wait_entry() - Notifies mlo sync wait state
+ * @vdev_mlme:  VDEV MLME comp object
  *
  * Return: NO_SUPPORT if the callback is not supported.
  *         SUCCESS if notification is handled by caller
@@ -744,8 +744,8 @@ static inline QDF_STATUS mlme_vdev_notify_mlo_sync_wait_entry(
 
 #ifdef VDEV_SM_LOCK_SUPPORT
 /**
- * mlme_vdev_sm_spinlock_create - Create VDEV MLME spinlock
- * @vdev_mlme_obj:  VDEV MLME comp object
+ * mlme_vdev_sm_spinlock_create() - Create VDEV MLME spinlock
+ * @vdev_mlme:  VDEV MLME comp object
  *
  * Creates VDEV MLME spinlock
  *
@@ -757,8 +757,8 @@ static inline void mlme_vdev_sm_spinlock_create(struct vdev_mlme_obj *vdev_mlme)
 }
 
 /**
- * mlme_vdev_sm_spinlock_destroy - Destroy VDEV MLME spinlock
- * @vdev_mlme_obj:  VDEV MLME comp object
+ * mlme_vdev_sm_spinlock_destroy() - Destroy VDEV MLME spinlock
+ * @vdev_mlme:  VDEV MLME comp object
  *
  * Destroy VDEV MLME spinlock
  *
@@ -771,8 +771,8 @@ static inline void mlme_vdev_sm_spinlock_destroy(
 }
 
 /**
- * mlme_vdev_sm_spin_lock - acquire spinlock
- * @vdev_mlme_obj:  vdev mlme comp object
+ * mlme_vdev_sm_spin_lock() - acquire spinlock
+ * @vdev_mlme:  vdev mlme comp object
  *
  * acquire vdev mlme spinlock
  *
@@ -784,8 +784,8 @@ static inline void mlme_vdev_sm_spin_lock(struct vdev_mlme_obj *vdev_mlme)
 }
 
 /**
- * mlme_vdev_sm_spin_unlock - release spinlock
- * @vdev_mlme_obj:  vdev mlme comp object
+ * mlme_vdev_sm_spin_unlock() - release spinlock
+ * @vdev_mlme:  vdev mlme comp object
  *
  * release vdev mlme spinlock
  *
@@ -797,8 +797,8 @@ static inline void mlme_vdev_sm_spin_unlock(struct vdev_mlme_obj *vdev_mlme)
 }
 
 /**
- * mlme_vdev_cmd_mutex_create - Create VDEV MLME cmd mutex
- * @vdev_mlme_obj:  VDEV MLME comp object
+ * mlme_vdev_cmd_mutex_create() - Create VDEV MLME cmd mutex
+ * @vdev_mlme:  VDEV MLME comp object
  *
  * Creates VDEV MLME cmd mutex
  *
@@ -811,8 +811,8 @@ mlme_vdev_cmd_mutex_create(struct vdev_mlme_obj *vdev_mlme)
 }
 
 /**
- * mlme_vdev_cmd_mutex_destroy - Destroy VDEV MLME cmd mutex
- * @vdev_mlme_obj:  VDEV MLME comp object
+ * mlme_vdev_cmd_mutex_destroy() - Destroy VDEV MLME cmd mutex
+ * @vdev_mlme:  VDEV MLME comp object
  *
  * Destroy VDEV MLME cmd mutex
  *
@@ -825,8 +825,8 @@ mlme_vdev_cmd_mutex_destroy(struct vdev_mlme_obj *vdev_mlme)
 }
 
 /**
- * mlme_vdev_cmd_mutex_acquire - acquire mutex
- * @vdev_mlme_obj:  vdev mlme comp object
+ * mlme_vdev_cmd_mutex_acquire() - acquire mutex
+ * @vdev_mlme:  vdev mlme comp object
  *
  * acquire vdev mlme cmd mutex
  *
@@ -838,8 +838,8 @@ static inline void mlme_vdev_cmd_mutex_acquire(struct vdev_mlme_obj *vdev_mlme)
 }
 
 /**
- * mlme_vdev_cmd_mutex_release - release mutex
- * @vdev_mlme_obj:  vdev mlme comp object
+ * mlme_vdev_cmd_mutex_release() - release mutex
+ * @vdev_mlme:  vdev mlme comp object
  *
  * release vdev mlme cmd mutex
  *

umac/mlme/vdev_mgr/dispatcher/inc/wlan_vdev_mgr_tgt_if_rx_defs.h

@@ -1,6 +1,6 @@
 /*
  * Copyright (c) 2019-2021 The Linux Foundation. All rights reserved.
- * Copyright (c) 2021-2022 Qualcomm Innovation Center, Inc. All rights reserved.
+ * Copyright (c) 2021-2023 Qualcomm Innovation Center, Inc. All rights reserved.
  *
  * Permission to use, copy, modify, and/or distribute this software for
  * any purpose with or without fee is hereby granted, provided that the
@@ -37,12 +37,13 @@
 
 /**
  * enum wlan_vdev_mgr_tgt_if_rsp_bit - response status bit
- * START_RESPONSE_BIT: vdev start response bit
- * RESTART_RESPONSE_BIT: vdev restart response bit
- * STOP_RESPONSE_BIT: vdev stop response bit
- * DELETE_RESPONSE_BIT:  vdev delete response bit
- * PEER_DELETE_ALL_RESPONSE_BIT: vdev peer delete all response bit
- * RSO_STOP_RESPONSE_BIT : RSO stop response bit
+ * @START_RESPONSE_BIT: vdev start response bit
+ * @RESTART_RESPONSE_BIT: vdev restart response bit
+ * @STOP_RESPONSE_BIT: vdev stop response bit
+ * @DELETE_RESPONSE_BIT:  vdev delete response bit
+ * @PEER_DELETE_ALL_RESPONSE_BIT: vdev peer delete all response bit
+ * @RSO_STOP_RESPONSE_BIT: RSO stop response bit
+ * @RESPONSE_BIT_MAX: Max enumeration
  */
 enum wlan_vdev_mgr_tgt_if_rsp_bit {
 	START_RESPONSE_BIT = 0,
@@ -56,7 +57,7 @@ enum wlan_vdev_mgr_tgt_if_rsp_bit {
 
 /**
  * string_from_rsp_bit() - Convert response bit to string
- * @bit - response bit as in wlan_vdev_mgr_tgt_if_rsp_bit
+ * @bit: response bit as in wlan_vdev_mgr_tgt_if_rsp_bit
  *
  * Please note to add new string in the array at index equal to
  * its enum value in wlan_vdev_mgr_tgt_if_rsp_bit.
@@ -175,12 +176,15 @@ struct peer_delete_all_response {
 	uint32_t peer_type_bitmap;
 };
 
-/**
+/*
  * struct multi_vdev_restart_resp - multi-vdev restart response structure
  * @pdev_id: pdev id
  * @status: FW status for multi vdev restart request
  * @vdev_id_bmap: Bitmap of vdev_ids
  * @timestamp: Time stamp corresponding to the start of event processing
+ *
+ * NB: not using kernel-doc format since the kernel-doc script doesn't
+ *     handle the qdf_bitmap() macro
  */
 struct multi_vdev_restart_resp {
 	uint8_t pdev_id;

umac/mlme/vdev_mgr/dispatcher/inc/wlan_vdev_mgr_tgt_if_tx_api.h

@@ -1,6 +1,6 @@
 /*
  * Copyright (c) 2019, 2021 The Linux Foundation. All rights reserved.
- * Copyright (c) 2021-2022 Qualcomm Innovation Center, Inc. All rights reserved.
+ * Copyright (c) 2021-2023 Qualcomm Innovation Center, Inc. All rights reserved.
  *
  * Permission to use, copy, modify, and/or distribute this software for
  * any purpose with or without fee is hereby granted, provided that the
@@ -33,7 +33,7 @@
 #include <include/wlan_vdev_mlme.h>
 
 /**
- * tgt_vdev_mgr_create_send() – API to send create command
+ * tgt_vdev_mgr_create_send() - API to send create command
  * @mlme_obj: pointer to vdev_mlme_obj
  * @param: pointer to vdev_create_params
  *
@@ -44,7 +44,7 @@ QDF_STATUS tgt_vdev_mgr_create_send(
 				struct vdev_create_params *param);
 
 /**
- * tgt_vdev_mgr_create_complete() – API to send wmi cfg corresponding
+ * tgt_vdev_mgr_create_complete() - API to send wmi cfg corresponding
  * to create command
  * @mlme_obj: pointer to vdev_mlme_obj
  *
@@ -53,7 +53,7 @@ QDF_STATUS tgt_vdev_mgr_create_send(
 QDF_STATUS tgt_vdev_mgr_create_complete(struct vdev_mlme_obj *mlme_obj);
 
 /**
- * tgt_vdev_mgr_start_send() – API to send start command
+ * tgt_vdev_mgr_start_send() - API to send start command
  * @mlme_obj: pointer to vdev_mlme_obj
  * @param: pointer to vdev_start_params
  *
@@ -64,7 +64,7 @@ QDF_STATUS tgt_vdev_mgr_start_send(
 				struct vdev_start_params *param);
 
 /**
- * tgt_vdev_mgr_delete_send() – API to send delete
+ * tgt_vdev_mgr_delete_send() - API to send delete
  * @mlme_obj: pointer to vdev_mlme_obj
  * @param: pointer to vdev_delete_params
  *
@@ -75,7 +75,7 @@ QDF_STATUS tgt_vdev_mgr_delete_send(
 				struct vdev_delete_params *param);
 
 /**
- * tgt_vdev_mgr_peer_flush_tids_send() – API to send peer flush tids in FW
+ * tgt_vdev_mgr_peer_flush_tids_send() - API to send peer flush tids in FW
  * @mlme_obj: pointer to vdev_mlme_obj
  * @param: pointer to peer_flush_params
  *
@@ -86,7 +86,7 @@ QDF_STATUS tgt_vdev_mgr_peer_flush_tids_send(
 				struct peer_flush_params *param);
 
 /**
- * tgt_vdev_mgr_stop_send() – API to send stop command
+ * tgt_vdev_mgr_stop_send() - API to send stop command
  * @mlme_obj: pointer to vdev_mlme_obj
  * @param: pointer to vdev_stop_params
  *
@@ -97,7 +97,7 @@ QDF_STATUS tgt_vdev_mgr_stop_send(
 				struct vdev_stop_params *param);
 
 /**
- * tgt_vdev_mgr_beacon_stop() – API to handle beacon buffer
+ * tgt_vdev_mgr_beacon_stop() - API to handle beacon buffer
  * @mlme_obj: pointer to vdev_mlme_obj
  *
  * Return: QDF_STATUS - Success or Failure
@@ -105,7 +105,7 @@ QDF_STATUS tgt_vdev_mgr_stop_send(
 QDF_STATUS tgt_vdev_mgr_beacon_stop(struct vdev_mlme_obj *mlme_obj);
 
 /**
- * tgt_vdev_mgr_beacon_free() – API to free beacon buffer
+ * tgt_vdev_mgr_beacon_free() - API to free beacon buffer
  * @mlme_obj: pointer to vdev_mlme_obj
  *
  * Return: QDF_STATUS - Success or Failure
@@ -113,7 +113,7 @@ QDF_STATUS tgt_vdev_mgr_beacon_stop(struct vdev_mlme_obj *mlme_obj);
 QDF_STATUS tgt_vdev_mgr_beacon_free(struct vdev_mlme_obj *mlme_obj);
 
 /**
- * tgt_vdev_mgr_up_send() – API to send up
+ * tgt_vdev_mgr_up_send() - API to send up
  * @mlme_obj: pointer to vdev_mlme_obj
  * @param: pointer to vdev_up_params
  *
@@ -124,7 +124,7 @@ QDF_STATUS tgt_vdev_mgr_up_send(
 				struct vdev_up_params *param);
 
 /**
- * tgt_vdev_mgr_down_send() – API to send down
+ * tgt_vdev_mgr_down_send() - API to send down
  * @mlme_obj: pointer to vdev_mlme_obj
  * @param: pointer to vdev_down_params
  *
@@ -135,7 +135,7 @@ QDF_STATUS tgt_vdev_mgr_down_send(
 				struct vdev_down_params *param);
 
 /**
- * tgt_vdev_mgr_set_neighbour_rx_cmd_send() – API to send neighbour rx
+ * tgt_vdev_mgr_set_neighbour_rx_cmd_send() - API to send neighbour rx
  * @mlme_obj: pointer to vdev_mlme_obj
  * @param: pointer to set_neighbour_rx_params
  *
@@ -146,7 +146,7 @@ QDF_STATUS tgt_vdev_mgr_set_neighbour_rx_cmd_send(
 				struct set_neighbour_rx_params *param);
 
 /**
- * tgt_vdev_mgr_nac_rssi_send() – API to send NAC RSSI
+ * tgt_vdev_mgr_nac_rssi_send() - API to send NAC RSSI
  * @mlme_obj: pointer to vdev_mlme_obj
  * @param: pointer to vdev_scan_nac_rssi_params
  *
@@ -157,7 +157,7 @@ QDF_STATUS tgt_vdev_mgr_nac_rssi_send(
 				struct vdev_scan_nac_rssi_params *param);
 
 /**
- * tgt_vdev_mgr_sifs_trigger_send() – API to send SIFS trigger
+ * tgt_vdev_mgr_sifs_trigger_send() - API to send SIFS trigger
  * @mlme_obj: pointer to vdev_mlme_obj
  * @param: pointer to sifs_trigger_param
  *
@@ -168,7 +168,7 @@ QDF_STATUS tgt_vdev_mgr_sifs_trigger_send(
 				struct sifs_trigger_param *param);
 
 /**
- * tgt_vdev_mgr_set_custom_aggr_size_send() – API to send custom aggr size
+ * tgt_vdev_mgr_set_custom_aggr_size_send() - API to send custom aggr size
  * @mlme_obj: pointer to vdev_mlme_obj
  * @param: pointer to set_custom_aggr_size_params
  *
@@ -179,7 +179,7 @@ QDF_STATUS tgt_vdev_mgr_set_custom_aggr_size_send(
 				struct set_custom_aggr_size_params *param);
 
 /**
- * tgt_vdev_mgr_config_ratemask_cmd_send() – API to configure ratemask
+ * tgt_vdev_mgr_config_ratemask_cmd_send() - API to configure ratemask
  * @mlme_obj: pointer to vdev_mlme_obj
  * @param: pointer to config_ratemask_params
  *
@@ -190,7 +190,7 @@ QDF_STATUS tgt_vdev_mgr_config_ratemask_cmd_send(
 				struct config_ratemask_params *param);
 
 /**
- * tgt_vdev_mgr_sta_ps_param_send() – API to send sta power save configuration
+ * tgt_vdev_mgr_sta_ps_param_send() - API to send sta power save configuration
  * @mlme_obj: pointer to vdev_mlme_obj
  * @param: pointer to sta_ps_params
  *
@@ -201,7 +201,7 @@ QDF_STATUS tgt_vdev_mgr_sta_ps_param_send(
 				struct sta_ps_params *param);
 
 /**
- * tgt_vdev_mgr_beacon_cmd_send() – API to send beacon
+ * tgt_vdev_mgr_beacon_cmd_send() - API to send beacon
  * @mlme_obj: pointer to vdev_mlme_obj
  * @param: pointer to beacon_params
  *
@@ -212,7 +212,7 @@ QDF_STATUS tgt_vdev_mgr_beacon_cmd_send(
 				struct beacon_params *param);
 
 /**
- * tgt_vdev_mgr_beacon_tmpl_send() – API to send beacon template
+ * tgt_vdev_mgr_beacon_tmpl_send() - API to send beacon template
  * @mlme_obj: pointer to vdev_mlme_obj
  * @param: pointer to beacon_tmpl_params
  *
@@ -250,7 +250,7 @@ static inline QDF_STATUS tgt_vdev_mgr_fils_enable_send(
 #endif
 
 /**
- * tgt_vdev_mgr_multiple_vdev_restart_send() – API to send multiple vdev
+ * tgt_vdev_mgr_multiple_vdev_restart_send() - API to send multiple vdev
  * restart
  * @pdev: pointer to pdev
  * @param: pointer to multiple_vdev_restart_params
@@ -262,7 +262,7 @@ QDF_STATUS tgt_vdev_mgr_multiple_vdev_restart_send(
 				struct multiple_vdev_restart_params *param);
 
 /**
- * tgt_vdev_mgr_multiple_vdev_set_param() – API to send multiple vdev
+ * tgt_vdev_mgr_multiple_vdev_set_param() - API to send multiple vdev
  * param
  * @pdev: pointer to pdev
  * @param: pointer to multiple_vdev_set_param
@@ -274,10 +274,10 @@ QDF_STATUS tgt_vdev_mgr_multiple_vdev_set_param(
 				struct multiple_vdev_set_param *param);
 
 /**
- * tgt_vdev_mgr_set_tx_rx_decap_type() – API to send tx rx decap type
+ * tgt_vdev_mgr_set_tx_rx_decap_type() - API to send tx rx decap type
  * @mlme_obj: pointer to vdev mlme obj
  * @param_id: param id
- * value: value to set for param id
+ * @value: value to set for param id
  *
  * Return: QDF_STATUS - Success or Failure
  */
@@ -286,7 +286,7 @@ QDF_STATUS tgt_vdev_mgr_set_tx_rx_decap_type(struct vdev_mlme_obj *mlme_obj,
 					     uint32_t value);
 
 /**
- * tgt_vdev_mgr_set_param_send() – API to send parameter cfg
+ * tgt_vdev_mgr_set_param_send() - API to send parameter cfg
  * @mlme_obj: pointer to vdev_mlme_obj
  * @param: pointer to vdev_set_params
  *
@@ -297,7 +297,7 @@ QDF_STATUS tgt_vdev_mgr_set_param_send(
 				struct vdev_set_params *param);
 
 /**
- * tgt_vdev_mgr_bcn_miss_offload_send() – API to send beacon miss offload
+ * tgt_vdev_mgr_bcn_miss_offload_send() - API to send beacon miss offload
  * @mlme_obj: pointer to vdev_mlme_obj
  *
  * Return: QDF_STATUS - Success or Failure
@@ -305,7 +305,7 @@ QDF_STATUS tgt_vdev_mgr_set_param_send(
 QDF_STATUS tgt_vdev_mgr_bcn_miss_offload_send(struct vdev_mlme_obj *mlme_obj);
 
 /**
- * tgt_vdev_mgr_peer_delete_all_send() – API to send peer delete all request
+ * tgt_vdev_mgr_peer_delete_all_send() - API to send peer delete all request
  * @mlme_obj: pointer to vdev_mlme_obj
  * @param: pointer to peer_delete_all_params
  *

umac/mlme/vdev_mgr/dispatcher/inc/wlan_vdev_mgr_tgt_if_tx_defs.h

@@ -1,6 +1,6 @@
 /*
  * Copyright (c) 2019-2021 The Linux Foundation. All rights reserved.
- * Copyright (c) 2021-2022 Qualcomm Innovation Center, Inc. All rights reserved.
+ * Copyright (c) 2021-2023 Qualcomm Innovation Center, Inc. All rights reserved.
  *
  * Permission to use, copy, modify, and/or distribute this software for
  * any purpose with or without fee is hereby granted, provided that the
@@ -32,15 +32,17 @@
 #endif
 #include <wlan_mlme_dbg.h>
 
-/** slot time long */
+/* slot time long */
 #define WLAN_MLME_VDEV_SLOT_TIME_LONG   0x1
-/** slot time short */
+/* slot time short */
 #define WLAN_MLME_VDEV_SLOT_TIME_SHORT  0x2
 
 #define WLAN_MU_SNIF_MAX_AIDS 4
 
 /**
  * enum mlme_dev_setparam - type of set params pdev/vdev
+ * @MLME_PDEV_SETPARAM: pdev param
+ * @MLME_VDEV_SETPARAM: vdev param
  */
 enum mlme_dev_setparam {
 	MLME_PDEV_SETPARAM = 0,
@@ -48,7 +50,19 @@ enum mlme_dev_setparam {
 };
 
 /**
- * enum MLME_bcn_tx_rate_code - beacon tx rate code
+ * enum mlme_bcn_tx_rate_code - beacon tx rate code
+ * @MLME_BCN_TX_RATE_CODE_1_M:
+ * @MLME_BCN_TX_RATE_CODE_2_M:
+ * @MLME_BCN_TX_RATE_CODE_5_5_M:
+ * @MLME_BCN_TX_RATE_CODE_6_M:
+ * @MLME_BCN_TX_RATE_CODE_9_M:
+ * @MLME_BCN_TX_RATE_CODE_11M:
+ * @MLME_BCN_TX_RATE_CODE_12_M:
+ * @MLME_BCN_TX_RATE_CODE_18_M:
+ * @MLME_BCN_TX_RATE_CODE_24_M:
+ * @MLME_BCN_TX_RATE_CODE_36_M:
+ * @MLME_BCN_TX_RATE_CODE_48_M:
+ * @MLME_BCN_TX_RATE_CODE_54_M:
  */
 enum mlme_bcn_tx_rate_code {
 	MLME_BCN_TX_RATE_CODE_1_M = 0x43,
@@ -67,6 +81,14 @@ enum mlme_bcn_tx_rate_code {
 
 /**
  * enum wlan_mlme_host_sta_ps_param_uapsd - STA UPASD params
+ * @WLAN_MLME_HOST_STA_PS_UAPSD_AC0_DELIVERY_EN:
+ * @WLAN_MLME_HOST_STA_PS_UAPSD_AC0_TRIGGER_EN:
+ * @WLAN_MLME_HOST_STA_PS_UAPSD_AC1_DELIVERY_EN:
+ * @WLAN_MLME_HOST_STA_PS_UAPSD_AC1_TRIGGER_EN:
+ * @WLAN_MLME_HOST_STA_PS_UAPSD_AC2_DELIVERY_EN:
+ * @WLAN_MLME_HOST_STA_PS_UAPSD_AC2_TRIGGER_EN:
+ * @WLAN_MLME_HOST_STA_PS_UAPSD_AC3_DELIVERY_EN:
+ * @WLAN_MLME_HOST_STA_PS_UAPSD_AC3_TRIGGER_EN:
  */
 enum wlan_mlme_host_sta_ps_param_uapsd {
 	WLAN_MLME_HOST_STA_PS_UAPSD_AC0_DELIVERY_EN = (1 << 0),
@@ -81,6 +103,14 @@ enum wlan_mlme_host_sta_ps_param_uapsd {
 
 /**
  * enum wlan_mlme_host_vdev_start_status - vdev start status code
+ * @WLAN_MLME_HOST_VDEV_START_OK:
+ * @WLAN_MLME_HOST_VDEV_START_CHAN_INVALID:
+ * @WLAN_MLME_HOST_VDEV_START_CHAN_BLOCKED:
+ * @WLAN_MLME_HOST_VDEV_START_CHAN_DFS_VIOLATION:
+ * @WLAN_MLME_HOST_VDEV_START_CHAN_INVALID_REGDOMAIN:
+ * @WLAN_MLME_HOST_VDEV_START_CHAN_INVALID_BAND:
+ * @WLAN_MLME_HOST_VDEV_START_TIMEOUT:
+ * @WLAN_MLME_HOST_VDEV_START_MAX_REASON: Max enumeration
  */
 enum wlan_mlme_host_vdev_start_status {
 	WLAN_MLME_HOST_VDEV_START_OK = 0,
@@ -96,7 +126,7 @@ enum wlan_mlme_host_vdev_start_status {
 
 /**
  * string_from_start_rsp_status() - Convert start response status to string
- * @start_rsp - start response status
+ * @start_rsp: start response status
  *
  * Please note to add new string in the array at index equal to
  * its enum value in wlan_mlme_host_vdev_start_status.
@@ -121,6 +151,8 @@ static inline char *string_from_start_rsp_status(
 
 /**
  * enum wlan_mlme_host_start_event_param - start/restart resp event
+ * @WLAN_MLME_HOST_VDEV_START_RESP_EVENT: Start response
+ * @WLAN_MLME_HOST_VDEV_RESTART_RESP_EVENT: Restart response
  */
 enum wlan_mlme_host_start_event_param {
 	WLAN_MLME_HOST_VDEV_START_RESP_EVENT = 0,
@@ -359,8 +391,8 @@ struct fils_discovery_tmpl_params {
  * @cfreq2: centre frequency on secondary
  * @maxpower: max power for channel
  * @minpower: min power for channel
- * @maxreqpower: Max regulatory power
- * @antennamac: Max antenna
+ * @maxregpower: Max regulatory power
+ * @antennamax: Max antenna
  * @reg_class_id: Regulatory class id.
  * @puncture_bitmap: 11be static puncture bitmap
  */
@@ -457,9 +489,9 @@ struct peer_flush_params {
 };
 
 /**
- * struct peer_delete_params - peer delete cmd parameter
+ * struct peer_delete_cmd_params - peer delete cmd parameter
  * @vdev_id: vdev id
- * @mlo_logical_link_id_bitmap: logical link id bitmap for peers
+ * @hw_link_id_bitmap: logical link id bitmap for peers
  * not getting created
  */
 struct peer_delete_cmd_params {
@@ -506,7 +538,13 @@ struct config_ratemask_params {
  * @vdev_id : vdev id
  * @tx_aggr_size : TX aggr size
  * @rx_aggr_size : RX aggr size
- * @enable_bitmap: Bitmap for aggr size check
+ * @ac:
+ * @aggr_type:
+ * @tx_aggr_size_disable:
+ * @rx_aggr_size_disable:
+ * @tx_ac_enable:
+ * @aggr_ba_enable:
+ * @reserved: spare bits
  */
 struct set_custom_aggr_size_params {
 	uint32_t  vdev_id;
@@ -575,12 +613,14 @@ struct vdev_scan_nac_rssi_params {
 
 #ifdef WLAN_FEATURE_11BE_MLO
 /**
+ * struct mlo_vdev_start_flags - MLO start flags
  * @mlo_enabled: indicate is MLO enabled
  * @mlo_assoc_link: indicate is the link used to initialize
  *                  the association of mlo connection
  * @mlo_mcast_vdev: MLO cast vdev
  * @emlsr_support: indicate non AP MLD STA supports eMLSR mode
  * @mlo_link_add: Dynamic link addition
+ * @rsvd: reserved bits
  */
 struct mlo_vdev_start_flags {
 	uint32_t mlo_enabled:1,
@@ -604,7 +644,7 @@ struct ml_vdev_start_partner_info {
 };
 
 /**
- * struct mlo_vdev_start__partner_links - ML partner links
+ * struct mlo_vdev_start_partner_links - ML partner links
  * @num_links: Number of links
  * @partner_info: Partner link info
  */
@@ -630,11 +670,13 @@ struct mlo_vdev_start_partner_links {
  * @regdomain: Regulatory domain
  * @he_ops: HE ops
  * @eht_ops: EHT ops
- * @channel_param: Channel params required by target.
+ * @channel: Channel params required by target.
  * @bcn_tx_rate_code: Beacon tx rate code.
  * @ldpc_rx_enabled: Enable/Disable LDPC RX for this vdev
  * @mbssid_flags: MBSSID flags to FW
  * @vdevid_trans: Tx VDEV ID
+ * @mlo_flags: Flags for multi-link operation
+ * @mlo_partner: Partner links for multi-link operation
  * @mbssid_multi_group_flag: Flag to identify multi group mbssid support
  * @mbssid_multi_group_id: Group id of current vdev
  */
@@ -682,7 +724,7 @@ struct vdev_set_params {
 };
 
 /**
- * struct dev_set_param_info - vdev/pdev set param info
+ * struct dev_set_param - vdev/pdev set param info
  * @param_id: parameter id
  * @param_value: parameter value
  */
@@ -737,7 +779,7 @@ QDF_STATUS mlme_check_index_setparam(struct dev_set_param *param,
 }
 
 /**
- * struct vdev_set_mu_snif_params - vdev set mu sniffer cmd parameter
+ * struct vdev_set_mu_snif_param - vdev set mu sniffer cmd parameter
  * @vdev_id: vdev id
  * @mode: mu snif mode
  * @num_user: max number of user
@@ -766,6 +808,7 @@ struct vdev_set_mu_snif_param {
  * @mbssid_flags: MBSS IE flags indicating vdev type
  * @vdevid_trans: id of transmitting vdev for MBSS IE
  * @special_vdev_mode: indicates special vdev mode
+ * @mlo_mac: Multilink Operation MAC address
  */
 struct vdev_create_params {
 	uint8_t vdev_id;
@@ -841,6 +884,7 @@ struct peer_delete_all_params {
 #define WMI_MUEDCA_PARAM_MASK 0xff
 /**
  * struct muedca_params - MU-EDCA parameters
+ * @pdev_id: pdev id
  * @muedca_ecwmin: CWmin in exponential form
  * @muedca_ecwmax: CWmax in exponential form
  * @muedca_aifsn:  AIFSN parameter

umac/mlme/vdev_mgr/dispatcher/inc/wlan_vdev_mgr_ucfg_api.h

@@ -144,7 +144,7 @@ struct wlan_vdev_mgr_cfg {
 };
 
 /**
- * ucfg_wlan_vdev_mgr_set_param() – ucfg MLME API to
+ * ucfg_wlan_vdev_mgr_set_param() - ucfg MLME API to
  * set value into mlme vdev mgr component
  * @vdev: pointer to vdev object
  * @param_id: param of type wlan_mlme_cfg_id
@@ -157,7 +157,7 @@ QDF_STATUS ucfg_wlan_vdev_mgr_set_param(struct wlan_objmgr_vdev *vdev,
 					struct wlan_vdev_mgr_cfg mlme_cfg);
 
 /**
- * ucfg_wlan_vdev_mgr_get_param() – ucfg MLME API to
+ * ucfg_wlan_vdev_mgr_get_param() - ucfg MLME API to
  * get value from mlme vdev mgr component
  * @vdev: pointer to vdev object
  * @param_id: param of type wlan_mlme_cfg_id
@@ -170,7 +170,7 @@ void ucfg_wlan_vdev_mgr_get_param(struct wlan_objmgr_vdev *vdev,
 				  uint32_t *param_value);
 
 /**
- * ucfg_wlan_vdev_mgr_get_param_ssid() – ucfg MLME API to
+ * ucfg_wlan_vdev_mgr_get_param_ssid() - ucfg MLME API to
  * get ssid from mlme vdev mgr component
  * @vdev: pointer to vdev object
  * @ssid: pointer to store the ssid
@@ -183,7 +183,7 @@ void ucfg_wlan_vdev_mgr_get_param_ssid(struct wlan_objmgr_vdev *vdev,
 				       uint8_t *ssid_len);
 
 /**
- * ucfg_wlan_vdev_mgr_get_param_bssid() – ucfg MLME API to
+ * ucfg_wlan_vdev_mgr_get_param_bssid() - ucfg MLME API to
  * get bssid from mlme vdev mgr component
  * @vdev: pointer to vdev object
  * @bssid: pointer to store the bssid
@@ -194,7 +194,7 @@ void ucfg_wlan_vdev_mgr_get_param_bssid(
 				uint8_t *bssid);
 
 /**
- * ucfg_wlan_vdev_mgr_get_beacon_buffer() – ucfg MLME API to
+ * ucfg_wlan_vdev_mgr_get_beacon_buffer() - ucfg MLME API to
  * get beacon buffer from mlme vdev mgr component
  * @vdev: pointer to vdev object
  * @buf: pointer to store the beacon buffer
@@ -205,7 +205,7 @@ void ucfg_wlan_vdev_mgr_get_beacon_buffer(struct wlan_objmgr_vdev *vdev,
 					  qdf_nbuf_t buf);
 
 /**
- * ucfg_wlan_vdev_mgr_get_trans_bssid() – ucfg MLME API to
+ * ucfg_wlan_vdev_mgr_get_trans_bssid() - ucfg MLME API to
  * get transmission bssid from mlme vdev mgr component
  * @vdev: pointer to vdev object
  * @addr: pointer to store the transmission bssid
@@ -216,7 +216,7 @@ void ucfg_wlan_vdev_mgr_get_trans_bssid(struct wlan_objmgr_vdev *vdev,
 					uint8_t *addr);
 
 /**
- * ucfg_wlan_vdev_mgr_get_tsf_adjust() – ucfg MLME API to
+ * ucfg_wlan_vdev_mgr_get_tsf_adjust() - ucfg MLME API to
  * get tsf_adjust from mlme vdev mgr component
  * @vdev: pointer to vdev object
  * @tsf_adjust: pointer to store the tsf adjust value
@@ -236,7 +236,7 @@ void ucfg_wlan_vdev_mgr_get_tsf_adjust(struct wlan_objmgr_vdev *vdev,
 QDF_STATUS ucfg_vdev_mgr_cdp_vdev_attach(struct wlan_objmgr_vdev *vdev);
 
 /**
- * vdev_mgr_cdp_vdev_detach() - ucfg MLME API to detach CDP vdev
+ * ucfg_vdev_mgr_cdp_vdev_detach() - ucfg MLME API to detach CDP vdev
  * @vdev: pointer to vdev object
  *
  * Return: QDF_STATUS - Success or Failure

umac/mlme/vdev_mgr/dispatcher/inc/wlan_vdev_mgr_utils_api.h

@@ -60,7 +60,7 @@ enum wlan_op_subtype
 wlan_util_vdev_get_cdp_txrx_subtype(struct wlan_objmgr_vdev *vdev);
 
 /**
- * wlan_util_vdev_mlme_set_ratemask_config) – common MLME API to set
+ * wlan_util_vdev_mlme_set_ratemask_config() - common MLME API to set
  * ratemask configuration and send it to FW
  * @vdev_mlme: pointer to vdev_mlme object
  * @index: ratemask array index
@@ -72,11 +72,11 @@ wlan_util_vdev_mlme_set_ratemask_config(struct vdev_mlme_obj *vdev_mlme,
 					uint8_t index);
 
 /**
- * wlan_util_vdev_mlme_set_param() – common MLME API to fill common
+ * wlan_util_vdev_mlme_set_param() - common MLME API to fill common
  * parameters of vdev_mlme object
  * @vdev_mlme: pointer to vdev_mlme object
  * @param_id: param id for which the value should be set
- * @param_value: value that should bem set to the parameter
+ * @mlme_cfg: value that should be set to the parameter
  *
  * Return: QDF_STATUS - Success or Failure
  */
@@ -85,7 +85,7 @@ QDF_STATUS wlan_util_vdev_mlme_set_param(struct vdev_mlme_obj *vdev_mlme,
 					 struct wlan_vdev_mgr_cfg mlme_cfg);
 
 /**
- * wlan_util_vdev_mlme_get_param() – common MLME API to get common
+ * wlan_util_vdev_mlme_get_param() - common MLME API to get common
  * parameters of vdev_mlme object
  * @vdev_mlme: pointer to vdev_mlme object
  * @param_id: param id for which the value should be set
@@ -98,7 +98,7 @@ void wlan_util_vdev_mlme_get_param(struct vdev_mlme_obj *vdev_mlme,
 				   uint32_t *param_value);
 
 /**
- * wlan_util_vdev_get_param() – common MLME API to get common
+ * wlan_util_vdev_get_param() - common MLME API to get common
  * parameters of vdev_mlme object
  * @vdev: pointer to vdev object
  * @param_id: param id for which the value should be set

umac/mlme/vdev_mgr/dispatcher/inc/wlan_vdev_mlme_api.h

@@ -1,6 +1,6 @@
 /*
  * Copyright (c) 2018-2019, 2021 The Linux Foundation. All rights reserved.
- * Copyright (c) 2021-2022 Qualcomm Innovation Center, Inc. All rights reserved.
+ * Copyright (c) 2021-2023 Qualcomm Innovation Center, Inc. All rights reserved.
  *
  * Permission to use, copy, modify, and/or distribute this software for any
  * purpose with or without fee is hereby granted, provided that the above
@@ -52,6 +52,7 @@
 /**
  * enum wlan_mlme_peer_param_id - peer param id in mlme layer
  * @WLAN_MLME_PEER_BW_PUNCTURE: update puncture 20 MHz bitmap
+ * @WLAN_MLME_PEER_MAX: max enumeration
  */
 enum wlan_mlme_peer_param_id {
 	WLAN_MLME_PEER_BW_PUNCTURE,
@@ -230,7 +231,7 @@ QDF_STATUS wlan_vdev_is_dfs_cac_wait(struct wlan_objmgr_vdev *vdev);
 
 /**
  * wlan_vdev_mlme_cmd_lock - Acquire lock for command queuing atomicity
- * vdev: Object manager VDEV object
+ * @vdev: Object manager VDEV object
  *
  * API to take VDEV MLME command lock
  *
@@ -240,7 +241,7 @@ void wlan_vdev_mlme_cmd_lock(struct wlan_objmgr_vdev *vdev);
 
 /**
  * wlan_vdev_mlme_cmd_unlock - Release lock for command queuing atomicity
- * vdev: Object manager VDEV object
+ * @vdev: Object manager VDEV object
  *
  * API to release VDEV MLME command lock
  *