samsung-sm8650/android_kernel_samsung_sm8650-modules
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

qcacmn: Add NULL check for dp_pev

Browse Source 
Currently, no NULL check is made for the value of dp_pev.
Adding a NULL check to avoid NULL dereference.

Change-Id: I2712b7e2fd53ba3a346878e73d2eedac161c5935
CRs-Fixed: 2955365
This commit is contained in:
Amit Mehta
2021-06-09 13:06:03 +05:30
committed by Madan Koyyalamudi
parent d7adec6324
commit ad4cb6357b
1 changed files with 13 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

14
dp/wifi3.0/dp_rx.c
View File

@@ -324,7 +324,13 @@ QDF_STATUS __dp_rx_buffers_replenish(struct dp_soc *dp_soc, uint32_t mac_id,
rxdma_srng = dp_rxdma_srng->hal_srng; rxdma_srng = dp_rxdma_srng->hal_srng;
if (!rxdma_srng) { if (qdf_unlikely(!dp_pdev)) {
dp_rx_err("%pK: pdev is null for mac_id = %d",
dp_soc, mac_id);
return QDF_STATUS_E_FAILURE;
}
if (qdf_unlikely(!rxdma_srng)) {
dp_rx_debug("%pK: rxdma srng not initialized", dp_soc); dp_rx_debug("%pK: rxdma srng not initialized", dp_soc);
DP_STATS_INC(dp_pdev, replenish.rxdma_err, num_req_buffers); DP_STATS_INC(dp_pdev, replenish.rxdma_err, num_req_buffers);
return QDF_STATUS_E_FAILURE; return QDF_STATUS_E_FAILURE;
@@ -2290,6 +2296,12 @@ dp_pdev_rx_buffers_attach(struct dp_soc *dp_soc, uint32_t mac_id,
int sync_hw_ptr = 1; int sync_hw_ptr = 1;
uint32_t num_entries_avail; uint32_t num_entries_avail;
if (qdf_unlikely(!dp_pdev)) {
dp_rx_err("%pK: pdev is null for mac_id = %d",
dp_soc, mac_id);
return QDF_STATUS_E_FAILURE;
}
if (qdf_unlikely(!rxdma_srng)) { if (qdf_unlikely(!rxdma_srng)) {
DP_STATS_INC(dp_pdev, replenish.rxdma_err, num_req_buffers); DP_STATS_INC(dp_pdev, replenish.rxdma_err, num_req_buffers);
return QDF_STATUS_E_FAILURE; return QDF_STATUS_E_FAILURE;