From ad4cb6357b4f4a945a5a91f47c6e61c7c68c2de0 Mon Sep 17 00:00:00 2001 From: Amit Mehta Date: Wed, 9 Jun 2021 13:06:03 +0530 Subject: [PATCH] qcacmn: Add NULL check for dp_pev Currently, no NULL check is made for the value of dp_pev. Adding a NULL check to avoid NULL dereference. Change-Id: I2712b7e2fd53ba3a346878e73d2eedac161c5935 CRs-Fixed: 2955365 --- dp/wifi3.0/dp_rx.c | 14 +++++++++++++- 1 file changed, 13 insertions(+), 1 deletion(-) diff --git a/dp/wifi3.0/dp_rx.c b/dp/wifi3.0/dp_rx.c index f19da364b5..35e986dc80 100644 --- a/dp/wifi3.0/dp_rx.c +++ b/dp/wifi3.0/dp_rx.c @@ -324,7 +324,13 @@ QDF_STATUS __dp_rx_buffers_replenish(struct dp_soc *dp_soc, uint32_t mac_id, rxdma_srng = dp_rxdma_srng->hal_srng; - if (!rxdma_srng) { + if (qdf_unlikely(!dp_pdev)) { + dp_rx_err("%pK: pdev is null for mac_id = %d", + dp_soc, mac_id); + return QDF_STATUS_E_FAILURE; + } + + if (qdf_unlikely(!rxdma_srng)) { dp_rx_debug("%pK: rxdma srng not initialized", dp_soc); DP_STATS_INC(dp_pdev, replenish.rxdma_err, num_req_buffers); return QDF_STATUS_E_FAILURE; @@ -2290,6 +2296,12 @@ dp_pdev_rx_buffers_attach(struct dp_soc *dp_soc, uint32_t mac_id, int sync_hw_ptr = 1; uint32_t num_entries_avail; + if (qdf_unlikely(!dp_pdev)) { + dp_rx_err("%pK: pdev is null for mac_id = %d", + dp_soc, mac_id); + return QDF_STATUS_E_FAILURE; + } + if (qdf_unlikely(!rxdma_srng)) { DP_STATS_INC(dp_pdev, replenish.rxdma_err, num_req_buffers); return QDF_STATUS_E_FAILURE;