samsung-sm8650/android_kernel_samsung_sm8650-modules
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

qcacmn: Fix return values in if_ahb.c

Browse Source 
Fix return code to return error code instead
of -1 in if_ahb.c.

Change-Id: I41a6e0b6db44c9ade02a0f835232b5d6c9ba7a73
CRs-Fixed: 2597545
This commit is contained in:
Naga
2020-01-06 16:44:41 +05:30
committed by nshrivas
parent 4db109a3d2
commit ab425a2edf
1 changed files with 6 additions and 6 deletions
Download Patch File Download Diff File Expand all files Collapse all files

12
hif/src/snoc/if_ahb.c
View File

@@ -233,14 +233,14 @@ int hif_ahb_configure_legacy_irq(struct hif_pci_softc *sc)
qal_vbus_get_irq((struct qdf_pfm_hndl *)pdev, "legacy", &irq); qal_vbus_get_irq((struct qdf_pfm_hndl *)pdev, "legacy", &irq);
if (irq < 0) { if (irq < 0) {
dev_err(&pdev->dev, "Unable to get irq\n"); dev_err(&pdev->dev, "Unable to get irq\n");
ret = -1; ret = -EFAULT;
goto end; goto end;
} }
ret = request_irq(irq, hif_pci_legacy_ce_interrupt_handler, ret = request_irq(irq, hif_pci_legacy_ce_interrupt_handler,
IRQF_DISABLED, "wlan_ahb", sc); IRQF_DISABLED, "wlan_ahb", sc);
if (ret) { if (ret) {
dev_err(&pdev->dev, "ath_request_irq failed\n"); dev_err(&pdev->dev, "ath_request_irq failed\n");
ret = -1; ret = -EFAULT;
goto end; goto end;
} }
sc->irq = irq; sc->irq = irq;
@@ -276,7 +276,7 @@ int hif_ahb_configure_irq(struct hif_pci_softc *sc)
HIF_IC_CE0_IRQ_OFFSET + i, &irq); HIF_IC_CE0_IRQ_OFFSET + i, &irq);
if (ret) { if (ret) {
dev_err(&pdev->dev, "get irq failed\n"); dev_err(&pdev->dev, "get irq failed\n");
ret = -1; ret = -EFAULT;
goto end; goto end;
} }
@@ -288,7 +288,7 @@ int hif_ahb_configure_irq(struct hif_pci_softc *sc)
&hif_state->tasklets[i]); &hif_state->tasklets[i]);
if (ret) { if (ret) {
dev_err(&pdev->dev, "ath_request_irq failed\n"); dev_err(&pdev->dev, "ath_request_irq failed\n");
ret = -1; ret = -EFAULT;
goto end; goto end;
} }
hif_ahb_irq_enable(scn, i); hif_ahb_irq_enable(scn, i);
@@ -321,7 +321,7 @@ int hif_ahb_configure_grp_irq(struct hif_softc *scn,
hif_ext_group->irq[j], &irq); hif_ext_group->irq[j], &irq);
if (ret) { if (ret) {
dev_err(&pdev->dev, "get irq failed\n"); dev_err(&pdev->dev, "get irq failed\n");
ret = -1; ret = -EFAULT;
goto end; goto end;
} }
ic_irqnum[hif_ext_group->irq[j]] = irq; ic_irqnum[hif_ext_group->irq[j]] = irq;
@@ -333,7 +333,7 @@ int hif_ahb_configure_grp_irq(struct hif_softc *scn,
hif_ext_group); hif_ext_group);
if (ret) { if (ret) {
dev_err(&pdev->dev, "ath_request_irq failed\n"); dev_err(&pdev->dev, "ath_request_irq failed\n");
ret = -1; ret = -EFAULT;
goto end; goto end;
} }
hif_ext_group->os_irq[j] = irq; hif_ext_group->os_irq[j] = irq;