From ab425a2edfc094f1fca91ed58b64bafb0287fe8c Mon Sep 17 00:00:00 2001 From: Naga Date: Mon, 6 Jan 2020 16:44:41 +0530 Subject: [PATCH] qcacmn: Fix return values in if_ahb.c Fix return code to return error code instead of -1 in if_ahb.c. Change-Id: I41a6e0b6db44c9ade02a0f835232b5d6c9ba7a73 CRs-Fixed: 2597545 --- hif/src/snoc/if_ahb.c | 12 ++++++------ 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/hif/src/snoc/if_ahb.c b/hif/src/snoc/if_ahb.c index 568f61eab5..7fa8af4111 100644 --- a/hif/src/snoc/if_ahb.c +++ b/hif/src/snoc/if_ahb.c @@ -233,14 +233,14 @@ int hif_ahb_configure_legacy_irq(struct hif_pci_softc *sc) qal_vbus_get_irq((struct qdf_pfm_hndl *)pdev, "legacy", &irq); if (irq < 0) { dev_err(&pdev->dev, "Unable to get irq\n"); - ret = -1; + ret = -EFAULT; goto end; } ret = request_irq(irq, hif_pci_legacy_ce_interrupt_handler, IRQF_DISABLED, "wlan_ahb", sc); if (ret) { dev_err(&pdev->dev, "ath_request_irq failed\n"); - ret = -1; + ret = -EFAULT; goto end; } sc->irq = irq; @@ -276,7 +276,7 @@ int hif_ahb_configure_irq(struct hif_pci_softc *sc) HIF_IC_CE0_IRQ_OFFSET + i, &irq); if (ret) { dev_err(&pdev->dev, "get irq failed\n"); - ret = -1; + ret = -EFAULT; goto end; } @@ -288,7 +288,7 @@ int hif_ahb_configure_irq(struct hif_pci_softc *sc) &hif_state->tasklets[i]); if (ret) { dev_err(&pdev->dev, "ath_request_irq failed\n"); - ret = -1; + ret = -EFAULT; goto end; } hif_ahb_irq_enable(scn, i); @@ -321,7 +321,7 @@ int hif_ahb_configure_grp_irq(struct hif_softc *scn, hif_ext_group->irq[j], &irq); if (ret) { dev_err(&pdev->dev, "get irq failed\n"); - ret = -1; + ret = -EFAULT; goto end; } ic_irqnum[hif_ext_group->irq[j]] = irq; @@ -333,7 +333,7 @@ int hif_ahb_configure_grp_irq(struct hif_softc *scn, hif_ext_group); if (ret) { dev_err(&pdev->dev, "ath_request_irq failed\n"); - ret = -1; + ret = -EFAULT; goto end; } hif_ext_group->os_irq[j] = irq;