samsung-sm8650/android_kernel_samsung_sm8650-modules
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

qcacmn: Avoid read access to IPA TX doorbell address

Browse Source 
Below signature is seen on sdxpinn when HOST reads IPA TX
doorbell address, which leads to HLOS crash.

Internal error: synchronous external abort: 96000010

Indeed IPA TX doorbell address is write-only. Behaviors
on such read access violation is arch-dependent. On
certains platforms, such violation is ignored but read
returns 0.

Hence remove the read access to IPA TX doorbell address
in hal_srng_dst_init_hp() to avoid arch-dependent
behavior.

Change-Id: I3486cd81741922e697e2b3d307db3209b710aa6a
CRs-Fixed: 3339302
This commit is contained in:
Jia Ding
2022-11-17 15:04:11 +08:00
committed by Madan Koyyalamudi
parent 80db72a890
commit a606a71b1e
1 changed files with 2 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files

5
hal/wifi3.0/hal_srng.c
View File

@@ -1407,10 +1407,9 @@ void hal_srng_dst_init_hp(struct hal_soc_handle *hal_soc,
if (vaddr) { if (vaddr) {
*srng->u.dst_ring.hp_addr = srng->u.dst_ring.cached_hp; *srng->u.dst_ring.hp_addr = srng->u.dst_ring.cached_hp;
QDF_TRACE(QDF_MODULE_ID_DP, QDF_TRACE_LEVEL_ERROR, QDF_TRACE(QDF_MODULE_ID_DP, QDF_TRACE_LEVEL_ERROR,
"hp_addr=%pK, cached_hp=%d, hp=%d", "hp_addr=%pK, cached_hp=%d",
(void *)srng->u.dst_ring.hp_addr, (void *)srng->u.dst_ring.hp_addr,
srng->u.dst_ring.cached_hp, srng->u.dst_ring.cached_hp);
*srng->u.dst_ring.hp_addr);
} }
} }