From a606a71b1edbc7b173664829a14f9dbad38a766f Mon Sep 17 00:00:00 2001 From: Jia Ding Date: Thu, 17 Nov 2022 15:04:11 +0800 Subject: [PATCH] qcacmn: Avoid read access to IPA TX doorbell address Below signature is seen on sdxpinn when HOST reads IPA TX doorbell address, which leads to HLOS crash. Internal error: synchronous external abort: 96000010 Indeed IPA TX doorbell address is write-only. Behaviors on such read access violation is arch-dependent. On certains platforms, such violation is ignored but read returns 0. Hence remove the read access to IPA TX doorbell address in hal_srng_dst_init_hp() to avoid arch-dependent behavior. Change-Id: I3486cd81741922e697e2b3d307db3209b710aa6a CRs-Fixed: 3339302 --- hal/wifi3.0/hal_srng.c | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/hal/wifi3.0/hal_srng.c b/hal/wifi3.0/hal_srng.c index a73e62a612..50f223817c 100644 --- a/hal/wifi3.0/hal_srng.c +++ b/hal/wifi3.0/hal_srng.c @@ -1407,10 +1407,9 @@ void hal_srng_dst_init_hp(struct hal_soc_handle *hal_soc, if (vaddr) { *srng->u.dst_ring.hp_addr = srng->u.dst_ring.cached_hp; QDF_TRACE(QDF_MODULE_ID_DP, QDF_TRACE_LEVEL_ERROR, - "hp_addr=%pK, cached_hp=%d, hp=%d", + "hp_addr=%pK, cached_hp=%d", (void *)srng->u.dst_ring.hp_addr, - srng->u.dst_ring.cached_hp, - *srng->u.dst_ring.hp_addr); + srng->u.dst_ring.cached_hp); } }