Преглед изворни кода

disp: msm: sde: add check to fix null pointer dereference

In pstate_cmp the plane_state structures are accessed
without checking it is allocated or not, which leads to
null pointer dereference. To fix it NULL check is added.

Change-Id: I5982138b396b70979205d87bc9aa260d9501fee0
Signed-off-by: Mahadevan <[email protected]>
Mahadevan пре 4 година
родитељ
комит
a3fdf9025e
1 измењених фајлова са 3 додато и 0 уклоњено
  1. 3 0
      msm/sde/sde_crtc.c

+ 3 - 0
msm/sde/sde_crtc.c

@@ -1193,6 +1193,9 @@ static int pstate_cmp(const void *a, const void *b)
 	int pa_zpos, pb_zpos;
 	enum sde_layout pa_layout, pb_layout;
 
+	if ((!pa || !pa->sde_pstate) || (!pb || !pb->sde_pstate))
+		return rc;
+
 	pa_zpos = sde_plane_get_property(pa->sde_pstate, PLANE_PROP_ZPOS);
 	pb_zpos = sde_plane_get_property(pb->sde_pstate, PLANE_PROP_ZPOS);