samsung-sm8650/android_kernel_samsung_sm8650-modules
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

msm: camera: common: Change log type to WARN

Browse Source 
When a request setting could not be applied by any device
on the link, it does not indicate a fatal error. It only
leads to a frame drop. Changing the apply failure logs to
warn as opposed to error.

CRs-Fixed: 2514752
Change-Id: Idbca2dbb06b0bbb4c380264cf31b665188306396
Signed-off-by: Karthik Anantha Ram <kartanan@codeaurora.org>
This commit is contained in:
Karthik Anantha Ram
2019-08-23 17:28:48 -07:00
committed by Gerrit - the friendly Code Review server
parent 6678f1003b
commit 72eeacf17a
2 changed files with 3 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
drivers/cam_isp/cam_isp_context.c
View File

@@ -3841,14 +3841,14 @@ static int __cam_isp_ctx_apply_req(struct cam_context *ctx,
if (ctx_ops->crm_ops.apply_req) { if (ctx_ops->crm_ops.apply_req) {
rc = ctx_ops->crm_ops.apply_req(ctx, apply); rc = ctx_ops->crm_ops.apply_req(ctx, apply);
} else { } else {
CAM_ERR_RATE_LIMIT(CAM_ISP, CAM_WARN_RATE_LIMIT(CAM_ISP,
"No handle function in activated substate %d", "No handle function in activated substate %d",
ctx_isp->substate_activated); ctx_isp->substate_activated);
rc = -EFAULT; rc = -EFAULT;
} }
if (rc) if (rc)
CAM_ERR_RATE_LIMIT(CAM_ISP, CAM_WARN_RATE_LIMIT(CAM_ISP,
"Apply failed in active substate %d rc %d", "Apply failed in active substate %d rc %d",
ctx_isp->substate_activated, rc); ctx_isp->substate_activated, rc);
return rc; return rc;

2
drivers/cam_req_mgr/cam_req_mgr_core.c
View File

@@ -631,7 +631,7 @@ static int __cam_req_mgr_send_req(struct cam_req_mgr_core_link *link,
} }
} }
if (rc < 0) { if (rc < 0) {
CAM_ERR_RATE_LIMIT(CAM_CRM, "APPLY FAILED pd %d req_id %lld", CAM_WARN_RATE_LIMIT(CAM_CRM, "APPLY FAILED pd %d req_id %lld",
dev->dev_info.p_delay, apply_req.request_id); dev->dev_info.p_delay, apply_req.request_id);
/* Apply req failed notify already applied devs */ /* Apply req failed notify already applied devs */
for (; i >= 0; i--) { for (; i >= 0; i--) {