From 72eeacf17aa5cf2d6c76b06e1511a270ae4c7bdc Mon Sep 17 00:00:00 2001 From: Karthik Anantha Ram Date: Fri, 23 Aug 2019 17:28:48 -0700 Subject: [PATCH] msm: camera: common: Change log type to WARN When a request setting could not be applied by any device on the link, it does not indicate a fatal error. It only leads to a frame drop. Changing the apply failure logs to warn as opposed to error. CRs-Fixed: 2514752 Change-Id: Idbca2dbb06b0bbb4c380264cf31b665188306396 Signed-off-by: Karthik Anantha Ram --- drivers/cam_isp/cam_isp_context.c | 4 ++-- drivers/cam_req_mgr/cam_req_mgr_core.c | 2 +- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/cam_isp/cam_isp_context.c b/drivers/cam_isp/cam_isp_context.c index 4144bfc62a..718c01ec8e 100644 --- a/drivers/cam_isp/cam_isp_context.c +++ b/drivers/cam_isp/cam_isp_context.c @@ -3841,14 +3841,14 @@ static int __cam_isp_ctx_apply_req(struct cam_context *ctx, if (ctx_ops->crm_ops.apply_req) { rc = ctx_ops->crm_ops.apply_req(ctx, apply); } else { - CAM_ERR_RATE_LIMIT(CAM_ISP, + CAM_WARN_RATE_LIMIT(CAM_ISP, "No handle function in activated substate %d", ctx_isp->substate_activated); rc = -EFAULT; } if (rc) - CAM_ERR_RATE_LIMIT(CAM_ISP, + CAM_WARN_RATE_LIMIT(CAM_ISP, "Apply failed in active substate %d rc %d", ctx_isp->substate_activated, rc); return rc; diff --git a/drivers/cam_req_mgr/cam_req_mgr_core.c b/drivers/cam_req_mgr/cam_req_mgr_core.c index 6a8e5fed6e..cce35d45b5 100644 --- a/drivers/cam_req_mgr/cam_req_mgr_core.c +++ b/drivers/cam_req_mgr/cam_req_mgr_core.c @@ -631,7 +631,7 @@ static int __cam_req_mgr_send_req(struct cam_req_mgr_core_link *link, } } if (rc < 0) { - CAM_ERR_RATE_LIMIT(CAM_CRM, "APPLY FAILED pd %d req_id %lld", + CAM_WARN_RATE_LIMIT(CAM_CRM, "APPLY FAILED pd %d req_id %lld", dev->dev_info.p_delay, apply_req.request_id); /* Apply req failed notify already applied devs */ for (; i >= 0; i--) {