ソースを参照

qcacld-3.0: sap: Remove logs for cds_get_context() checks

cds_get_context() function already takes care of logging the
caller function name in case of any error.
Hence there is no need to add the error log again.
Getting rid of these unnecessary logs reduces driver memory footprint.

CRs-Fixed: 2815522
Change-Id: I735ba28f98a38e832ecb8781e39d5d8e134ad01f
Srinivas Girigowda 4 年 前
コミット
1e37c63d94
3 ファイル変更4 行追加13 行削除
  1. 1 3
      core/sap/src/sap_api_link_cntl.c
  2. 2 7
      core/sap/src/sap_fsm.c
  3. 1 3
      core/sap/src/sap_module.c

+ 1 - 3
core/sap/src/sap_api_link_cntl.c

@@ -1264,10 +1264,8 @@ void sap_scan_event_callback(struct wlan_objmgr_vdev *vdev,
 	session_id = wlan_vdev_get_id(vdev);
 	scan_id = event->scan_id;
 	mac_handle = cds_get_context(QDF_MODULE_ID_SME);
-	if (!mac_handle) {
-		sap_alert("invalid MAC handle");
+	if (!mac_handle)
 		return;
-	}
 
 	qdf_mtrace(QDF_MODULE_ID_SCAN, QDF_MODULE_ID_SAP, event->type,
 		   event->vdev_id, event->scan_id);

+ 2 - 7
core/sap/src/sap_fsm.c

@@ -876,11 +876,8 @@ QDF_STATUS sap_channel_sel(struct sap_context *sap_context)
 	uint32_t default_op_freq;
 
 	mac_handle = cds_get_context(QDF_MODULE_ID_SME);
-	if (!mac_handle) {
-		/* we have a serious problem */
-		sap_alert("invalid mac_handle");
+	if (!mac_handle)
 		return QDF_STATUS_E_FAULT;
-	}
 
 	mac_ctx = MAC_CONTEXT(mac_handle);
 	if (!mac_ctx) {
@@ -1781,10 +1778,8 @@ bool sap_is_dfs_cac_wait_state(struct sap_context *sap_ctx)
 	}
 
 	mac_handle = cds_get_context(QDF_MODULE_ID_SME);
-	if (!mac_handle) {
-		sap_err("invalid mac_handle");
+	if (!mac_handle)
 		return false;
-	}
 
 	mac_ctx = MAC_CONTEXT(mac_handle);
 	if (!mac_ctx) {

+ 1 - 3
core/sap/src/sap_module.c

@@ -3043,10 +3043,8 @@ qdf_freq_t wlansap_get_chan_band_restrict(struct sap_context *sap_ctx,
 		return 0;
 
 	mac = cds_get_context(QDF_MODULE_ID_PE);
-	if (!mac) {
-		sap_err("Invalid MAC context");
+	if (!mac)
 		return 0;
-	}
 
 	if (ucfg_reg_get_band(mac->pdev, &band) != QDF_STATUS_SUCCESS) {
 		sap_err("Failed to get current band config");