ソースを参照

qcacld-3.0: mac: Remove logs for cds_get_context() checks

cds_get_context() function already takes care of logging the
caller function name in case of any error.
Hence there is no need to add the error log again.
Getting rid of these unnecessary logs reduces driver memory footprint.

CRs-Fixed: 2815522
Change-Id: I8bc78db0276ad0c1547ae0e046d99bf749bd7125
Srinivas Girigowda 4 年 前
コミット
382132b749

+ 1 - 3
core/mac/src/pe/lim/lim_process_message_queue.c

@@ -939,10 +939,8 @@ void lim_handle_sap_beacon(struct wlan_objmgr_pdev *pdev,
 		return;
 
 	mac_ctx = cds_get_context(QDF_MODULE_ID_PE);
-	if (!mac_ctx) {
-		pe_err("Failed to get mac_ctx");
+	if (!mac_ctx)
 		return;
-	}
 
 	filter = &mac_ctx->bcn_filter;
 

+ 1 - 3
core/mac/src/pe/lim/lim_process_mlm_host_roam.c

@@ -333,10 +333,8 @@ QDF_STATUS lim_sta_reassoc_error_handler(struct reassoc_params *param)
 	}
 
 	mac_ctx = cds_get_context(QDF_MODULE_ID_PE);
-	if (!mac_ctx) {
-		pe_err("mac_ctx is NULL");
+	if (!mac_ctx)
 		return QDF_STATUS_E_INVAL;
-	}
 
 	session = param->session;
 	if (param->result_code

+ 1 - 3
core/mac/src/pe/lim/lim_process_mlm_req_messages.c

@@ -212,10 +212,8 @@ lim_mlm_add_bss(struct mac_context *mac_ctx,
 	tp_wma_handle wma = cds_get_context(QDF_MODULE_ID_WMA);
 	struct bss_params *addbss_param = NULL;
 
-	if (!wma) {
-		pe_err("Invalid wma handle");
+	if (!wma)
 		return eSIR_SME_INVALID_PARAMETERS;
-	}
 
 	mlme_obj = wlan_vdev_mlme_get_cmpt_obj(vdev);
 	if (!mlme_obj) {

+ 3 - 6
core/mac/src/pe/lim/lim_process_mlm_rsp_messages.c

@@ -1257,10 +1257,9 @@ QDF_STATUS lim_sta_handle_connect_fail(join_params *param)
 	}
 
 	mac_ctx = cds_get_context(QDF_MODULE_ID_PE);
-	if (!mac_ctx) {
-		pe_err("Mac context is NULL");
+	if (!mac_ctx)
 		return QDF_STATUS_E_INVAL;
-	}
+
 	session = pe_find_session_by_session_id(mac_ctx, param->pe_session_id);
 	if (!session) {
 		pe_err("session is NULL");
@@ -1702,10 +1701,8 @@ lim_process_mlm_del_all_sta_rsp(struct vdev_mlme_obj *vdev_mlme,
 	vdev_id = wlan_vdev_get_id(vdev);
 
 	mac_ctx = cds_get_context(QDF_MODULE_ID_PE);
-	if (!mac_ctx) {
-		pe_err("mac_ctx is NULL");
+	if (!mac_ctx)
 		return QDF_STATUS_E_INVAL;
-	}
 
 	SET_LIM_PROCESS_DEFD_MESGS(mac_ctx, true);
 

+ 0 - 1
core/mac/src/pe/lim/lim_process_sme_req_messages.c

@@ -4721,7 +4721,6 @@ QDF_STATUS lim_sta_mlme_vdev_disconnect_bss(struct vdev_mlme_obj *vdev_mlme,
 
 	mac_ctx = cds_get_context(QDF_MODULE_ID_PE);
 	if (!mac_ctx) {
-		pe_err("mac_ctx is NULL");
 		if (data)
 			qdf_mem_free(data);
 		return QDF_STATUS_E_INVAL;

+ 2 - 3
core/mac/src/pe/lim/lim_send_messages.c

@@ -96,10 +96,9 @@ QDF_STATUS lim_send_switch_chnl_params(struct mac_context *mac,
 	struct vdev_start_response rsp = {0};
 	tp_wma_handle wma = cds_get_context(QDF_MODULE_ID_WMA);
 
-	if (!wma) {
-		pe_err("Invalid wma handle");
+	if (!wma)
 		return QDF_STATUS_E_FAILURE;
-	}
+
 	if (!session) {
 		pe_err("session is NULL");
 		return QDF_STATUS_E_FAILURE;

+ 3 - 8
core/mac/src/pe/lim/lim_utils.c

@@ -8071,7 +8071,6 @@ QDF_STATUS lim_sta_mlme_vdev_start_send(struct vdev_mlme_obj *vdev_mlme,
 
 	mac_ctx = cds_get_context(QDF_MODULE_ID_PE);
 	if (!mac_ctx) {
-		pe_err("mac_ctx is NULL");
 		if (data)
 			qdf_mem_free(data);
 		return QDF_STATUS_E_INVAL;
@@ -8262,10 +8261,8 @@ QDF_STATUS lim_ap_mlme_vdev_start_send(struct vdev_mlme_obj *vdev_mlme,
 	}
 
 	mac_ctx = cds_get_context(QDF_MODULE_ID_PE);
-	if (!mac_ctx) {
-		pe_err("mac_ctx is NULL");
+	if (!mac_ctx)
 		return QDF_STATUS_E_INVAL;
-	}
 
 	session = pe_find_session_by_session_id(mac_ctx,
 						start_req->sessionId);
@@ -8400,7 +8397,6 @@ QDF_STATUS lim_ap_mlme_vdev_start_req_failed(struct vdev_mlme_obj *vdev_mlme,
 
 	mac_ctx = cds_get_context(QDF_MODULE_ID_PE);
 	if (!mac_ctx) {
-		pe_err("mac_ctx is NULL");
 		if (data)
 			qdf_mem_free(data);
 		return QDF_STATUS_E_INVAL;
@@ -8609,10 +8605,9 @@ QDF_STATUS lim_set_ch_phy_mode(struct wlan_objmgr_vdev *vdev, uint8_t dot11mode)
 	enum channel_state ch_state;
 	uint32_t start_ch_freq;
 
-	if (!mac_ctx) {
-		pe_err("Invalid mac context");
+	if (!mac_ctx)
 		return QDF_STATUS_E_FAILURE;
-	}
+
 	mlme_obj = wlan_vdev_mlme_get_cmpt_obj(vdev);
 	if (!mlme_obj) {
 		pe_err("vdev component object is NULL");

+ 2 - 5
core/mac/src/sys/common/src/wlan_qct_sys.c

@@ -154,12 +154,9 @@ static QDF_STATUS sys_mc_process_msg(struct scheduler_msg *pMsg)
 			QDF_TRACE(QDF_MODULE_ID_SYS, QDF_TRACE_LEVEL_ERROR,
 				"Processing SYS MC STOP");
 			mac_handle = cds_get_context(QDF_MODULE_ID_PE);
-			if (!mac_handle) {
-				QDF_TRACE(QDF_MODULE_ID_SYS,
-					QDF_TRACE_LEVEL_ERROR,
-					"%s: Invalid mac_handle", __func__);
+			if (!mac_handle)
 				break;
-			}
+
 			qdf_status = sme_stop(mac_handle);
 			QDF_ASSERT(QDF_IS_STATUS_SUCCESS(qdf_status));
 			qdf_status = mac_stop(mac_handle);