samsung-sm8650/android_kernel_samsung_sm8650-modules
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

qcacmn: remove return value of qdf_debugfs_create_u*

Browse Source 
According to Kernel comment, no one checks the return value of routines:
debugfs_create_u8
debugfs_create_u16
debugfs_create_u32
debugfs_create_u64
debugfs_create_atomic_t
so remove return value of related qdf api.

Change-Id: I7d260bccfce463dddae963c54a776813df116eac
CRs-Fixed: 2666506
This commit is contained in:
bings
2020-04-17 16:44:53 +08:00
committed by nshrivas
parent 67ae88ddbb
commit 131d1bf176
2 changed files with 62 additions and 68 deletions
Download Patch File Download Diff File Expand all files Collapse all files

42
qdf/inc/qdf_debugfs.h
View File

@@ -1,5 +1,5 @@
/*
* Copyright (c) 2017-2019 The Linux Foundation. All rights reserved.
* Copyright (c) 2017-2020 The Linux Foundation. All rights reserved.
*
* Permission to use, copy, modify, and/or distribute this software for
* any purpose with or without fee is hereby granted, provided that the
@@ -144,10 +144,9 @@ void qdf_debugfs_write(qdf_debugfs_file_t file, const uint8_t *buf,
* @parent: parent node. If NULL, defaults to base 'qdf_debugfs_root'
* @value: pointer to a u8 variable (global/static)
*
* Return: dentry for the file; NULL in case of failure.
*
* Return: None
*/
qdf_dentry_t qdf_debugfs_create_u8(const char *name, uint16_t mode,
void qdf_debugfs_create_u8(const char *name, uint16_t mode,
qdf_dentry_t parent, u8 *value);
/**
@@ -157,10 +156,9 @@ qdf_dentry_t qdf_debugfs_create_u8(const char *name, uint16_t mode,
* @parent: parent node. If NULL, defaults to base 'qdf_debugfs_root'
* @value: pointer to a u16 variable (global/static)
*
* Return: dentry for the file; NULL in case of failure.
*
* Return: None
*/
qdf_dentry_t qdf_debugfs_create_u16(const char *name, uint16_t mode,
void qdf_debugfs_create_u16(const char *name, uint16_t mode,
qdf_dentry_t parent, u16 *value);
/**
@@ -170,10 +168,9 @@ qdf_dentry_t qdf_debugfs_create_u16(const char *name, uint16_t mode,
* @parent: parent node. If NULL, defaults to base 'qdf_debugfs_root'
* @value: pointer to a u32 variable (global/static)
*
* Return: dentry for the file; NULL in case of failure.
*
* Return: None
*/
qdf_dentry_t qdf_debugfs_create_u32(const char *name, uint16_t mode,
void qdf_debugfs_create_u32(const char *name, uint16_t mode,
qdf_dentry_t parent, u32 *value);
/**
@@ -183,10 +180,9 @@ qdf_dentry_t qdf_debugfs_create_u32(const char *name, uint16_t mode,
* @parent: parent node. If NULL, defaults to base 'qdf_debugfs_root'
* @value: pointer to a u64 variable (global/static)
*
* Return: dentry for the file; NULL in case of failure.
*
* Return: None
*/
qdf_dentry_t qdf_debugfs_create_u64(const char *name, uint16_t mode,
void qdf_debugfs_create_u64(const char *name, uint16_t mode,
qdf_dentry_t parent, u64 *value);
/**
@@ -196,10 +192,9 @@ qdf_dentry_t qdf_debugfs_create_u64(const char *name, uint16_t mode,
* @parent: parent node. If NULL, defaults to base 'qdf_debugfs_root'
* @value: pointer to an atomic variable (global/static)
*
* Return: dentry for the file; NULL in case of failure.
*
* Return: None
*/
qdf_dentry_t qdf_debugfs_create_atomic(const char *name, uint16_t mode,
void qdf_debugfs_create_atomic(const char *name, uint16_t mode,
qdf_dentry_t parent,
qdf_atomic_t *value);
@@ -320,43 +315,38 @@ static inline void qdf_debugfs_write(qdf_debugfs_file_t file,
{
}
static inline qdf_dentry_t qdf_debugfs_create_u8(const char *name,
static inline void qdf_debugfs_create_u8(const char *name,
uint16_t mode,
qdf_dentry_t parent, u8 *value)
{
return NULL;
}
static inline qdf_dentry_t qdf_debugfs_create_u16(const char *name,
static inline void qdf_debugfs_create_u16(const char *name,
uint16_t mode,
qdf_dentry_t parent,
u16 *value)
{
return NULL;
}
static inline qdf_dentry_t qdf_debugfs_create_u32(const char *name,
static inline void qdf_debugfs_create_u32(const char *name,
uint16_t mode,
qdf_dentry_t parent,
u32 *value)
{
return NULL;
}
static inline qdf_dentry_t qdf_debugfs_create_u64(const char *name,
static inline void qdf_debugfs_create_u64(const char *name,
uint16_t mode,
qdf_dentry_t parent,
u64 *value)
{
return NULL;
}
static inline qdf_dentry_t qdf_debugfs_create_atomic(const char *name,
static inline void qdf_debugfs_create_atomic(const char *name,
uint16_t mode,
qdf_dentry_t parent,
qdf_atomic_t *value)
{
return NULL;
}
static inline qdf_dentry_t debugfs_create_string(const char *name,

36
qdf/linux/src/qdf_debugfs.c
View File

@@ -1,5 +1,5 @@
/*
* Copyright (c) 2017-2019 The Linux Foundation. All rights reserved.
* Copyright (c) 2017-2020 The Linux Foundation. All rights reserved.
*
* Permission to use, copy, modify, and/or distribute this software for
* any purpose with or without fee is hereby granted, provided that the
@@ -331,84 +331,88 @@ qdf_dentry_t qdf_debugfs_create_file(const char *name, uint16_t mode,
}
qdf_export_symbol(qdf_debugfs_create_file);
qdf_dentry_t qdf_debugfs_create_u8(const char *name, uint16_t mode,
void qdf_debugfs_create_u8(const char *name, uint16_t mode,
qdf_dentry_t parent, u8 *value)
{
umode_t filemode;
if (!name)
return NULL;
return;
if (!parent)
parent = qdf_debugfs_get_root();
filemode = qdf_debugfs_get_filemode(mode);
return debugfs_create_u8(name, filemode, parent, value);
debugfs_create_u8(name, filemode, parent, value);
}
qdf_dentry_t qdf_debugfs_create_u16(const char *name, uint16_t mode,
void qdf_debugfs_create_u16(const char *name, uint16_t mode,
qdf_dentry_t parent, u16 *value)
{
umode_t filemode;
if (!name)
return NULL;
return;
if (!parent)
parent = qdf_debugfs_get_root();
filemode = qdf_debugfs_get_filemode(mode);
return debugfs_create_u16(name, filemode, parent, value);
debugfs_create_u16(name, filemode, parent, value);
}
qdf_export_symbol(qdf_debugfs_create_u16);
qdf_dentry_t qdf_debugfs_create_u32(const char *name,
void qdf_debugfs_create_u32(const char *name,
uint16_t mode,
qdf_dentry_t parent, u32 *value)
{
umode_t filemode;
if (!name)
return NULL;
return;
if (!parent)
parent = qdf_debugfs_get_root();
filemode = qdf_debugfs_get_filemode(mode);
return debugfs_create_u32(name, filemode, parent, value);
debugfs_create_u32(name, filemode, parent, value);
}
qdf_export_symbol(qdf_debugfs_create_u32);
qdf_dentry_t qdf_debugfs_create_u64(const char *name, uint16_t mode,
void qdf_debugfs_create_u64(const char *name, uint16_t mode,
qdf_dentry_t parent, u64 *value)
{
umode_t filemode;
if (!name)
return NULL;
return;
if (!parent)
parent = qdf_debugfs_get_root();
filemode = qdf_debugfs_get_filemode(mode);
return debugfs_create_u64(name, filemode, parent, value);
debugfs_create_u64(name, filemode, parent, value);
}
qdf_export_symbol(qdf_debugfs_create_u64);
qdf_dentry_t qdf_debugfs_create_atomic(const char *name, uint16_t mode,
void qdf_debugfs_create_atomic(const char *name, uint16_t mode,
qdf_dentry_t parent, qdf_atomic_t *value)
{
umode_t filemode;
if (!name)
return NULL;
return;
if (!parent)
parent = qdf_debugfs_get_root();
filemode = qdf_debugfs_get_filemode(mode);
return debugfs_create_atomic_t(name, filemode, parent, value);
debugfs_create_atomic_t(name, filemode, parent, value);
}
qdf_export_symbol(qdf_debugfs_create_atomic);
static int qdf_debugfs_string_show(struct seq_file *seq, void *pos)