From 131d1bf1769d0d2f7fb6a99e4bdadfc98d69bb07 Mon Sep 17 00:00:00 2001 From: bings Date: Fri, 17 Apr 2020 16:44:53 +0800 Subject: [PATCH] qcacmn: remove return value of qdf_debugfs_create_u* According to Kernel comment, no one checks the return value of routines: debugfs_create_u8 debugfs_create_u16 debugfs_create_u32 debugfs_create_u64 debugfs_create_atomic_t so remove return value of related qdf api. Change-Id: I7d260bccfce463dddae963c54a776813df116eac CRs-Fixed: 2666506 --- qdf/inc/qdf_debugfs.h | 82 ++++++++++++++++--------------------- qdf/linux/src/qdf_debugfs.c | 48 ++++++++++++---------- 2 files changed, 62 insertions(+), 68 deletions(-) diff --git a/qdf/inc/qdf_debugfs.h b/qdf/inc/qdf_debugfs.h index 46dc3a945a..04708c9448 100644 --- a/qdf/inc/qdf_debugfs.h +++ b/qdf/inc/qdf_debugfs.h @@ -1,5 +1,5 @@ /* - * Copyright (c) 2017-2019 The Linux Foundation. All rights reserved. + * Copyright (c) 2017-2020 The Linux Foundation. All rights reserved. * * Permission to use, copy, modify, and/or distribute this software for * any purpose with or without fee is hereby granted, provided that the @@ -144,11 +144,10 @@ void qdf_debugfs_write(qdf_debugfs_file_t file, const uint8_t *buf, * @parent: parent node. If NULL, defaults to base 'qdf_debugfs_root' * @value: pointer to a u8 variable (global/static) * - * Return: dentry for the file; NULL in case of failure. - * + * Return: None */ -qdf_dentry_t qdf_debugfs_create_u8(const char *name, uint16_t mode, - qdf_dentry_t parent, u8 *value); +void qdf_debugfs_create_u8(const char *name, uint16_t mode, + qdf_dentry_t parent, u8 *value); /** * qdf_debugfs_create_u16() - create a debugfs file for a u16 variable @@ -157,11 +156,10 @@ qdf_dentry_t qdf_debugfs_create_u8(const char *name, uint16_t mode, * @parent: parent node. If NULL, defaults to base 'qdf_debugfs_root' * @value: pointer to a u16 variable (global/static) * - * Return: dentry for the file; NULL in case of failure. - * + * Return: None */ -qdf_dentry_t qdf_debugfs_create_u16(const char *name, uint16_t mode, - qdf_dentry_t parent, u16 *value); +void qdf_debugfs_create_u16(const char *name, uint16_t mode, + qdf_dentry_t parent, u16 *value); /** * qdf_debugfs_create_u32() - create a debugfs file for a u32 variable @@ -170,11 +168,10 @@ qdf_dentry_t qdf_debugfs_create_u16(const char *name, uint16_t mode, * @parent: parent node. If NULL, defaults to base 'qdf_debugfs_root' * @value: pointer to a u32 variable (global/static) * - * Return: dentry for the file; NULL in case of failure. - * + * Return: None */ -qdf_dentry_t qdf_debugfs_create_u32(const char *name, uint16_t mode, - qdf_dentry_t parent, u32 *value); +void qdf_debugfs_create_u32(const char *name, uint16_t mode, + qdf_dentry_t parent, u32 *value); /** * qdf_debugfs_create_u64() - create a debugfs file for a u64 variable @@ -183,11 +180,10 @@ qdf_dentry_t qdf_debugfs_create_u32(const char *name, uint16_t mode, * @parent: parent node. If NULL, defaults to base 'qdf_debugfs_root' * @value: pointer to a u64 variable (global/static) * - * Return: dentry for the file; NULL in case of failure. - * + * Return: None */ -qdf_dentry_t qdf_debugfs_create_u64(const char *name, uint16_t mode, - qdf_dentry_t parent, u64 *value); +void qdf_debugfs_create_u64(const char *name, uint16_t mode, + qdf_dentry_t parent, u64 *value); /** * qdf_debugfs_create_atomic() - create a debugfs file for an atomic variable @@ -196,12 +192,11 @@ qdf_dentry_t qdf_debugfs_create_u64(const char *name, uint16_t mode, * @parent: parent node. If NULL, defaults to base 'qdf_debugfs_root' * @value: pointer to an atomic variable (global/static) * - * Return: dentry for the file; NULL in case of failure. - * + * Return: None */ -qdf_dentry_t qdf_debugfs_create_atomic(const char *name, uint16_t mode, - qdf_dentry_t parent, - qdf_atomic_t *value); +void qdf_debugfs_create_atomic(const char *name, uint16_t mode, + qdf_dentry_t parent, + qdf_atomic_t *value); /** * qdf_debugfs_create_string() - create a debugfs file for a string @@ -320,43 +315,38 @@ static inline void qdf_debugfs_write(qdf_debugfs_file_t file, { } -static inline qdf_dentry_t qdf_debugfs_create_u8(const char *name, - uint16_t mode, - qdf_dentry_t parent, u8 *value) +static inline void qdf_debugfs_create_u8(const char *name, + uint16_t mode, + qdf_dentry_t parent, u8 *value) { - return NULL; } -static inline qdf_dentry_t qdf_debugfs_create_u16(const char *name, - uint16_t mode, - qdf_dentry_t parent, - u16 *value) +static inline void qdf_debugfs_create_u16(const char *name, + uint16_t mode, + qdf_dentry_t parent, + u16 *value) { - return NULL; } -static inline qdf_dentry_t qdf_debugfs_create_u32(const char *name, - uint16_t mode, - qdf_dentry_t parent, - u32 *value) +static inline void qdf_debugfs_create_u32(const char *name, + uint16_t mode, + qdf_dentry_t parent, + u32 *value) { - return NULL; } -static inline qdf_dentry_t qdf_debugfs_create_u64(const char *name, - uint16_t mode, - qdf_dentry_t parent, - u64 *value) +static inline void qdf_debugfs_create_u64(const char *name, + uint16_t mode, + qdf_dentry_t parent, + u64 *value) { - return NULL; } -static inline qdf_dentry_t qdf_debugfs_create_atomic(const char *name, - uint16_t mode, - qdf_dentry_t parent, - qdf_atomic_t *value) +static inline void qdf_debugfs_create_atomic(const char *name, + uint16_t mode, + qdf_dentry_t parent, + qdf_atomic_t *value) { - return NULL; } static inline qdf_dentry_t debugfs_create_string(const char *name, diff --git a/qdf/linux/src/qdf_debugfs.c b/qdf/linux/src/qdf_debugfs.c index da98bb0bbe..14f2c03952 100644 --- a/qdf/linux/src/qdf_debugfs.c +++ b/qdf/linux/src/qdf_debugfs.c @@ -1,5 +1,5 @@ /* - * Copyright (c) 2017-2019 The Linux Foundation. All rights reserved. + * Copyright (c) 2017-2020 The Linux Foundation. All rights reserved. * * Permission to use, copy, modify, and/or distribute this software for * any purpose with or without fee is hereby granted, provided that the @@ -331,84 +331,88 @@ qdf_dentry_t qdf_debugfs_create_file(const char *name, uint16_t mode, } qdf_export_symbol(qdf_debugfs_create_file); -qdf_dentry_t qdf_debugfs_create_u8(const char *name, uint16_t mode, - qdf_dentry_t parent, u8 *value) +void qdf_debugfs_create_u8(const char *name, uint16_t mode, + qdf_dentry_t parent, u8 *value) { umode_t filemode; if (!name) - return NULL; + return; if (!parent) parent = qdf_debugfs_get_root(); filemode = qdf_debugfs_get_filemode(mode); - return debugfs_create_u8(name, filemode, parent, value); + debugfs_create_u8(name, filemode, parent, value); } -qdf_dentry_t qdf_debugfs_create_u16(const char *name, uint16_t mode, - qdf_dentry_t parent, u16 *value) +void qdf_debugfs_create_u16(const char *name, uint16_t mode, + qdf_dentry_t parent, u16 *value) { umode_t filemode; if (!name) - return NULL; + return; if (!parent) parent = qdf_debugfs_get_root(); filemode = qdf_debugfs_get_filemode(mode); - return debugfs_create_u16(name, filemode, parent, value); + debugfs_create_u16(name, filemode, parent, value); } + qdf_export_symbol(qdf_debugfs_create_u16); -qdf_dentry_t qdf_debugfs_create_u32(const char *name, - uint16_t mode, - qdf_dentry_t parent, u32 *value) +void qdf_debugfs_create_u32(const char *name, + uint16_t mode, + qdf_dentry_t parent, u32 *value) { umode_t filemode; if (!name) - return NULL; + return; if (!parent) parent = qdf_debugfs_get_root(); filemode = qdf_debugfs_get_filemode(mode); - return debugfs_create_u32(name, filemode, parent, value); + debugfs_create_u32(name, filemode, parent, value); } + qdf_export_symbol(qdf_debugfs_create_u32); -qdf_dentry_t qdf_debugfs_create_u64(const char *name, uint16_t mode, - qdf_dentry_t parent, u64 *value) +void qdf_debugfs_create_u64(const char *name, uint16_t mode, + qdf_dentry_t parent, u64 *value) { umode_t filemode; if (!name) - return NULL; + return; if (!parent) parent = qdf_debugfs_get_root(); filemode = qdf_debugfs_get_filemode(mode); - return debugfs_create_u64(name, filemode, parent, value); + debugfs_create_u64(name, filemode, parent, value); } + qdf_export_symbol(qdf_debugfs_create_u64); -qdf_dentry_t qdf_debugfs_create_atomic(const char *name, uint16_t mode, - qdf_dentry_t parent, qdf_atomic_t *value) +void qdf_debugfs_create_atomic(const char *name, uint16_t mode, + qdf_dentry_t parent, qdf_atomic_t *value) { umode_t filemode; if (!name) - return NULL; + return; if (!parent) parent = qdf_debugfs_get_root(); filemode = qdf_debugfs_get_filemode(mode); - return debugfs_create_atomic_t(name, filemode, parent, value); + debugfs_create_atomic_t(name, filemode, parent, value); } + qdf_export_symbol(qdf_debugfs_create_atomic); static int qdf_debugfs_string_show(struct seq_file *seq, void *pos)