Jan Kara f9f07b6c13
vfs: Fix data corruption after failed write in __block_write_begin() ...
I've got a report of a file corruption from fsxlinux on ext3. The important
operations to the page were:
mapwrite to a hole
partial write to the page
read - found the page zeroed from the end of the normal write
The culprit seems to be that if get_block() fails in __block_write_begin()
(e.g. transient ENOSPC in ext3), the function does ClearPageUptodate(page).
Thus when we retry the write, the logic in __block_write_begin() thinks zeroing
of the page is needed and overwrites old data. In fact, I don't see why we
should ever need to zero the uptodate bit here - either the page was uptodate
when we entered __block_write_begin() and it should stay so when we leave it,
or it was not uptodate and noone had right to set it uptodate during
__block_write_begin() so it remains !uptodate when we leave as well. So just
remove clearing of the bit.
Signed-off-by: Jan Kara <jack@suse.cz >
Signed-off-by: Al Viro <viro@zeniv.linux.org.uk >
2011-06-16 11:44:46 -04:00
2011-05-28 01:02:53 -04:00
2011-03-31 11:26:23 -03:00
2011-05-28 01:02:53 -04:00
2011-06-16 11:44:46 -04:00
2011-05-30 01:50:53 -04:00
2011-03-31 11:26:23 -03:00
2011-05-28 01:02:50 -04:00
2011-06-07 18:36:59 -07:00
2011-03-31 11:26:23 -03:00
2011-05-26 07:26:53 -04:00
2011-06-08 16:03:29 +00:00
2011-05-28 01:02:53 -04:00
2011-05-28 01:02:54 -04:00
2011-01-13 08:03:23 -08:00
2011-05-19 16:55:28 +09:30
2011-03-22 17:44:17 -07:00
2011-05-26 13:19:00 -07:00
2011-05-29 14:24:25 -05:00
2011-03-10 08:52:07 +01:00
2011-05-26 07:26:57 -04:00
2011-03-15 02:21:44 -04:00
2011-05-26 07:26:56 -04:00
2011-05-27 07:04:40 -04:00
2011-05-27 07:04:40 -04:00
2011-05-31 19:42:24 +09:00
2011-05-10 10:16:21 +02:00
2011-05-25 08:39:44 -07:00
2011-06-03 18:24:58 -04:00
2011-06-07 18:44:10 -07:00
2011-05-28 01:02:52 -04:00
2011-05-28 01:02:52 -04:00
2011-05-28 01:02:52 -04:00
2011-05-28 01:02:54 -04:00
2011-01-07 17:50:26 +11:00
2011-05-26 09:20:31 -07:00
2011-03-24 10:16:26 -07:00
2011-05-24 00:27:53 +02:00
2011-05-26 09:53:20 -07:00
2011-05-28 13:03:41 -07:00
2011-06-07 08:50:59 -04:00
2011-01-25 15:24:47 -05:00
2011-05-28 01:02:51 -04:00
2011-05-28 01:02:54 -04:00
2011-05-28 01:02:53 -04:00
2011-05-29 14:10:13 -07:00
2011-03-31 11:26:23 -03:00
2011-05-29 11:21:12 -07:00
2011-05-28 01:02:51 -04:00
2011-04-07 11:14:49 -07:00
2011-03-31 11:26:23 -03:00
2011-06-03 18:24:58 -04:00
2011-05-28 01:02:52 -04:00
2011-01-07 17:50:26 +11:00
2011-05-30 07:42:51 +02:00
2011-06-12 17:45:28 -04:00
2011-05-16 11:05:00 -07:00
2011-03-10 08:52:07 +01:00
2011-05-25 08:39:26 -07:00
2011-04-14 16:06:56 -07:00
2011-05-28 01:02:51 -04:00
2011-01-07 17:50:26 +11:00
2011-05-29 11:19:45 -07:00
2011-06-12 17:45:41 -04:00
2011-05-28 01:02:50 -04:00
2011-06-12 17:45:34 -04:00
2011-05-28 01:02:52 -04:00
2011-05-28 01:02:51 -04:00
2011-05-27 07:04:40 -04:00
2011-03-24 10:16:26 -07:00
2011-01-16 13:47:07 -05:00
2011-05-28 12:02:09 -04:00
2011-01-07 17:50:29 +11:00
2010-10-14 10:57:40 -07:00
2011-04-14 16:06:55 -07:00
2011-05-03 10:10:51 +10:00
2010-10-29 04:16:28 -04:00
2010-08-17 18:07:43 -07:00
2011-03-17 11:11:05 +01:00
2011-05-28 14:44:46 +02:00
2011-06-01 08:28:47 +02:00
2011-06-16 11:44:46 -04:00
2011-01-13 10:45:01 -08:00
2011-01-07 14:39:20 -08:00
2011-04-09 15:53:56 +02:00
2011-05-25 08:39:26 -07:00
2011-03-24 10:16:26 -07:00
2011-05-25 08:39:26 -07:00
2011-02-21 15:07:04 -08:00
2011-03-31 11:26:23 -03:00
2011-06-09 12:50:05 -07:00
2011-03-23 19:47:13 -07:00
2011-04-14 16:06:56 -07:00
2011-03-21 00:16:09 -04:00
2011-03-16 13:26:17 -07:00
2011-04-28 11:28:20 -07:00
2011-04-17 10:42:01 -07:00
2011-01-16 13:47:07 -05:00
2011-05-27 07:04:40 -04:00
2011-03-23 19:47:13 -07:00
2011-05-27 09:43:00 -04:00
2011-03-24 21:17:51 -04:00
2011-03-21 00:16:08 -04:00
2010-11-15 10:23:31 +01:00
2011-05-26 09:52:14 -07:00
2010-10-27 18:03:12 -07:00
2011-05-26 07:26:50 -04:00
2011-03-24 08:20:39 -07:00
2011-03-16 19:01:29 -07:00
2011-05-25 08:39:26 -07:00
2011-05-26 10:01:43 -06:00
2011-06-16 11:28:16 -04:00
2011-05-26 07:26:44 -04:00
2011-03-14 09:15:28 -04:00
2010-10-15 15:53:27 +02:00
2011-03-21 01:10:41 -04:00
2011-01-20 16:21:59 -08:00
2011-01-07 17:50:33 +11:00
2011-01-25 15:24:47 -05:00
2011-01-12 20:06:58 -05:00
2010-08-09 20:45:05 -07:00
2011-03-21 00:16:08 -04:00
2010-10-25 21:26:12 -04:00
2010-10-26 10:13:10 -07:00
2011-05-23 19:58:53 +02:00
2011-03-15 02:21:45 -04:00
2011-03-14 09:15:28 -04:00
2011-06-03 18:24:58 -04:00
2011-03-24 10:16:26 -07:00
2011-05-23 13:59:53 +02:00
2011-03-23 19:47:13 -07:00
2011-05-28 12:02:09 -04:00
f9f07b6c13