Eric Biggers 2da473e59e
fscrypt: add fscrypt_is_nokey_name() ...
commit 159e1de201b6fca10bfec50405a3b53a561096a8 upstream.
It's possible to create a duplicate filename in an encrypted directory
by creating a file concurrently with adding the encryption key.
Specifically, sys_open(O_CREAT) (or sys_mkdir(), sys_mknod(), or
sys_symlink()) can lookup the target filename while the directory's
encryption key hasn't been added yet, resulting in a negative no-key
dentry. The VFS then calls ->create() (or ->mkdir(), ->mknod(), or
->symlink()) because the dentry is negative. Normally, ->create() would
return -ENOKEY due to the directory's key being unavailable. However,
if the key was added between the dentry lookup and ->create(), then the
filesystem will go ahead and try to create the file.
If the target filename happens to already exist as a normal name (not a
no-key name), a duplicate filename may be added to the directory.
In order to fix this, we need to fix the filesystems to prevent
->create(), ->mkdir(), ->mknod(), and ->symlink() on no-key names.
(->rename() and ->link() need it too, but those are already handled
correctly by fscrypt_prepare_rename() and fscrypt_prepare_link().)
In preparation for this, add a helper function fscrypt_is_nokey_name()
that filesystems can use to do this check. Use this helper function for
the existing checks that fs/crypto/ does for rename and link.
Cc: stable@vger.kernel.org
Link: https://lore.kernel.org/r/20201118075609.120337-2-ebiggers@kernel.org
Signed-off-by: Eric Biggers <ebiggers@google.com >
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org >
2020-12-26 16:02:43 +01:00
2020-09-30 16:37:39 +02:00
2020-11-03 22:30:31 +01:00
2020-10-12 15:29:27 +02:00
2020-08-17 18:54:33 +02:00
2020-10-12 15:29:26 +02:00
2020-07-31 11:49:08 +02:00
2020-10-29 17:22:59 -05:00
2020-09-20 19:01:34 -07:00
2020-11-24 15:13:54 +01:00
2020-10-15 18:42:13 -07:00
2020-09-14 10:54:42 +02:00
2020-10-15 09:46:23 -07:00
2020-10-15 07:57:55 +02:00
2020-08-12 10:57:59 -07:00
2020-10-29 17:22:59 -05:00
2020-08-27 06:55:50 -07:00
2020-10-21 11:22:08 -07:00
2020-12-03 11:18:36 -08:00
2020-09-07 09:16:31 +02:00
2020-10-25 14:51:49 -07:00
2020-06-25 22:25:13 -07:00
2020-12-08 12:57:39 +01:00
2020-06-25 00:50:31 +02:00
2020-06-25 00:50:31 +02:00
2020-08-27 06:55:50 -07:00
2020-09-28 14:53:45 +01:00
2020-09-16 17:38:02 +05:30
2020-11-27 13:18:40 +01:00
2020-10-02 00:01:42 +02:00
2020-10-17 11:18:18 -07:00
2020-07-16 15:35:21 +02:00
2020-09-21 17:43:47 +01:00
2020-07-28 17:11:02 -07:00
2020-06-16 14:19:57 +02:00
2020-10-25 14:51:49 -07:00
2020-10-24 10:39:22 -07:00
2020-09-23 15:29:29 +05:30
2020-11-12 15:05:34 +00:00
2020-10-22 09:44:27 -07:00
2020-10-28 13:18:56 +01:00
2020-07-15 20:34:02 -07:00
2020-07-28 15:51:31 +01:00
2020-10-25 14:51:49 -07:00
2020-09-12 10:45:56 -07:00
2020-09-17 19:21:16 +02:00
2020-10-08 17:17:27 +02:00
2020-10-28 11:13:36 +00:00
2020-09-24 16:44:44 -07:00
2020-07-19 18:16:40 -07:00
2020-06-11 08:03:24 +02:00
2020-06-25 08:23:22 -07:00
2020-06-11 08:03:24 +02:00
2020-07-21 11:12:31 -04:00
2020-07-08 17:20:46 -06:00
2020-09-24 13:43:39 -06:00
2020-07-20 10:27:11 +01:00
2020-08-17 13:47:28 +02:00
2020-10-13 11:37:11 +02:00
2020-07-21 08:24:52 -05:00
2020-06-29 09:09:08 -06:00
2020-08-10 12:16:51 -07:00
2020-10-16 11:11:20 -07:00
2020-07-08 10:48:35 -07:00
2020-10-13 15:05:05 -06:00
2020-07-08 17:05:53 -06:00
2020-10-05 10:47:43 -06:00
2020-10-28 11:26:10 -06:00
2020-12-04 17:27:42 -05:00
2020-11-19 08:55:44 -05:00
2020-08-25 15:00:04 -07:00
2020-08-25 15:00:04 -07:00
2020-08-25 15:00:04 -07:00
2020-10-02 14:59:25 -07:00
2020-10-22 09:59:21 -07:00
2020-07-17 20:18:16 -07:00
2020-10-11 10:21:04 -07:00
2020-07-24 15:41:54 -07:00
2020-09-21 17:16:17 -07:00
2020-06-11 15:14:53 +02:00
2020-09-21 15:00:40 -07:00
2020-10-02 15:00:49 -07:00
2020-08-12 10:57:59 -07:00
2020-06-24 09:16:02 -06:00
2020-12-11 14:02:14 -08:00
2020-10-16 11:11:19 -07:00
2020-10-25 14:51:49 -07:00
2020-08-19 11:04:23 +02:00
2020-07-19 20:14:42 +02:00
2020-06-15 23:08:31 -05:00
2020-07-08 16:20:01 -06:00
2020-07-09 16:28:44 -07:00
2020-07-07 13:34:11 -07:00
2020-08-03 15:07:18 -07:00
2020-09-01 09:19:43 +02:00
2020-10-13 18:38:34 -07:00
2020-10-12 16:44:57 -07:00
2020-10-25 14:51:49 -07:00
2020-10-29 20:01:46 -07:00
2020-11-22 10:48:22 -08:00
2020-11-14 11:26:03 -08:00
2020-11-14 11:26:03 -08:00
2020-06-24 17:08:33 +02:00
2020-08-18 13:45:20 +02:00
2020-08-18 13:45:20 +02:00
2020-06-11 15:14:36 +02:00
2020-07-24 13:56:23 +02:00
2020-09-30 11:50:35 -07:00
2020-10-16 11:11:21 -07:00
2020-09-28 19:47:41 +02:00
2020-09-17 10:19:52 +03:00
2020-10-25 14:51:49 -07:00
2020-11-10 18:31:17 +01:00
2020-10-16 12:21:15 -07:00
2020-10-16 17:21:51 +02:00
2020-10-13 15:58:10 -07:00
2020-06-09 09:39:13 -07:00
2020-07-16 21:49:09 +10:00
2020-06-24 09:16:02 -06:00
2020-10-19 14:28:30 -07:00
2020-09-23 21:29:49 -07:00
2020-09-15 13:51:08 +02:00
2020-10-30 08:37:39 +01:00
2020-09-24 21:56:24 +02:00
2020-08-12 10:57:59 -07:00
2020-09-22 11:27:48 +02:00
2020-07-30 19:26:10 +02:00
2020-09-29 17:50:10 +09:00
2020-10-16 07:28:20 +02:00
2020-10-07 18:08:41 -04:00
2020-10-15 14:43:29 -07:00
2020-09-02 14:39:44 +02:00
2020-10-06 07:07:06 +02:00
2020-09-25 06:12:25 +02:00
2020-07-21 09:42:19 +02:00
2020-10-20 10:41:07 +02:00
2020-10-20 10:41:07 +02:00
2020-07-29 16:14:25 +02:00
2020-09-03 12:21:03 +05:30
2020-07-24 14:33:39 +02:00
2020-10-25 14:51:49 -07:00
2020-08-06 16:13:13 +02:00
2020-06-16 19:25:20 +02:00
2020-09-10 18:19:16 +02:00
2020-10-12 13:38:31 +02:00
2020-07-27 14:29:22 -04:00
2020-12-11 14:02:14 -08:00
2020-06-24 17:16:42 +02:00
2020-10-12 10:51:02 -07:00
2020-07-24 15:03:42 +02:00
2020-10-06 06:16:01 -07:00
2020-10-25 14:51:49 -07:00
2020-08-12 10:57:59 -07:00
2020-09-10 14:03:31 -07:00
2020-07-27 23:24:00 +02:00
2020-10-16 11:11:22 -07:00
2020-08-12 20:42:08 +02:00
2020-09-16 19:27:43 -04:00
2020-06-17 00:07:38 +02:00
2020-07-13 11:03:45 -07:00
2020-10-27 16:22:43 +01:00
2020-10-25 14:51:49 -07:00
2020-10-15 10:46:16 -07:00
2020-07-17 13:12:44 -04:00
2020-08-12 10:57:57 -07:00
2020-07-14 14:45:41 +02:00
2020-09-16 19:12:27 -04:00
2020-07-29 16:14:27 +02:00
2020-11-13 16:07:53 -08:00
2020-06-15 23:08:31 -05:00
2020-12-26 16:02:43 +01:00
2020-07-27 23:25:50 +02:00
2020-07-27 23:24:00 +02:00
2020-07-21 16:02:41 -07:00
2020-10-08 15:29:06 -04:00
2020-08-12 10:57:59 -07:00
2020-11-12 13:59:04 -07:00
2020-10-15 14:43:29 -07:00
2020-07-10 12:00:01 +02:00
2020-07-20 17:00:02 -07:00
2020-06-24 15:45:51 +10:00
2020-09-30 22:44:26 +02:00
2020-08-14 12:52:34 +02:00
2020-08-12 10:57:57 -07:00
2020-10-22 22:44:35 +02:00
2020-07-10 16:24:28 -03:00
2020-08-28 15:12:38 +02:00
2020-08-06 16:13:13 +02:00
2020-10-13 18:38:32 -07:00
2020-10-02 13:16:33 +02:00
2020-08-06 17:54:04 +02:00
2020-09-23 09:42:39 -07:00
2020-09-28 08:55:13 +00:00
2020-09-09 10:22:40 +02:00
2020-09-09 10:38:28 +02:00
2020-09-21 11:45:43 +02:00
2020-07-24 17:12:41 -07:00
2020-06-19 13:41:59 -07:00
2020-09-10 09:32:31 -06:00
2020-10-12 12:08:35 +02:00
2020-10-16 11:11:20 -07:00
2020-09-28 15:07:41 +02:00
2020-09-23 13:24:34 -07:00
2020-08-19 14:02:49 -07:00
2020-07-07 15:48:38 -07:00
2020-10-05 13:37:03 +02:00
2020-06-23 15:11:19 -07:00
2020-09-03 15:17:28 -07:00
2020-08-04 21:02:38 -04:00
2020-10-25 14:51:49 -07:00
2020-10-25 14:51:49 -07:00
2020-07-30 08:22:33 +02:00
2020-07-24 13:56:23 +02:00
2020-08-24 15:09:58 -07:00
2020-10-16 17:35:36 +02:00
2020-11-18 13:09:07 +00:00
2020-09-17 19:21:16 +02:00
2020-09-18 09:13:40 +03:00
2020-09-08 16:28:49 +03:00
2020-10-25 14:51:49 -07:00
2020-11-04 10:22:56 -07:00
2020-08-14 19:56:57 -07:00
2020-08-14 19:56:57 -07:00
2020-07-24 12:42:42 -07:00
2020-09-04 11:16:09 +02:00
2020-10-20 07:10:14 -06:00
2020-11-04 08:52:46 -08:00
2020-10-14 12:08:34 -07:00
2020-09-25 16:30:06 +02:00
2020-10-16 11:11:18 -07:00
2020-06-08 11:05:56 -07:00
2020-09-16 08:54:53 -05:00
2020-08-31 13:08:10 -07:00
2020-06-28 17:01:20 +02:00
2020-10-06 11:28:03 +01:00
2020-07-27 08:55:04 +01:00
2020-07-04 10:02:06 +02:00
2020-11-30 12:21:31 +01:00
2020-08-26 12:41:56 +02:00
2020-07-04 10:02:06 +02:00
2020-10-08 18:00:08 +02:00
2020-11-19 22:38:29 -05:00
2020-10-29 13:17:58 -05:00
2020-10-16 11:11:19 -07:00
2020-06-19 14:17:05 -06:00
2020-07-08 15:59:57 -07:00
2020-10-13 18:38:32 -07:00
2020-08-24 15:09:32 -07:00
2020-10-05 13:37:04 +02:00
2020-09-04 12:46:06 +01:00
2020-10-25 14:51:49 -07:00
2020-07-29 23:47:53 +10:00
2020-09-28 12:14:08 +01:00
2020-10-11 10:31:11 -07:00
2020-07-23 10:33:12 +02:00
2020-10-12 14:21:15 -07:00
2020-09-04 09:25:20 -07:00
2020-06-11 13:25:53 -07:00
2020-08-06 16:13:13 +02:00
2020-10-23 03:42:13 -04:00
2020-07-29 16:14:29 +02:00
2020-07-09 13:29:42 -04:00
2020-07-22 14:41:29 +02:00
2020-08-12 10:57:59 -07:00
2020-07-22 14:42:07 +02:00
2020-09-02 11:31:23 -06:00
2020-07-28 19:29:22 -06:00
2020-07-01 07:27:24 -06:00
2020-10-25 14:51:49 -07:00
2020-07-20 17:59:43 -07:00
2020-10-16 11:11:20 -07:00
2020-10-09 08:53:08 +02:00
2020-10-09 08:55:17 +02:00
2020-09-05 12:14:30 -07:00
2020-10-07 09:23:39 +02:00
2020-10-25 14:51:49 -07:00
2020-06-22 16:28:34 -07:00
2020-10-15 07:49:46 +02:00
2020-09-23 18:02:49 -07:00
2020-10-13 18:38:35 -07:00
2020-11-26 09:35:49 -08:00
2020-11-22 10:48:22 -08:00
2020-08-12 10:57:56 -07:00
2020-10-13 18:38:28 -07:00
2020-09-28 12:16:13 +02:00
2020-10-02 11:33:47 +02:00
2020-09-11 17:41:55 -07:00
2020-08-12 10:58:02 -07:00
2020-10-16 11:11:19 -07:00
2020-08-28 12:37:42 +02:00
2020-08-14 19:56:56 -07:00
2020-10-12 10:40:34 -07:00
2020-11-02 12:14:19 -08:00
2020-09-04 12:46:07 +01:00
2020-10-13 18:38:31 -07:00
2020-08-26 12:41:53 +02:00
2020-08-07 11:33:21 -07:00
2020-10-16 11:11:19 -07:00
2020-07-23 09:12:15 +02:00
2020-10-28 14:08:54 +00:00
2020-10-25 14:51:49 -07:00
2020-08-27 16:06:47 -04:00
2020-09-25 17:48:54 +10:00
2020-07-24 15:41:54 -07:00
2020-07-24 15:41:54 -07:00
2020-09-16 16:52:37 +02:00
2020-08-06 16:13:13 +02:00
2020-10-05 18:40:01 -07:00
2020-09-10 13:30:22 -07:00
2020-11-28 12:04:57 -08:00
2020-10-30 12:57:39 +01:00
2020-10-30 12:57:39 +01:00
2020-07-24 15:41:54 -07:00
2020-10-21 18:24:08 -07:00
2020-07-15 07:45:25 -07:00
2020-10-07 14:28:39 -04:00
2020-10-07 14:28:39 -04:00
2020-07-13 17:52:46 -04:00
2020-11-30 10:52:22 -05:00
2020-10-21 10:31:20 -04:00
2020-10-07 14:28:39 -04:00
2020-09-22 13:58:40 +02:00
2020-10-16 11:11:18 -07:00
2020-10-16 11:11:19 -07:00
2020-07-21 10:50:36 +01:00
2020-09-01 09:58:03 +02:00
2020-11-22 10:48:22 -08:00
2020-07-29 07:45:20 +02:00
2020-07-29 07:45:21 +02:00
2020-07-29 17:12:08 +02:00
2020-07-29 17:12:08 +02:00
2020-10-25 14:51:49 -07:00
2020-07-28 22:49:52 +02:00
2020-07-28 15:51:32 +01:00
2020-07-01 10:49:02 +02:00
2020-07-28 15:51:32 +01:00
2020-07-28 15:51:32 +01:00
2020-09-24 19:49:36 -07:00
2020-10-25 14:51:49 -07:00
2020-09-25 17:48:54 +10:00
2020-10-13 18:38:35 -07:00
2020-10-17 11:18:18 -07:00
2020-07-23 17:34:18 +10:00
2020-10-16 11:11:15 -07:00
2020-09-25 18:01:48 -04:00
2020-07-16 12:32:25 -07:00
2020-10-16 11:11:16 -07:00
2020-08-07 11:33:29 -07:00
2020-11-22 10:48:22 -08:00
2020-08-12 12:09:36 -07:00
2020-07-24 09:50:41 -05:00
2020-09-17 12:27:43 -05:00
2020-09-17 16:44:03 -05:00
2020-10-22 13:00:44 -07:00
2020-08-31 12:52:33 -07:00
2020-09-11 09:30:01 +03:00
2020-08-07 11:33:26 -07:00
2020-10-25 14:51:49 -07:00
2020-10-06 07:29:36 -06:00
2020-09-16 16:26:56 +02:00
2020-11-09 18:12:34 +01:00
2020-11-09 18:12:34 +01:00
2020-11-16 16:57:18 +01:00
2020-10-28 11:41:15 -06:00
2020-08-31 12:52:33 -07:00
2020-10-18 09:27:10 -07:00
2020-10-01 19:14:36 -07:00
2020-07-28 17:07:06 -07:00
2020-10-16 17:53:22 +02:00
2020-08-04 12:44:53 +02:00
2020-11-16 09:37:01 -08:00
2020-09-28 16:38:11 +02:00
2020-08-12 10:57:59 -07:00
2020-08-06 16:50:59 +02:00
2020-08-26 16:53:26 +02:00
2020-09-10 19:27:59 +02:00
2020-10-24 20:21:57 +02:00
2020-09-14 09:45:34 -07:00
2020-10-25 14:51:49 -07:00
2020-09-03 21:26:24 -04:00
2020-10-14 16:09:32 -07:00
2020-09-11 21:47:10 -07:00
2020-09-22 17:50:32 +02:00
2020-06-15 14:10:03 +02:00
2020-06-15 17:38:53 +10:00
2020-09-27 13:29:49 -07:00
2020-07-21 10:50:37 +01:00
2020-06-17 20:42:11 +02:00
2020-08-26 20:15:34 +01:00
2020-09-14 15:45:25 +02:00
2020-10-24 10:39:22 -07:00
2020-09-17 13:00:46 -04:00
2020-10-13 08:41:26 -04:00
2020-08-03 23:24:26 -07:00
2020-10-13 18:38:28 -07:00
2020-07-27 17:46:24 +09:00
2020-07-27 17:46:24 +09:00
2020-09-10 11:19:29 +02:00
2020-06-29 11:58:11 -07:00
2020-08-24 18:36:09 -07:00
2020-09-23 19:32:09 -07:00
2020-10-25 14:51:49 -07:00
2020-08-24 18:37:56 -07:00
2020-08-24 18:37:56 -07:00
2020-10-28 11:41:15 -06:00
2020-10-05 18:35:30 +01:00
2020-07-27 14:31:13 -04:00
2020-10-13 19:20:54 -05:00
2020-08-18 17:06:15 +02:00
2020-07-28 17:09:49 -07:00
2020-06-30 17:18:56 -04:00
2020-06-09 09:39:14 -07:00
2020-10-04 19:51:43 -07:00
2020-07-16 13:35:25 +02:00
2020-07-22 13:39:31 +02:00
2020-07-16 23:19:51 +02:00
2020-10-05 20:45:45 -03:00
2020-07-20 11:50:47 +01:00
2020-11-22 13:26:07 -08:00
2020-09-14 07:31:03 +01:00
2020-06-15 23:08:32 -05:00
2020-08-04 21:00:11 -07:00
2020-12-10 16:01:47 -08:00
2020-08-18 13:45:20 +02:00
2020-11-06 10:05:18 -08:00
2020-10-14 18:07:50 +02:00
2020-07-29 17:14:38 +02:00
2020-10-25 14:51:49 -07:00
2020-06-11 15:19:17 +02:00
2020-08-07 11:33:24 -07:00
2020-10-29 13:17:58 -05:00
2020-10-15 18:42:13 -07:00
2020-10-11 18:09:44 -07:00
2020-08-07 11:33:25 -07:00
2020-10-25 11:39:02 -07:00
2020-08-07 11:33:25 -07:00
2020-09-04 11:50:50 -07:00
2020-09-04 11:50:50 -07:00
2020-09-30 11:50:35 -07:00
2020-06-30 09:34:23 -04:00
2020-08-10 12:06:44 -07:00
2020-06-17 18:33:13 +02:00
2020-10-25 14:51:49 -07:00
2020-10-22 14:15:51 -06:00
2020-09-19 13:13:39 -07:00
2020-09-18 14:24:16 +01:00
2020-09-26 22:55:05 -04:00
2020-09-18 16:45:50 -04:00
2020-09-01 09:58:06 +02:00
2020-10-02 21:18:25 +02:00
2020-12-08 14:52:29 -08:00
2020-09-30 10:50:30 +02:00
2020-10-06 11:18:04 +02:00
2020-09-23 10:43:19 -06:00
2020-10-13 18:38:30 -07:00
2020-10-13 18:38:30 -07:00
2020-11-16 14:58:23 -08:00
2020-10-25 14:51:49 -07:00
2020-08-14 19:56:56 -07:00
2020-10-02 12:02:30 +02:00
2020-10-17 15:05:30 -06:00
2020-07-27 14:11:22 +02:00
2020-09-10 13:15:40 -07:00
2020-08-21 08:55:13 +02:00
2020-10-12 12:08:36 +02:00
2020-06-22 19:58:06 +03:00
2020-06-15 23:08:32 -05:00
2020-10-26 11:48:11 +01:00
2020-07-08 11:14:22 +02:00
2020-08-06 16:13:13 +02:00
2020-08-23 10:38:24 +02:00
2020-09-24 22:12:18 +02:00
2020-09-16 22:05:18 +10:00
2020-06-29 12:01:44 -07:00
2020-07-24 08:16:01 +03:00
2020-07-24 09:26:23 +03:00
2020-10-25 14:51:49 -07:00
2020-10-05 12:43:53 +02:00
2020-10-17 15:04:36 -06:00
2020-10-15 15:51:28 -07:00
2020-10-25 14:51:49 -07:00
2020-12-04 17:39:58 +01:00
2020-07-29 16:14:18 +02:00
2020-09-17 19:21:16 +02:00
2020-10-24 10:57:57 -07:00
2020-10-12 16:35:51 -07:00
2020-07-04 09:35:36 -05:00
2020-09-10 14:03:31 -07:00
2020-12-21 13:30:08 +01:00
2020-09-25 16:33:58 +02:00
2020-07-07 11:58:59 -05:00
2020-07-20 15:04:32 +02:00
2020-07-10 13:45:32 +02:00
2020-10-23 11:55:27 -04:00
2020-08-01 11:28:17 +02:00
2020-09-08 13:33:11 +02:00
2020-08-06 16:13:13 +02:00
2020-08-05 11:08:41 -04:00
2020-10-23 11:00:57 -07:00
2020-08-18 10:01:44 +02:00
2020-08-05 09:30:19 -04:00
2020-08-18 10:01:44 +02:00
2020-09-04 09:31:54 -07:00
2020-10-18 09:27:10 -07:00
2020-10-16 11:11:19 -07:00
2020-07-10 14:55:25 +02:00
2020-06-24 17:08:31 +02:00
2020-10-05 13:21:49 +02:00
2020-09-17 10:26:41 -07:00
2020-10-01 09:40:35 -04:00
2020-08-05 18:43:02 +02:00
2020-08-12 10:57:59 -07:00
2020-08-06 16:13:13 +02:00
2020-10-20 14:39:37 -07:00
2020-08-09 13:58:04 -07:00
2020-08-12 10:57:59 -07:00
2020-08-12 10:57:59 -07:00
2020-08-12 10:57:59 -07:00
2020-12-06 10:19:07 -08:00
2da473e59e