Yang Shi f4dbba5919 locktorture: Fix potential memory leak with rw lock test ...

When running locktorture module with the below commands with kmemleak enabled:

$ modprobe locktorture torture_type=rw_lock_irq
$ rmmod locktorture

The below kmemleak got caught:

root@10:~# echo scan > /sys/kernel/debug/kmemleak
[  323.197029] kmemleak: 2 new suspected memory leaks (see /sys/kernel/debug/kmemleak)
root@10:~# cat /sys/kernel/debug/kmemleak
unreferenced object 0xffffffc07592d500 (size 128):
  comm "modprobe", pid 368, jiffies 4294924118 (age 205.824s)
  hex dump (first 32 bytes):
    00 00 00 00 00 00 00 00 c3 7b 02 00 00 00 00 00  .........{......
    00 00 00 00 00 00 00 00 d7 9b 02 00 00 00 00 00  ................
  backtrace:
    [<ffffff80081e5a88>] create_object+0x110/0x288
    [<ffffff80086c6078>] kmemleak_alloc+0x58/0xa0
    [<ffffff80081d5acc>] __kmalloc+0x234/0x318
    [<ffffff80006fa130>] 0xffffff80006fa130
    [<ffffff8008083ae4>] do_one_initcall+0x44/0x138
    [<ffffff800817e28c>] do_init_module+0x68/0x1cc
    [<ffffff800811c848>] load_module+0x1a68/0x22e0
    [<ffffff800811d340>] SyS_finit_module+0xe0/0xf0
    [<ffffff80080836f0>] el0_svc_naked+0x24/0x28
    [<ffffffffffffffff>] 0xffffffffffffffff
unreferenced object 0xffffffc07592d480 (size 128):
  comm "modprobe", pid 368, jiffies 4294924118 (age 205.824s)
  hex dump (first 32 bytes):
    00 00 00 00 00 00 00 00 3b 6f 01 00 00 00 00 00  ........;o......
    00 00 00 00 00 00 00 00 23 6a 01 00 00 00 00 00  ........#j......
  backtrace:
    [<ffffff80081e5a88>] create_object+0x110/0x288
    [<ffffff80086c6078>] kmemleak_alloc+0x58/0xa0
    [<ffffff80081d5acc>] __kmalloc+0x234/0x318
    [<ffffff80006fa22c>] 0xffffff80006fa22c
    [<ffffff8008083ae4>] do_one_initcall+0x44/0x138
    [<ffffff800817e28c>] do_init_module+0x68/0x1cc
    [<ffffff800811c848>] load_module+0x1a68/0x22e0
    [<ffffff800811d340>] SyS_finit_module+0xe0/0xf0
    [<ffffff80080836f0>] el0_svc_naked+0x24/0x28
    [<ffffffffffffffff>] 0xffffffffffffffff

It is because cxt.lwsa and cxt.lrsa don't get freed in module_exit, so free
them in lock_torture_cleanup() and free writer_tasks if reader_tasks is
failed at memory allocation.

Signed-off-by: Yang Shi <yang.shi@linaro.org>
Signed-off-by: Paul E. McKenney <paulmck@linux.vnet.ibm.com>
Reviewed-by: Josh Triplett <josh@joshtriplett.org>

2017-01-14 21:36:06 -08:00

..

lockdep_internals.h

lockdep: Limit static allocations if PROVE_LOCKING_SMALL is defined

2016-11-18 11:33:19 -08:00

lockdep_proc.c

Replace <asm/uaccess.h> with <linux/uaccess.h> globally

2016-12-24 11:46:01 -08:00

lockdep_states.h

locking: Move the lockdep code to kernel/locking/

2013-11-06 07:55:08 +01:00

lockdep.c

Merge tag 'xfs-for-linus-4.10-rc1' of git://git.kernel.org/pub/scm/linux/kernel/git/dgc/linux-xfs

2016-12-14 21:35:31 -08:00

locktorture.c

locktorture: Fix potential memory leak with rw lock test

2017-01-14 21:36:06 -08:00

Makefile

locking/lglock: Remove lglock implementation

2016-09-22 15:25:56 +02:00

mcs_spinlock.h

locking/core: Remove cpu_relax_lowlatency() users

2016-11-16 10:15:10 +01:00

mutex-debug.c

locking/mutex: Rework mutex::owner

2016-10-25 11:31:50 +02:00

mutex-debug.h

locking/mutex: Rework mutex::owner

2016-10-25 11:31:50 +02:00

mutex.c

locking/mutex: Break out of expensive busy-loop on {mutex,rwsem}_spin_on_owner() when owner vCPU is preempted

2016-11-22 12:48:10 +01:00

mutex.h

locking/mutex: Rework mutex::owner

2016-10-25 11:31:50 +02:00

osq_lock.c

locking/osq: Break out of spin-wait busy waiting loop for a preempted vCPU in osq_lock()

2016-11-22 12:48:10 +01:00

percpu-rwsem.c

locking/percpu-rwsem: Optimize readers and reduce global impact

2016-08-10 14:34:01 +02:00

qrwlock.c

locking/core: Remove cpu_relax_lowlatency() users

2016-11-16 10:15:10 +01:00

qspinlock_paravirt.h

locking/pv-qspinlock: Use cmpxchg_release() in __pv_queued_spin_unlock()

2016-09-22 15:25:51 +02:00

qspinlock_stat.h

don't open-code file_inode()

2016-12-04 18:29:28 -05:00

qspinlock.c

locking/qspinlock: Use __this_cpu_dec() instead of full-blown this_cpu_dec()

2016-06-27 11:37:41 +02:00

rtmutex_common.h

locking/rtmutex: Get rid of RT_MUTEX_OWNER_MASKALL

2016-12-02 11:13:57 +01:00

rtmutex-debug.c

rtmutex: Cleanup deadlock detector debug logic

2014-06-21 22:05:30 +02:00

rtmutex-debug.h

rtmutex: Cleanup deadlock detector debug logic

2014-06-21 22:05:30 +02:00

rtmutex.c

locking/rtmutex: Explain locking rules for rt_mutex_proxy_unlock()/init_proxy_locked()

2016-12-02 11:13:57 +01:00

rtmutex.h

rtmutex: Cleanup deadlock detector debug logic

2014-06-21 22:05:30 +02:00

rwsem-spinlock.c

locking/rwsem: Introduce basis for down_write_killable()

2016-04-13 10:42:20 +02:00

rwsem-xadd.c

locking/mutex: Break out of expensive busy-loop on {mutex,rwsem}_spin_on_owner() when owner vCPU is preempted

2016-11-22 12:48:10 +01:00

rwsem.c

locking/rwsem: Add reader-owned state to the owner field

2016-06-08 15:16:59 +02:00

rwsem.h

locking/rwsem: Protect all writes to owner by WRITE_ONCE()

2016-06-08 15:16:59 +02:00

semaphore.c

locking/semaphore: Resolve some shadow warnings

2014-09-04 07:17:24 +02:00

spinlock_debug.c

locking: Move the spinlock code to kernel/locking/

2013-11-06 07:55:21 +01:00

spinlock.c

spinlock: Add spin_lock_bh_nested()

2015-01-03 14:32:57 -05:00