ed3bb00702
C-SKY syscall arguments are located in orig_a0,a1,a2,a3,regs[0],regs[1]
fields of struct pt_regs.
Due to an off-by-one bug and a bug in pointer arithmetic
syscall_get_arguments() was reading orig_a0,regs[1..5] fields instead.
Likewise, syscall_set_arguments() was writing orig_a0,regs[1..5] fields
instead.
Link: http://lkml.kernel.org/r/20190329171230.GB32456@altlinux.org
Fixes: 4859bfca11 ("csky: System Call")
Cc: Ingo Molnar <mingo@redhat.com>
Cc: Kees Cook <keescook@chromium.org>
Cc: Andy Lutomirski <luto@amacapital.net>
Cc: Will Drewry <wad@chromium.org>
Cc: stable@vger.kernel.org # v4.20+
Tested-by: Guo Ren <ren_guo@c-sky.com>
Acked-by: Guo Ren <ren_guo@c-sky.com>
Signed-off-by: Dmitry V. Levin <ldv@altlinux.org>
Signed-off-by: Steven Rostedt (VMware) <rostedt@goodmis.org>
81 lines
1.5 KiB
C
81 lines
1.5 KiB
C
/* SPDX-License-Identifier: GPL-2.0 */
|
|
|
|
#ifndef __ASM_SYSCALL_H
|
|
#define __ASM_SYSCALL_H
|
|
|
|
#include <linux/sched.h>
|
|
#include <linux/err.h>
|
|
#include <abi/regdef.h>
|
|
#include <uapi/linux/audit.h>
|
|
|
|
static inline int
|
|
syscall_get_nr(struct task_struct *task, struct pt_regs *regs)
|
|
{
|
|
return regs_syscallid(regs);
|
|
}
|
|
|
|
static inline void
|
|
syscall_rollback(struct task_struct *task, struct pt_regs *regs)
|
|
{
|
|
regs->a0 = regs->orig_a0;
|
|
}
|
|
|
|
static inline long
|
|
syscall_get_error(struct task_struct *task, struct pt_regs *regs)
|
|
{
|
|
unsigned long error = regs->a0;
|
|
|
|
return IS_ERR_VALUE(error) ? error : 0;
|
|
}
|
|
|
|
static inline long
|
|
syscall_get_return_value(struct task_struct *task, struct pt_regs *regs)
|
|
{
|
|
return regs->a0;
|
|
}
|
|
|
|
static inline void
|
|
syscall_set_return_value(struct task_struct *task, struct pt_regs *regs,
|
|
int error, long val)
|
|
{
|
|
regs->a0 = (long) error ?: val;
|
|
}
|
|
|
|
static inline void
|
|
syscall_get_arguments(struct task_struct *task, struct pt_regs *regs,
|
|
unsigned int i, unsigned int n, unsigned long *args)
|
|
{
|
|
BUG_ON(i + n > 6);
|
|
if (i == 0) {
|
|
args[0] = regs->orig_a0;
|
|
args++;
|
|
n--;
|
|
} else {
|
|
i--;
|
|
}
|
|
memcpy(args, ®s->a1 + i, n * sizeof(args[0]));
|
|
}
|
|
|
|
static inline void
|
|
syscall_set_arguments(struct task_struct *task, struct pt_regs *regs,
|
|
unsigned int i, unsigned int n, const unsigned long *args)
|
|
{
|
|
BUG_ON(i + n > 6);
|
|
if (i == 0) {
|
|
regs->orig_a0 = args[0];
|
|
args++;
|
|
n--;
|
|
} else {
|
|
i--;
|
|
}
|
|
memcpy(®s->a1 + i, args, n * sizeof(regs->a1));
|
|
}
|
|
|
|
static inline int
|
|
syscall_get_arch(void)
|
|
{
|
|
return AUDIT_ARCH_CSKY;
|
|
}
|
|
|
|
#endif /* __ASM_SYSCALL_H */
|