Vladimir Oltean e3da59f428 net: phy: prevent stale pointer dereference in phy_init() ...

[ Upstream commit 1c613beaf877c0c0d755853dc62687e2013e55c4 ]

mdio_bus_init() and phy_driver_register() both have error paths, and if
those are ever hit, ethtool will have a stale pointer to the
phy_ethtool_phy_ops stub structure, which references memory from a
module that failed to load (phylib).

It is probably hard to force an error in this code path even manually,
but the error teardown path of phy_init() should be the same as
phy_exit(), which is now simply not the case.

Fixes: 55d8f053ce ("net: phy: Register ethtool PHY operations")
Link: https://lore.kernel.org/netdev/ZLaiJ4G6TaJYGJyU@shell.armlinux.org.uk/
Suggested-by: Russell King (Oracle) <linux@armlinux.org.uk>
Signed-off-by: Vladimir Oltean <vladimir.oltean@nxp.com>
Link: https://lore.kernel.org/r/20230720000231.1939689-1-vladimir.oltean@nxp.com
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
Signed-off-by: Sasha Levin <sashal@kernel.org>

2023-07-27 08:44:43 +02:00

..

mscc

net: phy: mscc: enable VSC8501/2 RGMII RX clock

2023-06-05 09:07:04 +02:00

adin.c

…

amd.c

…

aquantia_hwmon.c

…

aquantia_main.c

net: phy: aquantia: wait for the suspend/resume operations to finish

2022-09-28 11:10:31 +02:00

aquantia.h

…

at803x.c

…

ax88796b.c

…

bcm7xxx.c

net: phy: bcm7xxx: Fixed indirect MMD operations

2021-10-06 15:55:58 +02:00

bcm63xx.c

…

bcm87xx.c

…

bcm54140.c

…

bcm84881.c

…

bcm-cygnus.c

…

bcm-phy-lib.c

net: phy: broadcom: Only advertise EEE for supported modes

2021-04-14 08:42:08 +02:00

bcm-phy-lib.h

…

broadcom.c

net: phy: broadcom: Fix brcm_fet_config_init()

2022-04-08 14:40:29 +02:00

cicada.c

…

cortina.c

…

davicom.c

…

dp83tc811.c

…

dp83640_reg.h

ptp: dp83640: don't define PAGE0

2021-09-22 12:27:56 +02:00

dp83640.c

…

dp83822.c

net: phy: dp83822: Fix null pointer access on DP83825/DP83826 devices

2023-02-15 17:22:12 +01:00

dp83848.c

…

dp83867.c

Revert "net: phy: dp83867: perform soft reset and retain established link"

2023-06-28 10:28:13 +02:00

dp83869.c

net: phy: dp83869: fix default value for tx-/rx-internal-delay

2023-04-05 11:23:50 +02:00

et1011c.c

…

fixed_phy.c

…

icplus.c

…

intel-xway.c

net: phy: intel-xway: enable integrated led functions

2021-05-14 09:50:41 +02:00

Kconfig

…

linkmode.c

…

lxt.c

net: phy: introduce phydev->port

2021-03-30 14:32:05 +02:00

Makefile

…

marvell10g.c

net: phy: marvell10g: fix return value on error

2022-05-09 09:05:05 +02:00

marvell.c

net: phy: marvell: Fix invalid comparison in the resume and suspend functions

2022-03-23 09:13:27 +01:00

mdio_bus.c

net: mdio: validate parameter addr in mdiobus_get_phy()

2023-02-01 08:23:13 +01:00

mdio_device.c

net: mdio: introduce a shutdown method to mdio device drivers

2021-10-09 14:40:56 +02:00

mdio_devres.c

net: mdio: fix owner field for mdio buses registered using device-tree

2023-04-05 11:23:34 +02:00

mdio-boardinfo.c

…

mdio-boardinfo.h

…

meson-gxl.c

net: phy: meson-gxl: use MMD access dummy stubs for GXL, internal PHY

2023-02-15 17:22:24 +01:00

micrel.c

net: phy: micrel: Allow probing without .driver_data

2022-06-09 10:20:55 +02:00

microchip_t1.c

…

microchip.c

net: lan78xx: fix accessing the LAN7800's internal phy specific registers from the MAC driver

2023-03-17 08:45:11 +01:00

mii_timestamper.c

…

national.c

…

nxp-tja11xx.c

…

phy_device.c

net: phy: prevent stale pointer dereference in phy_init()

2023-07-27 08:44:43 +02:00

phy_led_triggers.c

…

phy-c45.c

…

phy-core.c

net: phy: prefer 1000baseT over 1000baseKX

2022-01-27 10:54:15 +01:00

phy.c

net: phy: Ensure state transitions are processed from phy_stop()

2023-04-05 11:23:34 +02:00

phylink.c

net: phylink: Force retrigger in case of latched link-fail indicator

2021-12-01 09:19:07 +01:00

qsemi.c

…

realtek.c

net: phy: realtek: add delay to fix RXC generation issue

2021-07-19 09:44:49 +02:00

rockchip.c

…

sfp-bus.c

net: sfp: add 2500base-X quirk for Lantech SFP module

2022-04-13 21:01:00 +02:00

sfp.c

net: sfp: initialize sfp->i2c_block_size at sfp allocation

2023-04-20 12:10:27 +02:00

sfp.h

…

smsc.c

net: phy: smsc: bail out in lan87xx_read_status if genphy_read_status fails

2023-03-22 13:29:58 +01:00

spi_ks8995.c

…

ste10Xp.c

…

swphy.c

…

swphy.h

…

teranetics.c

…

uPD60620.c

…

vitesse.c

…

xilinx_gmii2rgmii.c

net: phy: xgmiitorgmii: Fix refcount leak in xgmiitorgmii_probe

2023-01-14 10:16:47 +01:00