xiaomi-sm8450/android_kernel_xiaomi_sm8450
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity
Files
db19c91c3b75cf8ece3ffd92a4e84a306a7547b0
android_kernel_xiaomi_sm8450/fs
History
Kees Cook db19c91c3b exec: change uselib(2) IS_SREG() failure to EACCES 
Patch series "Relocate execve() sanity checks", v2.

While looking at the code paths for the proposed O_MAYEXEC flag, I saw
some things that looked like they should be fixed up.

  exec: Change uselib(2) IS_SREG() failure to EACCES
	This just regularizes the return code on uselib(2).

  exec: Move S_ISREG() check earlier
	This moves the S_ISREG() check even earlier than it was already.

  exec: Move path_noexec() check earlier
	This adds the path_noexec() check to the same place as the
	S_ISREG() check.

This patch (of 3):

Change uselib(2)' S_ISREG() error return to EACCES instead of EINVAL so
the behavior matches execve(2), and the seemingly documented value.  The
"not a regular file" failure mode of execve(2) is explicitly
documented[1], but it is not mentioned in uselib(2)[2] which does,
however, say that open(2) and mmap(2) errors may apply.  The documentation
for open(2) does not include a "not a regular file" error[3], but mmap(2)
does[4], and it is EACCES.

[1] http://man7.org/linux/man-pages/man2/execve.2.html#ERRORS
[2] http://man7.org/linux/man-pages/man2/uselib.2.html#ERRORS
[3] http://man7.org/linux/man-pages/man2/open.2.html#ERRORS
[4] http://man7.org/linux/man-pages/man2/mmap.2.html#ERRORS

Signed-off-by: Kees Cook <keescook@chromium.org>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Acked-by: Christian Brauner <christian.brauner@ubuntu.com>
Cc: Aleksa Sarai <cyphar@cyphar.com>
Cc: Alexander Viro <viro@zeniv.linux.org.uk>
Cc: Dmitry Vyukov <dvyukov@google.com>
Cc: Eric Biggers <ebiggers3@gmail.com>
Cc: Tetsuo Handa <penguin-kernel@I-love.SAKURA.ne.jp>
Link: http://lkml.kernel.org/r/20200605160013.3954297-1-keescook@chromium.org
Link: http://lkml.kernel.org/r/20200605160013.3954297-2-keescook@chromium.org
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
2020-08-12 10:58:01 -07:00
..
9p
9p: read only once on O_NONBLOCK
2020-03-27 09:29:56 +00:00
adfs
block: move struct block_device to blk_types.h
2020-06-24 09:16:02 -06:00
affs
block: move block-related definitions out of fs.h
2020-06-24 09:16:02 -06:00
afs
Merge tag 'uninit-macro-v5.9-rc1' of git://git.kernel.org/pub/scm/linux/kernel/git/kees/linux
2020-08-04 13:49:43 -07:00
autofs
autofs: switch to kernel_write
2020-07-08 08:27:56 +02:00
befs
block: move struct block_device to blk_types.h
2020-06-24 09:16:02 -06:00
bfs
docs: filesystems: fix renamed references
2020-04-20 15:45:22 -06:00
btrfs
Merge branch 'work.misc' of git://git.kernel.org/pub/scm/linux/kernel/git/viro/vfs
2020-08-07 21:14:30 -07:00
cachefiles
cachefiles: switch to kernel_write
2020-07-08 08:27:56 +02:00
ceph
ceph: skip checking caps when session reconnecting and releasing reqs
2020-06-01 13:22:53 +02:00
cifs
Merge branch 'akpm' (patches from Andrew)
2020-08-07 11:39:33 -07:00
coda
docs: filesystems: convert coda.txt to ReST
2020-05-05 09:22:21 -06:00
configfs
Merge tag 'docs-5.8' of git://git.lwn.net/linux
2020-06-01 15:45:27 -07:00
cramfs
docs: filesystems: fix renamed references
2020-04-20 15:45:22 -06:00
crypto
mm, treewide: rename kzfree() to kfree_sensitive()
2020-08-07 11:33:22 -07:00
debugfs
Merge git://git.kernel.org/pub/scm/linux/kernel/git/netdev/net-next
2020-08-05 20:13:21 -07:00
devpts
…
dlm
Merge tag 'dlm-5.9' of git://git.kernel.org/pub/scm/linux/kernel/git/teigland/linux-dlm
2020-08-06 19:44:25 -07:00
ecryptfs
mm, treewide: rename kzfree() to kfree_sensitive()
2020-08-07 11:33:22 -07:00
efivarfs
efi/efivars: Expose RT service availability via efivars abstraction
2020-07-09 10:14:29 +03:00
efs
block: move struct block_device to blk_types.h
2020-06-24 09:16:02 -06:00
erofs
Merge tag 'erofs-for-5.9-rc1' of git://git.kernel.org/pub/scm/linux/kernel/git/xiang/erofs
2020-08-06 19:22:51 -07:00
exfat
exfat: fix name_hash computation on big endian systems
2020-07-21 10:44:19 +09:00
exportfs
…
ext2
ext2: ext2.h: fix duplicated word + typos
2020-07-27 10:58:06 +02:00
ext4
Merge tag 'iomap-5.9-merge-5' of git://git.kernel.org/pub/scm/fs/xfs/xfs-linux
2020-08-06 19:35:12 -07:00
f2fs
Merge tag 'f2fs-for-5.9-rc1' of git://git.kernel.org/pub/scm/linux/kernel/git/jaegeuk/f2fs
2020-08-10 18:33:22 -07:00
fat
fat: fix fat_ra_init() for data clusters == 0
2020-08-12 10:58:01 -07:00
freevxfs
…
fscache
Merge git://git.kernel.org/pub/scm/linux/kernel/git/netdev/net-next
2020-06-03 16:27:18 -07:00
fuse
Merge tag 'uninit-macro-v5.9-rc1' of git://git.kernel.org/pub/scm/linux/kernel/git/kees/linux
2020-08-04 13:49:43 -07:00
gfs2
Merge tag 'gfs2-for-5.9' of git://git.kernel.org/pub/scm/linux/kernel/git/gfs2/linux-gfs2
2020-08-10 18:22:43 -07:00
hfs
block: move block-related definitions out of fs.h
2020-06-24 09:16:02 -06:00
hfsplus
treewide: Remove uninitialized_var() usage
2020-07-16 12:35:15 -07:00
hostfs
hostfs: Use kasprintf() instead of fixed buffer formatting
2020-03-29 23:23:00 +02:00
hpfs
hpfs: fix warning due to superfluous semicolon
2020-06-06 10:08:17 -07:00
hugetlbfs
hugetlbfs: prevent filesystem stacking of hugetlbfs
2020-08-12 10:57:56 -07:00
iomap
iomap: fall back to buffered writes for invalidation failures
2020-08-05 09:24:16 -07:00
isofs
Merge tag 'uninit-macro-v5.9-rc1' of git://git.kernel.org/pub/scm/linux/kernel/git/kees/linux
2020-08-04 13:49:43 -07:00
jbd2
Merge tag 'ext4-for-linus-5.8-rc1-2' of git://git.kernel.org/pub/scm/linux/kernel/git/tytso/ext4
2020-06-15 09:32:10 -07:00
jffs2
Merge tag 'for-linus-5.9-rc1' of git://git.kernel.org/pub/scm/linux/kernel/git/rw/ubifs
2020-08-10 18:20:04 -07:00
jfs
block: move struct block_device to blk_types.h
2020-06-24 09:16:02 -06:00
kernfs
fsnotify: pass dir and inode arguments to fsnotify()
2020-07-27 23:15:48 +02:00
lockd
proc: convert everything to "struct proc_ops"
2020-02-04 03:05:26 +00:00
minix
fs/minix: remove expected error message in block_to_path()
2020-08-12 10:58:00 -07:00
nfs
Merge tag 'locking-urgent-2020-08-10' of git://git.kernel.org/pub/scm/linux/kernel/git/tip/tip
2020-08-10 19:07:44 -07:00
nfs_common
…
nfsd
Merge tag 'nfsd-5.9' of git://git.linux-nfs.org/projects/cel/cel-2.6
2020-08-09 13:58:04 -07:00
nilfs2
nilfs2: use a more common logging style
2020-08-12 10:58:01 -07:00
nls
treewide: replace '---help---' in Kconfig files with 'help'
2020-06-14 01:57:21 +09:00
notify
fanotify: compare fsid when merging name event
2020-07-28 10:58:07 +02:00
ntfs
ntfs: fix ntfs_test_inode and ntfs_init_locked_inode function type
2020-08-07 11:33:21 -07:00
ocfs2
Merge branch 'work.misc' of git://git.kernel.org/pub/scm/linux/kernel/git/viro/vfs
2020-08-07 21:14:30 -07:00
omfs
treewide: Remove uninitialized_var() usage
2020-07-16 12:35:15 -07:00
openpromfs
…
orangefs
Merge tag 'for-linus-5.8-ofs1' of git://git.kernel.org/pub/scm/linux/kernel/git/hubcap/linux
2020-06-05 16:44:36 -07:00
overlayfs
Merge tag 'uninit-macro-v5.9-rc1' of git://git.kernel.org/pub/scm/linux/kernel/git/kees/linux
2020-08-04 13:49:43 -07:00
proc
mm, oom: make the calculation of oom badness more accurate
2020-08-12 10:57:56 -07:00
pstore
pstore: Fix linking when crypto API disabled
2020-07-06 19:42:31 -07:00
qnx4
…
qnx6
fs: convert mpage_readpages to mpage_readahead
2020-06-02 10:59:07 -07:00
quota
Merge tag 'for_v5.9-rc1' of git://git.kernel.org/pub/scm/linux/kernel/git/jack/linux-fs
2020-08-06 19:28:26 -07:00
ramfs
fs_parse: fold fs_parameter_desc/fs_parameter_spec
2020-02-07 14:48:37 -05:00
reiserfs
Merge tag 'for_v5.9-rc1' of git://git.kernel.org/pub/scm/linux/kernel/git/jack/linux-fs
2020-08-06 19:28:26 -07:00
romfs
treewide: replace '---help---' in Kconfig files with 'help'
2020-06-14 01:57:21 +09:00
squashfs
squashfs: fix length field overlap check in metadata reading
2020-07-24 12:42:41 -07:00
sysfs
Merge tag 'for-linus' of git://git.kernel.org/pub/scm/linux/kernel/git/rdma/rdma
2020-06-05 14:05:57 -07:00
sysv
docs: filesystems: fix renamed references
2020-04-20 15:45:22 -06:00
tracefs
…
ubifs
Merge tag 'for-linus-5.9-rc1' of git://git.kernel.org/pub/scm/linux/kernel/git/rw/ubifs
2020-08-10 18:20:04 -07:00
udf
Merge tag 'for_v5.9-rc1' of git://git.kernel.org/pub/scm/linux/kernel/git/jack/linux-fs
2020-08-06 19:28:26 -07:00
ufs
fs/ufs: avoid potential u32 multiplication overflow
2020-08-12 10:58:01 -07:00
unicode
.gitignore: add SPDX License Identifier
2020-03-25 11:50:48 +01:00
vboxsf
vboxsf: don't use the source name in the bdi name
2020-05-07 08:45:47 -06:00
verity
fs-verity: use smp_load_acquire() for ->i_verity_info
2020-07-21 16:02:41 -07:00
xfs
Merge tag 'xfs-5.9-merge-7' of git://git.kernel.org/pub/scm/fs/xfs/xfs-linux
2020-08-07 10:57:29 -07:00
zonefs
Merge tag 'iomap-5.9-merge-5' of git://git.kernel.org/pub/scm/fs/xfs/xfs-linux
2020-08-06 19:35:12 -07:00
aio.c
mm: remove unnecessary wrapper function do_mmap_pgoff()
2020-08-07 11:33:27 -07:00
anon_inodes.c
…
attr.c
…
bad_inode.c
fs: move the fiemap definitions out of fs.h
2020-06-03 23:16:55 -04:00
binfmt_aout.c
exec: Rename flush_old_exec begin_new_exec
2020-05-07 16:55:47 -05:00
binfmt_elf_fdpic.c
Merge branch 'work.fdpic' of git://git.kernel.org/pub/scm/linux/kernel/git/viro/vfs
2020-08-07 13:29:39 -07:00
binfmt_elf.c
kill elf_fpxregs_t
2020-07-27 14:29:23 -04:00
binfmt_em86.c
Merge branch 'akpm' (patches from Andrew)
2020-06-04 19:18:29 -07:00
binfmt_flat.c
Merge branch 'uaccess.misc' of git://git.kernel.org/pub/scm/linux/kernel/git/viro/vfs
2020-06-10 16:02:54 -07:00
binfmt_misc.c
Merge branch 'akpm' (patches from Andrew)
2020-06-04 19:18:29 -07:00
binfmt_script.c
Merge branch 'akpm' (patches from Andrew)
2020-06-04 19:18:29 -07:00
block_dev.c
Merge tag 'for-5.9/io_uring-20200802' of git://git.kernel.dk/linux-block
2020-08-03 13:01:22 -07:00
buffer.c
Merge tag 'for-5.9/block-20200802' of git://git.kernel.dk/linux-block
2020-08-03 11:57:03 -07:00
char_dev.c
vfs: allow unprivileged whiteout creation
2020-05-14 16:44:23 +02:00
compat_binfmt_elf.c
Merge tag 'core_core_updates_for_5.8' of git://git.kernel.org/pub/scm/linux/kernel/git/tip/tip
2020-06-05 13:45:21 -07:00
compat.c
…
coredump.c
coredump: add %f for executable filename
2020-08-12 10:58:01 -07:00
d_path.c
…
dax.c
dax,iomap: Add helper dax_iomap_zero() to zero a range
2020-04-02 19:15:03 -07:00
dcache.c
vfs: Use sequence counter with associated spinlock
2020-07-29 16:14:27 +02:00
dcookies.c
…
direct-io.c
block: remove the bd_queue field from struct block_device
2020-07-01 08:08:20 -06:00
drop_caches.c
sysctl: pass kernel pointers to ->proc_handler
2020-04-27 02:07:40 -04:00
eventfd.c
eventfd: convert to f_op->read_iter()
2020-05-06 22:33:43 -04:00
eventpoll.c
epoll: call final ep_events_available() check under the lock
2020-05-14 10:00:35 -07:00
exec.c
exec: change uselib(2) IS_SREG() failure to EACCES
2020-08-12 10:58:01 -07:00
fcntl.c
fcntl: Distribute switch variables for initialization
2020-03-03 10:55:06 -05:00
fhandle.c
…
file_table.c
Revert "fs: Do not check if there is a fsnotify watcher on pseudo inodes"
2020-06-29 09:40:55 -07:00
file.c
Merge branch 'hch.init_path' of git://git.kernel.org/pub/scm/linux/kernel/git/viro/vfs
2020-08-07 09:40:34 -07:00
filesystems.c
fs/filesystems.c: downgrade user-reachable WARN_ONCE() to pr_warn_once()
2020-04-10 15:36:22 -07:00
fs_context.c
vfs: don't parse "silent" option
2020-05-14 16:44:25 +02:00
fs_parser.c
fs_parse: remove pr_notice() about each validation
2020-04-02 09:35:26 -07:00
fs_pin.c
…
fs_struct.c
vfs: Use sequence counter with associated spinlock
2020-07-29 16:14:27 +02:00
fs_types.c
…
fs-writeback.c
Merge tag 'ext4_for_linus' of git://git.kernel.org/pub/scm/linux/kernel/git/tytso/ext4
2020-06-05 16:19:28 -07:00
fsopen.c
add prefix to fs_context->log
2020-02-07 14:48:35 -05:00
init.c
init: add an init_dup helper
2020-08-04 21:02:38 -04:00
inode.c
Merge tag 'afs-next-20200604' of git://git.kernel.org/pub/scm/linux/kernel/git/dhowells/linux-fs
2020-06-05 16:26:36 -07:00
internal.h
Merge branch 'hch.init_path' of git://git.kernel.org/pub/scm/linux/kernel/git/viro/vfs
2020-08-07 09:40:34 -07:00
io_uring.c
Merge tag 'for-5.9/io_uring-20200802' of git://git.kernel.dk/linux-block
2020-08-03 13:01:22 -07:00
io-wq.c
io-wq: update hash bits
2020-07-25 09:47:44 -06:00
io-wq.h
io_uring/io-wq: move RLIMIT_FSIZE to io-wq
2020-07-24 13:00:44 -06:00
ioctl.c
fs: remove ksys_ioctl
2020-07-31 08:16:01 +02:00
Kconfig
tmpfs: support 64-bit inums per-sb
2020-08-07 11:33:24 -07:00
Kconfig.binfmt
treewide: replace '---help---' in Kconfig files with 'help'
2020-06-14 01:57:21 +09:00
libfs.c
block: remove the error_sector argument to blkdev_issue_flush
2020-05-22 08:45:46 -06:00
locks.c
Merge tag 'nfsd-5.9' of git://git.linux-nfs.org/projects/cel/cel-2.6
2020-08-09 13:58:04 -07:00
Makefile
init: add an init_mount helper
2020-07-31 08:17:51 +02:00
mbcache.c
…
mount.h
proc/mounts: add cursor
2020-05-14 16:44:24 +02:00
mpage.c
fs: convert mpage_readpages to mpage_readahead
2020-06-02 10:59:07 -07:00
namei.c
init: add an init_mknod helper
2020-07-31 08:17:54 +02:00
namespace.c
Merge branch 'fixes' of git://git.kernel.org/pub/scm/linux/kernel/git/viro/vfs
2020-08-07 21:03:25 -07:00
no-block.c
…
nsfs.c
nsproxy: attach to namespaces via pidfds
2020-05-13 11:41:22 +02:00
open.c
Merge branch 'hch.init_path' of git://git.kernel.org/pub/scm/linux/kernel/git/viro/vfs
2020-08-07 09:40:34 -07:00
pipe.c
Merge tag 'notifications-20200601' of git://git.kernel.org/pub/scm/linux/kernel/git/dhowells/linux-fs
2020-06-13 09:56:21 -07:00
pnode.c
propagate_one(): mnt_set_mountpoint() needs mount_lock
2020-04-27 10:37:14 -04:00
pnode.h
…
posix_acl.c
vfs: clean up posix_acl_permission() logic aroudn MAY_NOT_BLOCK
2020-06-08 11:04:19 -07:00
proc_namespace.c
Merge branch 'proc-linus' of git://git.kernel.org/pub/scm/linux/kernel/git/ebiederm/user-namespace
2020-06-04 13:54:34 -07:00
read_write.c
initrd: switch initrd loading to struct file based APIs
2020-07-30 08:22:47 +02:00
readdir.c
fs: remove ksys_getdents64
2020-07-31 08:16:00 +02:00
select.c
pselect6() and friends: take handling the combined 6th/7th args into helper
2020-05-29 19:10:42 -04:00
seq_file.c
fs/seq_file.c: seq_read: Update pr_info_ratelimited
2020-06-04 19:06:25 -07:00
signalfd.c
fs/signalfd.c: fix inconsistent return codes for signalfd4
2020-08-12 10:58:01 -07:00
splice.c
Merge tag 'notifications-20200601' of git://git.kernel.org/pub/scm/linux/kernel/git/dhowells/linux-fs
2020-06-13 09:56:21 -07:00
stack.c
…
stat.c
Merge tag 'vfs-5.8-merge-1' of git://git.kernel.org/pub/scm/fs/xfs/xfs-linux
2020-06-02 19:45:12 -07:00
statfs.c
…
super.c
Merge branch 'work.misc' of git://git.kernel.org/pub/scm/linux/kernel/git/viro/vfs
2020-06-10 16:09:11 -07:00
sync.c
Merge tag 'ovl-update-5.8' of git://git.kernel.org/pub/scm/linux/kernel/git/mszeredi/vfs
2020-06-09 15:40:50 -07:00
timerfd.c
…
userfaultfd.c
Merge tag 'locking-urgent-2020-08-10' of git://git.kernel.org/pub/scm/linux/kernel/git/tip/tip
2020-08-10 19:07:44 -07:00
utimes.c
fs: expose utimes_common
2020-07-31 08:16:01 +02:00
xattr.c
xattr: add a function to check if a namespace is supported
2020-07-13 17:27:03 -04:00