f632a8170a
Pull driver core and debugfs updates from Greg KH:
"Here is the "big" driver core and debugfs changes for 5.3-rc1
It's a lot of different patches, all across the tree due to some api
changes and lots of debugfs cleanups.
Other than the debugfs cleanups, in this set of changes we have:
- bus iteration function cleanups
- scripts/get_abi.pl tool to display and parse Documentation/ABI
entries in a simple way
- cleanups to Documenatation/ABI/ entries to make them parse easier
due to typos and other minor things
- default_attrs use for some ktype users
- driver model documentation file conversions to .rst
- compressed firmware file loading
- deferred probe fixes
All of these have been in linux-next for a while, with a bunch of
merge issues that Stephen has been patient with me for"
* tag 'driver-core-5.3-rc1' of git://git.kernel.org/pub/scm/linux/kernel/git/gregkh/driver-core: (102 commits)
debugfs: make error message a bit more verbose
orangefs: fix build warning from debugfs cleanup patch
ubifs: fix build warning after debugfs cleanup patch
driver: core: Allow subsystems to continue deferring probe
drivers: base: cacheinfo: Ensure cpu hotplug work is done before Intel RDT
arch_topology: Remove error messages on out-of-memory conditions
lib: notifier-error-inject: no need to check return value of debugfs_create functions
swiotlb: no need to check return value of debugfs_create functions
ceph: no need to check return value of debugfs_create functions
sunrpc: no need to check return value of debugfs_create functions
ubifs: no need to check return value of debugfs_create functions
orangefs: no need to check return value of debugfs_create functions
nfsd: no need to check return value of debugfs_create functions
lib: 842: no need to check return value of debugfs_create functions
debugfs: provide pr_fmt() macro
debugfs: log errors when something goes wrong
drivers: s390/cio: Fix compilation warning about const qualifiers
drivers: Add generic helper to match by of_node
driver_find_device: Unify the match function with class_find_device()
bus_find_device: Unify the match callback with class_find_device
...
152 lines
2.6 KiB
Plaintext
152 lines
2.6 KiB
Plaintext
// SPDX-License-Identifier: GPL-2.0-only
|
|
/// Find uses of standard freeing functons on values allocated using devm_
|
|
/// functions. Values allocated using the devm_functions are freed when
|
|
/// the device is detached, and thus the use of the standard freeing
|
|
/// function would cause a double free.
|
|
/// See Documentation/driver-model/devres.rst for more information.
|
|
///
|
|
/// A difficulty of detecting this problem is that the standard freeing
|
|
/// function might be called from a different function than the one
|
|
/// containing the allocation function. It is thus necessary to make the
|
|
/// connection between the allocation function and the freeing function.
|
|
/// Here this is done using the specific argument text, which is prone to
|
|
/// false positives. There is no rule for the request_region and
|
|
/// request_mem_region variants because this heuristic seems to be a bit
|
|
/// less reliable in these cases.
|
|
///
|
|
// Confidence: Moderate
|
|
// Copyright: (C) 2011 Julia Lawall, INRIA/LIP6.
|
|
// Copyright: (C) 2011 Gilles Muller, INRIA/LiP6.
|
|
// URL: http://coccinelle.lip6.fr/
|
|
// Comments:
|
|
// Options: --no-includes --include-headers
|
|
|
|
virtual org
|
|
virtual report
|
|
virtual context
|
|
|
|
@r depends on context || org || report@
|
|
expression x;
|
|
@@
|
|
|
|
(
|
|
x = devm_kmalloc(...)
|
|
|
|
|
x = devm_kvasprintf(...)
|
|
|
|
|
x = devm_kasprintf(...)
|
|
|
|
|
x = devm_kzalloc(...)
|
|
|
|
|
x = devm_kmalloc_array(...)
|
|
|
|
|
x = devm_kcalloc(...)
|
|
|
|
|
x = devm_kstrdup(...)
|
|
|
|
|
x = devm_kmemdup(...)
|
|
|
|
|
x = devm_get_free_pages(...)
|
|
|
|
|
x = devm_request_irq(...)
|
|
|
|
|
x = devm_ioremap(...)
|
|
|
|
|
x = devm_ioremap_nocache(...)
|
|
|
|
|
x = devm_ioport_map(...)
|
|
)
|
|
|
|
@safe depends on context || org || report exists@
|
|
expression x;
|
|
position p;
|
|
@@
|
|
|
|
(
|
|
x = kmalloc(...)
|
|
|
|
|
x = kvasprintf(...)
|
|
|
|
|
x = kasprintf(...)
|
|
|
|
|
x = kzalloc(...)
|
|
|
|
|
x = kmalloc_array(...)
|
|
|
|
|
x = kcalloc(...)
|
|
|
|
|
x = kstrdup(...)
|
|
|
|
|
x = kmemdup(...)
|
|
|
|
|
x = get_free_pages(...)
|
|
|
|
|
x = request_irq(...)
|
|
|
|
|
x = ioremap(...)
|
|
|
|
|
x = ioremap_nocache(...)
|
|
|
|
|
x = ioport_map(...)
|
|
)
|
|
...
|
|
(
|
|
kfree@p(x)
|
|
|
|
|
kzfree@p(x)
|
|
|
|
|
__krealloc@p(x, ...)
|
|
|
|
|
krealloc@p(x, ...)
|
|
|
|
|
free_pages@p(x, ...)
|
|
|
|
|
free_page@p(x)
|
|
|
|
|
free_irq@p(x)
|
|
|
|
|
iounmap@p(x)
|
|
|
|
|
ioport_unmap@p(x)
|
|
)
|
|
|
|
@pb@
|
|
expression r.x;
|
|
position p != safe.p;
|
|
@@
|
|
|
|
(
|
|
* kfree@p(x)
|
|
|
|
|
* kzfree@p(x)
|
|
|
|
|
* __krealloc@p(x, ...)
|
|
|
|
|
* krealloc@p(x, ...)
|
|
|
|
|
* free_pages@p(x, ...)
|
|
|
|
|
* free_page@p(x)
|
|
|
|
|
* free_irq@p(x)
|
|
|
|
|
* iounmap@p(x)
|
|
|
|
|
* ioport_unmap@p(x)
|
|
)
|
|
|
|
@script:python depends on org@
|
|
p << pb.p;
|
|
@@
|
|
|
|
msg="WARNING: invalid free of devm_ allocated data"
|
|
coccilib.org.print_todo(p[0], msg)
|
|
|
|
@script:python depends on report@
|
|
p << pb.p;
|
|
@@
|
|
|
|
msg="WARNING: invalid free of devm_ allocated data"
|
|
coccilib.report.print_report(p[0], msg)
|
|
|