Yu Kuai
c09cdf6eb8
scsi: scsi_dh_alua: Fix memleak for 'qdata' in alua_activate()
[ Upstream commit a13faca032acbf2699293587085293bdfaafc8ae ]
If alua_rtpg_queue() failed from alua_activate(), then 'qdata' is not
freed, which will cause following memleak:
unreferenced object 0xffff88810b2c6980 (size 32):
comm "kworker/u16:2", pid 635322, jiffies 4355801099 (age 1216426.076s)
hex dump (first 32 bytes):
00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 ................
40 39 24 c1 ff ff ff ff 00 f8 ea 0a 81 88 ff ff @9$.............
backtrace:
[<0000000098f3a26d>] alua_activate+0xb0/0x320
[<000000003b529641>] scsi_dh_activate+0xb2/0x140
[<000000007b296db3>] activate_path_work+0xc6/0xe0 [dm_multipath]
[<000000007adc9ace>] process_one_work+0x3c5/0x730
[<00000000c457a985>] worker_thread+0x93/0x650
[<00000000cb80e628>] kthread+0x1ba/0x210
[<00000000a1e61077>] ret_from_fork+0x22/0x30
Fix the problem by freeing 'qdata' in error path.
Fixes: 625fe857e4 ("scsi: scsi_dh_alua: Check scsi_device_get() return value")
Signed-off-by: Yu Kuai <yukuai3@huawei.com>
Link: https://lore.kernel.org/r/20230315062154.668812-1-yukuai1@huaweicloud.com
Reviewed-by: Benjamin Block <bblock@linux.ibm.com>
Reviewed-by: Bart Van Assche <bvanassche@acm.org>
Signed-off-by: Martin K. Petersen <martin.petersen@oracle.com>
Signed-off-by: Sasha Levin <sashal@kernel.org>
2023-04-05 11:23:33 +02:00
..
2020-12-30 11:53:02 +01:00
2021-07-25 14:36:16 +02:00
2023-03-11 16:39:37 +01:00
2021-07-20 16:05:39 +02:00
2020-10-14 15:15:35 -07:00
2022-04-20 09:23:16 +02:00
2022-04-13 21:00:55 +02:00
2022-02-08 18:30:39 +01:00
2022-04-20 09:23:16 +02:00
2021-11-18 14:04:18 +01:00
2022-04-20 09:23:16 +02:00
2020-10-16 12:21:15 -07:00
2023-04-05 11:23:33 +02:00
2020-03-11 23:07:59 -04:00
2020-10-14 15:15:35 -07:00
2023-01-14 10:15:52 +01:00
2021-02-07 15:37:14 +01:00
2023-02-01 08:23:17 +01:00
2022-12-02 17:39:58 +01:00
2022-04-20 09:23:21 +02:00
2021-07-25 14:36:16 +02:00
2022-04-13 21:00:59 +02:00
2022-10-26 13:25:37 +02:00
2022-09-15 11:32:04 +02:00
2023-03-17 08:45:12 +01:00
2023-03-22 13:29:56 +01:00
2022-04-20 09:23:24 +02:00
2021-09-18 13:40:14 +02:00
2022-04-20 09:23:15 +02:00
2022-10-26 13:25:11 +02:00
2022-04-27 13:53:54 +02:00
2023-03-11 16:40:05 +01:00
2022-04-20 09:23:16 +02:00
2022-08-21 15:15:59 +02:00
2023-01-14 10:15:52 +01:00
2020-10-23 16:19:02 -07:00
2022-08-31 17:15:24 +02:00
2020-03-25 11:50:48 +01:00
2022-10-26 13:25:52 +02:00
2019-10-23 17:23:44 +02:00
2020-10-23 16:19:02 -07:00
2020-09-25 06:20:43 +02:00
2020-06-09 09:39:13 -07:00
2020-06-09 09:39:13 -07:00
2021-11-26 10:39:10 +01:00
2022-04-13 21:00:58 +02:00
2020-03-26 21:10:53 -04:00
2019-11-12 22:21:34 -05:00
2019-11-12 22:21:35 -05:00
2021-09-18 13:40:35 +02:00
2021-06-03 09:00:43 +02:00
2020-02-24 14:54:25 -05:00
2020-04-01 22:03:04 -04:00
2022-06-09 10:21:24 +02:00
2020-09-01 22:15:47 -04:00
2020-03-11 23:07:59 -04:00
2020-08-23 17:36:59 -05:00
2019-12-19 22:08:51 -05:00
2020-09-02 22:49:07 -04:00
2019-07-30 12:17:28 -04:00
2020-07-08 01:12:44 -04:00
2021-07-14 16:56:40 +02:00
2020-08-23 17:36:59 -05:00
2020-03-17 13:36:10 -04:00
2020-10-07 21:48:28 -04:00
2020-06-09 09:39:13 -07:00
2023-03-22 13:29:57 +01:00
2020-09-02 22:49:06 -04:00
2023-02-01 08:23:21 +01:00
2020-09-02 22:49:06 -04:00
2020-08-23 17:36:59 -05:00
2020-10-07 21:48:28 -04:00
2023-03-11 16:40:14 +01:00
2020-07-15 17:26:58 -04:00
2020-07-24 22:32:00 -04:00
2020-06-02 21:23:47 -04:00
2023-02-15 17:22:15 +01:00
2022-10-26 13:25:37 +02:00
2021-05-14 09:50:27 +02:00
2020-07-24 22:09:55 -04:00
2020-06-09 09:39:13 -07:00
2020-10-02 15:27:08 -07:00
2022-04-20 09:23:15 +02:00
2020-06-09 09:39:13 -07:00
2020-10-02 21:52:53 -04:00
2019-11-12 22:21:34 -05:00
2019-07-17 22:39:27 +09:00
2022-06-09 10:20:52 +02:00
2020-08-23 17:36:59 -05:00
2020-06-09 09:39:13 -07:00
2020-10-02 21:42:22 -04:00
2020-03-11 23:07:56 -04:00
2022-06-14 18:32:43 +02:00
2020-01-02 21:57:44 -05:00
2022-02-16 12:54:20 +01:00
2020-01-02 21:57:44 -05:00
2020-08-23 17:36:59 -05:00
2020-08-23 17:36:59 -05:00
2019-06-20 15:37:02 -04:00
2020-09-15 17:34:18 -04:00
2022-06-22 14:13:15 +02:00
2020-03-11 23:07:56 -04:00
2020-08-23 17:36:59 -05:00
2020-09-09 22:37:48 -04:00
2020-01-15 23:09:11 -05:00
2020-10-14 15:15:35 -07:00
2023-01-14 10:15:52 +01:00
2022-01-27 10:54:29 +01:00
2021-06-18 10:00:05 +02:00
2020-07-08 01:16:23 -04:00
2023-01-14 10:15:46 +01:00
2020-08-23 17:36:59 -05:00
2021-11-18 14:03:37 +01:00
2020-07-24 22:09:57 -04:00
2019-12-19 22:08:54 -05:00
2022-01-27 10:54:08 +01:00
2020-10-02 18:53:06 -04:00
2020-02-04 03:05:26 +00:00
2023-02-15 17:22:11 +01:00
2022-11-10 18:14:22 +01:00
2020-03-16 22:08:36 -04:00
2020-09-02 22:49:07 -04:00
2023-02-01 08:23:16 +01:00
2022-12-02 17:39:56 +01:00
2021-01-12 20:18:15 +01:00
2021-04-21 13:00:52 +02:00
2021-11-06 14:10:08 +01:00
2020-03-24 07:57:08 -06:00
2021-09-30 10:11:01 +02:00
2022-11-03 23:57:54 +09:00
2020-10-14 15:15:35 -07:00
2020-09-15 20:28:06 -04:00
2023-03-11 16:40:06 +01:00
2022-08-21 15:15:24 +02:00
2020-09-25 06:20:44 +02:00
2021-05-14 09:50:27 +02:00
2022-01-27 10:54:23 +01:00
2022-01-27 10:54:23 +01:00
2020-02-24 15:01:57 -05:00
2021-04-07 15:00:05 +02:00
2022-10-15 07:55:55 +02:00
2022-12-02 17:39:59 +01:00
2020-08-23 17:36:59 -05:00
2021-05-14 09:50:27 +02:00
2020-10-02 21:52:55 -04:00
2021-10-17 10:43:33 +02:00
2022-01-05 12:40:33 +01:00
2022-06-22 14:13:14 +02:00
2020-08-23 17:36:59 -05:00
2019-07-11 15:14:01 -07:00
2022-03-11 12:11:54 +01:00
2020-01-06 09:45:59 +01:00
2022-04-13 21:01:04 +02:00
2020-06-09 09:39:13 -07:00