xiaomi-sm8450/android_kernel_xiaomi_sm8450
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity
Files
bfcea1c661eddabd7b5fee85dd3399bb16712c5a
android_kernel_xiaomi_sm8450/fs/btrfs
History
Johannes Thumshirn bfcea1c661 btrfs: free checksum hash on in close_ctree 
fs_info::csum_hash gets initialized in btrfs_init_csum_hash() which is
called by open_ctree().

But it only gets freed if open_ctree() fails, not on normal operation.

This leads to a memory leak like the following found by kmemleak:
unreferenced object 0xffff888132cb8720 (size 96):

  comm "mount", pid 450, jiffies 4294912436 (age 17.584s)
  hex dump (first 32 bytes):
    04 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00  ................
    00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00  ................
  backtrace:
    [<000000000c9643d4>] crypto_create_tfm+0x2d/0xd0
    [<00000000ae577f68>] crypto_alloc_tfm+0x4b/0xb0
    [<000000002b5cdf30>] open_ctree+0xb84/0x2060 [btrfs]
    [<0000000043204297>] btrfs_mount_root+0x552/0x640 [btrfs]
    [<00000000c99b10ea>] legacy_get_tree+0x22/0x40
    [<0000000071a6495f>] vfs_get_tree+0x1f/0xc0
    [<00000000f180080e>] fc_mount+0x9/0x30
    [<000000009e36cebd>] vfs_kern_mount.part.11+0x6a/0x80
    [<0000000004594c05>] btrfs_mount+0x174/0x910 [btrfs]
    [<00000000c99b10ea>] legacy_get_tree+0x22/0x40
    [<0000000071a6495f>] vfs_get_tree+0x1f/0xc0
    [<00000000b86e92c5>] do_mount+0x6b0/0x940
    [<0000000097464494>] ksys_mount+0x7b/0xd0
    [<0000000057213c80>] __x64_sys_mount+0x1c/0x20
    [<00000000cb689b5e>] do_syscall_64+0x43/0x130
    [<000000002194e289>] entry_SYSCALL_64_after_hwframe+0x44/0xa9

Free fs_info::csum_hash in close_ctree() to avoid the memory leak.

Fixes: 6d97c6e31b ("btrfs: add boilerplate code for directly including the crypto framework")
Reviewed-by: Qu Wenruo <wqu@suse.com>
Signed-off-by: Johannes Thumshirn <jthumshirn@suse.de>
Reviewed-by: David Sterba <dsterba@suse.com>
Signed-off-by: David Sterba <dsterba@suse.com>
2019-07-17 17:03:33 +02:00
..
tests
btrfs: Evaluate io_tree in find_lock_delalloc_range()
2019-07-04 17:26:17 +02:00
acl.c
btrfs: cleanup btrfs_setxattr_trans and drop transaction parameter
2019-04-29 19:02:44 +02:00
async-thread.c
btrfs: simplify workqueue name when allocating
2019-02-25 14:13:24 +01:00
async-thread.h
btrfs: replace GPL boilerplate by SPDX -- headers
2018-04-12 16:29:46 +02:00
backref.c
btrfs: fiemap: preallocate ulists for btrfs_check_shared
2019-07-01 13:34:53 +02:00
backref.h
btrfs: fiemap: preallocate ulists for btrfs_check_shared
2019-07-01 13:34:53 +02:00
block-rsv.c
btrfs: migrate the global_block_rsv helpers to block-rsv.c
2019-07-02 12:30:55 +02:00
block-rsv.h
btrfs: migrate the global_block_rsv helpers to block-rsv.c
2019-07-02 12:30:55 +02:00
btrfs_inode.h
btrfs: remove assumption about csum type form btrfs_print_data_csum_error()
2019-07-01 13:35:02 +02:00
check-integrity.c
btrfs: directly call into crypto framework for checksumming
2019-07-01 13:35:02 +02:00
check-integrity.h
btrfs: replace GPL boilerplate by SPDX -- headers
2018-04-12 16:29:46 +02:00
compression.c
btrfs: lift bio_set_dev from bio allocation helpers
2019-07-02 12:30:51 +02:00
compression.h
btrfs: correctly validate compression type
2019-07-02 12:30:48 +02:00
ctree.c
btrfs: ctree: Dump the leaf before BUG_ON in btrfs_set_item_key_safe
2019-04-29 19:02:52 +02:00
ctree.h
btrfs: migrate the delalloc space stuff to it's own home
2019-07-04 17:26:17 +02:00
dedupe.h
btrfs: replace GPL boilerplate by SPDX -- headers
2018-04-12 16:29:46 +02:00
delalloc-space.c
btrfs: migrate the delalloc space stuff to it's own home
2019-07-04 17:26:17 +02:00
delalloc-space.h
btrfs: migrate the delalloc space stuff to it's own home
2019-07-04 17:26:17 +02:00
delayed-inode.c
btrfs: get fs_info from eb in btrfs_leaf_free_space
2019-04-29 19:02:30 +02:00
delayed-inode.h
Btrfs: delayed-inode: use rb_first_cached for ins_root and del_root
2018-10-15 17:23:33 +02:00
delayed-ref.c
btrfs: migrate the delayed refs rsv code
2019-07-04 17:26:17 +02:00
delayed-ref.h
btrfs: migrate the delayed refs rsv code
2019-07-04 17:26:17 +02:00
dev-replace.c
btrfs: remove mapping tree structures indirection
2019-07-01 13:34:56 +02:00
dev-replace.h
btrfs: get fs_info from trans in btrfs_run_dev_replace
2019-04-29 19:02:43 +02:00
dir-item.c
btrfs: remove unused parameter fs_info from btrfs_extend_item
2019-04-29 19:02:50 +02:00
disk-io.c
btrfs: free checksum hash on in close_ctree
2019-07-17 17:03:33 +02:00
disk-io.h
btrfs: directly call into crypto framework for checksumming
2019-07-01 13:35:02 +02:00
export.c
btrfs: Remove 'objectid' member from struct btrfs_root
2018-10-15 17:23:25 +02:00
export.h
btrfs: replace GPL boilerplate by SPDX -- headers
2018-04-12 16:29:46 +02:00
extent_io.c
btrfs: fix memory leak of path on error return path
2019-07-05 18:47:57 +02:00
extent_io.h
btrfs: Evaluate io_tree in find_lock_delalloc_range()
2019-07-04 17:26:17 +02:00
extent_map.c
btrfs: Optimize unallocated chunks discard
2019-04-29 19:02:38 +02:00
extent_map.h
btrfs: Remove impossible condition from mergable_maps
2019-02-25 14:13:21 +01:00
extent-tree.c
btrfs: move the subvolume reservation stuff out of extent-tree.c
2019-07-04 17:26:18 +02:00
file-item.c
btrfs: directly call into crypto framework for checksumming
2019-07-01 13:35:02 +02:00
file.c
btrfs: migrate the delalloc space stuff to it's own home
2019-07-04 17:26:17 +02:00
free-space-cache.c
btrfs: migrate the delalloc space stuff to it's own home
2019-07-04 17:26:17 +02:00
free-space-cache.h
btrfs: get fs_info from block group in btrfs_find_space_cluster
2019-04-29 19:02:46 +02:00
free-space-tree.c
btrfs: get fs_info from block group in search_free_space_info
2019-04-29 19:02:46 +02:00
free-space-tree.h
btrfs: get fs_info from block group in search_free_space_info
2019-04-29 19:02:46 +02:00
inode-item.c
btrfs: remove unused parameter fs_info from btrfs_extend_item
2019-04-29 19:02:50 +02:00
inode-map.c
btrfs: migrate the delalloc space stuff to it's own home
2019-07-04 17:26:17 +02:00
inode-map.h
btrfs: replace GPL boilerplate by SPDX -- headers
2018-04-12 16:29:46 +02:00
inode.c
btrfs: inode: Don't compress if NODATASUM or NODATACOW set
2019-07-17 17:03:28 +02:00
ioctl.c
btrfs: migrate the delalloc space stuff to it's own home
2019-07-04 17:26:17 +02:00
Kconfig
btrfs: Fix build error while LIBCRC32C is module
2019-07-17 17:03:30 +02:00
locking.c
btrfs: switch extent_buffer write_locks from atomic to int
2019-07-02 12:30:47 +02:00
locking.h
btrfs: merge btrfs_set_lock_blocking_rw with it's caller
2019-02-25 14:13:28 +01:00
lzo.c
btrfs: change set_level() to bound the level passed in
2019-02-25 14:13:32 +01:00
Makefile
btrfs: migrate the delalloc space stuff to it's own home
2019-07-04 17:26:17 +02:00
math.h
btrfs: replace GPL boilerplate by SPDX -- headers
2018-04-12 16:29:46 +02:00
ordered-data.c
btrfs: migrate the delalloc space stuff to it's own home
2019-07-04 17:26:17 +02:00
ordered-data.h
btrfs: don't assume ordered sums to be 4 bytes
2019-07-01 13:35:00 +02:00
orphan.c
btrfs: replace GPL boilerplate by SPDX -- sources
2018-04-12 16:29:51 +02:00
print-tree.c
btrfs: switch extent_buffer write_locks from atomic to int
2019-07-02 12:30:47 +02:00
print-tree.h
btrfs: print-tree: debugging output enhancement
2018-04-20 19:18:16 +02:00
props.c
btrfs: shut up bogus -Wmaybe-uninitialized warning
2019-07-02 12:30:49 +02:00
props.h
btrfs: delete unused function btrfs_set_prop_trans
2019-04-29 19:02:54 +02:00
qgroup.c
btrfs: qgroup: Don't hold qgroup_ioctl_lock in btrfs_qgroup_inherit()
2019-07-02 12:30:48 +02:00
qgroup.h
btrfs: qgroup: Move reserved data accounting from btrfs_delayed_ref_head to btrfs_qgroup_extent_record
2019-02-25 14:13:39 +01:00
raid56.c
block: remove the i argument to bio_for_each_segment_all
2019-04-30 09:26:13 -06:00
raid56.h
btrfs: constify map parameter for nr_parity_stripes and nr_data_stripes
2019-07-01 13:34:58 +02:00
rcu-string.h
btrfs: replace GPL boilerplate by SPDX -- headers
2018-04-12 16:29:46 +02:00
reada.c
btrfs: start readahead also in seed devices
2019-06-14 17:33:46 +02:00
ref-verify.c
Merge tag 'Wimplicit-fallthrough-5.2-rc1' of git://git.kernel.org/pub/scm/linux/kernel/git/gustavoars/linux
2019-05-07 12:48:10 -07:00
ref-verify.h
btrfs: ref-verify: Use btrfs_ref to refactor btrfs_ref_tree_mod()
2019-04-29 19:02:49 +02:00
relocation.c
btrfs: migrate the delalloc space stuff to it's own home
2019-07-04 17:26:17 +02:00
root-tree.c
btrfs: move the subvolume reservation stuff out of extent-tree.c
2019-07-04 17:26:18 +02:00
scrub.c
btrfs: add mask for all RAID1 types
2019-07-02 12:30:48 +02:00
send.c
Btrfs: prevent send failures and crashes due to concurrent relocation
2019-07-02 12:30:49 +02:00
send.h
btrfs: replace GPL boilerplate by SPDX -- headers
2018-04-12 16:29:46 +02:00
space-info.c
btrfs: Simplify update of space_info in __reserve_metadata_bytes()
2019-07-02 12:30:53 +02:00
space-info.h
btrfs: unexport can_overcommit
2019-07-02 12:30:53 +02:00
struct-funcs.c
btrfs: prune unused includes
2018-08-06 13:12:43 +02:00
super.c
btrfs: move space_info to space-info.h
2019-07-02 12:30:51 +02:00
sysfs.c
btrfs: move space_info to space-info.h
2019-07-02 12:30:51 +02:00
sysfs.h
btrfs: drop extra enum initialization where using defaults
2018-12-17 14:51:43 +01:00
transaction.c
btrfs: migrate btrfs_trans_release_chunk_metadata
2019-07-04 17:26:17 +02:00
transaction.h
btrfs: migrate btrfs_trans_release_chunk_metadata
2019-07-04 17:26:17 +02:00
tree-checker.c
btrfs: tree-checker: Check if the file extent end overflows
2019-07-01 13:34:55 +02:00
tree-checker.h
btrfs: get fs_info from eb in btrfs_check_chunk_valid
2019-04-29 19:02:39 +02:00
tree-defrag.c
btrfs: open code now trivial btrfs_set_lock_blocking
2019-02-25 14:13:27 +01:00
tree-log.c
Btrfs: fix fsync not persisting dentry deletions due to inode evictions
2019-07-02 12:30:50 +02:00
tree-log.h
btrfs: get fs_info from trans in btrfs_set_log_full_commit
2019-04-29 19:02:41 +02:00
ulist.c
btrfs: replace GPL boilerplate by SPDX -- sources
2018-04-12 16:29:51 +02:00
ulist.h
btrfs: replace GPL boilerplate by SPDX -- headers
2018-04-12 16:29:46 +02:00
uuid-tree.c
btrfs: remove unused parameter fs_info from btrfs_extend_item
2019-04-29 19:02:50 +02:00
volumes.c
btrfs: move space_info to space-info.h
2019-07-02 12:30:51 +02:00
volumes.h
btrfs: Use btrfs_get_io_geometry appropriately
2019-07-02 12:30:50 +02:00
xattr.c
Btrfs: fix failure to persist compression property xattr deletion on fsync
2019-06-17 16:37:17 +02:00
xattr.h
btrfs: cleanup btrfs_setxattr_trans and drop transaction parameter
2019-04-29 19:02:44 +02:00
zlib.c
btrfs: change set_level() to bound the level passed in
2019-02-25 14:13:32 +01:00
zstd.c
btrfs: correct zstd workspace manager lock to use spin_lock_bh()
2019-05-28 18:54:09 +02:00