Al Viro bd9b51e79c
make default ->i_fop have ->open() fail with ENXIO ...
As it is, default ->i_fop has NULL ->open() (along with all other methods).
The only case where it matters is reopening (via procfs symlink) a file that
didn't get its ->f_op from ->i_fop - anything else will have ->i_fop assigned
to something sane (default would fail on read/write/ioctl/etc.).
Unfortunately, such case exists - alloc_file() users, especially
anon_get_file() ones. There we have tons of opened files of very different
kinds sharing the same inode. As the result, attempt to reopen those via
procfs succeeds and you get a descriptor you can't do anything with.
Moreover, in case of sockets we set ->i_fop that will only be used
on such reopen attempts - and put a failing ->open() into it to make sure
those do not succeed.
It would be simpler to put such ->open() into default ->i_fop and leave
it unchanged both for anon inode (as we do anyway) and for socket ones. Result:
* everything going through do_dentry_open() works as it used to
* sock_no_open() kludge is gone
* attempts to reopen anon-inode files fail as they really ought to
* ditto for aio_private_file()
* ditto for perfmon - this one actually tried to imitate sock_no_open()
trick, but failed to set ->i_fop, so in the current tree reopens succeed and
yield completely useless descriptor. Intent clearly had been to fail with
-ENXIO on such reopens; now it actually does.
* everything else that used alloc_file() keeps working - it has ->i_fop
set for its inodes anyway
Signed-off-by: Al Viro <viro@zeniv.linux.org.uk >
2014-12-10 21:32:15 -05:00
2014-09-24 10:25:52 +01:00
2014-09-30 13:17:14 -04:00
2014-08-06 18:01:23 -07:00
2014-11-18 13:23:31 +01:00
2014-10-14 12:57:02 -07:00
2014-10-15 07:05:03 +02:00
2014-04-04 21:07:28 -07:00
2014-08-08 15:57:26 -07:00
2014-10-15 20:31:05 +05:30
2014-09-22 16:48:47 +09:00
2014-10-09 14:58:15 -04:00
2014-05-16 00:55:30 +02:00
2014-08-09 09:15:07 -07:00
2014-08-25 21:47:22 +01:00
2014-08-07 23:37:07 -07:00
2014-10-09 06:42:04 -04:00
2014-06-04 23:13:41 -07:00
2014-09-09 16:01:09 -04:00
2014-11-10 15:22:02 +00:00
2014-10-06 01:04:15 -04:00
2014-10-19 12:29:23 -07:00
2014-10-03 14:18:17 +02:00
2014-10-21 13:46:03 -07:00
2014-09-15 22:20:21 +02:00
2014-07-22 12:46:11 +05:30
2014-09-04 19:21:45 +02:00
2014-10-19 12:50:44 -07:00
2014-10-28 03:30:21 +01:00
2014-10-13 13:05:58 +02:00
2014-06-04 16:54:05 -07:00
2014-09-24 11:53:39 -07:00
2014-10-18 18:11:04 -07:00
2014-07-18 13:45:24 -04:00
2014-10-08 12:51:44 -04:00
2014-10-28 17:26:19 -04:00
2014-08-07 14:40:09 -04:00
2014-10-24 11:21:43 -07:00
2014-09-16 16:28:34 -06:00
2014-08-16 08:35:34 -04:00
2014-07-09 16:02:41 +02:00
2014-07-07 21:34:43 -07:00
2014-08-23 13:05:08 -04:00
2014-05-07 16:08:08 -04:00
2014-09-08 10:54:03 +02:00
2014-09-09 13:58:58 +02:00
2014-06-21 11:37:35 +01:00
2014-08-13 10:31:57 +02:00
2014-11-19 13:01:26 -05:00
2014-09-08 10:00:43 -06:00
2014-05-27 01:29:01 +02:00
2014-10-09 22:26:01 -04:00
2014-04-07 16:36:05 -07:00
2014-10-03 15:28:18 -06:00
2014-08-06 18:01:27 -07:00
2014-11-16 09:55:39 +01:00
2014-10-14 09:00:44 -06:00
2014-10-18 11:53:51 -07:00
2014-11-02 14:39:35 -08:00
2014-11-13 16:17:06 -08:00
2014-09-26 15:05:15 -04:00
2014-10-01 22:12:48 -04:00
2014-09-04 22:04:42 -04:00
2014-07-24 21:53:47 +10:00
2014-09-24 14:23:34 +08:00
2014-05-19 16:37:06 -04:00
2014-11-19 13:01:25 -05:00
2014-09-27 12:52:33 -07:00
2014-09-27 12:52:33 -07:00
2014-10-15 07:05:03 +02:00
2014-10-22 16:14:03 -06:00
2014-10-27 13:00:55 +01:00
2014-09-29 14:36:26 -04:00
2014-10-09 22:25:54 -04:00
2014-04-02 12:51:41 -07:00
2014-04-09 13:44:35 -07:00
2014-10-28 11:03:40 +01:00
2014-10-28 11:03:40 +01:00
2014-04-15 09:15:39 -07:00
2014-06-12 19:18:49 -07:00
2014-07-03 11:32:43 +01:00
2014-05-27 13:56:21 -07:00
2014-05-28 13:37:21 -07:00
2014-06-25 13:26:47 -07:00
2014-09-18 16:22:27 -07:00
2014-10-21 00:51:01 +02:00
2014-10-21 00:51:01 +02:00
2014-06-09 18:10:34 -07:00
2014-08-28 08:58:57 -04:00
2014-10-10 07:24:40 -04:00
2014-10-22 16:14:04 -06:00
2014-05-16 14:26:52 -04:00
2014-06-25 16:04:00 -07:00
2014-09-27 09:14:59 -06:00
2014-07-17 16:15:35 -04:00
2014-08-01 22:35:55 +08:00
2014-11-19 13:01:20 -05:00
2014-11-05 14:13:38 -05:00
2014-05-08 14:28:07 +08:00
2014-09-23 22:53:15 -07:00
2014-05-24 22:33:41 +09:00
2014-06-04 09:46:34 -04:00
2014-10-15 07:23:49 +02:00
2014-07-08 13:36:52 -07:00
2014-08-06 18:01:16 -07:00
2014-08-26 07:39:13 +02:00
2014-10-18 18:11:04 -07:00
2014-10-02 12:12:25 +02:00
2014-07-10 18:35:01 +02:00
2014-07-10 18:35:01 +02:00
2014-07-10 18:35:23 +02:00
2014-10-03 14:55:48 -07:00
2014-09-29 00:04:55 -04:00
2014-06-26 15:46:55 -03:00
2014-10-03 18:41:03 +01:00
2014-06-22 16:34:11 -06:00
2014-04-03 16:21:06 -07:00
2014-09-05 17:47:02 -07:00
2014-09-05 12:12:20 -07:00
2014-04-29 09:45:56 +09:00
2014-09-23 11:10:20 -07:00
2014-07-01 13:32:32 +03:00
2014-04-01 23:19:14 -04:00
2014-07-08 13:41:08 -07:00
2014-09-26 15:05:15 -04:00
2014-05-26 14:33:10 +02:00
2014-07-08 15:28:16 -07:00
2014-09-08 09:51:30 +09:00
2014-10-09 11:35:48 +03:00
2014-10-08 16:01:41 -04:00
2014-08-07 14:40:08 -04:00
2014-12-10 21:32:15 -05:00
2014-09-03 18:02:55 -05:00
2014-10-15 21:31:27 +05:30
2014-08-06 18:01:12 -07:00
2014-08-09 17:33:44 -07:00
2014-09-10 10:48:45 -04:00
2014-10-09 22:25:52 -04:00
2014-04-18 14:20:48 +02:00
2014-10-14 17:03:53 -04:00
2014-10-09 22:25:55 -04:00
2014-08-06 18:01:24 -07:00
2014-05-20 10:30:40 +09:00
2014-05-14 16:39:49 -07:00
2014-09-13 11:24:03 -07:00
2014-05-05 10:59:49 +01:00
2014-04-29 22:11:53 +01:00
2014-10-06 23:34:40 +02:00
2014-08-06 18:01:22 -07:00
2014-08-04 10:07:36 +02:00
2014-07-23 10:17:54 -07:00
2014-10-09 22:25:57 -04:00
2014-08-06 18:01:19 -07:00
2014-07-15 04:49:40 -04:00
2014-05-03 19:24:26 -04:00
2014-09-25 16:07:15 +02:00
2014-06-06 16:08:13 -07:00
2014-09-11 12:21:18 +02:00
2014-07-08 16:12:53 -07:00
2014-05-23 15:04:02 -04:00
2014-09-29 15:37:01 -04:00
2014-06-02 14:56:01 -07:00
2014-08-11 12:16:51 -07:00
2014-09-04 22:26:14 -07:00
2014-09-09 10:28:43 -04:00
2014-11-14 17:08:58 -05:00
2014-09-07 16:27:34 -07:00
2014-05-27 14:26:31 -07:00
2014-05-14 16:40:04 -07:00
2014-07-04 12:35:59 +02:00
2014-09-01 13:48:59 +02:00
2014-07-23 12:02:30 +02:00
2014-10-15 07:23:49 +02:00
2014-09-04 14:41:43 -06:00
2014-07-23 16:04:47 +02:00
2014-09-23 23:13:13 -07:00
2014-12-04 14:31:00 -05:00
2014-04-17 12:30:40 -07:00
2014-04-17 12:23:07 -07:00
2014-07-07 21:14:21 -07:00
2014-09-13 18:38:15 +02:00
2014-09-01 13:48:51 +02:00
2014-10-09 16:07:43 -04:00
2014-06-21 23:03:36 +02:00
2014-08-02 15:03:58 -07:00
2014-09-18 00:58:12 -04:00
2014-09-12 13:59:03 -07:00
2014-08-10 09:00:16 +02:00
2014-11-16 10:04:18 +01:00
2014-10-23 14:45:09 -07:00
2014-10-14 15:05:34 -04:00
2014-07-10 11:38:23 -07:00
2014-10-14 02:18:21 +02:00
2014-09-16 17:36:08 +01:00
2014-07-22 21:55:45 +01:00
2014-09-09 10:34:56 +02:00
2014-10-22 16:14:04 -06:00
2014-10-29 16:33:14 -07:00
2014-08-06 18:01:24 -07:00
2014-06-06 16:08:17 -07:00
2014-04-25 12:00:49 -07:00
2014-06-12 19:18:49 -07:00
2014-07-28 14:16:30 -04:00
2014-07-23 10:17:54 -07:00
2014-10-24 13:30:47 +02:00
2014-08-29 16:35:53 +02:00
2014-09-12 14:01:54 -07:00
2014-04-07 16:36:14 -07:00
2014-09-23 10:02:31 -04:00
2014-05-05 16:07:37 -07:00
2014-04-03 16:21:01 -07:00
2014-10-14 02:18:13 +02:00
2014-10-13 15:51:40 +02:00
2014-10-08 10:39:41 +05:30
2014-10-08 10:39:41 +05:30
2014-03-18 19:19:41 -04:00
2014-04-24 05:00:36 +00:00
2014-06-06 16:08:07 -07:00
2014-05-27 17:38:11 -07:00
2014-04-16 15:09:51 -04:00
2014-09-29 11:56:02 -04:00
2014-08-06 18:01:15 -07:00
2014-10-29 16:33:15 -07:00
2014-10-09 22:25:52 -04:00
2014-10-22 16:14:04 -06:00
2014-10-09 22:25:56 -04:00
2014-07-11 18:27:56 -07:00
2014-10-10 15:35:13 -04:00
2014-10-09 22:26:01 -04:00
2014-05-27 17:43:11 -07:00
2014-08-08 15:57:23 -07:00
2014-10-29 16:33:14 -07:00
2014-10-09 22:25:58 -04:00
2014-09-24 14:07:58 +02:00
2014-11-13 16:17:05 -08:00
2014-04-09 13:44:35 -07:00
2014-07-27 20:52:44 +09:30
2014-07-27 20:52:42 +09:30
2014-10-14 02:18:28 +02:00
2014-10-24 00:14:36 +02:00
2014-10-01 12:21:23 -06:00
2014-08-13 10:32:03 +02:00
2014-07-16 12:58:36 +00:00
2014-12-10 21:32:13 -05:00
2014-04-01 23:19:10 -04:00
2014-05-14 00:37:34 -04:00
2014-07-24 01:15:04 -07:00
2014-10-15 12:11:00 -04:00
2014-09-26 18:42:31 +02:00
2014-08-25 10:45:28 +02:00
2014-06-03 23:32:12 -07:00
2014-03-29 17:58:37 -04:00
2014-09-30 16:24:56 -04:00
2014-09-30 16:24:56 -04:00
2014-10-18 11:53:51 -07:00
2014-08-22 18:04:43 -04:00
2014-11-12 14:22:51 -05:00
2014-05-29 11:11:48 -04:00
2014-04-03 16:21:26 -07:00
2014-05-16 17:23:41 -04:00
2014-10-14 02:18:27 +02:00
2014-08-06 18:01:21 -07:00
2014-12-10 21:30:20 -05:00
2014-07-29 18:08:50 -07:00
2014-04-07 10:59:19 -07:00
2014-06-13 10:43:34 -04:00
2014-09-30 17:08:40 -06:00
2014-07-26 00:21:41 +05:30
2014-07-29 21:26:45 -06:00
2014-05-21 11:14:46 +02:00
2014-05-23 11:40:25 +09:00
2014-07-02 00:24:14 -07:00
2014-09-30 17:08:57 -06:00
2014-07-07 13:33:46 +01:00
2014-10-29 16:33:14 -07:00
2014-11-04 10:19:48 +00:00
2014-07-09 14:58:37 +01:00
2014-09-18 09:53:25 -07:00
2014-06-10 14:35:22 -07:00
2014-07-29 12:38:07 +02:00
2014-10-21 23:44:21 +02:00
2014-07-16 13:28:05 +02:00
2014-08-08 15:57:18 -07:00
2014-08-06 18:01:17 -07:00
2014-11-13 16:17:05 -08:00
2014-06-04 16:54:09 -07:00
2014-10-09 22:26:01 -04:00
2014-04-03 16:21:00 -07:00
2014-09-12 20:09:52 -06:00
2014-10-15 06:58:16 +02:00
2014-11-05 13:06:16 -07:00
2014-10-09 15:03:49 -04:00
2014-07-09 14:58:37 +01:00
2014-09-08 09:51:29 +09:00
2014-08-26 13:45:56 -04:00
2014-11-23 12:36:06 -05:00
2014-09-02 14:46:05 -04:00
2014-08-24 08:11:09 -03:00
2014-10-07 13:06:45 -04:00
2014-08-23 11:39:09 -07:00
2014-12-04 14:31:00 -05:00
2014-04-12 14:49:50 -07:00
2014-10-08 10:39:33 +05:30
2014-07-08 15:31:26 -07:00
2014-06-04 16:54:07 -07:00
2014-11-11 22:28:44 +01:00
2014-05-07 00:39:03 +02:00
2014-09-25 01:18:33 +02:00
2014-07-23 01:00:36 +02:00
2014-10-07 01:18:12 +02:00
2014-10-19 20:22:32 +03:00
2014-10-28 03:30:19 +01:00
2014-08-13 15:13:44 +10:00
2014-09-17 16:33:11 -04:00
2014-12-10 21:30:20 -05:00
2014-05-18 19:01:33 -07:00
2014-09-08 09:51:30 +09:00
2014-07-07 16:57:18 -07:00
2014-03-21 14:21:13 -04:00
2014-07-03 17:27:23 -07:00
2014-05-07 10:15:31 +02:00
2014-05-21 11:19:36 +02:00
2014-03-21 18:26:03 +01:00
2014-07-15 22:40:22 +02:00
2014-04-03 16:20:54 -07:00
2014-04-03 16:21:01 -07:00
2014-08-24 18:36:01 -07:00
2014-06-25 11:22:03 -07:00
2014-10-14 02:18:21 +02:00
2014-08-06 18:01:24 -07:00
2014-10-28 18:25:17 -04:00
2014-09-07 16:27:35 -07:00
2014-05-14 09:46:09 -07:00
2014-09-26 00:00:06 -07:00
2014-07-25 19:01:53 +01:00
2014-04-07 16:35:54 -07:00
2014-07-08 13:41:08 -07:00
2014-04-14 16:47:28 +02:00
2014-04-11 09:29:16 +02:00
2014-09-03 20:56:32 -07:00
2014-11-10 16:45:43 -05:00
2014-08-08 15:57:24 -07:00
2014-04-07 16:36:07 -07:00
2014-10-09 22:25:57 -04:00
2014-06-19 21:17:37 -07:00
2014-06-21 22:05:30 +02:00
2014-09-13 12:30:26 -04:00
2014-07-16 14:56:55 +02:00
2014-08-13 10:32:03 +02:00
2014-08-08 15:57:26 -07:00
2014-04-22 13:38:33 -07:00
2014-10-13 16:23:15 +02:00
2014-10-09 22:26:04 -04:00
2014-09-03 14:58:17 -07:00
2014-10-12 10:13:55 -04:00
2014-10-29 20:26:06 -04:00
2014-09-19 12:35:16 +02:00
2014-08-28 11:59:38 +05:30
2014-09-29 18:20:38 -07:00
2014-09-26 18:01:56 +02:00
2014-03-21 04:12:33 +09:00
2014-04-19 22:42:19 -07:00
2014-07-23 01:10:45 +02:00
2014-07-09 10:55:57 +02:00
2014-07-02 16:01:51 +02:00
2014-05-02 21:48:33 +05:30
2014-08-08 15:57:26 -07:00
2014-08-08 15:57:31 -07:00
2014-10-14 02:18:20 +02:00
2014-10-30 19:58:30 -04:00
2014-10-09 22:25:51 -04:00
2014-10-09 22:25:50 -04:00
2014-05-06 13:04:59 -07:00
2014-09-19 12:35:15 +02:00
2014-04-24 13:44:53 -04:00
2014-11-05 15:52:45 -05:00
2014-08-13 10:32:38 +02:00
2014-06-12 00:21:11 -04:00
2014-03-19 08:58:30 +00:00
2014-07-31 14:13:29 -07:00
2014-10-14 02:18:26 +02:00
2014-10-24 12:33:32 -07:00
2014-09-30 21:06:07 +02:00
2014-10-09 22:25:59 -04:00
2014-06-04 16:54:07 -07:00
2014-06-04 16:53:55 -07:00
2014-06-04 16:53:57 -07:00
2014-03-26 16:49:31 -04:00
2014-09-26 15:05:14 -04:00
2014-08-08 15:57:24 -07:00
2014-05-27 14:29:56 -07:00
2014-09-27 09:14:59 -06:00
2014-10-08 21:40:54 -04:00
2014-10-10 14:02:25 +08:00
2014-06-04 16:53:56 -07:00
2014-09-26 08:15:29 +01:00
2014-10-14 03:47:00 +02:00
2014-07-23 10:17:53 -07:00
2014-07-23 10:17:54 -07:00
2014-07-30 09:26:25 +02:00
2014-07-23 15:01:55 -07:00
2014-07-18 11:49:57 +02:00
2014-10-09 22:25:51 -04:00
2014-09-16 13:41:06 -07:00
2014-07-29 23:10:56 +02:00
2014-07-01 07:13:39 -04:00
2014-08-06 13:03:43 +02:00
2014-09-10 10:48:46 -04:00
2014-09-23 21:19:35 -07:00
2014-04-24 16:16:33 -07:00
2014-09-25 12:17:25 +02:00
2014-05-20 16:54:21 -06:00
2014-09-01 21:36:28 -07:00
2014-10-02 21:35:54 -07:00
2014-12-08 20:25:23 -05:00
2014-10-22 16:14:04 -06:00
2014-09-23 21:40:48 -07:00
2014-09-25 17:05:12 +02:00
2014-12-04 14:31:00 -05:00
2014-12-04 14:31:00 -05:00
2014-07-09 14:58:37 +01:00
2014-05-15 17:02:21 +01:00
2014-08-08 10:39:16 -06:00
2014-09-18 19:21:20 -04:00
2014-09-16 15:02:55 -06:00
2014-10-15 10:25:01 +10:30
2014-06-02 12:41:33 -07:00
2014-10-15 10:24:56 +10:30
2014-10-09 22:26:01 -04:00
2014-04-07 16:35:53 -07:00
2014-08-06 18:01:19 -07:00
2014-06-04 16:53:57 -07:00
2014-10-13 16:23:15 +02:00
2014-10-20 20:46:25 +02:00
2014-09-13 05:13:08 +09:00
2014-07-16 15:10:39 +02:00
2014-08-06 18:01:23 -07:00
2014-08-08 15:57:26 -07:00
2014-08-06 18:01:23 -07:00
2014-10-09 22:26:02 -04:00
bd9b51e79c