Ingo Molnar
15c1247953
Revert "perf/x86/intel/uncore: Move uncore_box_init() out of driver initialization"
This reverts commit c05199e5a5.
Vince Weaver reported the following crash while perf fuzzing:
[ 79.473121] kernel BUG at mm/vmalloc.c:1335!
[ 79.694391] Call Trace:
[ 79.696997] <IRQ>
[ 79.699090] [<ffffffff811b2130>] get_vm_area_caller+0x40/0x50
[ 79.705505] [<ffffffff81039f4d>] ? snb_uncore_imc_init_box+0x6d/0x90
[ 79.712414] [<ffffffff810635e5>] __ioremap_caller+0x195/0x350
[ 79.718610] [<ffffffff81039f4d>] ? snb_uncore_imc_init_box+0x6d/0x90
[ 79.725462] [<ffffffff81427f6b>] ? debug_object_activate+0x14b/0x1e0
[ 79.732346] [<ffffffff810637b7>] ioremap_nocache+0x17/0x20
[ 79.738283] [<ffffffff81039f4d>] snb_uncore_imc_init_box+0x6d/0x90
[ 79.744945] [<ffffffff81039cf7>] snb_uncore_imc_event_start+0xb7/0x110
[ 79.752020] [<ffffffff81039d97>] snb_uncore_imc_event_add+0x47/0x60
[ 79.758832] [<ffffffff81162cbb>] event_sched_in.isra.85+0xfb/0x330
[ 79.765519] [<ffffffff81162f5f>] group_sched_in+0x6f/0x1e0
[ 79.771481] [<ffffffff8101df1a>] ? native_sched_clock+0x2a/0x90
[ 79.777858] [<ffffffff811637bc>] __perf_event_enable+0x25c/0x2a0
[ 79.784418] [<ffffffff810f3e69>] ? tick_nohz_irq_exit+0x29/0x30
[ 79.790820] [<ffffffff8115ef30>] ? cpu_clock_event_start+0x40/0x40
[ 79.797546] [<ffffffff8115ef80>] remote_function+0x50/0x60
[ 79.803535] [<ffffffff810f8cd1>] flush_smp_call_function_queue+0x81/0x180
[ 79.810840] [<ffffffff810f9763>] generic_smp_call_function_single_interrupt+0x13/0x60
[ 79.819328] [<ffffffff8104b5e8>] smp_trace_call_function_single_interrupt+0x38/0xc0
[ 79.827614] [<ffffffff816de9be>] trace_call_function_single_interrupt+0x6e/0x80
[ 79.835465] <EOI>
[ 79.837543] [<ffffffff8156e8b5>] ? cpuidle_enter_state+0x65/0x160
[ 79.844377] [<ffffffff8156e8a1>] ? cpuidle_enter_state+0x51/0x160
[ 79.851015] [<ffffffff8156e9e7>] cpuidle_enter+0x17/0x20
[ 79.856791] [<ffffffff810b6e39>] cpu_startup_entry+0x399/0x440
[ 79.863165] [<ffffffff816c9ddb>] rest_init+0xbb/0xd0
The offending commit is clearly confused as it moves heavy initialization
work into IPI context.
Revert it.
Reported-by: Vince Weaver <vincent.weaver@maine.edu>
Acked-by: Peter Zijlstra (Intel) <peterz@infradead.org>
Cc: Kan Liang <kan.liang@intel.com>
Cc: Arnaldo Carvalho de Melo <acme@kernel.org>
Cc: Stephane Eranian <eranian@google.com>
Cc: Yan, Zheng <zheng.z.yan@intel.com>
Cc: linux-kernel@vger.kernel.org
Signed-off-by: Ingo Molnar <mingo@kernel.org>
2015-06-09 11:44:37 +02:00
..
2015-05-18 10:31:22 +02:00
2015-03-31 09:54:32 +02:00
2015-04-15 16:35:24 -07:00
2008-10-20 11:24:31 -07:00
2015-04-26 17:57:38 -07:00
2009-07-11 11:24:09 +02:00
2013-06-06 14:32:04 -07:00
2014-03-11 10:16:18 -07:00
2015-04-14 14:37:47 -07:00
2013-10-26 13:34:39 +02:00
2014-01-06 21:25:18 -08:00
2015-05-05 18:27:43 +01:00
2015-03-23 10:22:38 +01:00
2015-04-02 17:14:20 +02:00
2015-02-22 08:55:58 +01:00
2015-04-02 17:14:21 +02:00
2014-02-18 12:45:38 -08:00
2015-02-19 02:21:00 +01:00
2015-01-20 14:36:25 +01:00
2015-02-18 17:01:46 +01:00
2014-11-07 11:45:00 -08:00
2013-06-19 13:04:53 +02:00
2014-11-07 11:45:00 -08:00
2015-04-02 17:33:10 +02:00
2015-04-02 17:58:45 +02:00
2015-03-23 10:58:04 +01:00
2015-05-27 08:46:44 +02:00
2015-04-02 17:33:20 +02:00
2015-06-04 16:07:51 +02:00
2015-05-11 11:52:30 +02:00
2014-08-13 07:51:09 +02:00
2015-04-22 08:29:19 +02:00
2015-06-07 15:46:50 +02:00
2015-06-09 11:44:37 +02:00
2015-06-09 11:44:37 +02:00
2015-05-27 09:16:03 +02:00
2014-08-26 13:45:49 -04:00
2014-08-26 13:45:49 -04:00
2014-02-09 13:08:24 +01:00
2015-05-27 09:16:20 +02:00
2015-05-27 09:16:03 +02:00
2012-10-04 13:32:37 +02:00
2013-05-28 12:02:10 +02:00
2014-12-08 11:48:15 +01:00
2014-05-11 20:25:20 -07:00
2015-04-02 17:14:18 +02:00
2013-07-14 19:36:56 -04:00
2014-01-06 21:25:18 -08:00
2014-01-06 21:25:18 -08:00
2013-08-05 06:35:33 -07:00