Tariq Toukan 40e473071d net/mlx4_core: Fix use of ENOSPC around mlx4_counter_alloc() ...

When ENOSPC is set the idx is still valid and gets set to the global
MLX4_SINK_COUNTER_INDEX.  However gcc's static analysis cannot tell that
ENOSPC is impossible from mlx4_cmd_imm() and gives this warning:

drivers/net/ethernet/mellanox/mlx4/main.c:2552:28: warning: 'idx' may be
used uninitialized in this function [-Wmaybe-uninitialized]
 2552 |    priv->def_counter[port] = idx;

Also, when ENOSPC is returned mlx4_allocate_default_counters should not
fail.

Fixes: 6de5f7f6a1 ("net/mlx4_core: Allocate default counter per port")
Signed-off-by: Jason Gunthorpe <jgg@mellanox.com>
Signed-off-by: Tariq Toukan <tariqt@mellanox.com>
Signed-off-by: David S. Miller <davem@davemloft.net>

2020-05-04 10:42:06 -07:00

..

alloc.c

mellanox: Switch to bitmap_zalloc()

2019-03-04 10:19:33 -08:00

catas.c

mlx4: Split restart_one into two functions

2019-09-13 22:11:14 +02:00

cmd.c

drivers: Remove explicit invocations of mmiowb()

2019-04-08 12:01:02 +01:00

cq.c

net/mlx4_core: Fix error handling when initializing CQ bufs in the driver

2019-01-24 21:48:26 -08:00

crdump.c

mlx4: fix "initializer element not constant" compiler error

2020-03-29 22:09:39 -07:00

en_clock.c

…

en_cq.c

net/mlx4_en: remove fallback after kzalloc_node()

2018-12-17 11:18:02 -08:00

en_dcb_nl.c

net/mlx4_en: Fix mixed PFC and Global pause user control requests

2018-03-27 12:02:30 -04:00

en_ethtool.c

net: mlx4: reject unsupported coalescing params

2020-03-10 16:28:53 -07:00

en_main.c

net/mlx4_en: Use minimal rx and tx ring sizes on kdump kernel

2018-10-09 11:08:48 -07:00

en_netdev.c

mlx4: use new txqueue timeout argument

2019-12-12 21:38:57 -08:00

en_port.c

net/mlx4_en: Add physical RX/TX bytes/packets counters

2018-02-27 14:53:26 -05:00

en_port.h

…

en_resources.c

…

en_rx.c

net/mlx4_en: fix a memory leak bug

2019-08-13 19:42:43 -07:00

en_selftest.c

net/mlx4_en: Fix selftest for small MTUs

2017-12-13 16:38:36 -05:00

en_tx.c

net/mlx4_en: avoid indirect call in TX completion

2020-04-18 15:30:22 -07:00

eq.c

ethernet: remove redundant memset

2019-07-15 11:06:27 -07:00

fw_qos.c

…

fw_qos.h

…

fw.c

net/mlx4_core: Add masking for a few queries on HCA caps

2019-01-24 21:48:26 -08:00

fw.h

net/mlx4_core: Add health buffer address capability

2018-07-12 17:37:13 -07:00

icm.c

net/mlx4: replace pci_{,un}map_sg with dma_{,un}map_sg

2019-01-07 05:14:17 -08:00

icm.h

net/mlx4: Get rid of page operation after dma_alloc_coherent

2019-01-07 05:14:17 -08:00

intf.c

net/mlx4: fix spelling mistake: "Inrerface" -> "Interface" and rephrase message

2018-05-23 14:58:10 -04:00

Kconfig

treewide: Add SPDX license identifier - Makefile/Kconfig

2019-05-21 10:50:46 +02:00

main.c

net/mlx4_core: Fix use of ENOSPC around mlx4_counter_alloc()

2020-05-04 10:42:06 -07:00

Makefile

net/mlx4_core: Add Crdump FW snapshot support

2018-07-12 17:37:13 -07:00

mcg.c

net: mlx4: Use scnprintf() for avoiding potential buffer overflow

2020-03-15 17:06:22 -07:00

mlx4_en.h

net: remove 'fallback' argument from dev->ndo_select_queue()

2019-03-20 11:18:55 -07:00

mlx4_stats.h

net/mlx4_en: Add physical RX/TX bytes/packets counters

2018-02-27 14:53:26 -05:00

mlx4.h

mlx4: Split restart_one into two functions

2019-09-13 22:11:14 +02:00

mr.c

net/mlx4_core: Zero out lkey field in SW2HW_MPT fw command

2018-11-15 16:09:30 -08:00

pd.c

…

port.c

net/mlx4_en: ethtool, Remove unsupported SFP EEPROM high pages query

2019-05-20 11:33:57 -07:00

profile.c

net/mlx4_core: Allow MTTs starting at any index

2018-07-25 16:30:38 -07:00

qp.c

net/mlx4: Fix irq-unsafe spinlock usage

2018-05-23 15:48:58 -04:00

reset.c

…

resource_tracker.c

net/mlx4_core: Dynamically set guaranteed amount of counters per VF

2019-10-29 16:29:43 -07:00

sense.c

…

srq.c

…