Naoya Horiguchi b5ff8161e3
mm: thp: introduce separate TTU flag for thp freezing ...
TTU_MIGRATION is used to convert pte into migration entry until thp
split completes. This behavior conflicts with thp migration added later
patches, so let's introduce a new TTU flag specifically for freezing.
try_to_unmap() is used both for thp split (via freeze_page()) and page
migration (via __unmap_and_move()). In freeze_page(), ttu_flag given
for head page is like below (assuming anonymous thp):
(TTU_IGNORE_MLOCK | TTU_IGNORE_ACCESS | TTU_RMAP_LOCKED | \
TTU_MIGRATION | TTU_SPLIT_HUGE_PMD)
and ttu_flag given for tail pages is:
(TTU_IGNORE_MLOCK | TTU_IGNORE_ACCESS | TTU_RMAP_LOCKED | \
TTU_MIGRATION)
__unmap_and_move() calls try_to_unmap() with ttu_flag:
(TTU_MIGRATION | TTU_IGNORE_MLOCK | TTU_IGNORE_ACCESS)
Now I'm trying to insert a branch for thp migration at the top of
try_to_unmap_one() like below
static int try_to_unmap_one(struct page *page, struct vm_area_struct *vma,
unsigned long address, void *arg)
{
...
/* PMD-mapped THP migration entry */
if (!pvmw.pte && (flags & TTU_MIGRATION)) {
if (!PageAnon(page))
continue;
set_pmd_migration_entry(&pvmw, page);
continue;
}
...
}
so try_to_unmap() for tail pages called by thp split can go into thp
migration code path (which converts *pmd* into migration entry), while
the expectation is to freeze thp (which converts *pte* into migration
entry.)
I detected this failure as a "bad page state" error in a testcase where
split_huge_page() is called from queue_pages_pte_range().
Link: http://lkml.kernel.org/r/20170717193955.20207-4-zi.yan@sent.com
Signed-off-by: Naoya Horiguchi <n-horiguchi@ah.jp.nec.com >
Signed-off-by: Zi Yan <zi.yan@cs.rutgers.edu >
Acked-by: Kirill A. Shutemov <kirill.shutemov@linux.intel.com >
Cc: "H. Peter Anvin" <hpa@zytor.com >
Cc: Anshuman Khandual <khandual@linux.vnet.ibm.com >
Cc: Dave Hansen <dave.hansen@intel.com >
Cc: David Nellans <dnellans@nvidia.com >
Cc: Ingo Molnar <mingo@elte.hu >
Cc: Mel Gorman <mgorman@techsingularity.net >
Cc: Minchan Kim <minchan@kernel.org >
Cc: Thomas Gleixner <tglx@linutronix.de >
Cc: Vlastimil Babka <vbabka@suse.cz >
Cc: Andrea Arcangeli <aarcange@redhat.com >
Cc: Michal Hocko <mhocko@kernel.org >
Signed-off-by: Andrew Morton <akpm@linux-foundation.org >
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org >
2017-09-08 18:26:45 -07:00
2017-07-09 18:48:37 -07:00
2017-08-27 15:47:43 -07:00
2017-05-08 17:15:13 -07:00
2017-04-25 09:04:29 +02:00
2017-08-01 16:46:45 +02:00
2017-08-30 14:01:47 +02:00
2017-08-01 16:46:44 +02:00
2017-08-28 16:40:18 +05:30
2017-07-17 17:26:14 +02:00
2017-08-23 09:16:35 +02:00
2017-09-05 08:45:36 +01:00
2017-09-07 13:51:13 -07:00
2017-05-29 20:02:01 -07:00
2017-08-31 15:31:42 +01:00
2017-07-13 15:58:02 -04:00
2017-03-28 23:33:30 +05:30
2017-09-07 13:51:13 -07:00
2017-09-06 14:45:08 -07:00
2017-09-06 14:45:08 -07:00
2017-09-07 12:24:50 -07:00
2017-08-02 10:26:42 +02:00
2017-08-28 17:11:28 +02:00
2017-09-04 12:54:42 +02:00
2017-06-19 19:09:19 +02:00
2017-07-27 13:43:22 +01:00
2017-08-30 15:17:45 -07:00
2017-08-31 09:15:21 +02:00
2017-09-07 13:55:16 -07:00
2017-06-08 17:57:38 +02:00
2017-07-27 00:05:22 -07:00
2017-08-09 18:52:07 +01:00
2017-08-15 12:50:48 +01:00
2017-03-28 17:58:07 -07:00
2017-09-06 20:49:49 -07:00
2017-09-05 09:11:45 -07:00
2017-07-06 11:38:59 -07:00
2017-07-13 13:56:24 -07:00
2017-08-31 18:08:47 +02:00
2017-08-07 14:28:51 +02:00
2017-09-05 12:50:00 -07:00
2017-08-04 13:34:14 -07:00
2017-07-17 17:32:05 +02:00
2017-08-29 08:33:24 -07:00
2017-07-04 22:35:16 +01:00
2017-08-10 12:29:02 +02:00
2017-05-02 10:16:05 -04:00
2017-04-20 12:09:55 -06:00
2017-07-12 16:26:05 -07:00
2017-06-08 18:52:36 -07:00
2017-08-01 12:03:09 -07:00
2017-09-07 11:59:42 -07:00
2017-07-10 16:32:34 -07:00
2017-07-17 17:26:14 +02:00
2017-08-23 12:49:55 -06:00
2017-07-29 09:00:03 -06:00
2017-08-08 14:58:03 -04:00
2017-08-18 08:36:58 -06:00
2017-09-07 11:59:42 -07:00
2017-07-29 09:00:03 -06:00
2017-07-06 16:24:33 -07:00
2017-08-16 15:34:13 -07:00
2017-08-23 22:38:08 -07:00
2017-07-17 13:37:56 -07:00
2017-08-28 11:13:21 -07:00
2017-09-07 21:11:05 -07:00
2017-07-10 10:51:53 -07:00
2017-07-10 16:32:34 -07:00
2017-07-10 16:32:34 -07:00
2017-07-03 16:56:28 -06:00
2017-08-04 09:27:41 +08:00
2017-06-30 12:00:51 -07:00
2017-08-18 08:24:21 -07:00
2017-09-07 11:59:42 -07:00
2017-06-05 16:59:12 +02:00
2017-06-07 15:32:12 +02:00
2017-07-14 12:37:41 -07:00
2017-06-12 10:54:47 +02:00
2017-07-03 16:14:51 -07:00
2017-04-18 20:41:12 +02:00
2017-04-20 12:09:55 -06:00
2017-08-31 17:32:38 -04:00
2017-07-06 16:24:29 -07:00
2017-09-04 12:21:28 -07:00
2017-09-04 12:21:28 -07:00
2017-08-29 15:14:38 +02:00
2017-06-12 13:20:20 +02:00
2017-04-18 18:01:52 +02:00
2017-08-28 17:35:43 +02:00
2017-06-09 11:45:25 +02:00
2017-06-22 15:43:47 +01:00
2017-05-27 17:32:24 -07:00
2017-05-26 10:10:46 +02:00
2017-09-04 00:05:22 +02:00
2017-09-07 10:15:40 -07:00
2017-09-04 00:06:02 +02:00
2017-05-23 10:01:32 +02:00
2017-08-10 12:28:57 +02:00
2017-07-12 16:26:00 -07:00
2017-06-09 11:52:07 +02:00
2017-07-19 08:55:18 -07:00
2017-04-10 19:17:27 +08:00
2017-03-24 22:02:56 +08:00
2017-09-06 17:27:24 -07:00
2017-07-19 08:55:18 -07:00
2017-07-17 16:25:11 +02:00
2017-05-05 15:54:45 +08:00
2017-08-28 10:22:27 +09:00
2017-08-28 09:58:27 -04:00
2017-08-28 18:02:46 +02:00
2017-08-24 13:23:03 -07:00
2017-06-19 11:03:51 -04:00
2017-04-26 23:57:53 +02:00
2017-04-20 13:47:46 +05:30
2017-07-27 08:15:43 +10:00
2017-05-30 11:25:45 +02:00
2017-08-26 09:19:13 +02:00
2017-09-06 21:55:10 +05:30
2017-06-15 13:46:00 +02:00
2017-08-29 15:34:44 -06:00
2017-08-29 15:34:44 -06:00
2017-08-29 15:34:46 -06:00
2017-07-17 13:42:48 +02:00
2017-08-28 16:55:47 +02:00
2017-04-05 12:27:25 +02:00
2017-09-07 09:42:35 -07:00
2017-06-18 10:08:55 -06:00
2017-05-08 17:15:11 -07:00
2017-07-29 09:01:02 -04:00
2017-08-18 16:30:17 -07:00
2017-06-20 12:18:27 +02:00
2017-07-12 16:26:01 -07:00
2017-07-10 16:32:35 -07:00
2017-08-16 09:27:55 +09:00
2017-05-03 10:04:56 -07:00
2017-04-27 05:13:04 -04:00
2017-08-24 11:59:36 -07:00
2017-07-03 18:44:02 -04:00
2017-03-29 14:50:21 -06:00
2017-08-28 16:24:22 +02:00
2017-06-30 12:00:51 -07:00
2017-09-07 15:19:35 -07:00
2017-09-06 17:27:26 -07:00
2017-07-09 09:31:22 -07:00
2017-05-04 11:44:37 -04:00
2017-06-23 19:59:08 -04:00
2017-06-09 11:52:08 +02:00
2017-04-10 17:37:36 +02:00
2017-07-07 20:09:10 -04:00
2017-07-20 09:27:29 -04:00
2017-08-01 14:36:35 +02:00
2017-07-22 00:04:51 +02:00
2017-08-31 09:47:22 -06:00
2017-08-09 13:09:28 -06:00
2017-07-12 16:26:03 -07:00
2017-06-30 13:49:53 -07:00
2017-05-16 19:44:01 +01:00
2017-05-16 19:44:01 +01:00
2017-09-05 11:54:41 -07:00
2017-06-15 14:25:38 +02:00
2017-06-30 04:14:14 -04:00
2017-07-10 16:32:31 -07:00
2017-08-15 23:20:30 +10:00
2017-04-02 07:01:53 -07:00
2017-09-07 09:25:15 -07:00
2017-07-31 17:33:53 +02:00
2017-06-09 09:27:32 -06:00
2017-08-30 14:36:44 -07:00
2017-06-30 09:47:24 +03:00
2017-05-26 15:18:44 -04:00
2017-05-18 10:07:41 -04:00
2017-06-02 10:20:49 -04:00
2017-05-18 10:07:40 -04:00
2017-06-16 11:48:40 -04:00
2017-08-07 11:39:22 -07:00
2017-06-21 14:37:12 -04:00
2017-06-20 07:25:17 -03:00
2017-09-01 18:38:09 -07:00
2017-04-04 09:48:23 -06:00
2017-07-01 07:39:08 -07:00
2017-07-24 16:01:34 -07:00
2017-03-24 20:51:49 -04:00
2017-07-10 16:32:34 -07:00
2017-05-17 14:57:56 +02:00
2017-08-10 16:28:53 +02:00
2017-07-18 11:38:02 +02:00
2017-07-10 10:51:53 -07:00
2017-08-15 13:58:48 +02:00
2017-06-30 12:00:51 -07:00
2017-07-19 08:55:18 -07:00
2017-08-07 11:39:22 -07:00
2017-08-16 16:40:02 +02:00
2017-08-18 11:22:27 +02:00
2017-07-04 12:46:16 +02:00
2017-09-05 12:50:00 -07:00
2017-08-29 15:14:38 +02:00
2017-05-03 15:52:09 -07:00
2017-07-17 09:22:34 -07:00
2017-06-02 15:07:37 -07:00
2017-08-10 12:28:59 +02:00
2017-07-26 13:08:54 +02:00
2017-03-31 17:13:30 -07:00
2017-04-23 15:51:26 +09:00
2017-08-17 10:40:26 +02:00
2017-07-29 09:00:03 -06:00
2017-07-18 11:38:04 +02:00
2017-06-30 12:00:51 -07:00
2017-07-03 21:13:25 -07:00
2017-07-10 16:32:31 -07:00
2017-07-06 16:24:34 -07:00
2017-06-30 12:00:51 -07:00
2017-08-14 13:33:39 -07:00
2017-07-08 11:05:34 +02:00
2017-05-08 17:15:14 -07:00
2017-05-03 15:52:10 -07:00
2017-08-02 16:34:47 -07:00
2017-06-26 10:39:40 +02:00
2017-08-02 22:41:02 +02:00
2017-06-20 12:18:27 +02:00
2017-04-19 20:27:50 +02:00
2017-08-29 21:10:40 +02:00
2017-08-29 08:36:58 -07:00
2017-07-03 16:54:58 -07:00
2017-04-16 10:06:25 -06:00
2017-07-10 16:32:33 -07:00
2017-07-19 15:33:50 -07:00
2017-08-29 15:14:38 +02:00
2017-05-23 12:28:02 -04:00
2017-08-01 12:03:10 -07:00
2017-06-22 10:29:53 -04:00
2017-08-28 20:51:22 +02:00
2017-09-05 14:42:52 -07:00
2017-07-18 11:38:00 +02:00
2017-08-18 15:32:01 -07:00
2017-09-06 17:27:27 -07:00
2017-09-06 17:27:25 -07:00
2017-07-06 16:24:34 -07:00
2017-05-31 20:56:31 -04:00
2017-07-12 16:26:04 -07:00
2017-06-05 11:00:42 -04:00
2017-05-18 16:59:06 +02:00
2017-06-16 11:48:37 -04:00
2017-08-17 10:30:49 +02:00
2017-05-24 10:18:27 +02:00
2017-09-06 17:27:29 -07:00
2017-09-06 17:27:30 -07:00
2017-06-20 15:42:32 -04:00
2017-08-31 16:13:00 -07:00
2017-09-06 17:27:26 -07:00
2017-08-28 16:19:44 +02:00
2017-07-19 08:55:18 -07:00
2017-07-02 15:37:23 -07:00
2017-06-30 12:00:51 -07:00
2017-04-24 14:30:46 -04:00
2017-06-30 12:00:51 -07:00
2017-07-30 08:23:27 -07:00
2017-05-16 08:43:25 -03:00
2017-04-21 14:05:36 -04:00
2017-06-29 13:50:38 -07:00
2017-08-15 20:23:23 -07:00
2017-07-24 13:52:59 -07:00
2017-09-06 14:45:08 -07:00
2017-08-28 17:44:00 +02:00
2017-08-28 17:44:00 +02:00
2017-05-30 11:55:32 -04:00
2017-07-01 07:39:08 -07:00
2017-07-13 16:00:15 -04:00
2017-07-13 16:00:12 -04:00
2017-07-21 11:51:19 -04:00
2017-07-13 17:12:07 -04:00
2017-08-01 16:28:55 -04:00
2017-08-18 12:35:02 +02:00
2017-07-06 16:24:32 -07:00
2017-07-06 16:24:35 -07:00
2017-07-06 11:30:07 -04:00
2017-08-10 11:06:38 +02:00
2017-07-25 18:05:25 +02:00
2017-08-30 14:46:32 +02:00
2017-08-28 17:33:23 +02:00
2017-07-10 14:27:39 +02:00
2017-08-21 12:19:57 -05:00
2017-06-22 11:14:48 -05:00
2017-05-29 11:07:55 +02:00
2017-05-17 10:21:16 +01:00
2017-05-11 10:26:22 -05:00
2017-06-13 14:00:16 -04:00
2017-05-22 18:01:46 +02:00
2017-07-22 00:04:50 +02:00
2017-06-19 22:06:28 -04:00
2017-08-18 15:32:01 -07:00
2017-05-26 10:10:37 +02:00
2017-07-10 16:32:31 -07:00
2017-09-06 17:27:28 -07:00
2017-05-08 17:15:10 -07:00
2017-09-06 17:27:26 -07:00
2017-09-06 17:27:27 -07:00
2017-06-30 12:00:51 -07:00
2017-08-11 10:35:07 -07:00
2017-06-07 12:20:49 +02:00
2017-05-30 15:40:50 -05:00
2017-04-18 14:21:04 -05:00
2017-04-11 14:18:36 -05:00
2017-04-11 14:18:37 -05:00
2017-04-11 14:18:37 -05:00
2017-09-03 17:49:17 -07:00
2017-04-04 17:49:49 +01:00
2017-06-20 15:42:32 -04:00
2017-07-26 17:41:06 -04:00
2017-09-04 13:56:37 -07:00
2017-08-06 20:55:29 -07:00
2017-08-06 20:55:29 -07:00
2017-06-30 12:00:51 -07:00
2017-08-21 12:47:31 -07:00
2017-07-03 08:31:43 +02:00
2017-07-24 23:02:02 +02:00
2017-06-24 01:41:55 +02:00
2017-06-28 01:52:52 +02:00
2017-05-05 22:54:28 +02:00
2017-07-24 23:53:45 +02:00
2017-06-11 17:08:19 -07:00
2017-06-20 12:18:27 +02:00
2017-06-04 15:40:22 +02:00
2017-06-25 21:58:46 -04:00
2017-06-08 16:29:28 +02:00
2017-05-08 17:15:11 -07:00
2017-06-30 12:00:51 -07:00
2017-06-28 22:49:11 +10:00
2017-07-22 00:04:51 +02:00
2017-05-31 10:13:44 -07:00
2017-08-01 15:22:55 -07:00
2017-08-16 16:28:47 -07:00
2017-07-03 15:12:52 -07:00
2017-06-06 20:01:15 +01:00
2017-03-28 16:03:21 -05:00
2017-08-21 14:06:46 +02:00
2017-08-17 22:00:59 +02:00
2017-08-30 14:36:44 -07:00
2017-07-15 12:44:02 -07:00
2017-06-29 10:48:57 +01:00
2017-06-08 18:52:26 -07:00
2017-06-08 18:52:26 -07:00
2017-04-19 09:29:18 -07:00
2017-09-07 21:11:05 -07:00
2017-07-24 16:03:22 -07:00
2017-06-08 18:52:40 -07:00
2017-06-08 18:18:19 +02:00
2017-08-17 10:40:26 +02:00
2017-07-03 16:20:28 +01:00
2017-08-14 13:00:49 -04:00
2017-04-04 17:36:10 +02:00
2017-05-21 13:11:00 -04:00
2017-06-14 00:00:42 +02:00
2017-05-01 16:22:40 -04:00
2017-05-01 10:26:40 -04:00
2017-09-08 18:26:45 -07:00
2017-05-03 15:52:09 -07:00
2017-07-12 23:11:23 +02:00
2017-06-08 10:35:49 +02:00
2017-05-27 18:51:41 -04:00
2017-08-10 12:28:55 +02:00
2017-08-10 12:28:55 +02:00
2017-04-14 14:06:52 -06:00
2017-06-15 14:30:14 +02:00
2017-09-04 13:56:37 -07:00
2017-06-05 11:14:35 +01:00
2017-08-03 09:45:47 -07:00
2017-08-01 12:03:10 -07:00
2017-08-07 14:16:22 -07:00
2017-07-19 08:55:18 -07:00
2017-05-18 17:38:24 +02:00
2017-08-28 20:51:20 +02:00
2017-08-28 20:51:20 +02:00
2017-03-25 10:37:26 -07:00
2017-07-06 16:24:30 -07:00
2017-08-06 20:55:29 -07:00
2017-09-06 17:27:28 -07:00
2017-09-06 17:27:28 -07:00
2017-09-06 17:27:24 -07:00
2017-07-06 20:57:13 -07:00
2017-08-16 16:28:47 -07:00
2017-09-01 20:22:03 -07:00
2017-07-12 16:26:03 -07:00
2017-09-06 17:27:24 -07:00
2017-08-29 15:14:38 +02:00
2017-08-03 21:37:29 -07:00
2017-08-17 08:08:58 -07:00
2017-09-04 11:52:29 -07:00
2017-05-18 17:37:52 +02:00
2017-06-08 18:52:42 -07:00
2017-07-24 16:04:08 -07:00
2017-08-17 08:10:04 -07:00
2017-04-03 01:06:00 -04:00
2017-06-01 14:53:04 -04:00
2017-05-26 10:10:36 +02:00
2017-07-15 12:00:42 -07:00
2017-06-09 11:00:46 +02:00
2017-08-18 01:54:22 +02:00
2017-08-17 07:26:07 -07:00
2017-07-06 16:24:31 -07:00
2017-09-06 17:27:30 -07:00
2017-07-10 16:32:30 -07:00
2017-07-18 11:38:03 +02:00
2017-07-31 10:55:24 -03:00
2017-09-06 14:45:08 -07:00
2017-07-19 08:55:18 -07:00
2017-05-25 18:30:51 +02:00
2017-08-17 16:29:19 -07:00
2017-07-03 16:56:25 -06:00
2017-08-30 11:20:09 -07:00
2017-08-15 18:34:46 +01:00
2017-08-31 11:09:45 -04:00
2017-06-20 22:13:59 -07:00
2017-04-14 21:49:55 +02:00
2017-06-01 12:55:58 +08:00
2017-08-08 17:51:34 -07:00
2017-04-03 22:46:02 +03:00
2017-08-29 13:29:29 +02:00
2017-06-13 17:10:57 -04:00
2017-08-28 20:51:23 +02:00
2017-07-30 07:52:19 -07:00
2017-08-28 16:15:42 +02:00
2017-04-19 09:29:17 -07:00
2017-08-31 17:32:39 -04:00
2017-05-16 15:41:29 -04:00
2017-04-08 18:13:27 +02:00
2017-07-10 07:40:49 -04:00
2017-04-18 16:54:19 +02:00
2017-06-30 12:00:51 -07:00
2017-06-30 12:00:51 -07:00
2017-07-24 17:50:37 +02:00
2017-06-22 16:15:45 -07:00
2017-07-26 13:30:23 -06:00
2017-05-02 23:41:43 +03:00
2017-07-17 09:52:58 -07:00
2017-05-02 23:41:43 +03:00
2017-04-24 12:35:56 -04:00
2017-05-09 16:43:22 +03:00
2017-09-06 17:27:29 -07:00
2017-05-12 15:57:15 -07:00
2017-09-06 17:27:29 -07:00
2017-07-05 09:54:14 +02:00
2017-08-31 18:50:14 +02:00
2017-06-20 12:19:14 +02:00
2017-08-18 15:32:01 -07:00
2017-06-06 10:15:20 -07:00
2017-09-05 06:34:17 -07:00
b5ff8161e3