Xin Long adbce6d20d tipc: fix a possible memleak in tipc_buf_append ...

[ Upstream commit 97bf6f81b29a8efaf5d0983251a7450e5794370d ]

__skb_linearize() doesn't free the skb when it fails, so move
'*buf = NULL' after __skb_linearize(), so that the skb can be
freed on the err path.

Fixes: b7df21cf1b79 ("tipc: skb_linearize the head skb when reassembling msgs")
Reported-by: Paolo Abeni <pabeni@redhat.com>
Signed-off-by: Xin Long <lucien.xin@gmail.com>
Reviewed-by: Simon Horman <horms@kernel.org>
Reviewed-by: Tung Nguyen <tung.q.nguyen@dektech.com.au>
Link: https://lore.kernel.org/r/90710748c29a1521efac4f75ea01b3b7e61414cf.1714485818.git.lucien.xin@gmail.com
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
Signed-off-by: Sasha Levin <sashal@kernel.org>

2024-05-17 11:48:01 +02:00

..

addr.c

tipc: initialise addr_trail_end when setting node addresses

2019-08-11 21:40:04 -07:00

addr.h

tipc: add 128-bit node identifier

2018-03-23 13:12:18 -04:00

bcast.c

net: tipc: fix FB_MTU eat two pages

2021-07-14 16:56:32 +02:00

bcast.h

tipc: update a binding service via broadcast

2020-06-17 08:53:34 -07:00

bearer.c

tipc: Check the bearer type before calling tipc_udp_nl_bearer_add()

2024-02-23 08:42:20 +01:00

bearer.h

tipc: add tipc_bearer_min_mtu to calculate min mtu

2023-05-30 12:57:52 +01:00

core.c

tipc: fix use-after-free Read in tipc_named_reinit

2022-06-29 08:59:47 +02:00

core.h

tipc: simplify the finalize work queue

2022-06-29 08:59:47 +02:00

crypto.c

tipc: fix a potential deadlock on &tx->lock

2023-10-10 21:53:38 +02:00

crypto.h

net/tipc: fix tipc header files for kernel-doc

2023-05-30 12:57:52 +01:00

diag.c

tipc: switch to rhashtable iterator

2018-08-29 18:04:54 -07:00

discover.c

tipc: check skb_linearize() return value in tipc_disc_rcv()

2022-12-02 17:40:01 +01:00

discover.h

tipc: some cleanups in the file discover.c

2018-03-23 13:12:17 -04:00

eth_media.c

tipc: Use is_broadcast_ether_addr() instead of memcmp()

2020-08-03 16:21:46 -07:00

group.c

tipc: Fix memory leak in tipc_group_create_member()

2020-09-14 16:36:20 -07:00

group.h

tipc: extend sock diag for group communication

2018-06-30 21:05:42 +09:00

ib_media.c

tipc: introduce variable window congestion control

2019-12-10 17:31:15 -08:00

Kconfig

tipc: not enable tipc when ipv6 works as a module

2020-08-16 21:04:55 -07:00

link.c

tipc: Use size_add() in calls to struct_size()

2023-11-20 11:06:44 +01:00

link.h

tipc: simplify the finalize work queue

2022-06-29 08:59:47 +02:00

Makefile

tipc: remove meaningless assignment in Makefile

2020-01-08 12:38:54 -08:00

monitor.c

tipc: fix shift wrapping bug in map_get()

2022-09-15 11:32:05 +02:00

monitor.h

tipc: update mon's self addr when node addr generated

2019-11-12 19:45:45 -08:00

msg.c

tipc: fix a possible memleak in tipc_buf_append

2024-05-17 11:48:01 +02:00

msg.h

net: tipc: fix FB_MTU eat two pages

2021-07-14 16:56:32 +02:00

name_distr.c

tipc: rate limit warning for received illegal binding update

2022-02-16 12:54:26 +01:00

name_distr.h

net/tipc: fix tipc header files for kernel-doc

2023-05-30 12:57:52 +01:00

name_table.c

tipc: Fix end of loop tests for list_for_each_entry()

2022-03-02 11:42:49 +01:00

name_table.h

net/tipc: fix tipc header files for kernel-doc

2023-05-30 12:57:52 +01:00

net.c

tipc: simplify the finalize work queue

2022-06-29 08:59:47 +02:00

net.h

tipc: fix a deadlock when flushing scheduled work

2020-09-07 12:08:53 -07:00

netlink_compat.c

tipc: Fix kernel-infoleak due to uninitialized TLV value

2023-11-28 16:54:54 +00:00

netlink.c

tipc: Change nla_policy for bearer-related names to NLA_NUL_STRING

2023-11-20 11:06:55 +01:00

netlink.h

net: tipc: allocate attrs locally instead of using genl_family_attrbuf in compat_dumpit()

2019-10-06 15:44:47 +02:00

node.c

tipc: stop tipc crypto on failure in tipc_node_create

2023-08-11 11:57:37 +02:00

node.h

tipc: add automatic session key exchange

2020-09-18 13:58:37 -07:00

socket.c

net: deal with most data-races in sk_wait_event()

2023-05-30 12:57:46 +01:00

socket.h

tipc: call tsk_set_importance from tipc_topsrv_create_listener

2020-05-28 11:11:46 -07:00

subscr.c

tipc: fix unbalanced reference counter

2018-04-12 21:46:10 -04:00

subscr.h

net/tipc: fix tipc header files for kernel-doc

2023-05-30 12:57:52 +01:00

sysctl.c

tipc: add automatic session key exchange

2020-09-18 13:58:37 -07:00

topsrv.c

tipc: add an extra conn_get in tipc_conn_alloc

2022-12-02 17:40:01 +01:00

topsrv.h

tipc: rename tipc_server to tipc_topsrv

2018-02-16 15:26:34 -05:00

trace.c

tipc: remove unneeded semicolon in trace.c

2019-01-17 22:04:43 -08:00

trace.h

tipc: add support for broadcast rcv stats dumping

2020-05-26 15:16:52 -07:00

udp_media.c

tipc: add tipc_bearer_min_mtu to calculate min mtu

2023-05-30 12:57:52 +01:00

udp_media.h

tipc: implement configuration of UDP media MTU

2018-04-20 11:04:05 -04:00