Jiri Slaby acfa747baf
TTY: open/hangup race fixup ...
Like in the "TTY: don't allow reopen when ldisc is changing" patch,
this one fixes a TTY WARNING as described in the option 1) there:
1) __tty_hangup from tty_ldisc_hangup to tty_ldisc_enable. During this
section tty_lock is held. However tty_lock is temporarily dropped in
the middle of the function by tty_ldisc_hangup.
The fix is to introduce a new flag which we set during the unlocked
window and check it in tty_reopen too. The flag is TTY_HUPPING and is
cleared after TTY_HUPPED is set.
While at it, remove duplicate TTY_HUPPED set_bit. The one after
calling ops->hangup seems to be more correct. But anyway, we hold
tty_lock, so there should be no difference.
Also document the function it does that kind of crap.
Nicely reproducible with two forked children:
static void do_work(const char *tty)
{
if (signal(SIGHUP, SIG_IGN) == SIG_ERR) exit(1);
setsid();
while (1) {
int fd = open(tty, O_RDWR|O_NOCTTY);
if (fd < 0) continue;
if (ioctl(fd, TIOCSCTTY)) continue;
if (vhangup()) continue;
close(fd);
}
exit(0);
}
Signed-off-by: Jiri Slaby <jslaby@suse.cz >
Reported-by: <Valdis.Kletnieks@vt.edu >
Reported-by: Kyle McMartin <kyle@mcmartin.ca >
Cc: Alan Cox <alan@lxorguk.ukuu.org.uk >
Cc: stable <stable@kernel.org >
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de >
2010-11-29 14:52:48 -08:00
2010-10-27 19:04:36 -07:00
2010-08-14 22:26:51 +02:00
2010-06-20 19:46:07 -07:00
2010-10-18 15:16:08 +02:00
2010-10-20 15:38:23 -07:00
2010-10-20 15:37:28 -07:00
2010-03-12 15:52:44 -08:00
2010-08-14 22:26:51 +02:00
2010-11-03 10:44:20 -07:00
2010-10-13 07:49:27 -07:00
2010-10-29 00:30:24 +02:00
2010-10-26 17:54:22 -07:00
2010-11-04 12:21:25 +09:00
2010-10-30 08:31:35 -07:00
2010-10-23 11:47:02 -07:00
2010-10-13 18:00:51 +02:00
2010-10-18 11:22:05 +02:00
2010-10-13 18:00:51 +02:00
2010-10-13 18:00:51 +02:00
2010-08-14 22:26:51 +02:00
2010-08-05 13:26:20 +01:00
2010-08-12 06:38:24 +10:00
2010-10-28 22:40:31 +01:00
2010-11-01 07:50:43 -04:00
2010-08-24 16:28:11 -04:00
2010-11-02 17:13:52 -04:00
2010-08-20 01:42:59 -07:00
2010-08-24 14:48:10 -07:00
2010-11-05 14:13:32 +02:00
2010-03-30 22:02:32 +09:00
2010-03-12 15:53:10 -08:00
2010-10-15 21:18:59 +02:00
2010-10-26 14:51:00 -04:00
2010-06-15 09:56:01 +10:00
2010-08-01 19:36:03 -04:00
2010-05-27 09:12:53 -07:00
2010-05-21 09:34:30 -07:00
2010-10-22 10:20:08 -07:00
2010-10-21 20:21:03 -04:00
2010-09-23 14:33:39 -07:00
2010-11-12 07:55:30 -08:00
2010-10-30 08:45:43 -04:00
2010-08-09 00:13:34 +02:00
2010-10-26 16:52:10 -07:00
2010-03-16 19:47:54 +00:00
2010-10-27 18:03:06 -07:00
2010-10-25 04:54:25 -04:00
2010-08-17 18:07:43 -07:00
2010-11-10 14:54:09 +01:00
2010-05-30 09:00:03 -07:00
2010-10-09 21:51:45 +02:00
2010-11-10 14:54:09 +01:00
2010-11-10 14:54:09 +01:00
2010-08-07 18:26:29 +02:00
2010-06-24 21:30:09 -07:00
2010-10-25 21:18:20 -04:00
2010-03-03 11:25:58 +01:00
2010-08-02 15:34:57 +10:00
2010-10-27 18:03:09 -07:00
2010-03-24 16:31:22 -07:00
2010-03-12 19:10:29 +01:00
2010-07-27 12:40:55 +02:00
2010-10-25 08:02:40 -07:00
2010-10-25 08:02:40 -07:00
2010-10-25 08:02:40 -07:00
2010-05-25 08:07:00 -07:00
2010-09-14 16:08:45 -07:00
2010-06-29 15:29:31 -07:00
2010-08-09 20:45:04 -07:00
2010-08-19 17:17:59 -07:00
2010-10-26 17:32:41 -07:00
2010-10-24 14:20:01 -07:00
2010-08-10 13:47:42 -07:00
2010-08-06 15:36:47 -05:00
2010-10-14 14:32:06 -07:00
2010-08-08 14:55:26 -04:00
2010-06-29 10:07:12 +02:00
2010-08-03 13:47:04 -04:00
2010-09-30 21:19:22 -04:00
2010-03-06 11:26:29 -08:00
2010-06-08 21:40:36 +02:00
2010-08-19 17:18:00 -07:00
2010-05-19 22:03:14 +03:00
2010-09-24 07:40:30 -07:00
2010-08-11 00:29:47 -04:00
2010-04-22 18:32:12 -07:00
2010-10-28 10:27:00 -07:00
2010-08-17 09:11:10 +02:00
2010-05-19 22:41:57 -04:00
2010-05-10 16:08:01 -07:00
2010-08-04 11:00:45 +02:00
2010-03-30 22:02:32 +09:00
2010-08-12 04:14:10 +01:00
2010-10-22 10:16:43 -07:00
2010-09-07 14:17:10 -05:00
2010-03-06 02:32:33 +00:00
2010-08-12 04:14:05 +01:00
2010-09-22 17:22:38 -07:00
2010-10-07 17:08:32 -07:00
2010-10-21 14:23:48 -07:00
2010-07-30 09:36:01 -07:00
2010-07-28 09:59:01 -04:00
2010-08-05 17:17:51 +00:00
2010-07-21 16:01:46 +02:00
2010-10-14 18:38:42 +02:00
2010-10-14 18:38:20 +02:00
2010-10-22 15:55:22 +02:00
2010-04-26 22:03:42 +04:00
2010-10-22 17:03:12 -07:00
2010-05-10 11:44:49 -03:00
2010-10-21 14:47:59 +02:00
2010-06-30 15:00:50 -04:00
2010-10-24 22:06:02 +02:00
2010-05-17 10:00:15 +02:00
2010-05-21 20:29:10 -07:00
2010-05-25 08:07:02 -07:00
2010-09-23 14:33:39 -07:00
2010-10-21 01:26:54 -07:00
2010-10-23 09:24:34 +09:00
2010-05-21 19:30:39 +02:00
2010-03-29 14:30:19 -07:00
2010-08-10 11:26:52 -07:00
2010-10-28 17:22:16 -04:00
2010-10-27 18:03:08 -07:00
2010-05-21 21:12:40 +02:00
2010-10-18 11:03:14 +02:00
2010-08-19 17:18:03 -07:00
2010-05-24 00:36:13 -07:00
2010-04-26 16:13:54 +02:00
2010-05-27 22:03:07 -04:00
2010-06-25 21:33:12 -07:00
2010-08-02 10:09:04 +02:00
2010-04-15 22:18:36 +02:00
2010-07-29 23:09:18 +02:00
2010-03-06 11:26:25 -08:00
2010-05-21 09:37:28 -07:00
2010-08-09 20:45:09 -07:00
2010-03-26 23:51:44 +01:00
2010-08-18 08:35:46 -04:00
2010-10-31 06:35:15 -07:00
2010-07-22 22:58:58 +02:00
2010-07-11 22:22:23 +02:00
2010-10-22 10:22:17 -07:00
2010-11-15 13:49:51 +09:00
2010-10-28 17:22:16 -04:00
2010-10-30 14:07:40 -04:00
2010-09-09 20:46:30 +02:00
2010-07-21 11:00:25 -04:00
2010-07-12 14:41:40 +02:00
2010-09-14 00:23:59 -07:00
2010-05-21 18:31:18 -04:00
2010-04-03 14:56:05 -07:00
2010-10-24 22:06:02 +02:00
2010-10-26 16:52:10 -07:00
2010-03-01 14:08:10 +00:00
2010-08-03 19:45:31 -07:00
2010-10-25 14:11:37 -07:00
2010-09-01 08:55:24 -06:00
2010-05-21 09:34:29 -07:00
2010-11-02 08:39:13 -04:00
2010-10-23 22:49:32 +02:00
2010-09-24 14:03:44 +02:00
2010-11-12 07:55:30 -08:00
2010-04-06 21:50:03 +02:00
2010-03-07 22:17:09 +01:00
2010-10-12 16:53:37 +02:00
2010-08-11 09:23:22 +02:00
2010-10-08 09:32:46 +02:00
2010-05-01 04:32:14 +02:00
2010-03-13 20:56:56 +01:00
2010-11-15 22:40:38 +01:00
2010-08-11 18:21:02 +02:00
2010-05-20 00:18:59 +01:00
2010-03-02 12:23:42 +01:00
2010-03-14 11:14:58 -07:00
2010-11-15 22:40:38 +01:00
2010-03-24 08:20:03 +01:00
2010-06-30 01:21:38 -07:00
2010-06-16 18:08:13 +02:00
2010-10-26 17:40:56 -07:00
2010-10-11 15:04:21 -04:00
2010-03-30 19:08:43 -07:00
2010-10-05 20:26:58 -07:00
2010-07-01 12:45:34 -07:00
2010-08-24 14:46:53 -07:00
2010-08-22 21:15:39 -07:00
2010-06-03 03:21:52 -07:00
2010-08-22 21:15:39 -07:00
2010-10-18 11:03:14 +02:00
2010-08-04 15:31:02 -07:00
2010-08-16 21:06:25 -07:00
2010-06-02 05:53:56 -07:00
2010-04-03 14:56:04 -07:00
2010-09-21 18:04:47 -07:00
2010-05-03 12:33:13 +03:00
2010-03-21 21:19:02 -07:00
2010-11-12 12:30:57 -08:00
2010-04-22 16:12:36 -07:00
2010-08-29 21:57:55 -07:00
2010-10-21 16:08:28 +02:00
2010-08-19 17:16:23 -07:00
2010-09-30 21:16:05 -07:00
2010-10-27 18:03:12 -07:00
2010-10-22 10:21:26 -07:00
2010-07-28 10:18:49 -04:00
2010-11-03 11:04:46 -07:00
2010-10-07 15:03:44 -07:00
2010-08-03 09:49:09 -04:00
2010-09-07 11:16:43 +01:00
2010-10-27 18:48:00 -07:00
2010-10-26 16:52:08 -07:00
2010-07-09 11:42:03 -07:00
2010-11-11 13:40:11 +01:00
2010-08-09 20:45:05 -07:00
2010-07-19 15:44:25 +02:00
2010-10-26 15:33:31 -07:00
2010-10-04 22:45:24 +09:00
2010-03-12 15:52:40 -08:00
2010-03-12 15:52:40 -08:00
2010-10-21 16:08:28 +02:00
2010-10-18 19:58:50 +02:00
2010-10-26 10:33:27 +02:00
2010-10-12 16:53:44 +02:00
2010-10-07 14:08:55 +01:00
2010-10-28 11:58:39 +02:00
2010-05-19 17:33:38 +09:30
2010-05-11 13:02:38 -04:00
2010-05-11 13:02:23 -04:00
2010-06-03 03:21:52 -07:00
2010-08-10 13:47:40 -07:00
2010-05-25 08:07:09 -07:00
2010-10-27 21:25:12 -04:00
2010-05-21 19:30:40 +02:00
2010-08-10 11:49:21 -07:00
2010-08-18 10:19:52 +02:00
2010-05-20 23:05:28 -07:00
2010-10-18 19:58:57 +02:00
2010-10-29 14:45:29 -04:00
2010-08-12 11:27:58 +02:00
2010-10-28 17:22:13 -04:00
2010-10-22 15:34:12 -05:00
2010-10-27 18:03:13 -07:00
2010-11-15 13:37:37 -08:00
2010-08-19 17:18:00 -07:00
2010-10-27 18:03:18 -07:00
2010-10-29 13:14:41 -05:00
2010-05-27 09:12:45 -07:00
2010-03-15 15:29:39 +01:00
2010-08-23 18:12:46 -07:00
2010-10-22 10:16:44 -07:00
2010-05-21 09:37:29 -07:00
2010-07-27 20:48:19 -07:00
2010-09-09 18:57:24 -07:00
2010-06-29 10:07:09 +02:00
2010-05-14 15:09:32 -04:00
2010-10-24 12:47:25 -07:00
2010-10-24 10:50:49 +02:00
2010-08-02 06:39:44 +03:00
2010-10-24 10:52:19 +02:00
2010-04-03 14:56:05 -07:00
2010-05-26 17:34:16 +01:00
2010-03-15 12:47:59 +01:00
2010-11-12 07:55:32 -08:00
2010-11-12 07:55:32 -08:00
2010-11-12 07:55:32 -08:00
2010-09-09 09:09:43 -07:00
2010-10-21 21:18:54 -04:00
2010-03-03 11:25:59 +01:00
2010-10-25 14:11:39 -07:00
2010-10-25 21:24:15 -04:00
2010-10-21 14:11:46 -07:00
2010-06-16 18:03:15 +02:00
2010-08-02 15:35:11 +10:00
2010-10-28 09:08:47 -05:00
2010-10-29 13:50:25 -07:00
2010-10-26 16:52:19 -07:00
2010-05-25 08:07:09 -07:00
2010-08-09 16:48:45 -04:00
2010-10-12 15:37:51 -07:00
2010-08-11 08:59:19 -07:00
2010-10-26 16:52:06 -07:00
2010-10-22 10:16:44 -07:00
2010-08-09 20:44:56 -07:00
2010-05-18 00:52:36 -03:00
2010-10-08 09:32:46 +02:00
2010-08-21 00:37:40 -07:00
2010-06-03 03:21:52 -07:00
2010-10-26 16:52:05 -07:00
2010-10-26 16:52:09 -07:00
2010-08-09 20:44:58 -07:00
2010-10-28 09:02:15 -07:00
2010-10-26 16:52:07 -07:00
2010-03-03 14:07:59 -05:00
2010-05-21 17:15:44 -07:00
2010-10-08 10:46:27 +02:00
2010-10-26 16:52:13 -07:00
2010-08-11 00:29:47 -04:00
2010-05-11 14:40:55 +02:00
2010-10-03 21:50:53 -07:00
2010-10-12 16:53:34 +02:00
2010-04-28 15:16:48 -07:00
2010-10-08 17:16:22 -05:00
2010-09-03 08:19:51 +02:00
2010-06-30 13:01:11 -07:00
2010-10-18 11:03:14 +02:00
2010-08-22 21:15:39 -07:00
2010-10-04 21:10:52 +02:00
2010-10-04 21:10:52 +02:00
2010-08-22 21:15:39 -07:00
2010-10-01 17:18:59 -04:00
2010-11-08 12:17:07 -08:00
2010-04-20 16:22:01 +02:00
2010-03-25 11:17:26 +01:00
2010-11-12 08:26:06 +01:00
2010-09-22 13:21:05 -07:00
2010-10-18 08:32:07 -07:00
2010-10-26 09:55:25 -07:00
2010-10-24 18:07:10 -04:00
2010-10-26 09:52:09 -07:00
2010-10-07 18:48:49 -04:00
2010-09-23 08:55:58 -04:00
2010-07-30 14:41:56 -04:00
2010-10-24 18:07:10 -04:00
2010-10-23 09:24:39 +09:00
2010-10-11 15:04:20 -04:00
2010-05-16 04:25:14 +02:00
2010-05-30 09:00:03 -07:00
2010-08-19 17:18:02 -07:00
2010-08-01 01:42:42 -06:00
2010-10-21 11:10:10 -06:00
2010-10-21 11:10:10 -06:00
2010-07-05 16:14:30 -06:00
2010-07-05 16:14:52 -06:00
2010-10-21 11:34:55 -06:00
2010-10-12 21:58:08 -06:00
2010-08-06 09:25:50 -06:00
2010-07-30 00:03:59 -06:00
2010-07-30 00:03:58 -06:00
2010-08-08 10:02:59 -07:00
2010-08-11 08:59:19 -07:00
2010-10-17 01:57:50 +02:00
2010-10-15 12:45:44 +02:00
2010-09-03 19:09:46 +08:00
2010-05-27 09:12:44 -07:00
2010-10-25 16:10:15 +02:00
2010-10-26 16:52:05 -07:00
2010-10-26 16:52:09 -07:00
2010-08-11 00:29:47 -04:00
2010-08-04 14:12:05 -07:00
2010-10-31 21:06:59 +01:00
2010-10-17 20:03:03 -07:00
2010-03-12 15:52:42 -08:00
2010-10-17 20:03:06 -07:00
2010-04-16 19:14:34 +04:00
2010-10-27 21:30:13 -04:00
2010-10-27 17:53:25 +02:00
2010-10-22 17:31:36 -07:00
2010-11-10 22:58:39 +01:00
2010-06-04 15:21:45 -07:00
2010-10-13 14:40:34 -07:00
2010-10-24 15:07:11 -07:00
2010-06-03 14:54:39 +02:00
2010-08-21 23:40:14 -07:00
2010-10-22 10:16:42 -07:00
2010-07-19 01:58:48 +02:00
2010-07-19 02:00:34 +02:00
2010-10-17 01:57:48 +02:00
2010-10-17 01:57:43 +02:00
2010-10-17 01:57:48 +02:00
2010-07-19 01:58:48 +02:00
2010-08-11 09:21:15 +02:00
2010-10-27 18:03:18 -07:00
2010-07-16 09:48:45 +02:00
2010-10-06 17:37:22 +04:00
2010-08-04 21:53:17 -07:00
2010-11-15 13:37:37 -08:00
2010-07-18 19:15:26 -07:00
2010-10-27 18:03:10 -07:00
2010-11-12 07:55:33 -08:00
2010-08-18 23:30:42 -07:00
2010-05-27 18:56:27 +02:00
2010-09-09 16:08:51 +02:00
2010-11-12 07:55:32 -08:00
2010-10-29 04:16:31 -04:00
2010-10-27 18:03:18 -07:00
2010-05-27 09:12:52 -07:00
2010-08-03 09:48:50 -04:00
2010-10-26 16:52:16 -07:00
2010-07-05 14:43:50 +02:00
2010-08-19 17:18:00 -07:00
2010-08-20 09:00:18 -07:00
2010-10-05 14:03:02 -07:00
2010-08-20 09:00:16 -07:00
2010-08-20 09:00:16 -07:00
2010-09-08 18:16:55 -07:00
2010-03-12 15:52:44 -08:00
2010-05-21 18:31:19 -04:00
2010-08-09 16:47:27 -04:00
2010-10-25 21:18:20 -04:00
2010-05-21 18:31:19 -04:00
2010-11-12 07:55:30 -08:00
2010-10-17 01:57:50 +02:00
2010-08-22 21:15:39 -07:00
2010-10-20 13:37:56 -04:00
2010-05-27 09:12:50 -07:00
2010-10-27 18:03:16 -07:00
2010-10-27 18:03:16 -07:00
2010-10-27 18:03:16 -07:00
2010-10-26 16:52:09 -07:00
2010-05-11 10:09:47 +02:00
2010-03-12 15:52:28 -08:00
2010-03-12 15:53:10 -08:00
2010-10-05 00:29:48 -07:00
2010-03-13 01:21:21 +01:00
2010-07-23 17:08:41 +04:00
2010-10-30 11:50:37 -07:00
2010-06-03 03:21:52 -07:00
2010-11-15 15:40:01 -08:00
2010-10-22 10:20:06 -07:00
2010-10-21 10:12:48 +11:00
2010-05-27 09:12:49 -07:00
2010-10-30 12:12:50 +02:00
2010-10-22 10:20:10 -07:00
2010-10-25 13:46:56 -07:00
2010-08-10 13:47:46 -07:00
2010-08-10 13:47:46 -07:00
2010-05-25 12:22:33 +09:00
2010-09-03 17:29:04 -07:00
2010-10-18 09:33:31 -07:00
2010-10-18 23:57:06 -04:00
2010-11-08 09:35:26 +09:00
2010-04-26 15:50:50 +09:00
2010-11-09 16:38:20 +09:00
2010-10-04 03:54:56 +09:00
2010-10-31 10:40:39 -04:00
2010-08-09 20:44:58 -07:00
2010-03-12 15:52:44 -08:00
2010-10-08 09:32:15 +02:00
2010-10-20 03:02:23 -07:00
2010-08-11 08:59:21 -07:00
2010-07-04 19:48:33 +03:00
2010-08-11 08:59:21 -07:00
2010-10-06 16:54:36 +03:00
2010-10-21 15:44:13 +02:00
2010-10-27 17:28:36 +01:00
2010-06-03 03:18:19 -07:00
2010-10-28 11:47:52 -07:00
2010-10-07 14:08:55 +01:00
2010-05-21 21:12:40 +02:00
2010-08-20 09:00:15 -07:00
2010-08-09 16:48:44 -04:00
2010-09-24 21:27:41 -07:00
2010-10-14 08:55:28 +02:00
2010-10-17 01:57:49 +02:00
2010-10-26 16:52:05 -07:00
2010-06-07 11:59:27 -04:00
2010-10-27 18:03:14 -07:00
2010-10-27 18:03:10 -07:00
2010-05-15 23:28:39 -07:00
2010-03-07 17:04:47 -08:00
2010-10-17 01:57:44 +02:00
2010-08-21 00:34:45 -07:00
2010-08-11 08:59:22 -07:00
2010-03-30 22:02:32 +09:00
2010-05-19 11:36:34 +03:00
2010-05-03 23:50:42 -07:00
2010-08-30 13:23:33 -07:00
2010-09-18 12:19:21 +02:00
2010-05-27 09:12:51 -07:00
2010-10-14 12:41:10 -07:00
2010-05-09 19:35:27 +02:00
2010-03-25 17:18:43 -07:00
2010-08-13 16:53:13 -07:00
2010-08-03 09:48:45 -04:00
2010-03-23 17:19:38 +01:00
2010-05-12 23:02:23 -07:00
2010-10-21 04:11:07 -07:00
2010-09-09 20:41:20 +02:00
2010-10-27 18:03:12 -07:00
2010-09-22 16:31:01 -04:00
2010-10-22 10:20:04 -07:00
2010-03-02 14:55:11 -08:00
2010-03-12 15:52:43 -08:00
2010-11-29 14:52:48 -08:00
2010-10-26 16:52:03 -07:00
2010-06-28 23:24:30 -07:00
2010-08-21 00:37:40 -07:00
2010-10-22 10:16:43 -07:00
2010-10-22 10:22:05 -07:00
2010-11-08 12:28:32 -08:00
2010-06-16 14:55:34 -07:00
2010-05-19 22:40:47 -04:00
2010-03-01 22:21:58 +11:00
2010-08-27 09:10:44 +10:00
2010-05-11 16:07:59 -06:00
2010-10-21 13:45:28 -02:00
2010-05-11 16:07:59 -06:00
2010-10-21 07:55:58 -02:00
2010-10-27 18:03:18 -07:00
2010-05-19 22:15:40 +09:30
2010-05-19 22:15:49 +09:30
2010-05-19 22:15:46 +09:30
2010-10-26 16:52:10 -07:00
2010-09-09 18:57:25 -07:00
2010-08-10 13:47:44 -07:00
2010-03-19 07:17:52 -07:00
2010-10-05 11:47:18 -07:00
2010-10-13 15:45:21 -04:00
2010-09-30 06:01:56 +03:00
2010-10-26 16:52:14 -07:00
2010-10-30 09:05:48 -07:00
2010-08-02 15:34:57 +10:00
2010-04-06 20:35:58 +04:00
2010-05-17 21:37:42 +02:00
acfa747baf