Pengcheng Yang
aa138efd2b
tcp: fix F-RTO may not work correctly when receiving DSACK
[ Upstream commit d9157f6806d1499e173770df1f1b234763de5c79 ]
Currently DSACK is regarded as a dupack, which may cause
F-RTO to incorrectly enter "loss was real" when receiving
DSACK.
Packetdrill to demonstrate:
// Enable F-RTO and TLP
0 `sysctl -q net.ipv4.tcp_frto=2`
0 `sysctl -q net.ipv4.tcp_early_retrans=3`
0 `sysctl -q net.ipv4.tcp_congestion_control=cubic`
// Establish a connection
+0 socket(..., SOCK_STREAM, IPPROTO_TCP) = 3
+0 setsockopt(3, SOL_SOCKET, SO_REUSEADDR, [1], 4) = 0
+0 bind(3, ..., ...) = 0
+0 listen(3, 1) = 0
// RTT 10ms, RTO 210ms
+.1 < S 0:0(0) win 32792 <mss 1000,sackOK,nop,nop,nop,wscale 7>
+0 > S. 0:0(0) ack 1 <...>
+.01 < . 1:1(0) ack 1 win 257
+0 accept(3, ..., ...) = 4
// Send 2 data segments
+0 write(4, ..., 2000) = 2000
+0 > P. 1:2001(2000) ack 1
// TLP
+.022 > P. 1001:2001(1000) ack 1
// Continue to send 8 data segments
+0 write(4, ..., 10000) = 10000
+0 > P. 2001:10001(8000) ack 1
// RTO
+.188 > . 1:1001(1000) ack 1
// The original data is acked and new data is sent(F-RTO step 2.b)
+0 < . 1:1(0) ack 2001 win 257
+0 > P. 10001:12001(2000) ack 1
// D-SACK caused by TLP is regarded as a dupack, this results in
// the incorrect judgment of "loss was real"(F-RTO step 3.a)
+.022 < . 1:1(0) ack 2001 win 257 <sack 1001:2001,nop,nop>
// Never-retransmitted data(3001:4001) are acked and
// expect to switch to open state(F-RTO step 3.b)
+0 < . 1:1(0) ack 4001 win 257
+0 %{ assert tcpi_ca_state == 0, tcpi_ca_state }%
Fixes: e33099f96d ("tcp: implement RFC5682 F-RTO")
Signed-off-by: Pengcheng Yang <yangpc@wangsu.com>
Acked-by: Neal Cardwell <ncardwell@google.com>
Tested-by: Neal Cardwell <ncardwell@google.com>
Reviewed-by: Eric Dumazet <edumazet@google.com>
Link: https://lore.kernel.org/r/1650967419-2150-1-git-send-email-yangpc@wangsu.com
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
Signed-off-by: Sasha Levin <sashal@kernel.org>
2022-05-09 09:05:06 +02:00
..
2021-09-15 09:50:34 +02:00
2022-03-11 12:11:54 +01:00
2021-07-31 08:16:11 +02:00
2021-12-01 09:19:08 +01:00
2021-04-07 15:00:08 +02:00
2020-10-31 12:26:30 -07:00
2022-04-20 09:23:32 +02:00
2022-04-13 21:00:56 +02:00
2022-04-13 21:01:00 +02:00
2021-10-27 09:56:56 +02:00
2021-07-14 16:56:29 +02:00
2022-02-01 17:25:48 +01:00
2021-09-22 12:27:56 +02:00
2022-04-27 13:53:57 +02:00
2020-10-12 15:29:27 +02:00
2022-05-09 09:05:02 +02:00
2022-03-08 19:09:37 +01:00
2021-11-18 14:04:08 +01:00
2021-07-28 14:35:38 +02:00
2020-04-28 14:39:46 -07:00
2022-05-09 09:05:02 +02:00
2020-05-23 16:56:17 -07:00
2021-12-17 10:14:41 +01:00
2021-06-03 09:00:50 +02:00
2022-02-08 18:30:37 +01:00
2022-05-09 09:05:06 +02:00
2022-05-09 09:05:04 +02:00
2021-03-07 12:34:05 +01:00
2020-07-24 15:41:54 -07:00
2022-04-08 14:39:48 +02:00
2021-09-22 12:27:56 +02:00
2022-04-27 13:53:50 +02:00
2021-02-10 09:29:14 +01:00
2022-03-28 09:57:10 +02:00
2022-03-28 09:57:10 +02:00
2021-04-14 08:42:13 +02:00
2021-12-08 09:03:23 +01:00
2021-12-22 09:30:54 +01:00
2022-01-05 12:40:32 +01:00
2022-05-09 09:05:02 +02:00
2022-04-13 21:01:00 +02:00
2022-04-27 13:53:51 +02:00
2022-01-27 10:54:03 +01:00
2022-04-20 09:23:18 +02:00
2020-06-14 01:57:21 +09:00
2022-04-27 13:53:55 +02:00
2022-04-27 13:53:50 +02:00
2022-01-11 15:25:01 +01:00
2021-03-07 12:34:07 +01:00
2021-09-03 10:09:21 +02:00
2021-12-22 09:30:54 +01:00
2020-11-12 09:18:06 +01:00
2020-11-20 10:04:58 -08:00
2022-04-27 13:53:49 +02:00
2022-04-27 13:53:50 +02:00
2022-05-09 09:05:03 +02:00
2022-05-09 09:05:04 +02:00
2021-11-18 14:04:27 +01:00
2022-04-13 21:01:07 +02:00
2021-02-07 15:37:12 +01:00
2022-04-08 14:40:23 +02:00
2022-05-09 09:05:05 +02:00
2022-01-27 10:54:31 +01:00
2022-03-23 09:13:27 +01:00
2020-10-02 19:11:11 -07:00
2022-04-20 09:23:28 +02:00
2022-04-08 14:40:30 +02:00
2021-12-22 09:30:59 +01:00
2022-04-08 14:39:47 +02:00
2021-06-18 10:00:06 +02:00
2020-06-30 15:57:34 -07:00
2020-09-30 18:01:26 -07:00
2020-05-23 16:56:17 -07:00
2021-09-18 13:40:21 +02:00