Kaike Wan a35cd6447e IB/qib: Call kobject_put() when kobject_init_and_add() fails ...

When kobject_init_and_add() returns an error in the function
qib_create_port_files(), the function kobject_put() is not called for the
corresponding kobject, which potentially leads to memory leak.

This patch fixes the issue by calling kobject_put() even if
kobject_init_and_add() fails. In addition, the ppd->diagc_kobj is released
along with other kobjects when the sysfs is unregistered.

Fixes: f931551baf ("IB/qib: Add new qib driver for QLogic PCIe InfiniBand adapters")
Link: https://lore.kernel.org/r/20200512031328.189865.48627.stgit@awfm-01.aw.intel.com
Cc: <stable@vger.kernel.org>
Suggested-by: Lin Yi <teroincn@gmail.com>
Reviewed-by: Mike Marciniszyn <mike.marciniszyn@intel.com>
Signed-off-by: Kaike Wan <kaike.wan@intel.com>
Signed-off-by: Dennis Dalessandro <dennis.dalessandro@intel.com>
Reviewed-by: Leon Romanovsky <leonro@mellanox.com>
Signed-off-by: Jason Gunthorpe <jgg@mellanox.com>

2020-05-19 20:58:03 -03:00

..

Kconfig

treewide: Add SPDX license identifier - Makefile/Kconfig

2019-05-21 10:50:46 +02:00

Makefile

License cleanup: add SPDX GPL-2.0 license identifier to files with no license

2017-11-02 11:10:55 +01:00

qib_6120_regs.h

…

qib_7220_regs.h

…

qib_7220.h

Merge branch 'timer_setup' into for-next

2017-10-18 13:12:09 -04:00

qib_7322_regs.h

IB/qib: Mask hardware error during link reset

2010-07-06 14:13:20 -07:00

qib_common.h

infiniband/qib: Fix typo in comment

2019-04-22 14:08:15 -03:00

qib_debugfs.c

infiniband: qib: no need to check return value of debugfs_create functions

2019-01-24 09:22:29 -07:00

qib_debugfs.h

IB/qib: Convert opcode counters to per-context

2013-06-21 17:19:50 -07:00

qib_diag.c

RDMA: Use u64_to_user_ptr everywhere

2018-03-29 13:42:29 -06:00

qib_driver.c

qib: Convert qib_unit_table to XArray

2019-04-01 13:31:35 -03:00

qib_eeprom.c

IB/{hfi1, qib}: Fix a concurrency issue with device name in logging

2018-01-05 13:34:55 -05:00

qib_file_ops.c

RDMA/qib: Unneeded variable ret

2019-07-25 13:53:45 -03:00

qib_fs.c

infiniband: don't bother with d_delete()

2019-09-03 09:30:55 -04:00

qib_iba6120.c

RDMA/qib: Delete extra line

2019-11-06 15:19:33 -04:00

qib_iba7220.c

drivers: Remove explicit invocations of mmiowb()

2019-04-08 12:01:02 +01:00

qib_iba7322.c

remove ioremap_nocache and devm_ioremap_nocache

2020-01-06 09:45:59 +01:00

qib_init.c

remove ioremap_nocache and devm_ioremap_nocache

2020-01-06 09:45:59 +01:00

qib_intr.c

IB/qib: Convert timers to use timer_setup()

2017-10-09 12:19:41 -04:00

qib_mad.c

RDMA: Change MAD processing function to remove extra casting and parameter

2019-11-12 20:20:15 -04:00

qib_mad.h

IB/core: Add core header changes needed for OPA

2015-08-28 22:54:50 -04:00

qib_pcie.c

remove ioremap_nocache and devm_ioremap_nocache

2020-01-06 09:45:59 +01:00

qib_pio_copy.c

…

qib_qp.c

IB/{rdmavt, hfi1, qib}: Add helpers to hide SWQE WR details

2019-06-28 22:34:26 -03:00

qib_qsfp.c

IB/qib: Remove empty function

2017-01-24 16:20:37 -05:00

qib_qsfp.h

IB/qib: Remove empty function

2017-01-24 16:20:37 -05:00

qib_rc.c

IB/{rdmavt, hfi1, qib}: Add a counter for credit waits

2019-09-13 16:59:55 -03:00

qib_ruc.c

IB/{hfi1, qib, rdmavt}: Move ruc_loopback to rdmavt

2018-10-03 16:38:28 -06:00

qib_sd7220.c

drivers: Remove explicit invocations of mmiowb()

2019-04-08 12:01:02 +01:00

qib_sdma.c

IB/{hfi1, qib, rvt} Cleanup open coded sge usage

2019-01-30 14:22:32 -05:00

qib_sysfs.c

IB/qib: Call kobject_put() when kobject_init_and_add() fails

2020-05-19 20:58:03 -03:00

qib_twsi.c

IB/qib: Add blank line after declaration

2015-02-20 09:04:12 -08:00

qib_tx.c

Merge branch 'timer_setup' into for-next

2017-10-18 13:12:09 -04:00

qib_uc.c

IB/{hfi1, qib, rdmavt}: Put qp in error state when cq is full

2019-06-28 22:34:26 -03:00

qib_ud.c

IB/{rdmavt, hfi1, qib}: Add helpers to hide SWQE WR details

2019-06-28 22:34:26 -03:00

qib_user_pages.c

mm, tree-wide: rename put_user_page*() to unpin_user_page*()

2020-01-31 10:30:38 -08:00

qib_user_sdma.c

mm, tree-wide: rename put_user_page*() to unpin_user_page*()

2020-01-31 10:30:38 -08:00

qib_user_sdma.h

…

qib_verbs.c

IB/qib: Delete struct qib_ivdev.qp_rnd

2020-03-29 11:15:16 -03:00

qib_verbs.h

IB/qib: Delete struct qib_ivdev.qp_rnd

2020-03-29 11:15:16 -03:00

qib_wc_ppc64.c

…

qib_wc_x86_64.c

IB/qib: fix test of unsigned variable

2015-05-12 13:55:41 -04:00

qib.h

qib: Convert qib_unit_table to XArray

2019-04-01 13:31:35 -03:00