xiaomi-sm8450/android_kernel_xiaomi_sm8450
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity
Files
a2fcd5c84f7a7825e028381b10182439067aa90d
android_kernel_xiaomi_sm8450/drivers/gpu/drm
History
Tina Zhang a2fcd5c84f drm/modes: Prevent division by zero htotal 
This patch prevents division by zero htotal.

In a follow-up mail Tina writes:

> > How did you manage to get here with htotal == 0? This needs backtraces (or if
> > this is just about static checkers, a mention of that).
> > -Daniel
>
> In GVT-g, we are trying to enable a virtual display w/o setting timings for a pipe
> (a.k.a htotal=0), then we met the following kernel panic:
>
> [   32.832048] divide error: 0000 [#1] SMP PTI
> [   32.833614] CPU: 0 PID: 1 Comm: swapper/0 Not tainted 4.18.0-rc4-sriov+ #33
> [   32.834438] Hardware name: QEMU Standard PC (Q35 + ICH9, 2009), BIOS rel-1.10.1-0-g8891697-dirty-20180511_165818-tinazhang-linux-1 04/01/2014
> [   32.835901] RIP: 0010:drm_mode_hsync+0x1e/0x40
> [   32.836004] Code: 31 c0 c3 90 90 90 90 90 90 90 90 90 0f 1f 44 00 00 8b 87 d8 00 00 00 85 c0 75 22 8b 4f 68 85 c9 78 1b 69 47 58 e8 03 00 00 99 <f7> f9 b9 d3 4d 62 10 05 f4 01 00 00 f7 e1 89 d0 c1 e8 06 f3 c3 66
> [   32.836004] RSP: 0000:ffffc900000ebb90 EFLAGS: 00010206
> [   32.836004] RAX: 0000000000000000 RBX: ffff88001c67c8a0 RCX: 0000000000000000
> [   32.836004] RDX: 0000000000000000 RSI: ffff88001c67c000 RDI: ffff88001c67c8a0
> [   32.836004] RBP: ffff88001c7d03a0 R08: ffff88001c67c8a0 R09: ffff88001c7d0330
> [   32.836004] R10: ffffffff822c3a98 R11: 0000000000000001 R12: ffff88001c67c000
> [   32.836004] R13: ffff88001c7d0370 R14: ffffffff8207eb78 R15: ffff88001c67c800
> [   32.836004] FS:  0000000000000000(0000) GS:ffff88001da00000(0000) knlGS:0000000000000000
> [   32.836004] CS:  0010 DS: 0000 ES: 0000 CR0: 0000000080050033
> [   32.836004] CR2: 0000000000000000 CR3: 000000000220a000 CR4: 00000000000006f0
> [   32.836004] DR0: 0000000000000000 DR1: 0000000000000000 DR2: 0000000000000000
> [   32.836004] DR3: 0000000000000000 DR6: 00000000fffe0ff0 DR7: 0000000000000400
> [   32.836004] Call Trace:
> [   32.836004]  intel_mode_from_pipe_config+0x72/0x90
> [   32.836004]  intel_modeset_setup_hw_state+0x569/0xf90
> [   32.836004]  intel_modeset_init+0x905/0x1db0
> [   32.836004]  i915_driver_load+0xb8c/0x1120
> [   32.836004]  i915_pci_probe+0x4d/0xb0
> [   32.836004]  local_pci_probe+0x44/0xa0
> [   32.836004]  ? pci_assign_irq+0x27/0x130
> [   32.836004]  pci_device_probe+0x102/0x1c0
> [   32.836004]  driver_probe_device+0x2b8/0x480
> [   32.836004]  __driver_attach+0x109/0x110
> [   32.836004]  ? driver_probe_device+0x480/0x480
> [   32.836004]  bus_for_each_dev+0x67/0xc0
> [   32.836004]  ? klist_add_tail+0x3b/0x70
> [   32.836004]  bus_add_driver+0x1e8/0x260
> [   32.836004]  driver_register+0x5b/0xe0
> [   32.836004]  ? mipi_dsi_bus_init+0x11/0x11
> [   32.836004]  do_one_initcall+0x4d/0x1eb
> [   32.836004]  kernel_init_freeable+0x197/0x237
> [   32.836004]  ? rest_init+0xd0/0xd0
> [   32.836004]  kernel_init+0xa/0x110
> [   32.836004]  ret_from_fork+0x35/0x40
> [   32.836004] Modules linked in:
> [   32.859183] ---[ end trace 525608b0ed0e8665 ]---
> [   32.859722] RIP: 0010:drm_mode_hsync+0x1e/0x40
> [   32.860287] Code: 31 c0 c3 90 90 90 90 90 90 90 90 90 0f 1f 44 00 00 8b 87 d8 00 00 00 85 c0 75 22 8b 4f 68 85 c9 78 1b 69 47 58 e8 03 00 00 99 <f7> f9 b9 d3 4d 62 10 05 f4 01 00 00 f7 e1 89 d0 c1 e8 06 f3 c3 66
> [   32.862680] RSP: 0000:ffffc900000ebb90 EFLAGS: 00010206
> [   32.863309] RAX: 0000000000000000 RBX: ffff88001c67c8a0 RCX: 0000000000000000
> [   32.864182] RDX: 0000000000000000 RSI: ffff88001c67c000 RDI: ffff88001c67c8a0
> [   32.865206] RBP: ffff88001c7d03a0 R08: ffff88001c67c8a0 R09: ffff88001c7d0330
> [   32.866359] R10: ffffffff822c3a98 R11: 0000000000000001 R12: ffff88001c67c000
> [   32.867213] R13: ffff88001c7d0370 R14: ffffffff8207eb78 R15: ffff88001c67c800
> [   32.868075] FS:  0000000000000000(0000) GS:ffff88001da00000(0000) knlGS:0000000000000000
> [   32.868983] CS:  0010 DS: 0000 ES: 0000 CR0: 0000000080050033
> [   32.869659] CR2: 0000000000000000 CR3: 000000000220a000 CR4: 00000000000006f0
> [   32.870599] DR0: 0000000000000000 DR1: 0000000000000000 DR2: 0000000000000000
> [   32.871598] DR3: 0000000000000000 DR6: 00000000fffe0ff0 DR7: 0000000000000400
> [   32.872549] Kernel panic - not syncing: Attempted to kill init! exitcode=0x0000000b
>
> Since drm_mode_hsync() has the logic to check mode->htotal, I just extend it to cover the case htotal==0.

Signed-off-by: Tina Zhang <tina.zhang@intel.com>
Cc: Adam Jackson <ajax@redhat.com>
Cc: Dave Airlie <airlied@redhat.com>
Cc: Daniel Vetter <daniel@ffwll.ch>
[danvet: Add additional explanations + cc: stable.]
Cc: stable@vger.kernel.org
Signed-off-by: Daniel Vetter <daniel.vetter@ffwll.ch>
Link: https://patchwork.freedesktop.org/patch/msgid/1548228539-3061-1-git-send-email-tina.zhang@intel.com
2019-01-24 13:04:14 +01:00
..
amd
drm/amd/display: Detach backlight from stream
2019-01-16 17:11:47 -05:00
arc
drm: replace "drm_dev_unref" function with "drm_dev_put"
2018-11-24 22:12:54 +01:00
arm
drm: mali-dp: Enable Mali-DP tiled buffer formats
2018-11-02 09:57:27 +00:00
armada
Remove 'type' argument from access_ok() function
2019-01-03 18:57:57 -08:00
ast
Merge tag 'drm-next-2018-12-14' of git://anongit.freedesktop.org/drm/drm
2018-12-25 11:48:26 -08:00
atmel-hlcdc
drm/atmel-hlcdc: Use drm_fbdev_generic_setup()
2018-11-01 15:24:22 +01:00
bochs
Merge branch 'drm-next-4.21' of git://people.freedesktop.org/~agd5f/linux into drm-next
2018-11-19 11:07:52 +10:00
bridge
drm/bridge: tc358767: use DP connector if no panel set
2019-01-09 10:49:31 +01:00
cirrus
Merge tag 'drm-misc-next-2018-11-21' of git://anongit.freedesktop.org/drm/drm-misc into drm-next
2018-11-22 12:54:38 +10:00
etnaviv
Remove 'type' argument from access_ok() function
2019-01-03 18:57:57 -08:00
exynos
drm/exynos: fimd: Make pixel blend mode configurable
2018-12-14 15:46:15 +09:00
fsl-dcu
drm/fsl-dcu: Use drm_fbdev_generic_setup()
2018-11-01 15:23:58 +01:00
gma500
Merge drm/drm-next into drm-misc-next
2018-08-27 10:00:03 -04:00
hisilicon
drm/ttm: initialize globals during device init (v2)
2018-11-05 14:21:21 -05:00
i2c
Merge branch 'drm-tda9950-fixes' of git://git.armlinux.org.uk/~rmk/linux-arm into drm-fixes
2018-10-04 10:32:14 +10:00
i810
drm/i810: off by one in i810_dma_vertex()
2018-07-03 15:00:42 +02:00
i915
Merge tag 'gvt-fixes-2018-01-17' of https://github.com/intel/gvt-linux into drm-intel-fixes
2019-01-17 11:49:51 +02:00
imx
drm/imx: ipuv3-plane: add IDMAC timeout warning
2018-11-05 14:56:04 +01:00
lib
…
mediatek
drm/mediatek: Only try to attach bridge if there is one
2018-12-03 11:08:22 +08:00
meson
drm/meson: Fix atomic mode switching regression
2019-01-15 13:21:32 +01:00
mga
…
mgag200
drm/ttm: initialize globals during device init (v2)
2018-11-05 14:21:21 -05:00
msm
Remove 'type' argument from access_ok() function
2019-01-03 18:57:57 -08:00
mxsfb
drm: replace "drm_dev_unref" function with "drm_dev_put"
2018-11-24 22:12:54 +01:00
nouveau
Merge branch 'linux-4.21' of git://github.com/skeggsb/linux into drm-fixes
2019-01-18 15:38:18 +10:00
omapdrm
drm/omap: fix incorrect union usage
2018-12-03 14:46:30 +02:00
panel
drm/panel: simple: Add AUO G101EVN010 panel support
2018-12-03 17:04:48 +01:00
pl111
drm/pl111: add of_node_put()
2018-11-28 09:31:07 -08:00
qxl
drm/qxl: drop prime import/export callbacks
2019-01-14 08:16:18 +01:00
r128
…
radeon
mm/mmu_notifier: use structure for invalidate_range_start/end callback
2018-12-28 12:11:50 -08:00
rcar-du
Merge tag 'drm-next-2018-12-14' of git://anongit.freedesktop.org/drm/drm
2018-12-25 11:48:26 -08:00
rockchip
drm/rockchip: add missing of_node_put
2019-01-13 19:20:45 +01:00
savage
drm/savage: off by one in savage_bci_cmdbuf()
2018-07-04 14:27:01 +02:00
scheduler
drm/scheduler: Add drm_sched_suspend/resume_timeout()
2018-12-05 17:56:16 -05:00
selftests
drm/selftest: fix spelling mistake "dimention" -> "dimension"
2018-12-11 15:19:42 +01:00
shmobile
drm: replace "drm_dev_unref" function with "drm_dev_put"
2018-11-24 22:12:54 +01:00
sis
…
sti
drm/sti: remove set but not used variable 'priv'
2018-11-13 12:07:18 +01:00
stm
drm/stm: Use drm_fbdev_generic_setup()
2018-10-25 17:00:28 +02:00
sun4i
drm/sun4i: hdmi: Fix usage of TMDS clock
2019-01-22 10:16:22 +01:00
tdfx
…
tegra
drm/tegra: sor: Reset the SOR if possible
2018-12-06 18:58:32 +01:00
tilcdc
drm/tilcdc: Use drm_fbdev_generic_setup()
2018-11-01 15:25:41 +01:00
tinydrm
drm/tinydrm: Use kmemdup rather than duplicating its implementation in repaper_spi_transfer()
2018-12-04 15:57:42 +01:00
ttm
drm/ttm: Use drm_debug_printer for all ttm_bo_mem_space_debug output
2018-12-21 15:27:58 -05:00
tve200
drm: replace "drm_dev_unref" function with "drm_dev_put"
2018-11-24 22:12:54 +01:00
udl
DRM: UDL: get rid of useless vblank initialization
2018-10-23 15:59:01 +02:00
v3d
Merge tag 'drm-misc-next-2018-12-06' of git://anongit.freedesktop.org/drm/drm-misc into drm-next
2018-12-07 11:23:05 +10:00
vc4
drm: revert "expand replace_fence to support timeline point v2"
2018-12-05 11:01:11 +01:00
vgem
drm/vgem: Fix typo in driver feature flags
2018-11-05 15:31:51 +00:00
via
…
virtio
drm/virtio: drop prime import/export callbacks
2019-01-14 08:16:19 +01:00
vkms
drm/vkms: Remove set but not used variable 'vkms_obj'
2018-12-04 11:47:27 +01:00
vmwgfx
Merge tag 'iommu-updates-v4.21' of git://git.kernel.org/pub/scm/linux/kernel/git/joro/iommu
2019-01-01 15:55:29 -08:00
xen
drm/xen-front: Use Xen common shared buffer implementation
2018-12-18 12:16:13 -05:00
zte
drm/zte: Use drm_atomic_helper_shutdown
2018-10-05 18:04:10 +02:00
ati_pcigart.c
…
drm_agpsupport.c
…
drm_atomic_helper.c
Merge tag 'drm-misc-next-2018-12-06' of git://anongit.freedesktop.org/drm/drm-misc into drm-next
2018-12-07 11:23:05 +10:00
drm_atomic_state_helper.c
drm: Put damage blob when destroy plane state
2018-12-24 11:53:50 +01:00
drm_atomic_uapi.c
gpu/drm: Fix lock held when returning to user space.
2019-01-10 11:31:58 +01:00
drm_atomic.c
drm: Add a new plane property to send damage during plane update
2018-12-05 10:00:35 +01:00
drm_auth.c
drm: set is_master to 0 upon drm_new_set_master() failure
2018-11-26 16:14:27 -05:00
drm_blend.c
drm: Clarify DRM_MODE_REFLECT_X/Y documentation
2018-09-11 11:21:30 +01:00
drm_bridge.c
drm: bridge: document bridge attach/detach imbalance
2018-09-13 11:28:12 +02:00
drm_bufs.c
drm/bufs: Fix Spectre v1 vulnerability
2018-10-17 09:17:33 +02:00
drm_cache.c
…
drm_client.c
drm/gem: Add drm_gem_object_funcs
2018-11-20 14:56:18 +01:00
drm_color_mgmt.c
drm: Add DRM_MODESET_LOCK_BEGIN/END helpers
2018-11-29 10:48:31 -05:00
drm_connector.c
Merge branch 'drm-next-4.21' of git://people.freedesktop.org/~agd5f/linux into drm-next
2018-12-06 13:29:09 +10:00
drm_context.c
drm: Differentiate the lack of an interface from invalid parameter
2018-09-14 17:29:47 +01:00
drm_crtc_helper_internal.h
…
drm_crtc_helper.c
drm: Remove transitional helpers
2018-10-05 18:04:10 +02:00
drm_crtc_internal.h
drm: refuse ADDFB2 ioctl for broken bigendian drivers
2018-09-10 07:10:36 +02:00
drm_crtc.c
Merge tag 'drm-misc-next-2018-12-06' of git://anongit.freedesktop.org/drm/drm-misc into drm-next
2018-12-07 11:23:05 +10:00
drm_damage_helper.c
drm: fix null pointer dereference on null state pointer
2018-12-24 11:52:43 +01:00
drm_debugfs_crc.c
Revert "drm: crc: Wait for a frame before returning from open()"
2018-08-22 09:50:16 -07:00
drm_debugfs.c
drm: Merge drm_info.c into drm_debugfs.c
2018-11-22 09:52:27 +01:00
drm_dma.c
…
drm_dp_aux_dev.c
…
drm_dp_cec.c
drm: Do not call drm_dp_cec_set_edid() while registering DP connectors
2018-10-11 10:52:35 +02:00
drm_dp_dual_mode_helper.c
…
drm_dp_helper.c
drm/i915: Disable PSR in Apple panels
2019-01-10 15:09:35 +02:00
drm_dp_mst_topology.c
Revert "drm/dp_mst: Skip validating ports during destruction, just ref"
2018-11-28 16:22:17 -05:00
drm_drv.c
Merge tag 'drm-misc-next-2018-11-28' of git://anongit.freedesktop.org/drm/drm-misc into drm-next
2018-11-29 10:28:49 +10:00
drm_dsc.c
drm/dsc: Add helpers for DSC picture parameter set infoframes
2018-11-27 18:35:17 -08:00
drm_dumb_buffers.c
Merge tag 'drm-misc-next-2018-06-27' of git://anongit.freedesktop.org/drm/drm-misc into drm-next
2018-06-28 13:29:07 +10:00
drm_edid_load.c
…
drm_edid.c
Merge tag 'drm-next-2018-11-02' of git://anongit.freedesktop.org/drm/drm
2018-11-02 10:58:20 -07:00
drm_encoder_slave.c
…
drm_encoder.c
drm: Differentiate the lack of an interface from invalid parameter
2018-09-14 17:29:47 +01:00
drm_fb_cma_helper.c
Merge tag 'drm-misc-next-2018-11-07' of git://anongit.freedesktop.org/drm/drm-misc into drm-next
2018-11-19 10:40:33 +10:00
drm_fb_helper.c
drm/fb-helper: Ignore the value of fb_var_screeninfo.pixclock
2019-01-10 08:25:36 +01:00
drm_file.c
Remove 'type' argument from access_ok() function
2019-01-03 18:57:57 -08:00
drm_flip_work.c
…
drm_fourcc.c
drm: Introduce new DRM_FORMAT_XYUV
2018-11-20 16:20:13 +02:00
drm_framebuffer.c
drm: Add macro to export functions only when CONFIG_DRM_DEBUG_SELFTEST is enabled
2018-11-02 09:58:10 +00:00
drm_gem_cma_helper.c
drm/cma-helper: Add DRM_GEM_CMA_VMAP_DRIVER_OPS
2018-11-20 14:57:25 +01:00
drm_gem_framebuffer_helper.c
drm/fourcc: Add char_per_block, block_w and block_h in drm_format_info
2018-11-02 09:55:27 +00:00
drm_gem.c
drm/gem: Add drm_gem_object_funcs
2018-11-20 14:56:18 +01:00
drm_hashtab.c
…
drm_internal.h
Merge tag 'drm-next-2018-12-14' of git://anongit.freedesktop.org/drm/drm
2018-12-25 11:48:26 -08:00
drm_ioc32.c
…
drm_ioctl.c
drm/ioctl: Fix Spectre v1 vulnerabilities
2018-12-20 08:13:29 +01:00
drm_irq.c
drm: Differentiate the lack of an interface from invalid parameter
2018-09-14 17:29:47 +01:00
drm_kms_helper_common.c
…
drm_lease.c
Merge tag 'drm-next-2018-12-14' of git://anongit.freedesktop.org/drm/drm
2018-12-25 11:48:26 -08:00
drm_legacy.h
…
drm_lock.c
drm: Differentiate the lack of an interface from invalid parameter
2018-09-14 17:29:47 +01:00
drm_memory.c
drm: Shift * to be adjacent to pointer name
2018-10-16 14:39:25 +02:00
drm_mipi_dsi.c
drm: Add support for pps and compression mode command packet
2018-07-25 07:51:05 -04:00
drm_mm.c
…
drm_mode_config.c
Merge tag 'vmwgfx-next-2018-12-05' of git://people.freedesktop.org/~thomash/linux into drm-next
2018-12-06 13:43:56 +10:00
drm_mode_object.c
gpu/drm: Fix lock held when returning to user space.
2019-01-10 11:31:58 +01:00
drm_modes.c
drm/modes: Prevent division by zero htotal
2019-01-24 13:04:14 +01:00
drm_modeset_helper.c
drm: Unexport primary plane helpers
2018-10-05 18:06:49 +02:00
drm_modeset_lock.c
drm: Add DRM_MODESET_LOCK_BEGIN/END helpers
2018-11-29 10:48:31 -05:00
drm_of.c
drm/doc: Include drm_of.c helpers
2018-07-13 18:40:28 +02:00
drm_panel_orientation_quirks.c
drm: panel-orientation-quirks: Do rotation quirk for new GPD Win2 FW
2018-11-15 10:55:30 +01:00
drm_panel.c
BackMerge v4.19-rc6 into drm-next
2018-10-04 11:03:34 +10:00
drm_pci.c
cross-tree: phase out dma_zalloc_coherent()
2019-01-08 07:58:37 -05:00
drm_plane_helper.c
drm: Unexport drm_plane_helper_check_update
2018-10-05 22:45:19 +02:00
drm_plane.c
drm: Add DRM_MODESET_LOCK_BEGIN/END helpers
2018-11-29 10:48:31 -05:00
drm_prime.c
drm/prime: Fix drm_gem_prime_mmap() stack use
2018-11-22 15:44:05 +01:00
drm_print.c
drm: Add puts callback for the coredump printer
2018-07-30 08:49:41 -04:00
drm_probe_helper.c
drm: drop _mode_ from remaining connector functions
2018-07-13 18:40:27 +02:00
drm_property.c
drm: Differentiate the lack of an interface from invalid parameter
2018-09-14 17:29:47 +01:00
drm_rect.c
…
drm_scatter.c
drm: Differentiate the lack of an interface from invalid parameter
2018-09-14 17:29:47 +01:00
drm_scdc_helper.c
…
drm_simple_kms_helper.c
drm/tinydrm: Advertise that we can do only DRM_FORMAT_MOD_LINEAR.
2018-10-30 13:01:50 -07:00
drm_syncobj.c
drm: revert "expand replace_fence to support timeline point v2"
2018-12-05 11:01:11 +01:00
drm_sysfs.c
drm/lease: Send a distinct uevent
2018-11-30 10:57:18 +01:00
drm_trace_points.c
…
drm_trace.h
…
drm_vblank.c
drm: Differentiate the lack of an interface from invalid parameter
2018-09-14 17:29:47 +01:00
drm_vm.c
…
drm_vma_manager.c
drm: Remove "protection" around drm_vma_offset_manager_destroy()
2018-09-04 19:00:32 +01:00
drm_writeback.c
drm: writeback: Fix doc that says connector should be disconnected
2018-07-16 16:35:27 +01:00
Kconfig
drm/fb_helper: Allow leaking fbdev smem_start
2018-10-03 21:08:21 +02:00
Makefile
Merge tag 'vmwgfx-next-2018-12-05' of git://people.freedesktop.org/~thomash/linux into drm-next
2018-12-06 13:43:56 +10:00